GNU bug report logs - #51426
29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?

Previous Next

Full log

Message #16 received at 51426 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 51426 <at> debbugs.gnu.org
Subject: Re: bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be
 connection-aware?
Date: Thu, 28 Oct 2021 10:02:46 +0200

Jim Porter <jporterbugs <at> gmail.com> writes:

Hi Jim,

> Thanks. I've expanded the section about `comint-terminfo-terminal' in
> the manual to include information about how `system-uses-terminfo'
> works as well as mentioning that these variables can be declared as
> connection-local.

LGTM. Just one nit:

>  color is supported.  Therefore, Emacs provides an option
> -@code{comint-terminfo-terminal}, which you can set to a terminal that
> -is present in your system's terminfo database, in order to take
> -advantage of advanced features of that terminal.
> +@code{comint-terminfo-terminal} to let you choose a terminal with more
> +advanced features, as defined in your system's terminfo database.
> +When @code{system-uses-terminfo} is non-nil, Emacs will use this
> +option as the value for @env{TERM}.

"this option" sounds like Emacs uses system-uses-terminfo for TERM, at
least in my ears. Could you pls rephrase it a little bit?

Otherwise, it is OK. If nobody else objects, I would push it in your
name to the master branch, when you have reworded it.

> Thanks for taking a look.
>
> - Jim

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.