GNU bug report logs - #51426
29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?

Previous Next

Full log

View this message in rfc822 format

From: Jim Porter <jporterbugs <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 51426 <at> debbugs.gnu.org
Subject: bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?
Date: Wed, 27 Oct 2021 17:45:53 -0700

[Message part 1 (text/plain, inline)]

On 10/27/2021 1:20 AM, Michael Albinus wrote:
> Looks good to me. However, this technique must be documented
> anywhere. Likely in the Emacs manual, node "Shell Options"
> (file doc/emacs/misc.texi).

Thanks. I've expanded the section about `comint-terminfo-terminal' in 
the manual to include information about how `system-uses-terminfo' works 
as well as mentioning that these variables can be declared as 
connection-local.

> Yes, it should be said in etc/NEWS.

I added a new entry too.

>> +  (with-connection-local-variables
>> +   (if (and (boundp 'system-uses-terminfo) system-uses-terminfo)
> 
> According to git log, the variable system-uses-terminfo exists since [1994.]
> I guess it is save to get rid of "(and (boundp 'system-uses-terminfo)".

Removed this.

Thanks for taking a look.

- Jim

[0001-Support-setting-comint-terminal-connection-locally.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.