GNU bug report logs - #51425
Invalid <file-system> flags lead to a crash when booting

Previous Next

Full log

Message #8 received at 51425 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 51425 <at> debbugs.gnu.org
Subject: Re: bug#51425: file-system: validate flags
Date: Wed, 27 Oct 2021 21:31:35 -0400

Hello,

Jonathan Brielmaier <jonathan.brielmaier <at> web.de> writes:

> Imagine the following file system definition in your config.scm:
>
> ```
> (file-system
>   (device (uuid "UUID-123"))
>   (flags '((create-mount-point? #t)))
>   (mount-point "/mnt")
>   (type "ext4")))
> ```
>
> When you reconfigure there will be no complain, but when you reboot your
> system wont boot. The parameter to flags is nonsense, it should be
> something like: `read-only`. So mounting of the file system will fail...
>
> It would be nice if we can have some flag validation during reconfigure.
>
> ~Jonathan

I agree that it'd be nice; I had gotten close to implementing such a
thing in the past, but it was discussed and abandoned because each file
system may have their own flags, add new flags with new releases, etc,
which means it'd be difficult to keep the list accurate.

That's if my memory serves me right :-).

Thanks,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.