GNU bug report logs - #51425
Invalid <file-system> flags lead to a crash when booting

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: bug#51425: closed (Re: bug#51425: file-system: validate flags)
Date: Sun, 07 Nov 2021 22:17:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#51425: Invalid <file-system> flags lead to a crash when booting

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 51425 <at> debbugs.gnu.org.

-- 
51425: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51425
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 51425-done <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#51425: file-system: validate flags
Date: Sun, 07 Nov 2021 23:16:17 +0100

Hi,

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Jonathan Brielmaier <jonathan.brielmaier <at> web.de> skribis:
>
>> Imagine the following file system definition in your config.scm:
>>
>> ```
>> (file-system
>>   (device (uuid "UUID-123"))
>>   (flags '((create-mount-point? #t)))
>>   (mount-point "/mnt")
>>   (type "ext4")))
>> ```
>>
>> When you reconfigure there will be no complain, but when you reboot your
>> system wont boot.
>
> I suppose it fails to boot because of a match error in
> ‘mount-flags->bit-mask’, right?
>
>> The parameter to flags is nonsense, it should be something like:
>> `read-only`. So mounting of the file system will fail...
>
> That’s a good use case for the recently-added ‘sanitize’ record field
> property.

Done in 5eb5c0789f34e87ee417a53ddfcfa3b6521bb337.

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: bug-guix <at> gnu.org
Subject: file-system: validate flags
Date: Wed, 27 Oct 2021 00:24:28 +0200

Imagine the following file system definition in your config.scm:

```
(file-system
  (device (uuid "UUID-123"))
  (flags '((create-mount-point? #t)))
  (mount-point "/mnt")
  (type "ext4")))
```

When you reconfigure there will be no complain, but when you reboot your
system wont boot. The parameter to flags is nonsense, it should be
something like: `read-only`. So mounting of the file system will fail...

It would be nice if we can have some flag validation during reconfigure.

~Jonathan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.