From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 26 18:24:43 2021 Received: (at submit) by debbugs.gnu.org; 26 Oct 2021 22:24:43 +0000 Received: from localhost ([127.0.0.1]:47779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfUs7-0000Fk-6t for submit@debbugs.gnu.org; Tue, 26 Oct 2021 18:24:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:50844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfUs6-0000Fd-JH for submit@debbugs.gnu.org; Tue, 26 Oct 2021 18:24:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfUs4-0005x9-9n for bug-guix@gnu.org; Tue, 26 Oct 2021 18:24:41 -0400 Received: from mout.web.de ([212.227.17.11]:57961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfUrx-0000oH-2a for bug-guix@gnu.org; Tue, 26 Oct 2021 18:24:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1635287068; bh=nRlQa7hW+RP70k/e0Q/viq7qS14fzRWvogRwG0//KJQ=; h=X-UI-Sender-Class:To:From:Subject:Date; b=OOtlRhxhhuu291niqeT1BI3X/5kY0pflRm57SJhAAG77J3QWO2vInFD3KyGbPjyxA CeDDRsyNUQmnkfCO8jHeh0YazjStKPrRyI8IYlPr8EPiY5/RRGh7BkqM/AKbmnZjpj ojT6okGhsMYFk0/35WLiu6mZRlrq33ZLJ9kOnuUo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.23] ([77.181.207.254]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MKrLo-1mfUrs2vbs-0002Yh for ; Wed, 27 Oct 2021 00:24:28 +0200 To: bug-guix@gnu.org From: Jonathan Brielmaier Subject: file-system: validate flags Message-ID: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> Date: Wed, 27 Oct 2021 00:24:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.15.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:sZAdMHI0Z5n0be7Xi6W9vE5CAYkcHqu5tsS/UAtmzUT/lcPxx9+ W8JUyf+FmimcuvO1gvWvO/MGPlhK6gJBqYV3Wk9mYOL4CB+hk9g/9IBK1BTbk3dxJAuw/t/ IU/0I9DXHILGC/Ks7DoaVxcxNUzH+zsYfKCivuyEfpW5WjGzDwaTe6ZZJg4pn+4TyXatXsV Dybcf709/w2YRO2IY6m6g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:v2Yr7IDlhhg=:BCJKBfda2Q4TO7ZzsU5Lw1 MfCzULVT3PbRHlmfYM6H3Hn6gYe1WDLNYVfEqnGsn+q9Zz1EVTqbWWuLZTek2ZC2pMwYsQn5V 1wEJRbyDB1Wh/KkzKP6E4EWhTO4B24+GgDTfr0VOr7dtkmmsfLZ7QoEWTYaV+x3oaFzfZ/NmY +95Z0CBq5HYb6w4BMZDAPuG7yt2f5+GAKszbH0Ng0wBoc+g2EA1kuQOHbllkngfGBAvN5KuIf Sb9/6mA911VKtoPpag+3YNDpEH/65hdGQx2ZkJSuSKwiVioGCEkb8SsvqCSozCcYaHVXZmlYQ yurp7r9iE+dIY1d3oneqjobeW2Sp04n1BABtb5EW8WR7eNPok3CCEcswUB3PRXLPMJ1Q9FN5A D9ZtKKHJ2zLDiA8xUjeCL+zlbYQ8OQz6rqnTs9xT2erlpLyttKxJ7qIDEHul525Akj8oVsZD3 oOpDKnJJuRDJa58LRjZyOvkZUc7RQNcd9DVUeSRzpMlabjdtjuTu7TlynQ2JIhipWYd8JE/kT OTuJ61+kI0WffIFqFe1QKFN24nxVZX9pN+5WQMmmFd5xH4vCAMdsboig/3mJ+PEmMDrgiuzXP R8b2CHndOvDCwZPxxcBpduydg1iYy/emom2QrWSP6AueMHj+J4ol1QXhumNvE2TSafCJgBsB9 GgBSigLXUUmoEfH0rdxvtlwPSK+OwXAavRIihjQIVV/ge+gVwVuaJ4w5gao5wS0tQgNDtsAtD doPx0O1elYK4f9FG2QuY863ZuFIbGRGnxl5owebpo/kQcOTF0HHosZFlJKkeLxLfg5bxKPJH8 JAzfD+2teIzL6d2BSljTePUuHaTzANyJZMGNcniQV+eqGWgZEd+QoYxUsFbSwDPkA7K/44F8r UA0bhtTTCdgcctolwur9KEgDnHcxS8mPB35mXTtU1FS00Vxj1avtIml1fAxEjsynz5uJJKb1U bZICzpccyt1RoIKZjkv4JlxyYH8Id+5hWCFNgWcVCZOHaZ7hzuoYGb31PKK3wDBsyQipwfdXm 1a0Aks9zuuINwTrWYRV3xXxF37SP/CBtKGPJer7LLaJQtlb8sBAj8piM+ksOfT9xZKRpXnt+B GOlqGHIcicY9gw= Received-SPF: pass client-ip=212.227.17.11; envelope-from=jonathan.brielmaier@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Imagine the following file system definition in your config.scm: ``` (file-system (device (uuid "UUID-123")) (flags '((create-mount-point? #t))) (mount-point "/mnt") (type "ext4"))) ``` When you reconfigure there will be no complain, but when you reboot your system wont boot. The parameter to flags is nonsense, it should be something like: `read-only`. So mounting of the file system will fail... It would be nice if we can have some flag validation during reconfigure. ~Jonathan From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 27 21:31:44 2021 Received: (at 51425) by debbugs.gnu.org; 28 Oct 2021 01:31:44 +0000 Received: from localhost ([127.0.0.1]:50917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfuGd-00022T-VB for submit@debbugs.gnu.org; Wed, 27 Oct 2021 21:31:44 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:38810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfuGb-00022F-Vu for 51425@debbugs.gnu.org; Wed, 27 Oct 2021 21:31:42 -0400 Received: by mail-qk1-f173.google.com with SMTP id bi29so4362532qkb.5 for <51425@debbugs.gnu.org>; Wed, 27 Oct 2021 18:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dg09e+ZlXTcX0AYh7sXmh0SQVVkeIRqakaI6csSyOPY=; b=IqE7ICqa+9hBsGEWvuccDfQaWsmdVLzgVrhaFJASIFkRuoQrBi/5v95AL8znlQc7na CVKZQRNOZ9xiIzMj57O2hmyvnTem0z4aJ6kKMOpHfG0rwZWC2gwhtpy3GS7BOS1wxdpG qG82IyGu1zzoz4/Cyz/z1hosv5UXlvTU5Z4GMCGzvAPWYeGdlgcXtJrIOuNKxCjdkHHM NIu4T503atz+EJeQwRlPfHMZVTi2T6CWFYcz6Ja/b7SZkz8HHzsiLT8NDa25wMfjOcfB cPekDTk5cLWrAwd+TIJJPR2QpbgwNcJ0pb65ZLOXoWMHTakH//jrjBda0GYUqC12Ob1J 6u8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dg09e+ZlXTcX0AYh7sXmh0SQVVkeIRqakaI6csSyOPY=; b=FtZ9TAOF3zVIQlU6ILY3bcyM5FktI225nxiPxde8DLC6Y0S6ec+Q8iCKyB1Bq8Ve21 Ipy7vMNLg371S+ifSgg+H4loQyjUOcz9wjRwy4URpbyuPCqd0rlwnvLO9vkPe049zp0A pzXisywvgkd68EagyUJZGoL1TCCUFXuzYYL11ywkpgvo364UXbEyRkJRws5MqDkL2r2N eTmP4/rOmsebGYqnfArLRc/Ei0H8j0mqx4upa45v9+g5vy7Recu7kzZaw2mWWCQeOX4U 1ZFwGCQL8Dw4Ow/in8j8QOAhetGuLZcNZvX9sAf66FzOAUs6iJW03OpFNtxHAcIlGFkC PGig== X-Gm-Message-State: AOAM531o97YQHI3ZPtxF3t6izn9kFXk1ao/BZw8llZmQANOVvp17n577 m2IZLZ1TTGEHe/rvzDvF0PDdE3GZJZQ= X-Google-Smtp-Source: ABdhPJwykBULSevvy0nnIylKJg/PbrpHzd1+JHcxsisoVl0eHP28DzO8cxALgTo4HS6X7CBJp9HcLw== X-Received: by 2002:a05:620a:24cf:: with SMTP id m15mr1099726qkn.434.1635384696336; Wed, 27 Oct 2021 18:31:36 -0700 (PDT) Received: from hurd (dsl-152-69.b2b2c.ca. [66.158.152.69]) by smtp.gmail.com with ESMTPSA id g11sm1268647qko.31.2021.10.27.18.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 18:31:35 -0700 (PDT) From: Maxim Cournoyer To: Jonathan Brielmaier Subject: Re: bug#51425: file-system: validate flags References: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> Date: Wed, 27 Oct 2021 21:31:35 -0400 In-Reply-To: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> (Jonathan Brielmaier's message of "Wed, 27 Oct 2021 00:24:28 +0200") Message-ID: <87zgqu9bpk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51425 Cc: 51425@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Jonathan Brielmaier writes: > Imagine the following file system definition in your config.scm: > > ``` > (file-system > (device (uuid "UUID-123")) > (flags '((create-mount-point? #t))) > (mount-point "/mnt") > (type "ext4"))) > ``` > > When you reconfigure there will be no complain, but when you reboot your > system wont boot. The parameter to flags is nonsense, it should be > something like: `read-only`. So mounting of the file system will fail... > > It would be nice if we can have some flag validation during reconfigure. > > ~Jonathan I agree that it'd be nice; I had gotten close to implementing such a thing in the past, but it was discussed and abandoned because each file system may have their own flags, add new flags with new releases, etc, which means it'd be difficult to keep the list accurate. That's if my memory serves me right :-). Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 29 15:13:50 2021 Received: (at 51425) by debbugs.gnu.org; 29 Oct 2021 19:13:50 +0000 Received: from localhost ([127.0.0.1]:55953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgXK2-0008F3-5O for submit@debbugs.gnu.org; Fri, 29 Oct 2021 15:13:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgXK0-0008Em-88 for 51425@debbugs.gnu.org; Fri, 29 Oct 2021 15:13:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgXJu-0003uq-TH; Fri, 29 Oct 2021 15:13:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=A0ePlGA7t4hS2AJ/v1Hjskdo5waAJe7CdCe/XqMBklM=; b=p6iP92AJzumFzjJk7fG6 bZqexy6tCq9UR+7YZEc5k/5sO1bclYfQZZ0qogVW0C6E1/4pQeYz0PygeV96Yarpf4W4FG693043d xtNIOhR25qiwsFcqnc4WbeuseddBO3VSlLwY3RbcM0ZTLgor5tCcB04QJYYa6g/dsZxhrMY2HMnux g6GoV+HHpCPpw8vt/bNhWsVRhg4IusjCGGJaWX4gHURmVIamawxiS1JcXmmTZFxrUoqIcFOAj3bCR eKqU8Zho2nqWDP+XwGQ64AFKh8X/gxJteZlcjFxh7YBhAYXKfx9PlCEwIeMqpkMcirr5HqAReTfJ8 y18Djknckre9cw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54878 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgXJu-0006Vr-Gj; Fri, 29 Oct 2021 15:13:42 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jonathan Brielmaier Subject: Re: bug#51425: file-system: validate flags References: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> Date: Fri, 29 Oct 2021 21:13:40 +0200 In-Reply-To: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> (Jonathan Brielmaier's message of "Wed, 27 Oct 2021 00:24:28 +0200") Message-ID: <87cznny78b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51425 Cc: 51425@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Jonathan Brielmaier skribis: > Imagine the following file system definition in your config.scm: > > ``` > (file-system > (device (uuid "UUID-123")) > (flags '((create-mount-point? #t))) > (mount-point "/mnt") > (type "ext4"))) > ``` > > When you reconfigure there will be no complain, but when you reboot your > system wont boot. I suppose it fails to boot because of a match error in =E2=80=98mount-flags->bit-mask=E2=80=99, right? > The parameter to flags is nonsense, it should be something like: > `read-only`. So mounting of the file system will fail... That=E2=80=99s a good use case for the recently-added =E2=80=98sanitize=E2= =80=99 record field property. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 29 15:46:45 2021 Received: (at submit) by debbugs.gnu.org; 29 Oct 2021 19:46:45 +0000 Received: from localhost ([127.0.0.1]:56016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgXps-0000r2-SO for submit@debbugs.gnu.org; Fri, 29 Oct 2021 15:46:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:54494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgXpp-0000qq-PY for submit@debbugs.gnu.org; Fri, 29 Oct 2021 15:46:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgXpo-00050Y-Hw for bug-guix@gnu.org; Fri, 29 Oct 2021 15:46:41 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:34946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgXpj-0000Ya-0N; Fri, 29 Oct 2021 15:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=aYp0FNx2FPi70 6klM6l7GSOjGeS8nWG8IXCLjBl+XbY=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=XXd+ZquDIpTvV1odng6mxR0/AnxosmibLmSUr1 mt8ZBUfebbLtoBivGImalOJVjC7wOcKabOLqij5Cqvtg+gyvheuZm0kKWFJWhEwmMPej4P IdFi24z2c+n2gdZ6f878HlXD6t39IUlahgrS2iRZTdL3ICfajDeRUejkjIGa+ZLn9p09aS jrH4vtesVOkctyrpm0z9UxuRkfTbEKcNSWRxue3JStxqqrQFMx2fV9SGVR+XqdMrIeZBg1 ZGldgp9OcihhFH+73fVTvpmv8cBWWYZq+OO/VHtOYG0enSrnRGqJq7EhmcJhjX34H4OL3S aH6arD4XO+K5xNESa18uNSCQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 4270d06d (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 29 Oct 2021 19:46:27 +0000 (UTC) References: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> <87zgqu9bpk.fsf@gmail.com> From: Tobias Geerinckx-Rice To: Maxim Cournoyer , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Subject: Re: bug#51425: file-system: validate flags Date: Fri, 29 Oct 2021 21:41:15 +0200 In-reply-to: <87zgqu9bpk.fsf@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87lf2bipgp.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 51425@debbugs.gnu.org, bug-guix@gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable [FTR, I'm the one who encouraged Jonathan to file a bug. Mount=20 flags seem ideally suited to build-time validation.] Maxim, Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > each file system may have their own flags Really? Huh. Interesting. How does that work? Where would=20 these file-system specific flags be #defined? (My guess is that if anyone does this, it'd be ZFS ;-) > add new flags with new [Linux] releases Well, sure, but then we simply add them to Guix. This applies to=20 everything from syscalls to services. Ludo', I'll take a look at =E2=80=98sanitize=E2=80=99; thanks! Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYXxPlw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15SgYA/0Qd9jtqLWTcopDd6QU3WruHqjmQnS6kb8HtrAlk tbAYAP4yPvTlVGJ+o5rKGgKr2Nm92R38XS72zQ1wJolDqQkECg== =R3T3 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 29 20:45:42 2021 Received: (at submit) by debbugs.gnu.org; 30 Oct 2021 00:45:42 +0000 Received: from localhost ([127.0.0.1]:56310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgcVC-0003G5-0h for submit@debbugs.gnu.org; Fri, 29 Oct 2021 20:45:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:48134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgcV9-0003Fv-JC for submit@debbugs.gnu.org; Fri, 29 Oct 2021 20:45:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgcV5-0003m9-9B for bug-guix@gnu.org; Fri, 29 Oct 2021 20:45:39 -0400 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]:44012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgcV1-0004P1-AF; Fri, 29 Oct 2021 20:45:34 -0400 Received: by mail-qv1-xf2c.google.com with SMTP id j9so1488614qvm.10; Fri, 29 Oct 2021 17:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=oGDfcqo5q4B34UguQ0XhJ6BZofuTKQZ2Qvu1wn53WCY=; b=bHRk0IIKAnNhv+K7ljz547Gai5Fv4QYDU4hHQK3WIEU4h1MnUS6IV5qKDQh1Zq1J5B CRnELr4oPyM+ce830N17j7zOOdEzXWgqXq/DJgBNfhZgTafxK7MLeNfUM7NQnmwAGCq4 xLDeXX2nu4T3Z7Jb0cEjdZ95og0WDC5xK+JH78ba4JTavZcmiEf/akRUHBVajCcV7lUh dRLFqlBgLiD0SR5gYBsh0lggMwT0gsCnEqO19mmrnMefm2/Y398IESDiW5vEXQuIYtAy mGJhfmQACa8qGdVMaN4Trhw05z0dm8aTIj2eJ83KJlD9pQbowT8vaVIEIVkxF88aE0/J 5KNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=oGDfcqo5q4B34UguQ0XhJ6BZofuTKQZ2Qvu1wn53WCY=; b=bZyZKUSyTlNifAWkh0JUX1cmOiOVjFsNFID7/riEzusiAmXx2yjIrobbKTyCHJkM4C 66374jM4g94az9cBUSL7ECBdOSJSpui32TWKwOW37MBOCYZ9YchQ9RGjnqh/tdMBFTCr IX3Syem/9+TwCnc5El27Zh+osG+c4HZFKTv/eYlNbHvbEbMYZkBWum8BS0Uk6dNThdCi 60XDp7G1YRZO/97RWeyaxg2iEAJ7T0KC5qRQtUXGgdfyQW57PLbs3gR/rrQr2sTT+0bi 60KO8/Gj6lCQqUUcFzAsp8uUBjSPDNTxX2W5EeCS4hI0VQDOjQxwHoTG2mTyY5Vvk90Y g/ng== X-Gm-Message-State: AOAM530ap8ybBOcxh+pR/KrzJtKHsVNUfNVM8V1e/MV3Dmp3IHIIQV2u QFFFKvpntq5Sprce27kbaifT/BtDySA= X-Google-Smtp-Source: ABdhPJxyyc0GePWu08P02NTIWmpBPY6KGO4bJtrZ3D5eSBrv76TfErDv4krkC1JOCy4qEtz6ePvNPg== X-Received: by 2002:a05:6214:300d:: with SMTP id ke13mr14663741qvb.54.1635554729867; Fri, 29 Oct 2021 17:45:29 -0700 (PDT) Received: from hurd (dsl-148-192.b2b2c.ca. [66.158.148.192]) by smtp.gmail.com with ESMTPSA id w15sm3410182qtn.60.2021.10.29.17.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 17:45:29 -0700 (PDT) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: bug#51425: file-system: validate flags References: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> <87zgqu9bpk.fsf@gmail.com> <87lf2bipgp.fsf@nckx> Date: Fri, 29 Oct 2021 20:45:28 -0400 In-Reply-To: <87lf2bipgp.fsf@nckx> (Tobias Geerinckx-Rice's message of "Fri, 29 Oct 2021 21:41:15 +0200") Message-ID: <87fssj8hnb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f2c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , bug-guix@gnu.org, 51425@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello Tobias, Tobias Geerinckx-Rice writes: > [FTR, I'm the one who encouraged Jonathan to file a bug. Mount flags > seem ideally suited to build-time validation.] > > Maxim, > > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> each file system may have their own flags > > Really? Huh. Interesting. How does that work? Where would these > file-system specific flags be #defined? Or maybe I'm confusing with file system options; I can't find the past discussion that I had on mind; but options are file driver specific, while flags are file system independent. So yes, flags are a good candidate for validation! Another thing that is tricky about options is that some of them are only really understood by the 'mount' command line utility, not the 'mount' system call such as used in our init RAM disk (both are thrown together in 'man 8 mount' without an easy way to discern them apart, IIRC). > Ludo', I'll take a look at =E2=80=98sanitize=E2=80=99; thanks! Neat, thank you Tobias! Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 29 20:59:08 2021 Received: (at submit) by debbugs.gnu.org; 30 Oct 2021 00:59:08 +0000 Received: from localhost ([127.0.0.1]:56320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgciC-0003cx-1G for submit@debbugs.gnu.org; Fri, 29 Oct 2021 20:59:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:54102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgci5-0003cI-US for submit@debbugs.gnu.org; Fri, 29 Oct 2021 20:59:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgci5-0000J2-HK for bug-guix@gnu.org; Fri, 29 Oct 2021 20:59:01 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:34970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgci3-0003Wh-EK; Fri, 29 Oct 2021 20:59:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=iN3SBh9eF2TFm xf97MINDukmUcZxl25ccQWC54aJyoY=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=S4itBWeJabgSw00dGzDvT0r7/PAXvdzrcXigpV idWumW5v9/aOKkLZLHDlaYKgIvRf4tegHUHJJr6Kp2qDmc9TDdovkMKGUrDmPOskhaD6Jq fM8t4efI+d+kLeJUlPWkk0sy8m6OEBefUlkOJRTJC5acXXdptIveU+0uuxUig8HAD0K3aO gaplC/q4T5MXUv5/4SI3Oc2goCtJwPae909O0tFtoBePF0VrjHXObXhAwrTaDhri2hXtFQ 7I0W6ASXynO4zfRwcW1rtlO6YiQBzJb8A1Q+9THMovHJIKt2YW6YFG/B/1zB94bJzaooNN SnmJwD2x+6vB5cIxxGeiMyiA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 80224881 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 30 Oct 2021 00:58:51 +0000 (UTC) References: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> <87zgqu9bpk.fsf@gmail.com> <87lf2bipgp.fsf@nckx> <87fssj8hnb.fsf@gmail.com> From: Tobias Geerinckx-Rice To: Maxim Cournoyer Subject: Re: bug#51425: file-system: validate flags Date: Sat, 30 Oct 2021 02:48:50 +0200 In-reply-to: <87fssj8hnb.fsf@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <878rybib00.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , bug-guix@gnu.org, 51425@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxim, Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > Another thing that is tricky about options is that some of them=20 > are only > really understood by the 'mount' command line utility, not the=20 > 'mount' > system call such as used in our init RAM disk (both are thrown=20 > together > in 'man 8 mount' without an easy way to discern them apart,=20 > IIRC). Aha! Let me introduce you to the only slightly unfortunately=20 named =E2=80=98man 2 mount=E2=80=99 instead. The way mount(8) lumps both together is=E2=80=A6 I guess it's=20 user-friendly =E2=80=94 in a way? =E2=80=94 but it leads to this total conf= usion=20 about what's what. Think of flags as literal bit flags, mainly=20 because they are. Guix does make the distinction. It's the right call but it leads=20 to a brief education moment the first time you encounter both=20 fields. You're absolutely right that mount options OTOH are arbitrary=20 strings. They can't and shouldn't be =E2=80=98validated=E2=80=99, but we d= on't=20 currently mandate their stringiness, and should. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYXyYzw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15IsABAMgyDMpFX7Q1THfIQ0vOxqXiSO0Z8v8OmQr4860H DKKhAPwNyHO4B0sD925g8YqVpB1/0todcP0NEF8kUSRqYdEeAg== =y72O -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 30 22:31:48 2021 Received: (at submit) by debbugs.gnu.org; 31 Oct 2021 02:31:48 +0000 Received: from localhost ([127.0.0.1]:58733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mh0dP-0003bL-WA for submit@debbugs.gnu.org; Sat, 30 Oct 2021 22:31:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:39434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mh0dO-0003ZT-2C for submit@debbugs.gnu.org; Sat, 30 Oct 2021 22:31:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mh0dN-0008O7-It for bug-guix@gnu.org; Sat, 30 Oct 2021 22:31:45 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:47078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mh0dL-0001Zu-91; Sat, 30 Oct 2021 22:31:45 -0400 Received: by mail-qt1-x82c.google.com with SMTP id s1so11529376qta.13; Sat, 30 Oct 2021 19:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=GjysnqDyhyO+7WtuE32/fzbKjvw7lzls/mxDEDRHRos=; b=XH/mzFmcJSDSsRCiKAeVrcRkTDjSpB6RidgtmtxdJMENnPTYvLEgYF78lkE+PB0Bp8 qdWnDTjgJ0QFgyecnYXl5AJ0A8hlS5h29d6ozArtpSfnMoH4qhsRz0sqZiyuloRAd4D0 d8sTlepzjM3C6IFEy/+ULFs0YRdDObyAv799hgN5yuIcuFVYQwrpFGkD4M85J5CaUMks 6pP8zdHiS0GZjWdfOEnKHzmX2/wyXWeqzGBPl+eBNdYdm+sihsEwexjLQiVdURQpY6VU 5qHUyqdOJpEcW2TSDXQo8QoN932bZ9g6zoDlxRWNJAhMLmksnlE44O6TZnsQ7fMYbP5T 6uHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=GjysnqDyhyO+7WtuE32/fzbKjvw7lzls/mxDEDRHRos=; b=pFmDjQdvVtEq4JI36mLL+BcbeUNQQocVTq2ySHNVuy54ZZEPTG6kDEQdpKyqxR5fKZ fFT9sxFklSFfRnEcU9xvKqp+8fqQ75E5CBWbUc0Uj8pt1YAS9qcVK6rFL2r72EMM1XiU rTQ0nAMlJRvXKOEJr7pPbI+Z1/jcPRtaD5wQoYZUAoFuOIWbkH8UrkOU16P4k66F3H8G 59hUlBFdqVF6Mnw4vqGHGMPwUGVYswB2587KXVtJiDqJ9FkUDLlmBkupZMJTME1k+ITz 00Hz63fGjZ9E14ZBfamonE7voucvok5Ab3ZIVhIYQcVc+dCE0N/0gubrOtQ5XsPbMHl6 FQKA== X-Gm-Message-State: AOAM5323ExehsXj6LRJL7pDbzDwLpFfzkrtK2FCpXs9IoqbgJbprZqIP tiQk+Ht79z+BWp5Yh+istrAnzQy7xu0= X-Google-Smtp-Source: ABdhPJyP1sxw0LGZadvvfgNhVXjWVwygwX6Vygt4cT6/6Uzegufy2Mw8U+Y04vpfG4DRES7pL03wjQ== X-Received: by 2002:a05:622a:1109:: with SMTP id e9mr10741131qty.86.1635647501790; Sat, 30 Oct 2021 19:31:41 -0700 (PDT) Received: from hurd (dsl-148-192.b2b2c.ca. [66.158.148.192]) by smtp.gmail.com with ESMTPSA id h12sm7367523qkp.52.2021.10.30.19.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Oct 2021 19:31:41 -0700 (PDT) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: bug#51425: file-system: validate flags References: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> <87zgqu9bpk.fsf@gmail.com> <87lf2bipgp.fsf@nckx> <87fssj8hnb.fsf@gmail.com> <878rybib00.fsf@nckx> Date: Sat, 30 Oct 2021 22:31:40 -0400 In-Reply-To: <878rybib00.fsf@nckx> (Tobias Geerinckx-Rice's message of "Sat, 30 Oct 2021 02:48:50 +0200") Message-ID: <87zgqp7wmr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , bug-guix@gnu.org, 51425@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Tobias, Tobias Geerinckx-Rice writes: > Maxim, > > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> Another thing that is tricky about options is that some of them are >> only >> really understood by the 'mount' command line utility, not the >> 'mount' >> system call such as used in our init RAM disk (both are thrown >> together >> in 'man 8 mount' without an easy way to discern them apart, IIRC). > > Aha! Let me introduce you to the only slightly unfortunately named > =E2=80=98man 2 mount=E2=80=99 instead. Eh, I'm not sure why I hadn't thought about that myself, thank you! It makes sense after all -- one man page (2) documents the options for the system call, the other one (8) for the command. > The way mount(8) lumps both together is=E2=80=A6 I guess it's user-friend= ly =E2=80=94 > in a way? =E2=80=94 but it leads to this total confusion about what's wha= t. > Think of flags as literal bit flags, mainly because they are. Hehe. > Guix does make the distinction. It's the right call but it leads to a > brief education moment the first time you encounter both fields. > > You're absolutely right that mount options OTOH are arbitrary strings. > They can't and shouldn't be =E2=80=98validated=E2=80=99, but we don't cur= rently > mandate their stringiness, and should. Makes sense. Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 07 17:15:46 2021 Received: (at control) by debbugs.gnu.org; 7 Nov 2021 22:15:46 +0000 Received: from localhost ([127.0.0.1]:55146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjqS2-000151-GB for submit@debbugs.gnu.org; Sun, 07 Nov 2021 17:15:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjqS1-00014l-Bp for control@debbugs.gnu.org; Sun, 07 Nov 2021 17:15:45 -0500 Received: from [2001:470:142:3::e] (port=57670 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjqRw-00018M-5g for control@debbugs.gnu.org; Sun, 07 Nov 2021 17:15:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=E8VEFnPDj6Sg2+4pYXKK0A0YbjFsDpwv/5z0USbsxrg=; b=H1RmFfJa5SCLbZ vU1zgUg6pxM+7byRPAoTPkwJQkeH7epl2oxkWtlSbmvAMXlO0mZuiQ0Vv8gGtgQ2AvzHVCMcWLSsk bP1ABfJPeuZbZy4X1jAsi5K7KN9XTg+CtfblvbfwwpzE+ok7MZUS6XiNSiw6zstAJXA66PJue2/aE fMtzQ0qUtZhs+Vu0ngTULD/i5Stb1WriXXFlnUQqnbXYc8Pv7F5fHtH2nB2h20mHI8BdZngrkkNGZ 2o5qgdLNcl8xjMu0/8OqaP6cyWA8uSZ1jMumPFiV++YfxzTIKSIuk8bwDny3mKq4eNPkrPh1uRDf0 lftPnqZbJBCT1ewQkrQQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55554 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjqRv-0005GD-R1 for control@debbugs.gnu.org; Sun, 07 Nov 2021 17:15:40 -0500 Date: Sun, 07 Nov 2021 23:15:38 +0100 Message-Id: <87cznbk3xx.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #51425 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) retitle 51425 Invalid flags lead to a crash when booting quit From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 07 17:16:27 2021 Received: (at 51425-done) by debbugs.gnu.org; 7 Nov 2021 22:16:28 +0000 Received: from localhost ([127.0.0.1]:55152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjqSh-00016m-NR for submit@debbugs.gnu.org; Sun, 07 Nov 2021 17:16:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjqSf-00016Y-VJ for 51425-done@debbugs.gnu.org; Sun, 07 Nov 2021 17:16:26 -0500 Received: from [2001:470:142:3::e] (port=57674 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjqSZ-0001AX-PV; Sun, 07 Nov 2021 17:16:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=HSz0K/0e1y3Qd72jsRWwhUZ5O5OlU1KbhA6dpVASYXU=; b=Pxpv0bAdF9UV5+kBLl5+ PYJMheO9u4TFZyXzjH1LjU15mKOf41trB1ZvdnZkFBcn06smMrj7REsvxpkcpjOuZyYWzLHpBMaQO FP8qTRKPLhyEL3I0VFjXxhBzeC+Dk8xa9Ni8VSjO1eCrE4dEu79NdUsYa+h99PtxDKpkdmyWMcRDM huBTbXEXx7MEqs/Dd12dCpdJsZwDMDznJJ2jBvb4ksoIQ5wdLYhWBtpw4GOIc0e2Wt11ZDYS57z22 i4sEh+5hsXwblsKrV2u+RgXBLlPxfdkGZcqsIPnCe/txrGMw5ZUJF9JnviCKUfgYm/uijrr3T9LwH 1R4cwYDTEFTR2A==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55556 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjqSZ-0005Jk-8d; Sun, 07 Nov 2021 17:16:19 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jonathan Brielmaier Subject: Re: bug#51425: file-system: validate flags References: <33625107-5cf9-85f8-9025-2b9f186723bc@web.de> <87cznny78b.fsf@gnu.org> Date: Sun, 07 Nov 2021 23:16:17 +0100 In-Reply-To: <87cznny78b.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 29 Oct 2021 21:13:40 +0200") Message-ID: <878rxzk3wu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51425-done Cc: 51425-done@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ludovic Court=C3=A8s skribis: > Jonathan Brielmaier skribis: > >> Imagine the following file system definition in your config.scm: >> >> ``` >> (file-system >> (device (uuid "UUID-123")) >> (flags '((create-mount-point? #t))) >> (mount-point "/mnt") >> (type "ext4"))) >> ``` >> >> When you reconfigure there will be no complain, but when you reboot your >> system wont boot. > > I suppose it fails to boot because of a match error in > =E2=80=98mount-flags->bit-mask=E2=80=99, right? > >> The parameter to flags is nonsense, it should be something like: >> `read-only`. So mounting of the file system will fail... > > That=E2=80=99s a good use case for the recently-added =E2=80=98sanitize= =E2=80=99 record field > property. Done in 5eb5c0789f34e87ee417a53ddfcfa3b6521bb337. Thanks, Ludo=E2=80=99. From unknown Fri Jun 20 07:26:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Dec 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator