GNU bug report logs - #51411
NS port cleanups

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Po Lu <luangruo <at> yahoo.com>
Subject: bug#51411: closed (Re: bug#51411: NS port cleanups)
Date: Sat, 06 Nov 2021 13:03:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#51411: NS port cleanups

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 51411 <at> debbugs.gnu.org.

-- 
51411: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51411
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alan Third <alan <at> idiocy.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51411-done <at> debbugs.gnu.org
Subject: Re: bug#51411: NS port cleanups
Date: Sat, 6 Nov 2021 13:02:03 +0000

On Sat, Nov 06, 2021 at 08:20:49AM +0800, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
> Po Lu <luangruo <at> yahoo.com> writes:
> 
> > As of 48af19c1 those patches don't apply anymore.  Here's a version that
> > does.  (I kept my version of the overhang computation code instead of
> > Daniel's, because the xterm code computes overhangs correctly, and
> > bug#51105 doesn't apply to it AFAIU.)
> 
> And it doesn't apply, again.  This should:

Sorry, I've not been very attentive to Emacs stuff recently. I've
pushed these changes to master.

Thank you!
-- 
Alan Third

[Message part 3 (message/rfc822, inline)]

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: NS port cleanups
Date: Tue, 26 Oct 2021 19:41:31 +0800

[Message part 4 (text/plain, inline)]

I did not notice that the thread previously titled "NS port
improvements" was moved off bug#51251 onto emacs-devel, but now that
there are concrete changes I think it would be a good opportunity to
post them on bug-gnu-emacs, per the CONTRIBUTE document.

The changes, with the generic improvements split from the changes to
font rendering are attached.

Alan raised several questions, which I answered.  I've reproduced that
part of the discussion below:

> Is there any reason to nest ns_focus? There are (according to Apple)
> performance reasons to not save the context unless you really need to.

Right now it's used in the code that clips to the exact bounds of a
string, if a string's overhangs are already drawn.

I couldn't find a cleaner way to do this, and that situation is rare, so
I think the performance problems will usually be avoided.

> I mean alt as defined by GNUstep in the quote I sent you in my last
> email. I don't think it's our job to say that GNUstep's choice of
> defaults is wrong and therefore do something that would be unexpected
> for a GNUstep user.

Well, on every other platform Meta is on the alt on the users' keyboard.
Emacs in general doesn't conform to the platform expectations WRT to key
bindings, so I think being consistent with Emacs on other platforms is
more important here.

But in the end, it's your call.  Thanks.

[0002-General-improvements-to-NS-port.patch (text/x-patch, attachment)]

[0001-Improve-font-display-on-NS-port.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.