GNU bug report logs - #51395
[PATCH] gnu: mda-lv2: Remove unnecessary search-path-specification.

Previous Next

To reply to this bug, email your comments to 51395 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Wilms <t_w_ <at> freenet.de>
To: guix-patches <at> gnu.org
Cc: Thorsten Wilms <t_w_ <at> freenet.de>
Subject: [PATCH] gnu: mda-lv2: Remove unnecessary search-path-specification.
Date: Mon, 25 Oct 2021 21:15:14 +0200

---
 gnu/packages/audio.scm | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index faf106fc68..f43964a804 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5556,10 +5556,6 @@ (define-public mda-lv2
      `(("lv2" ,lv2)))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
-    (native-search-paths
-     (list (search-path-specification
-            (variable "LV2_PATH")
-            (files '("lib/lv2")))))
     (home-page "https://drobilla.net/software/mda-lv2")
     (synopsis "Audio plug-in pack for LV2")
     (description
-- 
2.33.1

Message #8 received at 51395 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Nathan Dehnel <ncdehnel <at> gmail.com>, 55069 <at> debbugs.gnu.org, 
 51395 <at> debbugs.gnu.org, 49008 <at> debbugs.gnu.org, 49028 <at> debbugs.gnu.org, 
 46210 <at> debbugs.gnu.org
Subject: Re: bug#55069: Add some means to find LV2 plugins
Date: Sat, 23 Apr 2022 14:45:54 +0200

[Message part 1 (text/plain, inline)]

> [PATCH] gnu: mda-lv2: Remove unnecessary search-path-specification.

Isn't it currently necessary?  Because lv2 doesn't have a LV2_PATH
search path yet.

Nathan Dehnel schreef op vr 22-04-2022 om 17:13 [-0500]:
> It seems DAWs and plugins can't find each other because there is no
> way to find the plugins outside of the store because there is no
> directory where the plugins are aggregated, and $LV2_PATH isn't set.

I think this would be resolved by adding the search path to the 'lv2'
package (and removing it from lv2-mda-piano, mda-lv2 and calf).

> [PATCH] gnu: Add invada-studio-plugins-lv2.
> [PATCH] gnu: Add distrho-ports-lv2.
> [PATCH] gnu: Add omins-lv2.
> [PATCH] Add drumgizmo

The convention is to add the search paths to the users of the plugins,
not the plugins theirselves.  Cf. GUILE_LOAD_PATH, LIBRARY_PATH,
MINETEST_MOD_PATH, EMACSLOADPATH, INFOPATH ...  See
<https://issues.guix.gnu.org/49533#5>.

The benefit is that this avoids forgetting LV2_PATH for some plugins,
as it only needs to be added to relatively few places (lv2 itself,
maybe guitarix, maybe ir, arour ...).

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.