GNU bug report logs - #51386
29.0.50; fido-vertical-mode: ssh host completion

Previous Next

Package: emacs;

Reported by: Manuel Uberti <manuel.uberti <at> inventati.org>

Date: Mon, 25 Oct 2021 14:39:01 UTC

Severity: normal

Merged with 52758, 53513, 54042, 60505

Found in versions 28.0.50, 29.0.50, 29.0.60

Fixed in version 29.2

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log


Message #80 received at 51386 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 51386 <at> debbugs.gnu.org, Manuel Uberti <manuel.uberti <at> inventati.org>
Subject: Re: bug#51386: 29.0.50; fido-vertical-mode: ssh host completion
Date: Wed, 27 Oct 2021 13:10:52 +0200
Gregory Heytings <gregory <at> heytings.org> writes:

Hi Grepor,

>> If I do instead
>>
>> emacs -Q -l tramp --eval "(setq completion-styles '(basic flex))" -f
>> fido-vertical-mode
>>
>> it doesn't work. Debugging of fido-vertical-mode is needed, I suppose.
>>
>
> This has already been done, as Manuel suggested the solution would be
> to add a fallback in icomplete--fido-mode-setup, which amounts to
> doing (set completion-styles '(flex basic)).

Yep. However, even if I apply this patch to icomplete.el and also your
Tramp patch it doesn't complete method names like "/ss TAB". So this
cannot be the proper solution I believe.

And, beside of fido-vertical-mode, your Tramp patch hides the method
names at all. If I try

emacs -Q -l tramp --eval "(setq completion-styles '(flex basic))"

and apply then 'C-x C-f /ss TAB', it offers only the candidate '/sys/',
and nothing else. W/o your patch, there are the candidates

--8<---------------cut here---------------start------------->8---
Possible completions are:
sshfs: 	ssh:
sshx: 	sys/
--8<---------------cut here---------------end--------------->8---

Anyway, all our tests are mood. I would really appreciate if a
completion style author could chime in, and could investigate. I don't
say that there isn't an error in Tramp, but before I accept patches I
must understand what's up. And the proposed patch doesn't fix all cases
sufficiently (plus it violates the API, but this we have discussed
already in several rounds).

Best regards, Michael.




This bug report was last modified 2 years and 91 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.