GNU bug report logs - #51384
28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap

Previous Next

Full log

View this message in rfc822 format

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 51384 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap
Date: Thu, 15 Sep 2022 11:00:09 +0200

On Sep 15 2022, Robert Pluim wrote:

>>>>>> On Thu, 15 Sep 2022 09:39:43 +0200, Robert Pluim <rpluim <at> gmail.com> said:
>
>     Robert> The patch has shrunk in the meantime, somebody simplified the code ;-)
>
> Although, apart from the patch missing a paren, it doesnʼt work,
> because Iʼve forgotten how Lisp lists work :-)
>
> diff --git a/lisp/help.el b/lisp/help.el
> index 15ab3192ad..90476e4a4f 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -1204,7 +1204,11 @@ substitute-command-keys
>                  (delete-char 2)
>                  (let* ((fun (intern (buffer-substring (point) (1- end-point))))
>                         (key (with-current-buffer orig-buf
> -                              (where-is-internal fun keymap t))))
> +                              (where-is-internal fun
> +                                                 (if keymap
> +                                                     (list keymap)
> +                                                   keymap)

aka (and keymap (list keymap))

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.