From unknown Fri Jun 20 07:25:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51384 <51384@debbugs.gnu.org> To: bug#51384 <51384@debbugs.gnu.org> Subject: Status: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Reply-To: bug#51384 <51384@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:25:50 +0000 retitle 51384 28.0.60; substitute-command-keys finds global binding for und= o instead of in specified keymap reassign 51384 emacs submitter 51384 Robert Pluim severity 51384 normal tag 51384 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 05:57:45 2021 Received: (at submit) by debbugs.gnu.org; 25 Oct 2021 09:57:46 +0000 Received: from localhost ([127.0.0.1]:41679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mewjh-0008Ez-Nj for submit@debbugs.gnu.org; Mon, 25 Oct 2021 05:57:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:47684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mewjg-0008Em-6S for submit@debbugs.gnu.org; Mon, 25 Oct 2021 05:57:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mewjf-0006dv-U7 for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 05:57:43 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:37841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mewje-0007Kd-2M for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 05:57:43 -0400 Received: by mail-wr1-x430.google.com with SMTP id e12so11763348wra.4 for ; Mon, 25 Oct 2021 02:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=WomoSqangYxi0f+BFlQjaoOhpySsOtcrfzyeQ/fDPF0=; b=lmaoiFnauXgz3J2fNOl5ZcMwLYSrtKJ3mM0pJFJVwUKXca1VV/dzGaMOGDsBCCMnu0 Td1JshYYZGtTD+0CS60azqeJuyhpOZWk3wmofXSVceeri8Vccfax8njLDvZJ2KSZiJPQ LPRkrQ7OWk26EqpFKjS5SGYevqbdBOwINspYskAn3hi7YoCI5JGfyQhX0k9Wbjc903Rn L9YA9NZrfP0ltdHvLLhJxyTuB/tNeRPmFb18bVwcHDKyPsdbwDPs7Tw28d/UzyVWB6fS 80L797BUBbd47RAbLkS4advz63snWghERCSUW9bQ/xbfSmb88Im4sxetZlVKZRd1zKRw 5aVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=WomoSqangYxi0f+BFlQjaoOhpySsOtcrfzyeQ/fDPF0=; b=OE06PKUV/aeDZV+n8jU2XKfBaesgJm9++WnIJwhHubp0YunBAYUaGSEOwIp3Ra0xwq RAYqR7NOSOqcxKFskbY5dNc2+DMdJQh45LdtaB017UmwWXH5pG3thZHVXmgdDmBujaof /expyct9taPxnpbKKzYLGgU5MFE5Rz4B4tktR/FQBckmNpM6NL2ZX/hLduwMY07tzvIL puW4e76Y3vs1IipmFWxIsoxaHYeRRegI5nY9oCAoCQww4bphEA/rgP+l+O5bKrjAX7pl FqHlmKf7YNQZKWvo4MJFbx8LB05vZ7Ofi5bCi0Z4RPfU58V3f1i/QUPGoCUxnJEagyWk EckA== X-Gm-Message-State: AOAM533AbZu+Mow038KpYHbu3QrIPC2S40pI7mvbsJixzrFrZgobavjG FPBn2P3Z57CfYohei12m6vsdXA4sl0s= X-Google-Smtp-Source: ABdhPJxlfUwK3EphyL14hgRsBUvUyRQxDXZjRXlpYROTI62TCl1UI6oI7kEXf75wfeXS+rTMxnZpNQ== X-Received: by 2002:adf:f70f:: with SMTP id r15mr20861129wrp.328.1635155860136; Mon, 25 Oct 2021 02:57:40 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v6sm1635534wrx.17.2021.10.25.02.57.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 02:57:39 -0700 (PDT) From: Robert Pluim To: bug-gnu-emacs@gnu.org Subject: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap X-Debbugs-No-Ack: yes Date: Mon, 25 Oct 2021 11:57:38 +0200 Message-ID: <877de1s9yl.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The \ construct is documented to set the keymap for subsequent \[COMMAND] lookups, but for some bindings it doesn=CA=BCt seem to work, finding the global binding instead: emacs -Q (require 'repeat) (substitute-command-keys "\\\\[undo]") =3D> #("C-x u" 0 5 (face help-key-binding font-lock-face help-key-binding)) (substitute-command-keys "\\{undo-repeat-map}") =3D> #("key binding --- ------- u undo " 49 50 (face help-key-binding font-lock-face help-key-binding) 50 52 (font= -loc\ k-face nil face nil)) This is a with-native-compilation emacs-28, but emacs-28 without native compilation behaves the same. In GNU Emacs 28.0.60 (build 7, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, c= airo version 1.16.0) of 2021-10-24 built on rltb Repository revision: b0d64be0bc581958bf3a74152a2cd10172916b03 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-native-compilation' Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 06:16:20 2021 Received: (at 51384) by debbugs.gnu.org; 25 Oct 2021 10:16:20 +0000 Received: from localhost ([127.0.0.1]:41689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mex1f-0000Jk-Tv for submit@debbugs.gnu.org; Mon, 25 Oct 2021 06:16:20 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:51707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mex1a-0000JY-Jr for 51384@debbugs.gnu.org; Mon, 25 Oct 2021 06:16:18 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Hd9pP5JFZz1s9Qv; Mon, 25 Oct 2021 12:16:13 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Hd9pP2zGfz1qqkB; Mon, 25 Oct 2021 12:16:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id JRR8gSVu4lnS; Mon, 25 Oct 2021 12:16:12 +0200 (CEST) X-Auth-Info: FLB2rimty/f+RxG8eBdcBXxbl5jJrnEwnFSeR8nEHWNxy0yl1SVL0IWER9QFgRtM Received: from igel.home (ppp-46-244-179-15.dynamic.mnet-online.de [46.244.179.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 25 Oct 2021 12:16:12 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 3E9682C2635; Mon, 25 Oct 2021 12:16:12 +0200 (CEST) From: Andreas Schwab To: Robert Pluim Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap References: <877de1s9yl.fsf@gmail.com> X-Yow: In order to make PLANS for the WEEKEND...so that we can read RESTAURANT REVIEWS and decide to GO to that restaurant & then NEVER GO...so we can meet a FRIEND after work in a BAR and COMPLAIN about Interior Sect'y JAMES WATT until the SUBJECT is changed to NUCLEAR BLACKMAIL...and so our RELATIVES can FORCE us to listen to HOCKEY STATISTICS while we wait for them to LEAVE on the 7:48.... Date: Mon, 25 Oct 2021 12:16:12 +0200 In-Reply-To: <877de1s9yl.fsf@gmail.com> (Robert Pluim's message of "Mon, 25 Oct 2021 11:57:38 +0200") Message-ID: <87o87d9zpv.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Okt 25 2021, Robert Pluim wrote: > (substitute-command-keys "\\\\[undo]") > => #("C-x u" 0 5 (face help-key-binding font-lock-face help-key-binding)) :advertised-binding takes precedence. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 06:39:25 2021 Received: (at 51384) by debbugs.gnu.org; 25 Oct 2021 10:39:25 +0000 Received: from localhost ([127.0.0.1]:41707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mexO0-00015E-UL for submit@debbugs.gnu.org; Mon, 25 Oct 2021 06:39:25 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:36669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mexNy-00014z-Gy for 51384@debbugs.gnu.org; Mon, 25 Oct 2021 06:39:22 -0400 Received: by mail-wr1-f49.google.com with SMTP id w15so8333704wra.3 for <51384@debbugs.gnu.org>; Mon, 25 Oct 2021 03:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=D7WEgvjIBN0w7PqBSMU/XBBz/mXjNWxF5ZeGxyZIrDA=; b=Fq5uOunXVViu2SSolpQzslrX9zkpsbt+h4OEvkh7HTJ6xapsCz4CWmpZRtSDp5S8T2 noKOMsL1nB7pVc8/0pZtsuvAbaBptD9RqNldGtO75wxEBmZarYbFmLrVtQ9t4YPLm328 ZQmOELkD0ZrbynC4AIMpIcRO8w84RUO9CTK05owZaeYmOkENHMC2S6GykWAX4k3Zvhzl eErfYHRYFeR/4509NJsgoKgkIXvZwITXjvqCmi/i/unUWUJOdhx9exr7Z7ZReUByO/E/ plbJRgHzuUkqcOcXqeki8XSezj9+ewit22w32Eh6rWhM4xgtr5Hs+wJ7vVpCnmyyCMxJ RFGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=D7WEgvjIBN0w7PqBSMU/XBBz/mXjNWxF5ZeGxyZIrDA=; b=aNIMybHh+5b+YqwT8qkeZ8uVunFEowJ4+a/t6S6NSK5W1xQex42bm8Ip1igAPLNnJH rHPwCHVMktE/3W5lNbC9JJxxPlRvpe82DIhJINUbpd3mR2DRaQAPcZjqUOAEM/peIW7w vw1GnkKDbxfjdxAooqqa6a7BlYKj1mjGhdpbtbQ5pAzm5pnaD0L/nogvIbtAZe20ANzn zdzI5FKokAa1Rg1Hms/P1ebV89Dw9M5Q2kKXdMYwCJ9jEwrTo2bpogLKv5xSZJ0A+Hwl aFSfYwtr1JMqMljpMKe7EvTU0u99GtFfbp86dIci3rfp8sRqEeflvrk+1s2Jo0GXKw4R UU1A== X-Gm-Message-State: AOAM533rsyaICUC9qhdaYauRhgZqFl5y6SjEtRiSjo/kxBg6BynkTKDy FrV+/mJ24gqzYiwJx4vOGd5nB1rFTGM= X-Google-Smtp-Source: ABdhPJxMXYxMmZmenzh6CGp6DcTz9wak3QwLIfkFejz+97xMH1jN1xgPhDOA9GLFFndVyPcIXBzzUg== X-Received: by 2002:a5d:4a0a:: with SMTP id m10mr21970395wrq.8.1635158355880; Mon, 25 Oct 2021 03:39:15 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id f24sm15305560wmb.33.2021.10.25.03.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 03:39:15 -0700 (PDT) From: Robert Pluim To: Andreas Schwab Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> Date: Mon, 25 Oct 2021 12:39:14 +0200 In-Reply-To: <87o87d9zpv.fsf@igel.home> (Andreas Schwab's message of "Mon, 25 Oct 2021 12:16:12 +0200") Message-ID: <87y26hqtgt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 25 Oct 2021 12:16:12 +0200, Andreas Schwab said: Andreas> On Okt 25 2021, Robert Pluim wrote: >> (substitute-command-keys "\\\\[undo]") >> => #("C-x u" 0 5 (face help-key-binding font-lock-face help-key-binding)) Andreas> :advertised-binding takes precedence. So it does, which is unfortunate, underdocumented, and unnecessary, since just not specifying the map will get you the :advertised-binding anyway. \\(map) anyone, to mean "really only look up in this map"? Robert -- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 15 12:29:20 2021 Received: (at 51384) by debbugs.gnu.org; 15 Nov 2021 17:29:20 +0000 Received: from localhost ([127.0.0.1]:56041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmfnD-0001Dj-LB for submit@debbugs.gnu.org; Mon, 15 Nov 2021 12:29:19 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmfn5-0001D8-Li for 51384@debbugs.gnu.org; Mon, 15 Nov 2021 12:29:16 -0500 Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 1152CFF812; Mon, 15 Nov 2021 17:29:03 +0000 (UTC) From: Juri Linkov To: Robert Pluim Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Organization: LINKOV.NET References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> Date: Mon, 15 Nov 2021 19:25:16 +0200 In-Reply-To: <87y26hqtgt.fsf@gmail.com> (Robert Pluim's message of "Mon, 25 Oct 2021 12:39:14 +0200") Message-ID: <8635nxcow3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Andreas> On Okt 25 2021, Robert Pluim wrote: > >> (substitute-command-keys "\\\\[undo]") > >> => #("C-x u" 0 5 (face help-key-binding font-lock-face help-key-binding)) > > Andreas> :advertised-binding takes precedence. > > So it does, which is unfortunate, underdocumented, and unnecessary, > since just not specifying the map will get you the > :advertised-binding anyway. > > \\(map) anyone, to mean "really only look up in this map"? For readers of this bug report, here is a link to the discussion: https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg01845.html From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 15 12:48:10 2021 Received: (at 51384) by debbugs.gnu.org; 15 Nov 2021 17:48:10 +0000 Received: from localhost ([127.0.0.1]:56065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmg5R-0003z9-P2 for submit@debbugs.gnu.org; Mon, 15 Nov 2021 12:48:09 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:38588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmg5Q-0003ys-5i for 51384@debbugs.gnu.org; Mon, 15 Nov 2021 12:48:08 -0500 Received: by mail-wm1-f41.google.com with SMTP id p3-20020a05600c1d8300b003334fab53afso13598935wms.3 for <51384@debbugs.gnu.org>; Mon, 15 Nov 2021 09:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=2wo1huC0nGHVVcA9iYjIRZDC0DJTZ2nlF4VeugN1bEs=; b=izmR/RCCB0PG4rfz0oUO1ZjQKkk0f9zyKZ6SuNs30d5Z9V/7+cjB/a7x/u8OFwxUwL eSwVLub6tqLzFLKHTSVT4YMPRgwCg7DWSixskJ3HHqMFg9TENljfyczmD5nSI3D2iHwS l8Rxusx+p0+a8yJtcJv9H1ASKRzM4BbR6z9R2ld/BmAqWIFPzervZfMsUmsuSD85x+dp sPdEDYLH4FFktl2IriNDBOjJq7yN8O+pgGIWiJAJz9khgjVZGodrcaLSXK3saHbECONf L5SQJ1uot3MCiuPML7n17njcUUem4wLKwKWKhAbeA/9UnAuVuhYEwbkKVsbUhaWfIDoI 2Bwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=2wo1huC0nGHVVcA9iYjIRZDC0DJTZ2nlF4VeugN1bEs=; b=z6igj2kjSK55S6h3MZ3fpLeG5XSPOdbKH1F6BdLlosM8l4pgXUxctJfR+lb1RzO6xR pu13BUm5c6fE55i73nMEs1HjreKSkMczW7nplozAtAAvZrviGsjnJ5SOP8BGDctgCVIx McTNiYlV6eMYptkTnCyJJ4ioGbVX6IeWsWGqU86LdpeAgEFhthCc+k7d0IiH9jp4cdq5 TltLFp/qnmHp8T9g/bBvWtQm1RX8xcbW4vPUVDYVye24jy3G99rwi9Bly058NKxLJhGA 8DsO9gEQiOxp5Qc37kknMQOMkquC8ZNzXNZ3LGhjKzvDdezWzGD6mfJ+nqpuaihtpcoL RE+w== X-Gm-Message-State: AOAM533TcxH4GbG9SUtAfFrL48uPyZx+3qEJ8Rxfr8A6/eKSEpPr8EwC vx9QDUN1VsC8EZ0vvPx00FIPX0dlLc8= X-Google-Smtp-Source: ABdhPJwVozPJvbkKL6r03LlpZ6fa+yVY5EYGZn6a87VwlEr0FrdHdtYj93wZBn96fyeAaLYigw4v2w== X-Received: by 2002:a05:600c:1e8c:: with SMTP id be12mr4539709wmb.4.1636998481927; Mon, 15 Nov 2021 09:48:01 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:c894:e65c:c0bc:f1d9]) by smtp.gmail.com with ESMTPSA id o12sm20248825wrc.85.2021.11.15.09.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 09:48:01 -0800 (PST) From: Robert Pluim To: Juri Linkov Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> Date: Mon, 15 Nov 2021 18:48:00 +0100 In-Reply-To: <8635nxcow3.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 15 Nov 2021 19:25:16 +0200") Message-ID: <87czn1nwdr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 15 Nov 2021 19:25:16 +0200, Juri Linkov said: Andreas> On Okt 25 2021, Robert Pluim wrote: >> >> (substitute-command-keys "\\\\[undo]") >> >> => #("C-x u" 0 5 (face help-key-binding font-lock-face help-key-binding)) >> Andreas> :advertised-binding takes precedence. >> >> So it does, which is unfortunate, underdocumented, and unnecessary, >> since just not specifying the map will get you the >> :advertised-binding anyway. >> >> \\(map) anyone, to mean "really only look up in this map"? Juri> For readers of this bug report, here is a link to the discussion: Juri> https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg01845.html I have a change that will cause the lookups to happen in the specified map first, but I still need to audit the 50 or so uses of a command with an advertised binding in a docstring in the Emacs sources before I can declare it safe. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 14 14:30:06 2022 Received: (at 51384) by debbugs.gnu.org; 14 Sep 2022 18:30:06 +0000 Received: from localhost ([127.0.0.1]:56187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYX9C-0006X2-4M for submit@debbugs.gnu.org; Wed, 14 Sep 2022 14:30:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYX98-0006Vy-O0 for 51384@debbugs.gnu.org; Wed, 14 Sep 2022 14:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ihEFXho0WKQor0GPYsjFYvPXjgc/p6ongDx8QaLz5yY=; b=P8rykTW+gFq6ugWvMT73J9lG0t 31G4xWDalj/L5GK1zvj6vIVrtTuyPuQo5MC00xrzyuZYMqqhOt+AKDIcjq3VFdf4ckbXoeZWz40yH /DTc0+TLYtgexgmHnH2tn1rQEjTxj+whb3aKTig4rlziOyBDOQbV5Mhfd63gBIc0JAaE=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYX8z-0001Gd-Dn; Wed, 14 Sep 2022 20:29:55 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <87czn1nwdr.fsf@gmail.com> (Robert Pluim's message of "Mon, 15 Nov 2021 18:48:00 +0100") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> X-Now-Playing: 13 & God's _Own Your Ghost_: "Unyoung" Date: Wed, 14 Sep 2022 20:29:52 +0200 Message-ID: <871qsd4xnj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > I have a change that will cause the lookups to happen in the specified > map first, but I still need to audit the 50 or so uses of a command > with an advertised binding in a docstring in the Emacs [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > I have a change that will cause the lookups to happen in the specified > map first, but I still need to audit the 50 or so uses of a command > with an advertised binding in a docstring in the Emacs sources before > I can declare it safe. This was more than half a year ago -- did you get any further here? (I agree that the explicitly specified keymap should take precedence over :advertised-key-binding.) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 03:39:55 2022 Received: (at 51384) by debbugs.gnu.org; 15 Sep 2022 07:39:55 +0000 Received: from localhost ([127.0.0.1]:56895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYjTX-0002Br-Im for submit@debbugs.gnu.org; Thu, 15 Sep 2022 03:39:55 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:38884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYjTT-0002Bb-HZ for 51384@debbugs.gnu.org; Thu, 15 Sep 2022 03:39:54 -0400 Received: by mail-wr1-f54.google.com with SMTP id b5so29403947wrr.5 for <51384@debbugs.gnu.org>; Thu, 15 Sep 2022 00:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=TWg0C50eAj8ttuZ1DPPI9gsgqJr4oE5lHMNBaW0cuW0=; b=kZMSPDPFDoDEc4TFgk3CuoYFehU2OLJZwZMYgWskfjrI+oJQy3JgpXf+f9kdnB0N+x HMwJlZCJR/2rpeSRYqZ38N8DqFZauWFCm0yz1tGqMBpIraaiOjg2CpNspWESpTQePmZK NXnP1zNroLUtFJxR4MF6Y6FZjonCx71L7bnCBr2QOypBZw2pigW6eUKeA7H1EsiJZebr gjKpCN14XD8RrT+WJzlYpV5SRcabH3rWV2Y3zzjZM9UJhEUWNIdhQZQAgqbqFzfzovxj DvCsGI9BOn1B5x2W/k/kQxszugPjpVTP2qNYVNBWNm/kHYTLVNklZbNykB8ZQFlEQoSs euCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=TWg0C50eAj8ttuZ1DPPI9gsgqJr4oE5lHMNBaW0cuW0=; b=KIwgLb38ManBsLmEbaGaL2qWYLveGftrCfPoB7FeQCQMGT00Lgz0xwuFnPrnZuUXSE 2L4syKq8OIHfcdFoaPgR3iA2xeCIOm5RGuhGAyBkVjBK7ScLV2EhRGggcYeHnqlivtky waj0H1xPLWLUXaofvzTxvybopnW8b4bY15C4KFU1lQPBJTKWYVDs9J0p42KztV3+C7OE Zr1aBJN4OctxFY9+tdKFoLeeu27KoKs9d9R3yFilModYQHXisEYuT0CS3GNfx7M9zNjr SDATnX0Gma9KXyCG7djZptBRo6GFW/1JqKdK/RFJPjZ23uEBVyHzvGXjd1zvvbsaHlsm 2aiQ== X-Gm-Message-State: ACgBeo2hNmHa3IZLyyIj5dadeR0ZB7CQ7W+AegWokhqFLyS0FolNlaMY 1YIsFBenIMe1zBtZicOciEE= X-Google-Smtp-Source: AA6agR51WaHtkldvsBQXLwsDW6dlyP9oQgQW+fR2tn1rmsbvB8ZfpmBVj6ArNtt9UQhwvgdjY1fxFQ== X-Received: by 2002:a5d:65ce:0:b0:228:d8b6:d1 with SMTP id e14-20020a5d65ce000000b00228d8b600d1mr23281345wrw.486.1663227584575; Thu, 15 Sep 2022 00:39:44 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id l32-20020a05600c1d2000b003a845fa1edfsm1674928wms.3.2022.09.15.00.39.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 00:39:44 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <871qsd4xnj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Sep 2022 20:29:52 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> Date: Thu, 15 Sep 2022 09:39:43 +0200 Message-ID: <877d25krwg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 14 Sep 2022 20:29:52 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> I have a change that will cause the lookups to happen in the specifi= ed >> map first, but I still need to audit the 50 or so uses of a command >> with an advertised binding in a docstring in the Emacs sources before >> I can declare it safe. I don=CA=BCt think any of the advertised bindings caused a problem, but I=CA=BCll double check. Lars> This was more than half a year ago -- did you get any further her= e? (I Lars> agree that the explicitly specified keymap should take precedence= over Lars> :advertised-key-binding.) The patch has shrunk in the meantime, somebody simplified the code ;-) Robert diff --git a/lisp/help.el b/lisp/help.el index 15ab3192ad..263775e64e 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1204,7 +1204,8 @@ substitute-command-keys (delete-char 2) (let* ((fun (intern (buffer-substring (point) (1- end-poin= t)))) (key (with-current-buffer orig-buf - (where-is-internal fun keymap t)))) + (where-is-internal fun (ensure-list keyma= p) t))) + (if (not key) ;; Function is not on any key. (let ((op (point))) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 04:55:35 2022 Received: (at 51384) by debbugs.gnu.org; 15 Sep 2022 08:55:35 +0000 Received: from localhost ([127.0.0.1]:57049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYkek-0004GG-Nd for submit@debbugs.gnu.org; Thu, 15 Sep 2022 04:55:34 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:42927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYkei-0004G1-As for 51384@debbugs.gnu.org; Thu, 15 Sep 2022 04:55:34 -0400 Received: by mail-wm1-f52.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so2831032wmq.1 for <51384@debbugs.gnu.org>; Thu, 15 Sep 2022 01:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=RLMBqEz8bGF5Vs1ju41Gwvip7yzczeETUksPENCkRig=; b=jlaK9cab2eGQp8AljIqMmcXKvENrhv4/3Wlvk8LHqTuyx0XpOSUpGzqp6myX2VGYo6 jxBRMdupTYqzDuLjNm1BpUbjdg8ug09vn8sD1OM3+2BsBJ8uzQsS4UH9+rFlof2xS+4S OvTHfJdxnTK7Pfgn8kQHodpAMjJnYpK3L73JYxDxBuUgmU8fjdl4FhU8shkxbYOVfoDA i6GGqJvghIkC+y6J/9XVpn9yv9HSplJCOa+GvyTmiMrybqBrCdwu2gJvotzzzI5N7AkM 9lO5gjQbQTxMcmZF6UTDfnffH4bpEpU7pjnxzKyeCmmYjP807IDre7ReWWOn6REAbGIw H2Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=RLMBqEz8bGF5Vs1ju41Gwvip7yzczeETUksPENCkRig=; b=iizP7sjtysDveOTFkzRg0QbO5iU0M+1hR4sSKFI1Nje/4bWbHnptwvg5f8cKJeYzLG cNxVIHsvtH5t6Pn7dkriL7MLBA7ZwpVsPZNy7lreCc5VrvcVumZtl/qMCvIUStVCibnX OeghvEBbHdZYndfPD/cDRxWU/KvPVpxHaN0Pl4Ho/St3iBsR3pCLkugb7I3OwKVyIQUS /OPTjRVCx0PklHfkNCr+drtF24wVRY4wRA9RrnjTdlQIPEe7jC49h1v/DqCz4M2zY0A0 wbXFG8mlVDpiUiSefEjiFqE1uYKya7owe8c7bbTN2JryuECWsiwv5yYQTGdFqQN+04Jg G+rA== X-Gm-Message-State: ACgBeo367/RNLn4iFR5kYxbC4y9y2E3Rj1zpsnMTsWCFM8Kq3AUyngMz tBUMfobClEeDVmQNZ5TLK8o= X-Google-Smtp-Source: AA6agR5v3d6Bi/EvZ8Pq8tTBdYuzcqaZv2vODi96y1isLTQi6/PZy/ca9Uz7EXxPtvg4QuOCTx8hXA== X-Received: by 2002:a1c:19c4:0:b0:3b4:a1da:76c3 with SMTP id 187-20020a1c19c4000000b003b4a1da76c3mr4924956wmz.106.1663232126149; Thu, 15 Sep 2022 01:55:26 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id d16-20020a05600c049000b003a63a3b55c3sm1997693wme.14.2022.09.15.01.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 01:55:25 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <877d25krwg.fsf@gmail.com> (Robert Pluim's message of "Thu, 15 Sep 2022 09:39:43 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> Date: Thu, 15 Sep 2022 10:55:24 +0200 Message-ID: <871qsdkoeb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 15 Sep 2022 09:39:43 +0200, Robert Pluim s= aid: Robert> The patch has shrunk in the meantime, somebody simplified the c= ode ;-) Although, apart from the patch missing a paren, it doesn=CA=BCt work, because I=CA=BCve forgotten how Lisp lists work :-) diff --git a/lisp/help.el b/lisp/help.el index 15ab3192ad..90476e4a4f 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1204,7 +1204,11 @@ substitute-command-keys (delete-char 2) (let* ((fun (intern (buffer-substring (point) (1- end-poin= t)))) (key (with-current-buffer orig-buf - (where-is-internal fun keymap t)))) + (where-is-internal fun + (if keymap + (list keymap) + keymap) + t)))) (if (not key) ;; Function is not on any key. (let ((op (point))) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 05:00:14 2022 Received: (at 51384) by debbugs.gnu.org; 15 Sep 2022 09:00:14 +0000 Received: from localhost ([127.0.0.1]:57062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYkjG-0004Oq-DK for submit@debbugs.gnu.org; Thu, 15 Sep 2022 05:00:14 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:50867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYkjE-0004Og-TD for 51384@debbugs.gnu.org; Thu, 15 Sep 2022 05:00:13 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4MSrkg4bNtz1r1NT; Thu, 15 Sep 2022 11:00:11 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4MSrkg2Clbz1qqkg; Thu, 15 Sep 2022 11:00:11 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id o20G3cEWMwqY; Thu, 15 Sep 2022 11:00:10 +0200 (CEST) X-Auth-Info: IunpReIzFslRzrxhF/ZWX0ouJoVla6NC4ySCIbpu32V1vv1Wik9JiAnXusBMt+T3 Received: from hawking (unknown [81.95.8.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 15 Sep 2022 11:00:10 +0200 (CEST) From: Andreas Schwab To: Robert Pluim Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <871qsdkoeb.fsf@gmail.com> X-Yow: .. I have a VISION! It's a RANCID double-FISHWICH on an ENRICHED BUN!! Date: Thu, 15 Sep 2022 11:00:09 +0200 In-Reply-To: <871qsdkoeb.fsf@gmail.com> (Robert Pluim's message of "Thu, 15 Sep 2022 10:55:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51384 Cc: Lars Ingebrigtsen , 51384@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sep 15 2022, Robert Pluim wrote: >>>>>> On Thu, 15 Sep 2022 09:39:43 +0200, Robert Pluim said: > > Robert> The patch has shrunk in the meantime, somebody simplified the code ;-) > > Although, apart from the patch missing a paren, it doesnʼt work, > because Iʼve forgotten how Lisp lists work :-) > > diff --git a/lisp/help.el b/lisp/help.el > index 15ab3192ad..90476e4a4f 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -1204,7 +1204,11 @@ substitute-command-keys > (delete-char 2) > (let* ((fun (intern (buffer-substring (point) (1- end-point)))) > (key (with-current-buffer orig-buf > - (where-is-internal fun keymap t)))) > + (where-is-internal fun > + (if keymap > + (list keymap) > + keymap) aka (and keymap (list keymap)) -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 05:04:38 2022 Received: (at 51384) by debbugs.gnu.org; 15 Sep 2022 09:04:38 +0000 Received: from localhost ([127.0.0.1]:57083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYknV-0004Wp-Uy for submit@debbugs.gnu.org; Thu, 15 Sep 2022 05:04:38 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:51115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYknU-0004Wb-89 for 51384@debbugs.gnu.org; Thu, 15 Sep 2022 05:04:37 -0400 Received: by mail-wm1-f49.google.com with SMTP id ay36so3845847wmb.0 for <51384@debbugs.gnu.org>; Thu, 15 Sep 2022 02:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=5BaDXAKZ275KpAuaNMZ38y/fKKX6g7a49ka/kBChGRw=; b=Z8UtCQ0ra/mL8Y0IUMJd9lefFEZlEvUFUxnSXPYLI4Lctje0txdH7jLUg9CJ7lHjQK kcoK0bIeJZu+itaVcNX8W7zzoSGaFyTvNVOG8CzOjKXSQVzImPZl++bRvrqA7GCAMeDq 01kKbhHyfVQSDZ4eW3Ktyu/LuFZBBHCzSfi60uhcgx616QGLtC9ObV6bmOXeI6TfjwBy AQTVmR77el9eOF7LIqdUdJYyUs1wiopu7MGOVfp15hP8UEYeYkVQFZyZrpiNRMtWVt/d 8ThhpZCIvav9/h39enxusZgv6WTbjiuOaDBRUebvgiJuZFdTL4+6YemTWHalFVE0dTlq P63g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=5BaDXAKZ275KpAuaNMZ38y/fKKX6g7a49ka/kBChGRw=; b=mfw+TPb+WvH8aPrtrAa6jmUksjUDMmgGlpFAMcnZ68O+1oaOJMMQ+2HMOcYQn91u7P 55FcyoQoB9PzxBrUSqbDgkGpsCZogVS49zGWdLGzSgjMgi8T5y6W0HdSliQdnzoNU/f4 lLFFaPTlYdbp//OUL7NQNp2pEmiw5xzuRC/5yvR9km2duxvGun4YfF96+nO2QkohYgov E0tDEiDWkz18EWHn9f4HZ2YybEYwpneSVdRvkUHIVXSKGz9TBr2lsmZ3Y1i70KJamQ3s aynWRDPJaXi0qjsj6OU+iruU28CNQISLBYEqfx47MnHdH3UTc/hHHo872ZsLzt3gQo57 BUvg== X-Gm-Message-State: ACgBeo3jPdelqYjvaBJ7/cl7n+mpqzkfH4zn2mN51IlkaqMO5q6pvZam GSc+2Ag3IpO4m6VijZykPb+5o5ENkd8= X-Google-Smtp-Source: AA6agR6pqBVFSUN0cMWygjbOIqUxw3WqZ/c69P+TjVSN4NfhrFsb6U1KQZ1ghPf1NLRC3/FbwMdGng== X-Received: by 2002:a05:600c:ace:b0:3b4:621f:93f4 with SMTP id c14-20020a05600c0ace00b003b4621f93f4mr5794137wmr.8.1663232669808; Thu, 15 Sep 2022 02:04:29 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id e28-20020adf9bdc000000b00228c375d81bsm1963087wrc.2.2022.09.15.02.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 02:04:29 -0700 (PDT) From: Robert Pluim To: Andreas Schwab Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: (Andreas Schwab's message of "Thu, 15 Sep 2022 11:00:09 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <871qsdkoeb.fsf@gmail.com> Date: Thu, 15 Sep 2022 11:04:28 +0200 Message-ID: <87wna5j9er.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: Lars Ingebrigtsen , 51384@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 15 Sep 2022 11:00:09 +0200, Andreas Schwab said: Andreas> On Sep 15 2022, Robert Pluim wrote: >>>>>>> On Thu, 15 Sep 2022 09:39:43 +0200, Robert Pluim said: >>=20 Robert> The patch has shrunk in the meantime, somebody simplified the c= ode ;-) >>=20 >> Although, apart from the patch missing a paren, it doesn=CA=BCt work, >> because I=CA=BCve forgotten how Lisp lists work :-) >>=20 >> diff --git a/lisp/help.el b/lisp/help.el >> index 15ab3192ad..90476e4a4f 100644 >> --- a/lisp/help.el >> +++ b/lisp/help.el >> @@ -1204,7 +1204,11 @@ substitute-command-keys >> (delete-char 2) >> (let* ((fun (intern (buffer-substring (point) (1- end-point)))) >> (key (with-current-buffer orig-buf >> - (where-is-internal fun keymap t)))) >> + (where-is-internal fun >> + (if keymap >> + (list keymap) >> + keymap) Andreas> aka (and keymap (list keymap)) Indeed. Either too much C or not enough coffee this morning. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 07:54:25 2022 Received: (at 51384) by debbugs.gnu.org; 15 Sep 2022 11:54:25 +0000 Received: from localhost ([127.0.0.1]:57387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYnRp-00052f-CE for submit@debbugs.gnu.org; Thu, 15 Sep 2022 07:54:25 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:8842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYnRl-00052W-Kj for 51384@debbugs.gnu.org; Thu, 15 Sep 2022 07:54:23 -0400 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28F92CGc021810; Thu, 15 Sep 2022 11:54:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=YUMnnGjPnB5angbV3rMDpJeBXwdY7pXRHI5eY2OQZ2o=; b=dX2dsWrDzLVcWuEeJwpWTnuIYpivpkYiOKsH28MdISlFfFdETpUDcryNQMjc3rg6HuZ3 Nk87PNkS5fpBVSxWrEPn8TNQ9CpKevWy+yCysAzypI8zTy+9HQhp7NpWG5GPO5zqbqM7 gmTtc/uPZtkf6lO1bXQOC8nHuvOkNF6g6SdAgjJdOUtrYfOWRuU3VOXNQpUDk/j2mOoy yLCXDKJjmZWFIe3etFRSLZyzVVTeDIAhcZgfz16mBQdWUWfNdd9yOpj2VhSGB14llY3l Wq9DSk1jE0+EI9eP5/0L/6F2/uvBEz+duTbjHJ+QI0pZKqP208oBLKlJoYOKKRocK2vP ig== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jjxypd0a6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Sep 2022 11:54:20 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 28FBUTE8004858; Thu, 15 Sep 2022 11:54:19 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jjyee48hv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Sep 2022 11:54:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZ/Jrm/zS2d/crnTEuKUAlThTURJnj/KN/hHLKLIsalYvjF7BJOdVZsMczDP0Bm26odcUkS4i2lUj0T/AEs+EFBrwM4MkSV7+wJL2/D61sF+K76C2nX3lUd2zCaeLv6SlqElqV6XCpLmp7ENJmlRBQh7GaQn+mdJVM/hBVUhqk/aZkHdOEIP99lKxora1JiYNaw8ItLMJZTW+tjVVKFETL30cntAC8jk6tlhJDTQeKVv/D2Qu2etDB6C7e00fPifsG1+TfKXNk3tMI6LY3i9SJ9fsjkajlUy4TmwW1Oaa7tPBwcnF8U2Dq1DSk8z7PV3/5f5r0GU9S2A+ECz9ArmiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YUMnnGjPnB5angbV3rMDpJeBXwdY7pXRHI5eY2OQZ2o=; b=Bd0R0+162iYD/pN0btx5fsgZo7KRxQhnx2KcNmxpunzLNJeadf1Fqt+J5QcN41X8q5slK5niUs8abKEjFuflSnUjDGQa8oMGK0/fgglBSaOiyMb1qHvXwY4ml7KBHBwMZ26rqa7J009A5E6JFaRDUDfaCsV1piY5JeMxGzZaUdMTFUjxQOYzJDv6YF7VGmv4dnCHd+JmhLkr5Tu7KIQ40TiMx/UqXe/kfX5EdedRB2QiJMygM43BzVyKp9BG5nJPVXbHLuWNjRWQVowKn2ThagIX5lvs/38t6cKsZMtPW4sT+xFBHkiqz3u0xTWCXyObJsLnDE1h2VN7yQwkWmfh6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUMnnGjPnB5angbV3rMDpJeBXwdY7pXRHI5eY2OQZ2o=; b=JsQSsZ/wN0ma1DKdH7HkNQTSZ+T8ByFfY6F2UTH65wjo+T69HC12BOCRyXamrv4xbrnrRhCkiMETTazKGd/IWBecLqanpLxOfDMd2HE918S4+M+qsZluDP2dmtw/xiSqcj3KBAkhNVwIQSD31w43W2Undb+9jTBsj6KAFRGMHrY= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BY5PR10MB4305.namprd10.prod.outlook.com (2603:10b6:a03:20e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 11:54:17 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8972:615f:6c97:c027]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8972:615f:6c97:c027%3]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 11:54:17 +0000 From: Drew Adams To: Andreas Schwab , Robert Pluim Subject: RE: [External] : bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Thread-Topic: [External] : bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Thread-Index: AQHYyOHguyUU+q6iN0+MP13UdXWI8q3gYbtg Date: Thu, 15 Sep 2022 11:54:17 +0000 Message-ID: References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <871qsdkoeb.fsf@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|BY5PR10MB4305:EE_ x-ms-office365-filtering-correlation-id: 3b2eaf5a-be50-408c-2be3-08da97110484 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gD8GG/XyIqLNlDQx1EBywySqILJo94stHmcyI4jkk3Stn3YuLcDBK/9JF+RDC5ZVF7rReZoxEG0H89e5kLZ5iryTVqrkLSkQvcz11O641LyT7zYwZAK6JrRsnr1k6uiZdhb7wcWQVe1ltkvkjYlQmic/0vGQLY/7KrBm6wz4Co+pint4pm/fWqwXCyFnRecJ8mj1GeA+ENoxULUBQGJlzMPjFYJgcmElr4HJ+Q27BSFm55cR/1Xgf/TW7kYcJrtgPCZDTzTx1NhsUoSz7GDQEqDzAtHaLgMMy+SAo51sNQGTxZypLsOv5i/PhGSVthW1+VBWnNj7cHzSonvrB5wX9jrLCEd5T3VOWScv1sPotPdnUIBloYex44PcE1ZQqXzdo1u5yTvpHHOX6AC4U2icULUY3aNUHZE9qTmGM7wzTO2laZtGMGND68UVPg0Z7rrG9hEgyGVuQQpzLDMQeK1x6XF63jj8EojRilP0FOAvh6Wg4fCL0OMlmdqb6IvbjQJb5p3eiShmpYmSTbpCFw6z4S42T0CiEm8rfj7WQgV8O2AV2HDnpRJ0KFAqmx0YWlvQz4hoC+3pK3B0GetymhXIWH6FVZOLLAdhciEEyHIOWwUVvbZcmPpDsIlmHLqBoDyIAtrfvKyT/6ULawC76EZxWS+JM4UjiRLgnDGYfTL9A2Uosvn6b84j9j1NwMyALAtUfsN6s+L4dD11XKP60pktD/oNfMZ2ApGiDD6dyqDkzV8vaO0qsJu8UQIVlHNzlDIHNdELI4cqjsSHdwkxaSfzGw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(376002)(136003)(396003)(346002)(451199015)(38100700002)(186003)(38070700005)(122000001)(52536014)(5660300002)(4326008)(2906002)(8676002)(8936002)(44832011)(55016003)(66946007)(66446008)(9686003)(478600001)(71200400001)(26005)(41300700001)(64756008)(66556008)(6506007)(7696005)(66476007)(316002)(110136005)(54906003)(558084003)(76116006)(33656002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aWErMjV1NGNySFVNeGdKVFcyRCs3R0ZUbStXVHE5ZlRtMzYrZmVDVGpGRmVU?= =?utf-8?B?cU9HUjdWUjNqYUtOdFRoRklQN1JHWGZYRTJ0QUsrZkhvcndHdDF2Mm12cnZ1?= =?utf-8?B?SDhicTZZTnBqQ1hBSXFtZ2tZVmZJZnMveHh4LzhnUU43ZkJkakUvRVpDUjlI?= =?utf-8?B?cWtuTUc4aWUybXVML2lyVkhVdUJzTnFrazlySFdMUk14V09XRW83aHJZNlNp?= =?utf-8?B?UHBjLzdCVlFQdmgxYUtwMzBtNS8zUEttNEN6eE5TZWo5NDJvcTlhV0NkN3h3?= =?utf-8?B?WVdoalpEQ2d0dlA0KytqUy84V1Q3K3AxaGM2TEY3ZmVNalpEdFB4dUc0eUV3?= =?utf-8?B?VnE4Sy9wT201MkRiRE1JckZMbHpHRVg0S0ZqQ1JjeFo1Z0ZvUFVmWHVhb05t?= =?utf-8?B?eHJzK1BjM21LK3R6cXA3cnJjWjZXTmFkQm9FQzlja1g0TzlrSzd1allBbCtD?= =?utf-8?B?eXZ1bFk2cGdjM3I1RlZ2R3J3MS91dUlPanZRRFA0WXBacGk3dUZhMHVaMXZV?= =?utf-8?B?bnFyb0JiL2lJc0p3N1QvSHVaSVQ5dnJiMFRNVVozWUFJZ0kveDdiQS9iNmFH?= =?utf-8?B?eVZtclg0dEN0OEVmNnFvTXEvS3M0SklFajB2cVpJYTREV05MTlhMU1NmSW1N?= =?utf-8?B?WlJZNHZzTm5sTnc3NnpFcExrUjBMcXpOdVBqam1tNkJsRXVwOWwySHZCM04x?= =?utf-8?B?d1QrWHY3ODh6aEF3K2R0MTdqckhoSW81VWxkK1o4aytzQUpQdFFZaGdmeGNL?= =?utf-8?B?ckw3dXMyTnlnMFpwZVFDMlkvOU02T05NQXEyaDNYS1EvMzg3RG1YcW5HSEUy?= =?utf-8?B?TDNaTUx3VlV5UEtHTXhEaEVyUzZEVHdoeUVacG1hdGJSNGt1UTFjSnJMdTd1?= =?utf-8?B?VXRObDAwOE1jMDV6TWw1UFpjOGZISTBBL1pDS1VTRkVKRFlJSTBGK1ZBeDFj?= =?utf-8?B?NWNScnJuMms2Yi9mNzh6bDVoVGthcHZrQ3BtcGl3ZmxWRlpYZTZDeEN3dml3?= =?utf-8?B?cXdpekp6ZlMxQjJZOS9GUmlJei82USs4SkhPdlV1dFUrM2t1YzE1TzN4TWVi?= =?utf-8?B?R2hkM291WXlqK0ZKVUtlVFlvSW1GdnVwMEFhdWcyZ3J0SG1FeDZKaU5IZjNC?= =?utf-8?B?NS9IdWNQRisyZGwwTkxLV01JUG84dW1KZzBDRWVrM21ZMGVsL1Q5N1hmQ1ZE?= =?utf-8?B?ckd2VkxFc3dkeFBBTHNKRW9sOVBzTndCUXBWeEcrS0szaHBGTWxnVmtaZi83?= =?utf-8?B?RnpKM3I0Rzc3Tk5sVXpvaEthK0RGU0hlQXhDVXh3Zm1UNTU3N24vU1MvT2pv?= =?utf-8?B?KzFScEFpRnE1U2t0ZWIyS1F4NWJ3R0g2R1ZPVjB2bzB1bjRLS091OFBDa2Fr?= =?utf-8?B?NzBLYlpjS1NNazJVZHZVMS9vbkg2ejFsN09OMWQxdHlNaHVtYm1nNHFzZHBI?= =?utf-8?B?OFJJTyttZXhDMFNXNjE2Q3MwdStqNzk0VHR2czVQYmhhYk1BM252bzNQbGxQ?= =?utf-8?B?SHJ4L3lZYktpYXl4WGxqZDJXMXZsQmU1K2J4d2pVVEJUQi91NzhPdXM1S2xx?= =?utf-8?B?QWNtbHlWOUFjUnBESzJzdTliaUhsU1gybCtyTTNVWndiSjR5Y2plbllsM05k?= =?utf-8?B?Qkw0TGJMQ2xoeW9MOVgvQVFjV2duSHkzd1BlbEY5RDhWM1pYNCs4N3I1aThM?= =?utf-8?B?OXF5Wm5JZkxCdk1VRCsvdkdGYkNPZG81Q3JBT2FEcU8wL2E0Y3hNNE11czFk?= =?utf-8?B?b1VISk8wZUFVQmltU0h0Q2tiZGZHMmRvMDdudEY0Mll1RFdvcUxhSzhQTEhj?= =?utf-8?B?MlQ5WDlhcWw3d1lLVGJicnFFY1ZROFR4dWF3ci8wc0hPL1lOcHRENW92SHU1?= =?utf-8?B?a21kbXhyZlhpSG1mL3Q1QnZCdHluM1lWdDhsKzRXekFuVDdYNnZ3N291YVZj?= =?utf-8?B?VDJ6aTdjaXhFMjRlVEViVUJyOUdyZFM4SDJ6NW12MmFIbEZMQWRTUkF0Sldv?= =?utf-8?B?SDBuQlRqVktDMk1kbW5hWUxZMDdrSXFZRk9lWW44aDRobmpDSThvMGlHSkg3?= =?utf-8?B?L0FjeEhQWEZ3YnplejZJMFJ2VDdGakRpTER0U0tGeTFBaFBZcUtxY3dxSFVT?= =?utf-8?Q?7U/e3nb1UM0nnMB+WoLxfCnoa?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b2eaf5a-be50-408c-2be3-08da97110484 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 11:54:17.2199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AYk8lIj2hGrjHBKwXpSLZaqSgmuN8RYdvW//kywS5cbEuqZ2BC8c8zMMbf8fjjPHE1i2+BH0Vy0mse1T1t+AsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4305 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_07,2022-09-14_04,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2208220000 definitions=main-2209150066 X-Proofpoint-ORIG-GUID: Jt1887veXYrqfCLahN10Nim-VnXs2ZUe X-Proofpoint-GUID: Jt1887veXYrqfCLahN10Nim-VnXs2ZUe X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51384 Cc: Lars Ingebrigtsen , "51384@debbugs.gnu.org" <51384@debbugs.gnu.org>, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiA+IChpZiBrZXltYXAgKGxpc3Qga2V5bWFwKSBrZXltYXApDQo+IGFrYSAoYW5kIGtleW1hcCAo bGlzdCBrZXltYXApKQ0KDQorMQ0K From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 05:29:38 2022 Received: (at 51384) by debbugs.gnu.org; 16 Sep 2022 09:29:38 +0000 Received: from localhost ([127.0.0.1]:41651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ7fG-0006Yl-0P for submit@debbugs.gnu.org; Fri, 16 Sep 2022 05:29:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ7fE-0006YX-4j for 51384@debbugs.gnu.org; Fri, 16 Sep 2022 05:29:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YR6KLwnInOIy8VvZ5AXWDcnIJDS7hAFZMevBz3cyQYU=; b=LdulDnO5PIlvKMB9w32stjf/G8 TQiwQ7ckp8dES/qm937JL/RSUtZOTcUWh10Inoy7ZgQCFcfRx9bDnnFDg+s0N8SgPxfYs0ov/7jAg Vxc6BqYE3Ek+zKZHs3vQoqICfv3D5RFbqYLZd0Jr0/yHb3IXzJeZ0L058tmtPS/HBMs4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ7f4-0002dh-Nh; Fri, 16 Sep 2022 11:29:28 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <877d25krwg.fsf@gmail.com> (Robert Pluim's message of "Thu, 15 Sep 2022 09:39:43 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> X-Now-Playing: Sly Stone's _I'm Just Like You: Sly's Stone Flower 1969-1970_: "Africa" Date: Fri, 16 Sep 2022 11:29:26 +0200 Message-ID: <87wna3y8eh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > I donʼt think any of the advertised bindings caused a problem, but > Iʼll double check. Thanks; feel free to push after checking. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > I don=CA=BCt think any of the advertised bindings caused a problem, but > I=CA=BCll double check. Thanks; feel free to push after checking. > - (where-is-internal fun keymap t)))) > + (where-is-internal fun (ensure-list key= map) t))) You later said that that's not correct -- but in which cases isn't it? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 05:58:43 2022 Received: (at 51384) by debbugs.gnu.org; 16 Sep 2022 09:58:44 +0000 Received: from localhost ([127.0.0.1]:41722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ87P-00016N-Lr for submit@debbugs.gnu.org; Fri, 16 Sep 2022 05:58:43 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:38596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ87O-00016B-43 for 51384@debbugs.gnu.org; Fri, 16 Sep 2022 05:58:42 -0400 Received: by mail-wm1-f54.google.com with SMTP id n23-20020a7bc5d7000000b003a62f19b453so19528141wmk.3 for <51384@debbugs.gnu.org>; Fri, 16 Sep 2022 02:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=fyopICh7c7z0DatY8BdJIcmi5A38UY2ICzIpqEz39D4=; b=RXjkyMMe0v5pRPnd9H9ZIQJxO3qwO34yMbqWW3MowKTyjpWHTb4AaujBjKzgfhGOpW 9Poj8U6TuCwRBoZ74M+LUfeZt+lMZfo+OGvBd64yRWztdit/Hp8/ZaGMnHp9iznt8rKB nR7wuyxg48QYfrHOaow2v2Bitp82/foR7mg/6Ahtmg5yNsV7a0gWpxNRAHUEuRe07TPu k19KWjFTS9Lv5nUE65IzexFgXpKoBG/nbciXEFMqOC39rMH9OLazsd4vaePNq8pjhbuq pXwz3cJwHa2LIUyEmXsWzIaDdEYOBBJpBKP7T+8FHlF6gLPYb1AlcVVBNmpP+kYbP3Et mK5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=fyopICh7c7z0DatY8BdJIcmi5A38UY2ICzIpqEz39D4=; b=eKr0q80uPGFn3T2Ynjzi7LcacTOP9nI+NWHlLx3kHp0EiOjOqqyn5EPHJE/rDL9yEe binQwUqlblu3COOugKvOczbKaMBBdz9XStEJH9tagxaBxHlX3r7xckc42JgLC8YsaPIR BZ2hot8u6+9NLZbELGFXpomUkmDatruxy1A9nQo/evS3aSICC7/Wft7IUAJc45ry4qoo DG/vsLGbkuvFCWmjCxgJrJVG4FfET7ja3myticcw5e+FZy645nhf/6cCseShq1t+i1Az xqs9rzXOp76nPh/BpKH4leaXVmlgIDnoe7BPCYhtfMQyLnpvPqJVRRV+l14t2GkT+ClK 4BZg== X-Gm-Message-State: ACgBeo1yxBstMmG/oYtdxoAUQCIzMKcDcLHajWCNuQ0mmZ/Hp+Dx/4AX lHkqO8kzvV7veS0JQ3J4Dc8= X-Google-Smtp-Source: AA6agR6gwAiKDFXYVCmtFyTBP1KsXy4zrMF2UaXbUNLK55BIVlUJKhOIhkqX5y/xH/e1ILJI44+KWA== X-Received: by 2002:a05:600c:2e52:b0:3b4:622c:1b4b with SMTP id q18-20020a05600c2e5200b003b4622c1b4bmr9770551wmf.153.1663322316125; Fri, 16 Sep 2022 02:58:36 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id q6-20020a05600c46c600b003b4935f04aasm1823065wmo.10.2022.09.16.02.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 02:58:35 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <87wna3y8eh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 16 Sep 2022 11:29:26 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> Date: Fri, 16 Sep 2022 11:58:34 +0200 Message-ID: <87fsgriqt1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 16 Sep 2022 11:29:26 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> I don=CA=BCt think any of the advertised bindings caused a problem, = but >> I=CA=BCll double check. Lars> Thanks; feel free to push after checking. I=CA=BCm about half way through. It=CA=BCs one of those situations where ma= ybe you=CA=BCre tempted to code up a solution using el-search, but that might take longer than doing it manually =F0=9F=98=80 >> - (where-is-internal fun keymap t)))) >> + (where-is-internal fun (ensure-lis= t keymap) t))) Lars> You later said that that's not correct -- but in which cases isn'= t it? Test case: (substitute-command-keys "\\\\[undo]") My model was wrong. I thought keymap was either nil or bound to a keymap, but `undo-repeat-map' is a list of value (keymap (117 . undo)) hence the need to do (and keymap (list keymap)) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 05:59:50 2022 Received: (at 51384) by debbugs.gnu.org; 16 Sep 2022 09:59:50 +0000 Received: from localhost ([127.0.0.1]:41726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ88U-00018B-0Q for submit@debbugs.gnu.org; Fri, 16 Sep 2022 05:59:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ88R-00017w-On for 51384@debbugs.gnu.org; Fri, 16 Sep 2022 05:59:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=koo1GmRMOTuyOXAdZNUYDwYfRMtTaZxoy1LhQj83rr0=; b=W0KMCPOvOlMtJsrhh/nLxW7bXj gVXXjIs8Fi0XC9zEM7skk4sZZ8Vo180nooiilQ+jBzzq1LwyzKkS3dS1GPYU+4A6tumyCxSNAeHCY cJpGHtCE+7lWVuNIoOqmgWdJWID+w0Ru5I+OOv6CDJEpmpKJx7u9Or4Jtlq27GE/nXuw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ88J-0002sp-6y; Fri, 16 Sep 2022 11:59:41 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <87fsgriqt1.fsf@gmail.com> (Robert Pluim's message of "Fri, 16 Sep 2022 11:58:34 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEU2LCuzkVj////D FCTDAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+YJEAkFHUBgxMIA AACjSURBVCjPvdHBDoMwCABQmsi9S+R/2sPuLIH//xUBraXLtuNIPLyCBRSAGLDBFXw9HsVPd0ix ZZSvgAb/iDn1O5YB9gzhnMmvPHLZsg5+xNJPBcp9MxnkhpaegKIDT9UfoIGuygkCCTzRDHNQGyEh /eDqGI2q7YzqYWkqA74lGRqfa3j9ZhXR2t4PoOdI40MwdDt92QQGAb+tRwq1R696Lu8FB9XeINDC 9y8+AAAAWmVYSWZNTQAqAAAACAAFARIAAwAAAAEAAQAAARoABQAAAAEAAABKARsABQAAAAEAAABS ASgAAwAAAAEAAgAAAhMAAwAAAAEAAQAAAAAAAAAAAEgAAAABAAAASAAAAAEfUvc0AAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIyLTA5LTE2VDA5OjA1OjI5KzAwOjAwnrkTCgAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMi0wOS0xNlQwOTowNToyOSswMDowMO/kq7YAAAAXdEVYdGV4aWY6WUNiQ3JQb3NpdGlv bmluZwAxrA+AYwAAAABJRU5ErkJggg== X-Now-Playing: Sly Stone's _I'm Just Like You: Sly's Stone Flower 1969-1970_: "Dynamite (alternate version)" Date: Fri, 16 Sep 2022 11:59:38 +0200 Message-ID: <874jx7y705.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > My model was wrong. I thought keymap was either nil or bound to a > keymap, but `undo-repeat-map' is a list of value > > (keymap (117 . undo)) > > hence the need to do > > (and keymap (list keymap)) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > My model was wrong. I thought keymap was either nil or bound to a > keymap, but `undo-repeat-map' is a list of value > > (keymap (117 . undo)) > > hence the need to do > > (and keymap (list keymap)) Ah; of course. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 11:47:47 2022 Received: (at 51384) by debbugs.gnu.org; 20 Sep 2022 15:47:47 +0000 Received: from localhost ([127.0.0.1]:59356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oafTP-0006cw-6W for submit@debbugs.gnu.org; Tue, 20 Sep 2022 11:47:47 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:41478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oafTM-0006c3-0L; Tue, 20 Sep 2022 11:47:45 -0400 Received: by mail-wr1-f52.google.com with SMTP id t14so4967758wrx.8; Tue, 20 Sep 2022 08:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=WHIEkmTuebo6JOeOBVyrO1N7W3OYMFGvtv7lBf/Q+F0=; b=V4bzwpi45wk88k8pcKWknyUg7IhYBP/Uhaz+IxbMcqLw1zd27v3dNQOGi5mVMUfKnq t9T8yZhKr5aOROUfTiE6060rMzcEN8jJhzOeU3N5tY+N0ocXa5nQzcB0EiOgrk/vQg5M kOr97gtflmroAdfttMiBVMn7oKL3+iG5N4JkxH3m6fAs6L8i+BG/k9wZP/JoFtfq5y9h d549Djc+Rq+MljNrf7bmtIEjn5on4Sj96QLbjUvxN/gVmXjlU1tXKNmXcVUSmzs9fuZG leZGzRhQE7F21zXdGT/PFC+Ft4b0D3XAtMFoDV73nw6VdE7hiNFaIrMnkhQ8AeQQXp/E F91g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=WHIEkmTuebo6JOeOBVyrO1N7W3OYMFGvtv7lBf/Q+F0=; b=loh3cSRFYxlmT5ZExW8x5+Ox/pcvlP0f1WA2dPa6N6dsyUn88kkobCKesVjFqO6y1B YXqaoNxLV4wG/5PxBaFRpUNKVaseQ8k7pij4UtktY9JXx+0NDEtoAf0EK5D+V5Bp858i 8o3XpUAWxM3jcA72QrNuzN5k1BOiLd9aIHWQlaLUae3b5NulXttb41Tckh/cLxiLE5Or AwK3WG6A0ufbzfFKfgnSBwJM3oZQd7T7s6J71sg95iDUvOecCmNJi2AmrgwlSWBBOpZ/ iOZsCE7EWikFA0ORKfkDOmK0ta+iA95JU71hhWmKlzta1mHJtpy9UPb1g/1zthk4MhtE UHGA== X-Gm-Message-State: ACrzQf0bGEsHcByG+3lSV0kZcu/iAOU4QLrkspn2Gq6wyVGNfg687C65 b4fHnlugRp0fpvgx+z7dGkTDyKcrKrU= X-Google-Smtp-Source: AMsMyM4DMrwzyOa3BifciLSU2qiYQslP4iaTzEsTatiuJUMtZE4HQfT7noywBGf6ZaSpARIHh5UE7A== X-Received: by 2002:a5d:61c7:0:b0:22a:fa77:1cef with SMTP id q7-20020a5d61c7000000b0022afa771cefmr8421943wrv.50.1663688857695; Tue, 20 Sep 2022 08:47:37 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c154c00b003b4931eb435sm147594wmg.26.2022.09.20.08.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 08:47:37 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <874jx7y705.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 16 Sep 2022 11:59:38 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> <874jx7y705.fsf@gnus.org> Date: Tue, 20 Sep 2022 17:47:36 +0200 Message-ID: <875yhidp47.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 51384 fixed close 51384 29.1 quit So I found one occurence of a missing keymap spec in a docstring, but that was wrong with or without this change anyway (by some bloke called Lassie? Larry? something like that =F0=9F=98=89). I fixed that, and pushed to master. Closing. Committed as 120ade62cd Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 11:51:48 2022 Received: (at 51384) by debbugs.gnu.org; 20 Sep 2022 15:51:48 +0000 Received: from localhost ([127.0.0.1]:59368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oafXI-0006m6-Cm for submit@debbugs.gnu.org; Tue, 20 Sep 2022 11:51:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oafXH-0006lt-B5 for 51384@debbugs.gnu.org; Tue, 20 Sep 2022 11:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Gz8VhuQAUNlRLL677Jc0O82jr4eqMnLBJsOF+8LH00w=; b=sNqssmy3Bm+i7GIMtCSiCP1OCU K+YnmUsWshVDGMatAlOqXE4wTTH+Nt+dFeyiDQrHCdiyuJCir8SZ/rTH5R82bTX5LQT4RHO0/Uvp9 aHuYQO/rqqIu0BMMKza2yk01mhz9lAJKaNeXBpclXPXI/Nd/dvEw8YYZ8Mitobf31Mv4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oafX7-0003TH-Uf; Tue, 20 Sep 2022 17:51:40 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <875yhidp47.fsf@gmail.com> (Robert Pluim's message of "Tue, 20 Sep 2022 17:47:36 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> <874jx7y705.fsf@gnus.org> <875yhidp47.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX+IZ38IJ2uGGc9 DSP///8lpndiAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJFA8XN2jAliIAAAFgSURBVDjLzVRrcsYg CBS9wKIX8HGBCPe/W4n54qPTzvRnmUxiWGHDgnHuNJq301BrrLfhOxBjrFyYcaYhBhzBcTwBIn6s 1rz5zTEAW4jfAPA0krZSEe9WzwhgwLZa+0F4XC/RBAbHiBihG8NOApr5waetEn4EjIH4RD8kUQs3 4castloAqUpS7QOQBZAXB4UJwdy5lclB4TJ5iNUA4bQAF7J5CO0B+uKwCH4i4hFBvrsyOEAdLd8i uPerNEm7mop91S0P3hHQQiq4Aclbfc6ePK5H0CluKin7noqQr6oW8hEXKacernapS20Ab6w5JWST BC1c1qzZJX+JpNolZQ1St/Z5kWZ7NXQJlmobHbUSTN4oRrU13KS9rD5rheZwHTPecuhqyijOVC7C l0JUqvPnPP9qVulNifuE8F8C/rHhh9XzirfpExi/A+vbZ2hWAx0PKcBjM30mgek+r9gPxXh8AZTR Mwr6mWZUAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA5LTIwVDE1OjIzOjU1KzAwOjAwARDTDAAA ACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0yMFQxNToyMzo1NSswMDowMHBNa7AAAAAASUVORK5C YII= X-Now-Playing: Dave I.D.'s _Cold Wave Volume 2_: "Help Starts" Date: Tue, 20 Sep 2022 17:51:37 +0200 Message-ID: <87fsgmavsm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > So I found one occurence of a missing keymap spec in a docstring, but > that was wrong with or without this change anyway (by some bloke > called Lassie? Larry? something like that 😉). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > So I found one occurence of a missing keymap spec in a docstring, but > that was wrong with or without this change anyway (by some bloke > called Lassie? Larry? something like that =F0=9F=98=89). The VC lies -- the code was written by Per. =F0=9F=AB=A0 > I fixed that, and pushed to master. This seems to lead to: 1 unexpected results: FAILED help-tests-substitute-command-keys/keymap-change From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 12:41:59 2022 Received: (at 51384) by debbugs.gnu.org; 20 Sep 2022 16:41:59 +0000 Received: from localhost ([127.0.0.1]:59479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oagJr-0001oK-C9 for submit@debbugs.gnu.org; Tue, 20 Sep 2022 12:41:59 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:38600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oagJl-0001o3-M8 for 51384@debbugs.gnu.org; Tue, 20 Sep 2022 12:41:57 -0400 Received: by mail-wr1-f50.google.com with SMTP id b5so5255803wrr.5 for <51384@debbugs.gnu.org>; Tue, 20 Sep 2022 09:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=Bp7+WW0uQ1jzCRLwxVeNaU0LyIJAhpRhr4u8Fqm91ko=; b=Xrlr8R82WyWVnnW60t2F7oq6PmFwIR7rwdj0otiu7OSy0Gi8AUlmj8mNXduqmdZPkO 40PzhfFmYMPYhw9Dml2uEMXlhusUG8/xZd6zTnuqEagPwTqP9qXJ4S8k+fotumpBm/4n pSeUQAoWGFrU2nIpRZlGmGrEIyZtKcTm8TfMz5bXAQnjnxARlNEXERKtRtDUbANagqEF GGQIdi1jEuRooMLcof1MtQJ8sYlrtoqQaxxk6Lx+scnxgu/5yVVuZ3kBIrK3dpqLzQvK 1HrzaBxN5O/mPrboxCm8PWSK3WBoT8hJ58G3xXBM6KcBl1K9hJmo80w4sLIOuvvreAB/ hwBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Bp7+WW0uQ1jzCRLwxVeNaU0LyIJAhpRhr4u8Fqm91ko=; b=DtvrdlLSBUd0T+5HmaZnSgZMGTQVtJeS0zBKc//d407cf8Il1IB13baNaBnrQUTezF 9zcs7Q9mnlFArhAsj4pShx80I7lUpbh530OsutMXSNi7J+8tFZN1gN3BQDF1Y17mZuGq DkU5K31hq6uyU7b1/xX33IRypKMLFPQJHTZTz+A43TizpBgrGRzAIOD9f6hoklIRWi+o Te9BhkVaQdsN459SaeDnK66GsFkIpn2caiKALslF6CcZ3Mlt/IAZ3HSameFPoc48PSCa i40D7RHTMet5Bm7iBOdnIsEJN+2IQ0t4rgSJtP6vGvZDiRWAN/bHnITTwenMhWDZEBhn xIFA== X-Gm-Message-State: ACrzQf1QVzPP7n0wkEdLenOHGRmE/D526BWQ+wJy1MAPJyUMjUPnfBAD /GCGfQn2Dqfc/47pe4dmffs= X-Google-Smtp-Source: AMsMyM5vG3NP95afmQrhr6N5ZREqG1utxF8I8E+wZVilyVauaHV9/OKCZPNUxcEJWeuyhHo9d3B1qw== X-Received: by 2002:a05:6000:1b92:b0:220:7d86:2e30 with SMTP id r18-20020a0560001b9200b002207d862e30mr15232936wru.530.1663692106793; Tue, 20 Sep 2022 09:41:46 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id c7-20020adffb47000000b00226dfac0149sm135561wrs.114.2022.09.20.09.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 09:41:46 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: <87fsgmavsm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 20 Sep 2022 17:51:37 +0200") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> <874jx7y705.fsf@gnus.org> <875yhidp47.fsf@gmail.com> <87fsgmavsm.fsf@gnus.org> Date: Tue, 20 Sep 2022 18:41:45 +0200 Message-ID: <87v8pic81i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: Stefan Kangas , 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 20 Sep 2022 17:51:37 +0200, Lars Ingebrigtsen said: Lars> 1 unexpected results: Lars> FAILED help-tests-substitute-command-keys/keymap-change That=CA=BCs doing (test "\\\\[abort-recursive-edit]" "C-]") and abort-recursive-edit is in the global-map, and not minibuffer-local-must-match-map. Oops. This fixes it. If that looks ok I=CA=BCll push later tonight. diff --git a/lisp/help.el b/lisp/help.el index 0ec5b9c85b..b4b9120da3 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1208,6 +1208,12 @@ substitute-command-keys (and keymap (list keymap)) t)))) + ;; If we're looking in a particular keymap which has + ;; no binding, then we need to redo the lookup, with + ;; the global map as well this time. + (when (and (not key) keymap) + (setq key (with-current-buffer orig-buf + (where-is-internal fun keymap t)))) (if (not key) ;; Function is not on any key. (let ((op (point))) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 14:04:03 2022 Received: (at 51384) by debbugs.gnu.org; 20 Sep 2022 18:04:03 +0000 Received: from localhost ([127.0.0.1]:59568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oahbH-0003vB-0w for submit@debbugs.gnu.org; Tue, 20 Sep 2022 14:04:03 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:36377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oahbD-0003uh-RF for 51384@debbugs.gnu.org; Tue, 20 Sep 2022 14:04:01 -0400 Received: by mail-ot1-f52.google.com with SMTP id r34-20020a05683044a200b0065a12392fd7so2293902otv.3 for <51384@debbugs.gnu.org>; Tue, 20 Sep 2022 11:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=QWrq+c9gm042RlrHyc/OwF3FURlY+IlPUSCYLKMnhzY=; b=GdXO/SZfiakwvAsZg9tPqcVD35Qz22MDjhyYDTZaAUlWw5n8dq4LSDq3GbqbIcs4C+ N6U17EThg7+4la2k2+hJ1ZevbdRDZB8J5u7gohtX7+BC3GNVSMaPD6wU1edcvmyoWl26 if5vNmq41tSnfXi8nW8UYiG5+YaVWMkR1mgh4NEdVB9tEKVx7R4ndFCZ+ilY8BqTSX0O VjUMeCwBWwHK5+2LaEe8EAtH00OGZ/qlO+ll1ZtbNcGfvZmhIA5GIhvIFKG8XigpviH9 CmQuhKPt6CXMrkBJAd4qwLV3l+BS/KFxgT1zGxYb493v+Z8fplOLUndNbdmz83W+ch+g bdhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=QWrq+c9gm042RlrHyc/OwF3FURlY+IlPUSCYLKMnhzY=; b=yya8fo4o+zgsBMDDOeu3dUOuCRfshzR6giwOZRzok/dSV6J6Xf5IVjD4+qD9AFeUww UsqaWZ4OX3TGWmr7KIL8sDUsOslxnrbkA2EGxqW/hAd+LKpXeWNn3me+Dl/oRax/MgWh swUGrv2NvHaxvSi0wAj6Lhbi1tKHXGlnBGbq3g/p6Wwl9uDniNxZDb42TMIxGLyZrlLl CgfaV8t7uSz6TwuE16vsiiiuspAnHnhgG+B7xj8Py5GevcscAU7RC6LmmS7ulaC1zZVW tAjGkdsQZ723GzIejZdkS4lFrF9vWrwX8ImxOTxrtO7Yne7CuYqbJgQqv30QZuvsoqcr eFRQ== X-Gm-Message-State: ACrzQf2TvoSZ0qk67y6nYI7HD0V8ujgI5fqTpWmtKkFT6CmbW2BoBI2L V2+1crPOIdwsO4bVqH62jbTK3PiNazL2q8r+1HA= X-Google-Smtp-Source: AMsMyM7LCxDU56sdXCPYCTG57VQqAEM2/HirxxLxb9Vu2WS7btYrgENg6jVKKQON8ZR9iKuipFOPEgr8ZoPXIr7UtXI= X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id q9-20020a9d7c89000000b00655dfb1331cmr10438475otn.224.1663697034107; Tue, 20 Sep 2022 11:03:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Sep 2022 14:03:53 -0400 From: Stefan Kangas In-Reply-To: <87v8pic81i.fsf@gmail.com> References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> <874jx7y705.fsf@gnus.org> <875yhidp47.fsf@gmail.com> <87fsgmavsm.fsf@gnus.org> <87v8pic81i.fsf@gmail.com> X-Hashcash: 1:20:220920:schwab@linux-m68k.org::Ov0eabUcbXn/4xHr:6XOB MIME-Version: 1.0 Date: Tue, 20 Sep 2022 14:03:53 -0400 Message-ID: Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap To: Robert Pluim , Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: 51384@debbugs.gnu.org, Andreas Schwab , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > diff --git a/lisp/help.el b/lisp/help.el > index 0ec5b9c85b..b4b9120da3 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -1208,6 +1208,12 @@ substitute-command-keys > (and keymap > (list keymap)) > t)))) > + ;; If we're looking in a particular keymap which has > + ;; no binding, then we need to redo the lookup, with > + ;; the global map as well this time. > + (when (and (not key) keymap) > + (setq key (with-current-buffer orig-buf > + (where-is-internal fun keymap t)))) > (if (not key) > ;; Function is not on any key. > (let ((op (point))) This looks eerily similar to the code I removed here: commit ac0027f6a5480bd4739fdf71413a19012f400483 Author: Stefan Kangas Date: Mon Jul 11 17:21:23 2022 +0200 Remove dead branch from substitute-command-keys * lisp/help.el (substitute-command-keys): Remove dead branch; where-is-internal will follow any remaps for us. Note also that the test case for remapping still pass. Do we have a test case that reverting that commit would fix? (I can't see Lars' message yet, so the delays with the gnu.org mail systems seem to be ongoing...) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 03:18:00 2022 Received: (at 51384) by debbugs.gnu.org; 21 Sep 2022 07:18:00 +0000 Received: from localhost ([127.0.0.1]:60441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oatzb-0003LQ-N0 for submit@debbugs.gnu.org; Wed, 21 Sep 2022 03:17:59 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:42971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oatzX-0003L8-6P for 51384@debbugs.gnu.org; Wed, 21 Sep 2022 03:17:58 -0400 Received: by mail-wm1-f50.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so3199273wmq.1 for <51384@debbugs.gnu.org>; Wed, 21 Sep 2022 00:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=uiJCJ97xdUM1T790WlH56BHzV1AXPApkSaqjULTIt+A=; b=ANp8IMCPPBvSctR7sZHAPQWNHeqoPE+ddlTnwmDnUv8MEsZfO26WMA1W5R6sglAhK1 4SdhswOWi1LtmHyuq7K2w53eX6NHwoJrWikyZild2oEhoVSGheuOFbJ7aWjr7Bpqb6+5 /d3fydHgTIvzu0UUg9SL7vMxExpUw0B4QEOFW7thslNjOZA4o030uLl7QDR+ep5p+D3H LsFslgSFosuOUwjUJgrvTvENSDi8Z/nP8bM00xj4uGH8fc4nDoByZMnAMjmBPXBtacxu +LgyNTxIEShAloyusLKaEcV7n5SPtDbagzBd16XbdlNeKIn0cD7YOOrSO+aV+yfxbwjf IDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uiJCJ97xdUM1T790WlH56BHzV1AXPApkSaqjULTIt+A=; b=pbMM+78B5jZhIjOJz4j8BTVlmtwJ9aXlmzvlwwaPI1iYRW0hNrpb4B4yAwKqvZMZ9W 5eFrwxq4pdsvPpfkoSHwzfxWbcdhLle/cBPyTDnIaaGv5DTiIXJWNqn7W7E35sL5trMR es0Lr+EliU/mpx+TizJdFb7sfJr+gU4oG8mFgUMtbqPKHkv+k2Ko/zXTM3aIvfrqd0pD YMf1flpZ0p2nfjCozg/vJl6KASk4N5sDK+6viqx2z7ghLQyO+s/dmqSmJk810wWxMVE0 WdQCNtDhjL/OKtzZvvh5V4FwZHALsxopvvfLT2FCh43WPzM1GPBbgdwPxm+3+wlui43p Uj1A== X-Gm-Message-State: ACrzQf1oQJw8u1krfce4rO+rriz8J0/v/ZkW7QORtPWL5qND2ZDfEYz4 1wV5mdRy6G02BOeD9zlCoZg= X-Google-Smtp-Source: AMsMyM5SeYtDo359cYAPggEUgzDk529urSK+1TDGYU4PotsRMoeCJy0tyEjXirwLRb8LlQJNCqSGuQ== X-Received: by 2002:a05:600c:19ce:b0:3b4:c709:4307 with SMTP id u14-20020a05600c19ce00b003b4c7094307mr4748802wmq.182.1663744668194; Wed, 21 Sep 2022 00:17:48 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b00228cbac7a25sm1665558wru.64.2022.09.21.00.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 00:17:47 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap In-Reply-To: (Stefan Kangas's message of "Tue, 20 Sep 2022 14:03:53 -0400") References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> <874jx7y705.fsf@gnus.org> <875yhidp47.fsf@gmail.com> <87fsgmavsm.fsf@gnus.org> <87v8pic81i.fsf@gmail.com> Date: Wed, 21 Sep 2022 09:17:46 +0200 Message-ID: <87pmfpci1x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: Lars Ingebrigtsen , Andreas Schwab , 51384@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 20 Sep 2022 14:03:53 -0400, Stefan Kangas said: Stefan> This looks eerily similar to the code I removed here: Stefan> commit ac0027f6a5480bd4739fdf71413a19012f400483 Stefan> Author: Stefan Kangas Stefan> Date: Mon Jul 11 17:21:23 2022 +0200 Stefan> Remove dead branch from substitute-command-keys Stefan> * lisp/help.el (substitute-command-keys): Remove dead b= ranch; Stefan> where-is-internal will follow any remaps for us. Note = also that the Stefan> test case for remapping still pass. Similar, but not the same. That dead branch followed remaps, this code redoes the lookup in the global map. Stefan> Do we have a test case that reverting that commit would fix? No, and I don=CA=BCt see why you=CA=BCd want to revert it, it seems correct= to me. Stefan> (I can't see Lars' message yet, so the delays with the gnu.org = mail Stefan> systems seem to be ongoing...) It=CA=BCs not jut gnu.org for me, but maybe that=CA=BCs a local issue. Anyway, I=CA=BCve pushed the fix as cee9a2cbe0 Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 04:55:57 2022 Received: (at 51384) by debbugs.gnu.org; 21 Sep 2022 08:55:57 +0000 Received: from localhost ([127.0.0.1]:60621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oavWO-00069s-O7 for submit@debbugs.gnu.org; Wed, 21 Sep 2022 04:55:57 -0400 Received: from mail-ot1-f48.google.com ([209.85.210.48]:34644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oavWM-00069b-Tj for 51384@debbugs.gnu.org; Wed, 21 Sep 2022 04:55:55 -0400 Received: by mail-ot1-f48.google.com with SMTP id u6-20020a056830118600b006595e8f9f3fso3493963otq.1 for <51384@debbugs.gnu.org>; Wed, 21 Sep 2022 01:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date; bh=uclIWMujUJoYabsJEFA/E/SDSW6xLUeLVJarifTtqiE=; b=MHbnv8m2LF7S3SuiL6s4xeZGo+T6eesKhztHLPQugzdmAjn+T6HuEHg4nLEbxb7otn XuSWpj2OVQ+j2J2OTZ/keFN1aW7X8G60vErFEYqctVKOL5NraRlLri0HaFJ2T0u1UhSJ kgvjBGV1hFofA6ox/0aueGIeqnL74vEvS8EooebtF9JPxIUf3IzfLlcoKZzcsoB+wAmJ 5OcnYbsX7JYV5aP1tYceGjal+ogd00YwQO7/8ZAdYEb2xj8sj4slKJY7gacjSPboiMM0 o6vSsH2hHuYYUuQDTlTEU8na6s5rd2PnPUr1HBalqVjwGzv1ovMiZuuHC79H4rZPMzL5 wPvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date; bh=uclIWMujUJoYabsJEFA/E/SDSW6xLUeLVJarifTtqiE=; b=X2wgL0HfB/LqDhTIXMhV5ZmM/s9AC0IXflM9TEHGvrfdq2GMHyuveQ3DuLHiOhN/po j0Ih4QdKIdyuxQ9FCZK3xXoKIdkDZI5VFzM+J7p8JBZSn3Pw4lDylHx6whA2Q15mBNMN sIipIOaG5lndA63OYa1qRhmnnqp1kztdOXYOZCVr50J21EweSpR78XoEKDsd0pON+L9+ We/d/xepWtzCqO42e3aXepYAZ609AUQEzOReaH4F25Xm88ECR/jCtVn5cI97DwRyUwNc Llbj7FdP5D6WiFwiWQMEgzV8FvaS0SLSjrSy0I74T0rQWCsSIUJz1xPi3jb2jDmMMx/g iWLQ== X-Gm-Message-State: ACrzQf28Ki1S/nHmKE57mLk8cOeuVGCnvTPlfpiMX89zcFp4xuT84W5h 8Agff4dAaX+6cxgoofaLOrRSQA1bUfKSSP7C0zA= X-Google-Smtp-Source: AMsMyM6Q3IYwAGzSVcxRV/HvWiU2UXRB/FM1zUpCiybUiNenXnIh33TlFptlDX4oaDVWyBjXwEyevVsX2ZcdJpivdjQ= X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id p1-20020a05683003c100b0063728be7920mr11625494otc.105.1663750549387; Wed, 21 Sep 2022 01:55:49 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 21 Sep 2022 01:55:48 -0700 From: Stefan Kangas In-Reply-To: <87pmfpci1x.fsf@gmail.com> References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> <874jx7y705.fsf@gnus.org> <875yhidp47.fsf@gmail.com> <87fsgmavsm.fsf@gnus.org> <87v8pic81i.fsf@gmail.com> <87pmfpci1x.fsf@gmail.com> X-Hashcash: 1:20:220921:schwab@linux-m68k.org::2S3FnlYrSG+Y6WH5:5DNA MIME-Version: 1.0 Date: Wed, 21 Sep 2022 01:55:48 -0700 Message-ID: Subject: Re: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51384 Cc: Lars Ingebrigtsen , Andreas Schwab , 51384@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Similar, but not the same. That dead branch followed remaps, this code > redoes the lookup in the global map. > > Stefan> Do we have a test case that reverting that commit would fix? > > No, and I don=CA=BCt see why you=CA=BCd want to revert it, it seems corre= ct to > me. Right, thanks for confirming. From unknown Fri Jun 20 07:25:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Oct 2022 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator