GNU bug report logs - #51373
[PATCH] etc: completion: Filter gratuitous spaces from available packages.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#51373: closed ([PATCH] etc: completion: Filter gratuitous
 spaces from available packages.)
Date: Sun, 24 Oct 2021 19:04:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 24 Oct 2021 21:01:04 +0200
with message-id <87wnm29rdz.fsf <at> nckx>
and subject line Re: [bug#51373] [PATCH] etc: completion: Filter gratuitous spaces from available packages.
has caused the debbugs.gnu.org bug report #51373,
regarding [PATCH] etc: completion: Filter gratuitous spaces from available packages.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
51373: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51373
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] etc: completion: Filter gratuitous spaces from available
 packages.
Date: Sun, 24 Oct 2021 14:09:47 +0200

* etc/completion/zsh/_guix (_guix_list_available_packages): Add a sed filter
to remove spaces.
---
 etc/completion/zsh/_guix | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/completion/zsh/_guix b/etc/completion/zsh/_guix
index bbc13c6ca1..6b4060ddeb 100644
--- a/etc/completion/zsh/_guix
+++ b/etc/completion/zsh/_guix
@@ -57,7 +57,7 @@ _guix_list_available_packages()
 {
     if ( [[ ${+_guix_available_packages} -eq 0 ]] || _cache_invalid GUIX_AVAILABLE_PACKAGES ) \
        && ! _retrieve_cache GUIX_AVAILABLE_PACKAGES; then
-        _guix_available_packages=(${${(f)"$(guix package -A | cut -f1)"}})
+        _guix_available_packages=(${${(f)"$(guix package -A | cut -f1 | sed -e 's/ //g')"}})
         _store_cache GUIX_AVAILABLE_PACKAGES _guix_available_packages
     fi
 }
-- 
2.33.1

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 51373-done <at> debbugs.gnu.org
Subject: Re: [bug#51373] [PATCH] etc: completion: Filter gratuitous spaces
 from available packages.
Date: Sun, 24 Oct 2021 21:01:04 +0200

[Message part 4 (text/plain, inline)]

Liliana Marie Prikler 写道：
> Haha, yeah, zsh can be weird at times.  I typically don't play 
> around
> with such fancy syntax all that much so on the top of my head I

Your sanity is duly envied.

> wouldn't even know how to rewrite my patch using that.  However, 
> if it
> helps not spawning a process like once during compinit, then go 
> ahead
> and use your version :)

There are plenty of other seds littering the file—though not this 
trivial.  At least commit 55f6d9e818512b4e3e4adacfa99deb201b6854be 
avoids one more.

Thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.