GNU bug report logs - #51371
28.0.50; [PATCH] Make list-colors-display sorting support general

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: dalanicolai <dalanicolai <at> gmail.com>
Cc: 51371 <at> debbugs.gnu.org
Subject: bug#51371: 28.0.50; [PATCH] Make list-colors-display sorting support general
Date: Sun, 24 Oct 2021 05:47:07 -0700

dalanicolai <dalanicolai <at> gmail.com> writes:

> The snippet passes colors form the shr-color-html-colors-alist variable
> to list-colors-display. However, currently, despite the docstring
> suggesting to me something different, the list-colors-display function
> only applies its sort functionality if no list is passes as argument.
> I don't see a good reason for that limitation, because the limitation is
> set using a when condition, while the sort function works perfectly fine
> with custom color-lists (e.g. try the snippet above).
>
> So this patch simply removes the (when (null list)) condition, and
> passes the list, if given, to the sort functionality.
> Adapting the docstring is not necessary as it already suggests that the  sort functionality works in general.

Is there any situation in which you wouldn't want the list sorted?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.