GNU bug report logs - #51368
29.0.50; `cl-case' should error on incorrect use

Previous Next

Full log

Message #23 received at 51368 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51368 <at> debbugs.gnu.org
Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use
Date: Fri, 12 Nov 2021 20:34:13 +0100

[Message part 1 (text/plain, inline)]

Am Mo., 1. Nov. 2021 um 14:31 Uhr schrieb Lars Ingebrigtsen <larsi <at> gnus.org>:
>
> Philipp Stephani <p.stephani2 <at> gmail.com> writes:
>
> > Yes, but the problem only arises if the user wants to match the symbol
> > `quote' plus exactly one other value. That should already be
> > exceedingly rare, and can be trivially rewritten by swapping the two
> > values (i.e. write (foo quote) instead of (quote foo)). So I think
> > issuing a warning or error for that case is worth it.
>
> I think we're getting into slightly muddy waters, but I think I agree --
> a warning here is (much more) likely to be helpful than not.
>

Ok, I've attached two patches that implement these suggestions.

[0001-Signal-an-error-if-a-fallback-case-is-misplaced-Bug-.patch (application/octet-stream, attachment)]

[0002-Have-cl-case-warn-about-suspicious-cases-Bug-51368.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.