From unknown Sun Jun 22 22:42:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51368 <51368@debbugs.gnu.org> To: bug#51368 <51368@debbugs.gnu.org> Subject: Status: 29.0.50; `cl-case' should error on incorrect use Reply-To: bug#51368 <51368@debbugs.gnu.org> Date: Mon, 23 Jun 2025 05:42:33 +0000 retitle 51368 29.0.50; `cl-case' should error on incorrect use reassign 51368 emacs submitter 51368 Philipp Stephani severity 51368 normal tag 51368 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 03:52:31 2021 Received: (at submit) by debbugs.gnu.org; 24 Oct 2021 07:52:31 +0000 Received: from localhost ([127.0.0.1]:37848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meYIx-0003t3-GI for submit@debbugs.gnu.org; Sun, 24 Oct 2021 03:52:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:53100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meYIs-0003st-WF for submit@debbugs.gnu.org; Sun, 24 Oct 2021 03:52:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meYIs-0006XK-Mr for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 03:52:26 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:35476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1meYIq-0003eu-Ii for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 03:52:26 -0400 Received: by mail-wr1-x42f.google.com with SMTP id s19so6352192wra.2 for ; Sun, 24 Oct 2021 00:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=0dlVVNOcq8nN3iptbrslkYINTvFWnCmyLfRfaKHjfwQ=; b=fMzyumwyCuUeHdKtEog3wjg3gzXVGSpnAe8VOfYHiL4BOVdDoKl+ztwW8MeDh+j7du vTu15zQ9837xkT3p95Ydi/tiXi4KxtBgVZNl1Ts5W2K7Pv6z9z2UBEJto96yYjjkrknf pW2PKRVBsaV+jQdrMaZYbZup9BSFCdc2ag6+OQ6+jIsbHDpJhemV3TdkUx5uocx0RcT/ A7GRCAFYyZgD4K+AZCbAGdxksXGDXjcR/sHl/5QmEb18B6Msren+wZXsWqEL84BrI7LK qg40B1vm7gbnVtYoAOhzV4Pe9azbDw0ZMumKEdCUT4Uf9tNvBPHWvtflR0TAmXtIXXDm sBkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=0dlVVNOcq8nN3iptbrslkYINTvFWnCmyLfRfaKHjfwQ=; b=PVq2CxdOVaxjhmqppdyAUp8N5osW+23A54ap+/XjMUcy42kKl7SOntCMtVDvFvv0uB m9XxQ1B7Q47BTlFuWVU09HcGNjYmTHTzMP/QyzXJYXSQMqNl5Wrom6/Z0vo1VRUHyh6X vXKnzT4aUTV704GI3wNzLKpeyexM2LyMu34LRSET5rq/XNznne59CVg5Xf61EdWgyyy3 grXSlNs5Lwlpv4XRowCW62qdK0YP3otyoN2uLWLzhKnIeeMt/7BiGNj1PPvK5cscQ0m5 JaEHpOYjtx99dGgEC3wr96FGaenPlgo06UQ6+G18d2tUpgN6V0ogqt1HrOcTvt0/hjAg 8ErQ== X-Gm-Message-State: AOAM532PraOXd0FUH/bozPK3NL5M2N8fSYpU+TBQinkYzV1Gm2b5l/d8 cX5NBAHHqgbjQnFKFzoCFdzNt8OG550= X-Google-Smtp-Source: ABdhPJxEssJaeQzWPPeGt4uLyttr9ogqZgjyP2U6+X99Zgh8GzkLNSL5P7bTRUqdnVC0aWTihRT/ow== X-Received: by 2002:adf:9bc4:: with SMTP id e4mr14026953wrc.257.1635061941406; Sun, 24 Oct 2021 00:52:21 -0700 (PDT) Received: from phst ([2a02:2455:29f:8100:e416:c467:d574:6ba5]) by smtp.gmail.com with ESMTPSA id v13sm8354951wrp.11.2021.10.24.00.52.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 00:52:21 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 29.0.50; `cl-case' should error on incorrect use Date: Sun, 24 Oct 2021 09:52:19 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=p.stephani2@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This form demonstrates a few incorrect uses of `cl-case': (cl-case a (nil 0) ; doesn't match anything (t 1) ; matches everything, but too early ('foo 2)) ; matches `quote' in addition to `foo' It would be nice if `cl-case' would signal an error or at least warn about these at macroexpansion time, since they are somewhat subtle and easy to get wrong. In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, c= airo version 1.16.0) of 2021-10-24 Repository revision: aea4af5119fdf130f1df7190478a23c6777f92a2 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=3Dall --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_TIME: en_DK.utf8 value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars mailcap rx gnutls puny dbus xml seq gv subr-x byte-opt bytecomp byte-compile cconv compile text-property-search comint ansi-color ring cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 68529 4717) (symbols 48 8401 3) (strings 32 24306 1951) (string-bytes 1 786068) (vectors 16 15413) (vector-slots 8 204610 8730) (floats 8 26 36) (intervals 56 225 0) (buffers 992 11)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 04:16:14 2021 Received: (at 51368) by debbugs.gnu.org; 24 Oct 2021 08:16:14 +0000 Received: from localhost ([127.0.0.1]:37876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meYft-0004T6-Pp for submit@debbugs.gnu.org; Sun, 24 Oct 2021 04:16:13 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:51417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meYfq-0004Sw-Vv for 51368@debbugs.gnu.org; Sun, 24 Oct 2021 04:16:12 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4HcWBK3HVyz1qwdl; Sun, 24 Oct 2021 10:16:09 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4HcWBK1kl2z1qqkB; Sun, 24 Oct 2021 10:16:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Syb0VVjmLF_X; Sun, 24 Oct 2021 10:16:08 +0200 (CEST) X-Auth-Info: JMWLtvtOD3fvolL2u8eZzYSz5gRR2zLj26MUuxaiOdxbVi/3GhGy3fG099s9nuhN Received: from tiger.home (ppp-46-244-185-242.dynamic.mnet-online.de [46.244.185.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 24 Oct 2021 10:16:08 +0200 (CEST) Received: by tiger.home (Postfix, from userid 1000) id D3AFF6E7D9; Sun, 24 Oct 2021 10:16:07 +0200 (CEST) From: Andreas Schwab To: Philipp Stephani Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use References: X-Yow: My ELBOW is a remote FRENCH OUTPOST!! Date: Sun, 24 Oct 2021 10:16:07 +0200 In-Reply-To: (Philipp Stephani's message of "Sun, 24 Oct 2021 09:52:19 +0200") Message-ID: <87k0i2j0s8.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) On Okt 24 2021, Philipp Stephani wrote: > This form demonstrates a few incorrect uses of `cl-case': > > (cl-case a > (nil 0) ; doesn't match anything > (t 1) ; matches everything, but too early > ('foo 2)) ; matches `quote' in addition to `foo' > > It would be nice if `cl-case' would signal an error or at least warn > about these at macroexpansion time, since they are somewhat subtle and > easy to get wrong. clisp errors out on the misplaced `t' clause, but is otherwise silent. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 08:46:17 2021 Received: (at 51368) by debbugs.gnu.org; 24 Oct 2021 12:46:17 +0000 Received: from localhost ([127.0.0.1]:38109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mectF-0001P0-LR for submit@debbugs.gnu.org; Sun, 24 Oct 2021 08:46:17 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:43632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mectE-0001Om-C0 for 51368@debbugs.gnu.org; Sun, 24 Oct 2021 08:46:16 -0400 Received: by mail-pl1-f182.google.com with SMTP id y1so6013288plk.10 for <51368@debbugs.gnu.org>; Sun, 24 Oct 2021 05:46:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=qHi126+KauhpsIZTUdiW9CayZqBTt3seZfGdL9koLwU=; b=oKeDldQdeWnIw339EZXG0WFphbLB9oaMb0YlL/fizSCsQls092qnP/Ry8RCOYs5Xdj jHwN8HbTBbMivmBpBpnR9LTioH1mle+2Q5/Z+AIEEsU7WavwrkE6detJSWtxNqwAEytn F33S99vuCI4vk4kVysOPkDElPFTjH4elD85f1S6txo3jV74C6GBMRTmFtwh4DHEgN2/1 akvf//jFzJ539pYXVdEmGBfQXeF5WLH8I9a/WmTMXUVhjDmCYoKa2byLI1G2ImPCA6Jj IO3HTRngRG74WeNHX98rvgWVUSDCOUXEpXY5fwOeKyCBuLsBUF2mWFghDKiIu70m8LRF O+2A== X-Gm-Message-State: AOAM532MVd5RoaOIgz38Oz7SB/FyqR+Wtvrq/mKzdNONufb/d7Zkvr+x ZjFFA9kipQDJjXkDZKS+jHjn3AdIA7yLKwDM3Dk= X-Google-Smtp-Source: ABdhPJzEoZpJ0bhYMNTq1GMcMdePhfAwWzioeSSc1K2Z9C+fy+DiZUEIeLSjffySFd5kl0xIUBps7zcT71Jl9Tw+Yu0= X-Received: by 2002:a17:90b:17d2:: with SMTP id me18mr27993713pjb.132.1635079570560; Sun, 24 Oct 2021 05:46:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Oct 2021 05:46:10 -0700 From: Stefan Kangas In-Reply-To: <87k0i2j0s8.fsf@linux-m68k.org> (Andreas Schwab's message of "Sun, 24 Oct 2021 10:16:07 +0200") References: <87k0i2j0s8.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 24 Oct 2021 05:46:10 -0700 Message-ID: Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use To: Andreas Schwab Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Andreas Schwab writes: > On Okt 24 2021, Philipp Stephani wrote: > >> This form demonstrates a few incorrect uses of `cl-case': >> >> (cl-case a >> (nil 0) ; doesn't match anything >> (t 1) ; matches everything, but too early >> ('foo 2)) ; matches `quote' in addition to `foo' >> >> It would be nice if `cl-case' would signal an error or at least warn >> about these at macroexpansion time, since they are somewhat subtle and >> easy to get wrong. > > clisp errors out on the misplaced `t' clause, but is otherwise silent. I think it would be good if we could error out on the misplaced t. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 13:49:07 2021 Received: (at 51368) by debbugs.gnu.org; 24 Oct 2021 17:49:07 +0000 Received: from localhost ([127.0.0.1]:40708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mehcJ-0003YA-HZ for submit@debbugs.gnu.org; Sun, 24 Oct 2021 13:49:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mehcH-0003Xb-1e for 51368@debbugs.gnu.org; Sun, 24 Oct 2021 13:49:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bBholxVRXpD5nm7w6nlzad4hLsjYR5KIRMyAQUP7yuU=; b=sBU4mMjVgXPEAtM7AqrRFDzQ+P S1lfcHe8sjveqguFChlR9hZmYtltnlu6mWtii24ANs1fqBTim5t3O6pZu93Crs7JDF/KiIoV3P5yv s7XHlrTV1qtEwf9N1r0IilZAtNBW2lkrgY8M5xpUXVSs5mUzYqwIxWF+N6taoyT+TBnc=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mehc7-00011p-8A; Sun, 24 Oct 2021 19:48:58 +0200 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use References: Date: Sun, 24 Oct 2021 19:48:54 +0200 In-Reply-To: (Philipp Stephani's message of "Sun, 24 Oct 2021 09:52:19 +0200") Message-ID: <87a6iy71q1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > This form demonstrates a few incorrect uses of `cl-case': > > (cl-case a > (nil 0) ; doesn't match anything > (t 1) ; matches everything, but too early > ('foo 2)) ; matches `quote' in addition to ` [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp Stephani writes: > This form demonstrates a few incorrect uses of `cl-case': > > (cl-case a > (nil 0) ; doesn't match anything > (t 1) ; matches everything, but too early > ('foo 2)) ; matches `quote' in addition to `foo' > > It would be nice if `cl-case' would signal an error or at least warn > about these at macroexpansion time, since they are somewhat subtle and > easy to get wrong. An error from the second case would be nice, and a warning on the first case, but the third case: (macroexpand '(cl-case a ('foo (message "foo")))) => (cond ((cl-member a ''foo) (message "foo"))) and (equal ''foo (list 'quote 'foo)) which, sure, whatever. But I guess the question is whether we can actually warn about that, because to the reader, the two forms are equivalent? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 31 14:54:11 2021 Received: (at 51368) by debbugs.gnu.org; 31 Oct 2021 18:54:11 +0000 Received: from localhost ([127.0.0.1]:33120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhFy6-0000j9-Tw for submit@debbugs.gnu.org; Sun, 31 Oct 2021 14:54:11 -0400 Received: from mail-ot1-f43.google.com ([209.85.210.43]:46980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhFy5-0000iw-KI for 51368@debbugs.gnu.org; Sun, 31 Oct 2021 14:54:10 -0400 Received: by mail-ot1-f43.google.com with SMTP id x27-20020a9d459b000000b0055303520cc4so22221464ote.13 for <51368@debbugs.gnu.org>; Sun, 31 Oct 2021 11:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9kVO8K1ANUg1/8pN5wZjmXObZ+hNrdW4ye31GTld0qQ=; b=lfGosQsY0J5XrtQnsGDj19Q/6EH4wn3gqPH22CxSPxRaKByERpuY908nw6Keg/cc7i PD2i+QK3oJOnmhKTitm1kuJkHDH5Onzwj3R/H4sYa/4USjl15Y3E8b7aqr/XWQYrTjH6 Rcmq/K0Jxo1iweeaZfEhJFVGU7rneZu5JPLEiYJpORjRje3nmyQOumF5kKpsLlWUDkWQ jMeUuu6tKcfD5tWw0eKVk040RLQrHZ6uQHmhbQJ3U3PAjevpDdzHWw8r9D2MFihtt8sF E/RtJNnH87x8P+hG5N1PRUiNFADxYKwr5+rxOiOTBSyklP/rCqBWjP4CKU/oYwNKc9kg uhXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9kVO8K1ANUg1/8pN5wZjmXObZ+hNrdW4ye31GTld0qQ=; b=tMlRMgKw6TzH1OlDjRzR/8CYUxPfPR/VPkAmtQXK7O2w+2LmANDutmBeQdw3I0PbsF V4U84WAQ2sItqm71O1SNsv50e8wIpKI8c22YpqwbACLOwVOQJxcdSJ3X+9HpkH2aapUw q+BpW0KMoB+yNFxFixMro8B586s2RI40iZVBA0Jyans9tpfgOdSmw4rwGMdseoCtZKq7 3MVWL5GwQ37OWGev68lX/tQKDvdmePrmOdJpyXbbET/CL1gxXwl3UccT5Ej/aEyVGquq FG5Kk1Dp5z4eRIgEJ9u51U2vKHGxgISEM/ubEVDjKe3hBjQZRE52G95n4iix2Y7NUhLa W+jg== X-Gm-Message-State: AOAM532Y5udyGN/Ogn/MueQMIckU8QGdqt8ATDEzeiQWmqM/V6YdV/uw mENOHLFaKjF+xQlEj1u1WFVZf/2ziXdz/mV7QbE= X-Google-Smtp-Source: ABdhPJyJmT5JJ18hTo9XrllZrCgyjznqOWYpxKvEFFCfdXQ6GnbFUof3OiIKh+rCYAWG/TcpSyfeLPnZV2B2RljO5OM= X-Received: by 2002:a9d:669:: with SMTP id 96mr18214145otn.224.1635706443845; Sun, 31 Oct 2021 11:54:03 -0700 (PDT) MIME-Version: 1.0 References: <87a6iy71q1.fsf@gnus.org> In-Reply-To: <87a6iy71q1.fsf@gnus.org> From: Philipp Stephani Date: Sun, 31 Oct 2021 19:53:53 +0100 Message-ID: Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am So., 24. Okt. 2021 um 19:48 Uhr schrieb Lars Ingebrigtsen : > > Philipp Stephani writes: > > > This form demonstrates a few incorrect uses of `cl-case': > > > > (cl-case a > > (nil 0) ; doesn't match anything > > (t 1) ; matches everything, but too early > > ('foo 2)) ; matches `quote' in addition to `foo' > > > > It would be nice if `cl-case' would signal an error or at least warn > > about these at macroexpansion time, since they are somewhat subtle and > > easy to get wrong. > > An error from the second case would be nice, and a warning on the first > case, but the third case: > > (macroexpand > '(cl-case a > ('foo (message "foo")))) > => (cond ((cl-member a ''foo) (message "foo"))) > > and > > (equal ''foo (list 'quote 'foo)) > > which, sure, whatever. But I guess the question is whether we can > actually warn about that, because to the reader, the two forms are > equivalent? Yes, but the problem only arises if the user wants to match the symbol `quote' plus exactly one other value. That should already be exceedingly rare, and can be trivially rewritten by swapping the two values (i.e. write (foo quote) instead of (quote foo)). So I think issuing a warning or error for that case is worth it. Assuming we'd want to prevent similar bugs with other reader constructs, I think the only real problematic case is matching exactly two of the symbols `function', `quote', `,', `,@', and `\`'. Maybe for those cases we should just instruct people to write (cond (memq ...)) or similar. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 01 09:31:31 2021 Received: (at 51368) by debbugs.gnu.org; 1 Nov 2021 13:31:31 +0000 Received: from localhost ([127.0.0.1]:34023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhXPP-0008Ox-7I for submit@debbugs.gnu.org; Mon, 01 Nov 2021 09:31:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhXPN-0008Oi-5P for 51368@debbugs.gnu.org; Mon, 01 Nov 2021 09:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AGaZLqCNmJ62btOujn73ROIyBZaSof77S9+qX640hGo=; b=rmr6MDzficsU9j+cH9i+fp7q9z Q3c2A3Ke/bLZAjWw0W5isfGBka1571EJ+FyzexnEskjS+Xgj1dAlOzoweF+gNK6gZp491FB5UU825 3UycKH+kVt61n8bLe3zjY4OZkwDT3hIyr9/3ZfKAu2FUcPwYbYwaXi+ppJLRq9qD1oVY=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhXPE-0005Qd-A7; Mon, 01 Nov 2021 14:31:22 +0100 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use References: <87a6iy71q1.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEWqiF7Ak2iSdFCl eUlcT0D///99GfO2AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+ULAQ0dGKHpEfwAAAGuSURBVDjLdZQN jsQgCIUpXqC9AUs9gNELTFzvf6Z9gPZnkqXJ1PoJwpOR6CDa9mPavm87+Qi/czQJhR10mbrZiF+A tdUGkFRPFQOpUEulEmazmmMeowMkW96o0jnGOIkxDZODtLTSWlFWAxKgA7CBREo68CjnnvEy0CIn 0q7jlzVCkQFESiXAyXwBKuaQLNS1h/IDIFukixwUrloAmpEmxeo+K3v9xTxQcquorJkVemqF7Cwa 5usTCB6w5DGEppQH7cRLVrE3+6dsU3BJS3etvmxzwX0THj3n7iCbx07qijQANWAVdr1B5fHJTxDZ QhEA5QV88zz6sHTGh29ge7ts9Aa2xwQVR2QzE1AA7FFYJL8AZdEdA/5h95jSPIAsULWSh/IVsiRZ HbnTQ9U3gFaCOHEOm3W1n0SIqHcLW5ZeIGlg8aVWqLXo1f8WKp2tSfSqS+IddiLgQBD9BmjOHjV7 l16g9wug37KDEKd7hPDQ8JgTDvJ/wHUdr80N2NIPfwExj25vygtos78CT/GYot1Dh4cxnURV7k+o 7HLx6na7PaD1Nu+IbV0qzwvmZf+CPycEgT8AFtXZAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTEx LTAxVDEzOjI5OjI0KzAwOjAwNY8UYAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMS0wMVQxMzoy OToyNCswMDowMETSrNwAAAAASUVORK5CYII= X-Now-Playing: Electrelane's _The Power Out_: "Birds" Date: Mon, 01 Nov 2021 14:31:15 +0100 In-Reply-To: (Philipp Stephani's message of "Sun, 31 Oct 2021 19:53:53 +0100") Message-ID: <87v91ct330.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > Yes, but the problem only arises if the user wants to match the symbol > `quote' plus exactly one other value. That should already be > exceedingly rare, and can be trivially rewritten by swapping t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp Stephani writes: > Yes, but the problem only arises if the user wants to match the symbol > `quote' plus exactly one other value. That should already be > exceedingly rare, and can be trivially rewritten by swapping the two > values (i.e. write (foo quote) instead of (quote foo)). So I think > issuing a warning or error for that case is worth it. I think we're getting into slightly muddy waters, but I think I agree -- a warning here is (much more) likely to be helpful than not. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 12 14:34:33 2021 Received: (at 51368) by debbugs.gnu.org; 12 Nov 2021 19:34:33 +0000 Received: from localhost ([127.0.0.1]:46014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlcJl-0003ci-82 for submit@debbugs.gnu.org; Fri, 12 Nov 2021 14:34:33 -0500 Received: from mail-ot1-f48.google.com ([209.85.210.48]:41599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlcJh-0003cA-PG for 51368@debbugs.gnu.org; Fri, 12 Nov 2021 14:34:31 -0500 Received: by mail-ot1-f48.google.com with SMTP id o15-20020a9d410f000000b0055c942cc7a0so15380081ote.8 for <51368@debbugs.gnu.org>; Fri, 12 Nov 2021 11:34:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2nm22+yifGtQHBa2aWaGlXoQrpJpFkgOtCB9OhwdCMg=; b=UFbU8ER1cxKRhYpDqb6eTPXDg1j3xzePdIZtxMxvjsFOG5YYuiRISJuJ7h8+IwcOY4 tHSIMBWsEmMp6CtPVEdxB2b+MhyjUfJzDXslrlSwRjF5Y0opvj9krQM1DG+kovPFU2JX nyH8A4FJkzBkY7VBYHv5tPBqjcDMvyRplcsx64h0uuzY9UXn6Lbf+bCPNsETVCiwXK4g fbNxZO7fu3PtJJ2vi+NLSapcQTFLd1OqxTPE/J4NBOObQN3g2Ew0UVWrBx3m/MAtJQ61 EbM3Jzs2PUZBqaZxTYvMa2sjpuifV+1do9XwkfYwct95FXd39S+4jDi32v41tHLKFqnS 8Wgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2nm22+yifGtQHBa2aWaGlXoQrpJpFkgOtCB9OhwdCMg=; b=NxQuaOPdXDlx67B4nddjHOobcO8O9MpNahyKVKD+mNq6M+TV3EMZLgjwj2stAqfmBS 61FQ4LF7bZAsTQq7bIAaOGqC26sMHDXcwof7Sny3iQJA8mYBdQvslk6XhgEz7YQNZidW tnqn6URuP9bbb+PSklTDFcu3pWlq8YlBO26J9m90VdkS9ceGnexqYnSBEhWF+oOqGtFK fUzbDmqXJGePqDeTSMPJvCfyNmQDcSbCSvMWMN25Qc/zpKUQAZxBionWpZN/HVHH610Y 5u3arFiWUiyZ/gC18SkJYq/ZjBhQ80awphuhEDq8CZUNknM9z0BMEY0hqaLeBociGPki 2gcw== X-Gm-Message-State: AOAM532fuZQh7zSDDoMzC7VdVtUjb7HBXyERWPm5DeOIJ9RZTkN+IDWa hhazAePyi77XTcn45YpvBa175rALKFk9YeyWfcA= X-Google-Smtp-Source: ABdhPJxlUYSqr7TEt+82hg4s493gyjbSHUp1iuVW/XHfuj4ZFC5ZFOD5PYwpQhCZqhtuZjLQ/Uc/wtLZqAyT5309GbY= X-Received: by 2002:a9d:669:: with SMTP id 96mr14534800otn.224.1636745663999; Fri, 12 Nov 2021 11:34:23 -0800 (PST) MIME-Version: 1.0 References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> In-Reply-To: <87v91ct330.fsf@gnus.org> From: Philipp Stephani Date: Fri, 12 Nov 2021 20:34:13 +0100 Message-ID: Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="000000000000e46af405d09c8ba1" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000e46af405d09c8ba1 Content-Type: text/plain; charset="UTF-8" Am Mo., 1. Nov. 2021 um 14:31 Uhr schrieb Lars Ingebrigtsen : > > Philipp Stephani writes: > > > Yes, but the problem only arises if the user wants to match the symbol > > `quote' plus exactly one other value. That should already be > > exceedingly rare, and can be trivially rewritten by swapping the two > > values (i.e. write (foo quote) instead of (quote foo)). So I think > > issuing a warning or error for that case is worth it. > > I think we're getting into slightly muddy waters, but I think I agree -- > a warning here is (much more) likely to be helpful than not. > Ok, I've attached two patches that implement these suggestions. --000000000000e46af405d09c8ba1 Content-Type: application/octet-stream; name="0001-Signal-an-error-if-a-fallback-case-is-misplaced-Bug-.patch" Content-Disposition: attachment; filename="0001-Signal-an-error-if-a-fallback-case-is-misplaced-Bug-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kvws1xjb0 RnJvbSA5YzYyOWI4NWNlY2ZkMjg0NTU4NWQwM2MzYmQ3NDM4YjY5Njg2YWY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IEZyaSwgMTIgTm92IDIwMjEgMjA6MjY6MDYgKzAxMDAKU3ViamVjdDogW1BBVENIIDEvMl0g U2lnbmFsIGFuIGVycm9yIGlmIGEgZmFsbGJhY2sgY2FzZSBpcyBtaXNwbGFjZWQKIChCdWcjNTEz NjgpLgoKKiBsaXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCAoY2wtY2FzZSk6IFNpZ25hbCBhbiBl cnJvciBpZiBhIHQgb3IKJ290aGVyd2lzZScga2V5IGRvZXNuJ3QgY29tZSBsYXN0LgoKKiB0ZXN0 L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVsIChjbC1jYXNlLWVycm9yKTogTmV3IHVu aXQKdGVzdC4KLS0tCiBsaXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCAgICAgICAgICAgIHwgIDkg KysrKysrKy0tCiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVsIHwgMTEgKysr KysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCBiL2xpc3AvZW1hY3Mt bGlzcC9jbC1tYWNzLmVsCmluZGV4IDE4NTI0NzFiY2IuLjYxY2FhMDkwMDkgMTAwNjQ0Ci0tLSBh L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNz LmVsCkBAIC03NzYsMTEgKzc3NiwxNiBAQCBjbC1jYXNlCiBcKGZuIEVYUFIgKEtFWUxJU1QgQk9E WS4uLikuLi4pIgogICAoZGVjbGFyZSAoaW5kZW50IDEpIChkZWJ1ZyAoZm9ybSAmcmVzdCAoc2V4 cCBib2R5KSkpKQogICAobWFjcm9leHAtbGV0MiBtYWNyb2V4cC1jb3B5YWJsZS1wIHRlbXAgZXhw cgotICAgIChsZXQqICgoaGVhZC1saXN0IG5pbCkpCisgICAgKGxldCogKChoZWFkLWxpc3Qgbmls KQorICAgICAgICAgICAoaGFzLW90aGVyd2lzZSBuaWwpKQogICAgICAgYChjb25kCiAgICAgICAg ICxAKG1hcGNhcgogICAgICAgICAgICAobGFtYmRhIChjKQotICAgICAgICAgICAgIChjb25zIChj b25kICgobWVtcSAoY2FyIGMpICcodCBvdGhlcndpc2UpKSB0KQorICAgICAgICAgICAgIChjb25z IChjb25kIChoYXMtb3RoZXJ3aXNlCisgICAgICAgICAgICAgICAgICAgICAgICAgIChlcnJvciAi TWlzcGxhY2VkIHQgb3IgYG90aGVyd2lzZScgY2xhdXNlIikpCisgICAgICAgICAgICAgICAgICAg ICAgICAgKChtZW1xIChjYXIgYykgJyh0IG90aGVyd2lzZSkpCisgICAgICAgICAgICAgICAgICAg ICAgICAgIChzZXRxIGhhcy1vdGhlcndpc2UgdCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg dCkKICAgICAgICAgICAgICAgICAgICAgICAgICAoKGVxIChjYXIgYykgJ2NsLS1lY2FzZS1lcnJv ci1mbGFnKQogICAgICAgICAgICAgICAgICAgICAgICAgICBgKGVycm9yICJjbC1lY2FzZSBmYWls ZWQ6ICVzLCAlcyIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAsdGVtcCAnLChy ZXZlcnNlIGhlYWQtbGlzdCkpKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wt bWFjcy10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MtdGVzdHMuZWwKaW5k ZXggMDMzNzY0YTdmOS4uNjhlMjliMzJkOSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNzLWxp c3AvY2wtbWFjcy10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLXRl c3RzLmVsCkBAIC02NzMsNCArNjczLDE1IEBAIGNsLW1hY3MtLXByb2d2CiAgIChzaG91bGQgKGVx dWFsIChjbC1wcm9ndiAnKHRlc3QxIHRlc3QyKSAnKDEgMikgKGxpc3QgdGVzdDEgdGVzdDIpKQog ICAgICAgICAgICAgICAgICAnKDEgMikpKSkKIAorKGVydC1kZWZ0ZXN0IGNsLWNhc2UtZXJyb3Ig KCkKKyAgIlRlc3QgdGhhdCBgY2wtY2FzZScgYW5kIGBjbC1lY2FzZScgc2lnbmFsIGFuIGVycm9y IGlmIGEgdCBvcgorYG90aGVyd2lzZScga2V5IGlzIG1pc3BsYWNlZC4iCisgIChkb2xpc3QgKGZv cm0gJygoY2wtY2FzZSB2YWwgKHQgMSkgKDEyMyAyKSkKKyAgICAgICAgICAgICAgICAgIChjbC1l Y2FzZSB2YWwgKHQgMSkgKDEyMyAyKSkKKyAgICAgICAgICAgICAgICAgIChjbC1lY2FzZSB2YWwg KDEyMyAyKSAodCAxKSkpKQorICAgIChlcnQtaW5mbyAoKHByaW4xLXRvLXN0cmluZyBmb3JtKSA6 cHJlZml4ICJGb3JtOiAiKQorICAgICAgKGxldCAoKGVycm9yIChzaG91bGQtZXJyb3IgKG1hY3Jv ZXhwYW5kIGZvcm0pKSkpCisgICAgICAgIChzaG91bGQgKGVxdWFsIChjZHIgZXJyb3IpCisgICAg ICAgICAgICAgICAgICAgICAgICcoIk1pc3BsYWNlZCB0IG9yIGBvdGhlcndpc2UnIGNsYXVzZSIp KSkpKSkpCisKIDs7OyBjbC1tYWNzLXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4zMC4xIChBcHBs ZSBHaXQtMTMwKQoK --000000000000e46af405d09c8ba1 Content-Type: application/octet-stream; name="0002-Have-cl-case-warn-about-suspicious-cases-Bug-51368.patch" Content-Disposition: attachment; filename="0002-Have-cl-case-warn-about-suspicious-cases-Bug-51368.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kvws1xjn1 RnJvbSAzMWM4YTZkOTgyMjJkZTdmNzc5MGY4MjJlOWFlMjJmZTY2YWRkZWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IEZyaSwgMTIgTm92IDIwMjEgMjA6Mjg6MjMgKzAxMDAKU3ViamVjdDogW1BBVENIIDIvMl0g SGF2ZSAnY2wtY2FzZScgd2FybiBhYm91dCBzdXNwaWNpb3VzIGNhc2VzIChCdWcjNTEzNjgpLgoK KiBsaXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCAoY2wtY2FzZSk6IFdhcm4gaWYgdGhlIHVzZXIg cGFzc2VzIGEgbmlsCmtleSBsaXN0ICh3aGljaCB3b3VsZCBuZXZlciBtYXRjaCkuICBXYXJuIGFi b3V0IHF1b3RlZCBzeW1ib2xzIHRoYXQKc2hvdWxkIHByb2JhYmx5IGJlIHVucXVvdGVkLgoKKiB0 ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVsIChjbC1jYXNlLXdhcm5pbmcpOiBO ZXcgdW5pdAp0ZXN0LgotLS0KIGxpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsICAgICAgICAgICAg fCAxNSArKysrKysrKysrKysrCiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVs IHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ3IGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCBiL2xp c3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsCmluZGV4IDYxY2FhMDkwMDkuLmMxNjgxZjM3YzUgMTAw NjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlz cC9jbC1tYWNzLmVsCkBAIC03ODksNiArNzg5LDIxIEBAIGNsLWNhc2UKICAgICAgICAgICAgICAg ICAgICAgICAgICAoKGVxIChjYXIgYykgJ2NsLS1lY2FzZS1lcnJvci1mbGFnKQogICAgICAgICAg ICAgICAgICAgICAgICAgICBgKGVycm9yICJjbC1lY2FzZSBmYWlsZWQ6ICVzLCAlcyIKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAsdGVtcCAnLChyZXZlcnNlIGhlYWQtbGlzdCkp KQorICAgICAgICAgICAgICAgICAgICAgICAgICgobnVsbCAoY2FyIGMpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAobWFjcm9leHAtd2Fybi1hbmQtcmV0dXJuCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAiQ2FzZSBuaWwgd2lsbCBuZXZlciBtYXRjaCIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgIG5pbCAnc3VzcGljaW91cykpCisgICAgICAgICAgICAgICAgICAgICAgICAgKChh bmQgKGNvbnNwIChjYXIgYykpIChub3QgKGNkZGFyIGMpKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChtZW1xIChjYWFyIGMpICcocXVvdGUgZnVuY3Rpb24pKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgKG1hY3JvZXhwLXdhcm4tYW5kLXJldHVybgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGZvcm1hdC1tZXNzYWdlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGNvbmNhdCAiQ2FzZSAlcyB3aWxsIG1hdGNoIGAlcycuICBJZiAiCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAidGhhdCdzIGludGVuZGVkLCB3cml0ZSAlcyAiCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiaW5zdGVhZC4gIE90aGVyd2lzZSwgZG9uJ3Qg IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInF1b3RlIGAlcycuIikKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FyIGMpIChjYWFyIGMpIChsaXN0IChjYWRhciBj KSAoY2FhciBjKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FkYXIgYykpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICBgKGNsLW1lbWJlciAsdGVtcCAnLChjYXIgYykpICdzdXNw aWNpb3VzKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAoKGxpc3RwIChjYXIgYykpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGhlYWQtbGlzdCAoYXBwZW5kIChjYXIgYykgaGVh ZC1saXN0KSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgYChjbC1tZW1iZXIgLHRlbXAgJywo Y2FyIGMpKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MtdGVzdHMu ZWwgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVsCmluZGV4IDY4ZTI5YjMy ZDkuLjY5ZDgyODcwOWEgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3Mt dGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy10ZXN0cy5lbApAQCAt MjQsNiArMjQsOCBAQAogKHJlcXVpcmUgJ2NsLWxpYikKIChyZXF1aXJlICdjbC1tYWNzKQogKHJl cXVpcmUgJ2VydCkKKyhyZXF1aXJlICdlcnQteCkKKyhyZXF1aXJlICdwY2FzZSkKIAogDAogOzs7 OyBjbC1sb29wIHRlc3RzIC0tIG1hbnkgYWRhcHRlZCBmcm9tIFN0ZWVsZSdzIENMdEwyCkBAIC02 ODQsNCArNjg2LDM0IEBAIGNsLWNhc2UtZXJyb3IKICAgICAgICAgKHNob3VsZCAoZXF1YWwgKGNk ciBlcnJvcikKICAgICAgICAgICAgICAgICAgICAgICAgJygiTWlzcGxhY2VkIHQgb3IgYG90aGVy d2lzZScgY2xhdXNlIikpKSkpKSkKIAorKGVydC1kZWZ0ZXN0IGNsLWNhc2Utd2FybmluZyAoKQor ICAiVGVzdCB0aGF0IGBjbC1jYXNlJyBhbmQgYGNsLWVjYXNlJyB3YXJuIGFib3V0IHN1c3BpY2lv dXMKK2NvbnN0cnVjdHMuIgorICAocGNhc2UtZG9saXN0IChgKCxjYXNlIC4gLG1lc3NhZ2UpCisg ICAgICAgICAgICAgICAgIGAoKG5pbCAuICJDYXNlIG5pbCB3aWxsIG5ldmVyIG1hdGNoIikKKyAg ICAgICAgICAgICAgICAgICAoJ25pbCAuICwoY29uY2F0ICJDYXNlICduaWwgd2lsbCBtYXRjaCBg cXVvdGUnLiAgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIklmIHRoYXQn cyBpbnRlbmRlZCwgd3JpdGUgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IihuaWwgcXVvdGUpIGluc3RlYWQuICAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiT3RoZXJ3aXNlLCBkb24ndCBxdW90ZSBgbmlsJy4iKSkKKyAgICAgICAgICAgICAgICAg ICAoJ3QgLiAsKGNvbmNhdCAiQ2FzZSAndCB3aWxsIG1hdGNoIGBxdW90ZScuICAiCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIklmIHRoYXQncyBpbnRlbmRlZCwgd3JpdGUgIgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIodCBxdW90ZSkgaW5zdGVhZC4gICIK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiT3RoZXJ3aXNlLCBkb24ndCBxdW90 ZSBgdCcuIikpCisgICAgICAgICAgICAgICAgICAgKCdmb28gLiAsKGNvbmNhdCAiQ2FzZSAnZm9v IHdpbGwgbWF0Y2ggYHF1b3RlJy4gICIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJJZiB0aGF0J3MgaW50ZW5kZWQsIHdyaXRlICIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICIoZm9vIHF1b3RlKSBpbnN0ZWFkLiAgIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIk90aGVyd2lzZSwgZG9uJ3QgcXVvdGUgYGZvbycuIikpCisgICAg ICAgICAgICAgICAgICAgKCMnZm9vIC4gLChjb25jYXQgIkNhc2UgIydmb28gd2lsbCBtYXRjaCAi CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImBmdW5jdGlvbicuICBJZiB0 aGF0J3MgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJpbnRlbmRlZCwg d3JpdGUgKGZvbyBmdW5jdGlvbikgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJpbnN0ZWFkLiAgT3RoZXJ3aXNlLCBkb24ndCAiCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgInF1b3RlIGBmb28nLiIpKSkpCisgICAgKGRvbGlzdCAobWFjcm8gJyhj bC1jYXNlIGNsLWVjYXNlKSkKKyAgICAgIChsZXQgKChmb3JtIGAoLG1hY3JvIHZhbCAoLGNhc2Ug MSkpKSkKKyAgICAgICAgKGVydC1pbmZvICgocHJpbjEtdG8tc3RyaW5nIGZvcm0pIDpwcmVmaXgg IkZvcm06ICIpCisgICAgICAgICAgKGVydC13aXRoLW1lc3NhZ2UtY2FwdHVyZSBtZXNzYWdlcwor ICAgICAgICAgICAgKG1hY3JvZXhwYW5kIGZvcm0pCisgICAgICAgICAgICAoc2hvdWxkIChlcXVh bCBtZXNzYWdlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbmNhdCAiV2FybmluZzog IiBtZXNzYWdlICJcbiIpKSkpKSkpKSkKKwogOzs7IGNsLW1hY3MtdGVzdHMuZWwgZW5kcyBoZXJl Ci0tIAoyLjMwLjEgKEFwcGxlIEdpdC0xMzApCgo= --000000000000e46af405d09c8ba1-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 20:09:33 2021 Received: (at 51368) by debbugs.gnu.org; 14 Nov 2021 01:09:33 +0000 Received: from localhost ([127.0.0.1]:48529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mm41V-0005PR-39 for submit@debbugs.gnu.org; Sat, 13 Nov 2021 20:09:33 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mm41T-0005PD-6v for 51368@debbugs.gnu.org; Sat, 13 Nov 2021 20:09:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=H5Ij8ngCeRhSMaHRgBCX6UOVksSHB0Fg85IMY6hXUa0=; b=g1kBhVdMbw9WCQgGbpXfsEIrR1 Vs9qPZP/tC4efBRo5PPzSL9PcgjkaxBttabfValKjGdHR5p1yDZ1osWnK5O3m5W/nTc1G/1qDK0dl BPOCbZgc/aOtMucUKYnNWa55WYNP+hq+Im8EDpfJwtbWbfOwNACj4IP+PK5XnQYzPu+8=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mm41K-0005nt-RU; Sun, 14 Nov 2021 02:09:25 +0100 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEU8QEs3OkMoKCsb Gh0fICRUWGGcn6izucX09PbO0todHSFqcYEgHiEgHR/////UU9brAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+ULDgEIKg/yT1oAAAFvSURBVDjL7dExS8NAFAfwVKxIJxU/QD2vKOKUgwoFQY4DoXRpS4t1 FA3VyU3dXDTNWtDSTdLocHTyI2gmSaduxXwX3+XuEoTL5uh/SOB+9+69S6wCMsdC//DnsGXlQLmQ B0s5sJbTg6ybAXc3zHDs5Yx7+2gboeq5JSPsjlyHmuBkMLg8owYo9j3HXU4BI6x2lVdGd961n1Vg VVFxnNF4fJoBQzQxfON0eoN7qoBiRsEge73nSrPvZj2YiNhXdVvvBw80myoR8e5dfby0dQVFWJcs 7QxR0U6bM6Zgu3vR1DOKHinsrw5t1KpoYDoIvZ4j2nprS8AsE2iH/aMnP4MoVO1BcYcmIFYjCSy5 KwrkUawRJQnBKKOb+n/ASbD6pWvsEpafx2IhVHDOp1HYAPOxHAJZ4pTveLEAgaJ6PVBTAMzieEEI 5wBqXUJ8OCeQGsgUjtR3tWYxkalx0YoHGj4JSYVP4BEomJNfqU3ApzDeD3Ut/PmjBFl0AAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIxLTExLTE0VDAxOjA4OjQyKzAwOjAwJzK4SgAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMS0xMS0xNFQwMTowODo0MiswMDowMFZvAPYAAAAASUVORK5CYII= X-Now-Playing: Anna B Savage's _A Common Turn_: "Corncrakes" Date: Sun, 14 Nov 2021 02:09:22 +0100 In-Reply-To: (Philipp Stephani's message of "Fri, 12 Nov 2021 20:34:13 +0100") Message-ID: <871r3jh7b1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > Ok, I've attached two patches that implement these suggestions. > > From 9c629b85cecfd2845585d03c3bd7438b69686af9 Mon Sep 17 00:00:00 2001 > From: Philipp Stephani > Date: Fri, 12 [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp Stephani writes: > Ok, I've attached two patches that implement these suggestions. > > From 9c629b85cecfd2845585d03c3bd7438b69686af9 Mon Sep 17 00:00:00 2001 > From: Philipp Stephani > Date: Fri, 12 Nov 2021 20:26:06 +0100 > Subject: [PATCH 1/2] Signal an error if a fallback case is misplaced > (Bug#51368). Looks good to me -- I've added Stefan to the CCs; perhaps he has some comments. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 14 10:09:02 2021 Received: (at 51368) by debbugs.gnu.org; 14 Nov 2021 15:09:02 +0000 Received: from localhost ([127.0.0.1]:51334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmH7u-0002X7-Ei for submit@debbugs.gnu.org; Sun, 14 Nov 2021 10:09:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmH7s-0002Wb-Fh for 51368@debbugs.gnu.org; Sun, 14 Nov 2021 10:09:01 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9CBA5440B41; Sun, 14 Nov 2021 10:08:54 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 28B84440B1F; Sun, 14 Nov 2021 10:08:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1636902533; bh=RF6FM7cjZV36XDAiB/vjEJwNboA7KkgGLk31S8dP9Dk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kb5x+zbf9SN9hHgaTwsUWGGdxBNAQJiD9W5Jhvws2iDwMHPFWkE0DXCdfibFSelFM 7keb41LzDvMHMNDkFlv/t0nQOReztaMpw2yffbXxo9fAiEGnZgGjFsRMzYJ4OMX8iX cYybUheuuHhCQYsUPYnBnDU6gqgxfK2nA/6dbnq0iET/vCBcYoxDMUXjQGPDfwda2w NuNVIfFV2ZO5JXhbGiUjCrlinZr8zoANkNUfLpELrRpdU2t1Tib+5raVzNkiai1lm0 fahNsFy6weu3M7rxireml70jaOtjckTAyFddWwyNk+D8w2ivtMwnx9Dqc0gzyMMOb3 vEhu7aIKuZP4Q== Received: from pastel (unknown [45.72.128.33]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BF543120893; Sun, 14 Nov 2021 10:08:52 -0500 (EST) From: Stefan Monnier To: Philipp Stephani Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use Message-ID: References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> Date: Sun, 14 Nov 2021 10:08:51 -0500 In-Reply-To: (Philipp Stephani's message of "Fri, 12 Nov 2021 20:34:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Ok, I've attached two patches that implement these suggestions. BTW, there's a third issue which is that (cl-case EXP ((a b) FOO) ((a c) BAR)) won't warn about the duplicate `a`. After fixing this, many/most uses of `quote` will already emit a warning, so maybe it would make the quote/function part of your second patch unnecessary. Personally, I just recommend the use of `pcase` over `cl-case` ;-) BTW, I just noticed the use of the `suspicious` category of warning messages. Doesn't this category apply to all warnings? Oh, and for the `nil` case and the presence of branches after `otherwise`, the warnings could use the same text saying the branch is unreachable. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 11:20:07 2022 Received: (at 51368) by debbugs.gnu.org; 13 Sep 2022 15:20:07 +0000 Received: from localhost ([127.0.0.1]:52485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY7hn-0003tu-Hd for submit@debbugs.gnu.org; Tue, 13 Sep 2022 11:20:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY7hl-0003tH-8W for 51368@debbugs.gnu.org; Tue, 13 Sep 2022 11:20:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jyQfmTbHrajhpL01jJZZxdjYkSbVXlpauzrHXKA3kS8=; b=iWCwhi+RksBziULQKK6ApMfT3t cFLarSl1/TPAPYt39LSRT1tql0L0VmAJdx66FB44xSCBnkqISZ74mX7CtyDgYnIUagyIU77eZGful 1NyqTknerkk7B+ADjLfOjIiNngv+aM4nwDN8aCj3C3LWSi1zPC1qSXkNWIPe208ohKDA=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY7hb-000504-0n; Tue, 13 Sep 2022 17:19:57 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use In-Reply-To: (Stefan Monnier's message of "Sun, 14 Nov 2021 10:08:51 -0500") References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> X-Now-Playing: Nia Andrews's _Modern Love_: "Silly Boy Blue" Date: Tue, 13 Sep 2022 17:19:54 +0200 Message-ID: <87o7vjxpwl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > BTW, there's a third issue which is that > > (cl-case EXP > ((a b) FOO) > ((a c) BAR)) > > won't warn about the duplicate `a`. > > After fixing this, many/most uses of `quote` will already emit > a [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > BTW, there's a third issue which is that > > (cl-case EXP > ((a b) FOO) > ((a c) BAR)) > > won't warn about the duplicate `a`. > > After fixing this, many/most uses of `quote` will already emit > a warning, so maybe it would make the quote/function part of your second > patch unnecessary. I think it's nice to have an explicit error case for the quote case so that the warning can be better, though, so I've pushed Philipps patches to Emacs 29. But this test case should also emit a warning. Philipp, you don't happen to have a fix for that one, too? =F0=9F=98=80 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 11:20:11 2022 Received: (at control) by debbugs.gnu.org; 13 Sep 2022 15:20:11 +0000 Received: from localhost ([127.0.0.1]:52488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY7hq-0003u9-QO for submit@debbugs.gnu.org; Tue, 13 Sep 2022 11:20:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY7ho-0003tk-70 for control@debbugs.gnu.org; Tue, 13 Sep 2022 11:20:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YVKpY2+gTZapvUa+39XNcFgnL+jx5fSWf3sFOr451E8=; b=hFM6glj9Ni+71VMcJsA5K3d2iz 6u+TjT98/qRk1M6xtRrHuIkn9RQxwbsw888sahKq9lgnV6IEOENGRAqxVdQN+JwCBxwwmyInEMt33 VTzWBV5m4K/Foo0Lxis5iI6JMMNNqqrDBqUZNexvyq+R2+lmtpP0kjhuvdJOfPn/Ijr0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY7hg-00050C-F3 for control@debbugs.gnu.org; Tue, 13 Sep 2022 17:20:02 +0200 Date: Tue, 13 Sep 2022 17:20:00 +0200 Message-Id: <87mtb3xpwf.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51368 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 51368 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 51368 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 12:13:03 2022 Received: (at 51368) by debbugs.gnu.org; 13 Sep 2022 16:13:03 +0000 Received: from localhost ([127.0.0.1]:52745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY8X1-0007ed-EZ for submit@debbugs.gnu.org; Tue, 13 Sep 2022 12:13:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY8Wy-0007dp-00 for 51368@debbugs.gnu.org; Tue, 13 Sep 2022 12:13:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UQG/c05nqcJxp7/SdkoVcyI755muAGY9nlxIx9oYo7Q=; b=c0YkI0pXZ6KQNrhVvhkzk8m4q0 BhCyoWS/4J7Zt1CbFOusus7z9iwzXU45y2HZUf8jsGDpgrJinz8FnMdE7d+7iZuZtrAwLlebdPYdW QPeOtCso2fpTYFk694Nyi0hjqz260fCde1E7TsW7ju376o5FMVUL0xw0iDYvMFWjgbrw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY8Wo-0005cF-AL; Tue, 13 Sep 2022 18:12:52 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use In-Reply-To: <87o7vjxpwl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Sep 2022 17:19:54 +0200") References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> <87o7vjxpwl.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUAAAMkJy6irLF2 gIjp6upQWGH///9DTtf1AAAAAWJLR0QGYWa4fQAAAAlwSFlzAAAASAAAAEgARslrPgAAAAd0SU1F B+YJDRAGFzocaaIAAADqSURBVDjL5dJRbsMgDAZgUNT3sKgHqONeAJIDjPwHaBdx/6sMWBKzDB4q 9W2WkCJ/wsQGpd4ZvTK6f2WDboIxLxX6Z9E38npsSIdbHS5Y6jAAj62okexVaQY+470ZE0LYizyu /FwRY47JdT6gWxzfM/g5rPHTHccSvE2Axdm4duhSijP4BJY2+MARniitDSYBFHAxfALGT2PjL2AB KkvFrAfyrAcmnCPC19MCNRg81aFsQv4sz3g65/c+tP2zAdu9TNUzqqJaIk+nmIovQXXSTRpK8XZI 9vBxH3mSItQGJ6ALGF0QUFbgbtQ3uV5uZHYbI0AAAABaZVhJZk1NACoAAAAIAAUBEgADAAAAAQAB AAABGgAFAAAAAQAAAEoBGwAFAAAAAQAAAFIBKAADAAAAAQABAAACEwADAAAAAQABAAAAAAAAAAAA SAAAAAEAAABIAAAAAZSByS0AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDktMTNUMTY6MDY6MjMr MDA6MDAR2B4SAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA5LTEzVDE2OjA2OjIzKzAwOjAwYIWm rgAAABd0RVh0ZXhpZjpZQ2JDclBvc2l0aW9uaW5nADGsD4BjAAAAAElFTkSuQmCC X-Now-Playing: Jana Rush's _Pariah_: "Break It" Date: Tue, 13 Sep 2022 18:12:49 +0200 Message-ID: <874jxbxnge.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: I was surprised that these new tests didn't yield any new warnings. :-) But I'm doing a nativecomp bootstrap now, and: ../lisp/dnd.el: Warning: Case 'copy will match ‘quote’. If that’s intended, write (copy quote) instead. Otherwise, don’t quote ‘copy’. ../lisp/dnd.el: Warning: Case 'move will match ‘quo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I was surprised that these new tests didn't yield any new warnings. :-) But I'm doing a nativecomp bootstrap now, and: ../lisp/dnd.el: Warning: Case 'copy will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (copy quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98copy=E2=80=99. ../lisp/dnd.el: Warning: Case 'move will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (move quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98move=E2=80=99. ../lisp/dnd.el: Warning: Case 'copy will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (copy quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98copy=E2=80=99. ../lisp/dnd.el: Warning: Case 'move will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (move quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98move=E2=80=99. ../lisp/dnd.el: Warning: Case 'link will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (link quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98link=E2=80=99. ../lisp/dnd.el: Warning: Case 'copy will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (copy quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98copy=E2=80=99. ../lisp/dnd.el: Warning: Case 'move will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (move quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98move=E2=80=99. ../lisp/dnd.el: Warning: Case 'link will match =E2=80=98quote=E2=80=99. If= that=E2=80=99s intended, write (link quote) instead. Otherwise, don=E2=80= =99t quote =E2=80=98link=E2=80=99. ../lisp/progmodes/compile.el: Warning: Case 'if-location-known will match = =E2=80=98quote=E2=80=99. If that=E2=80=99s intended, write (if-location-kn= own quote) instead. Otherwise, don=E2=80=99t quote =E2=80=98if-location-kn= own=E2=80=99. ../lisp/progmodes/compile.el: Warning: Case 'first-known will match =E2=80=98quote=E2=80=99. If that=E2=80=99s intended, write From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 12:15:31 2022 Received: (at 51368) by debbugs.gnu.org; 13 Sep 2022 16:15:31 +0000 Received: from localhost ([127.0.0.1]:52754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY8ZP-0000t6-Fu for submit@debbugs.gnu.org; Tue, 13 Sep 2022 12:15:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY8ZN-0000Vm-Gs for 51368@debbugs.gnu.org; Tue, 13 Sep 2022 12:15:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xrg13rWti0FR3Myee5vxsCHL14/MnZoUXTX2Q2Yf3bo=; b=MlZIr6jmQH/PocRS7RtAK02x+n IgC1HGHWjWrp2j7iJuBYXHtrsS+k5n9g/I3V68FsERaKEnCZrXM2dX03qzyjnDWCrfPr2LZweYWwo jdqbPbaYWZ67evab8PRfjNYrOwwaxy8hiSSbjGv+YwHH266dK+AHDgnz7mY/0U1cvio4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY8ZE-0005cv-8z; Tue, 13 Sep 2022 18:15:22 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use In-Reply-To: <874jxbxnge.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Sep 2022 18:12:49 +0200") References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> <87o7vjxpwl.fsf@gnus.org> <874jxbxnge.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUAAAMkJy6irLF2 gIjp6upQWGH///9DTtf1AAAAAWJLR0QGYWa4fQAAAAlwSFlzAAAASAAAAEgARslrPgAAAAd0SU1F B+YJDRAGFzocaaIAAADqSURBVDjL5dJRbsMgDAZgUNT3sKgHqONeAJIDjPwHaBdx/6sMWBKzDB4q 9W2WkCJ/wsQGpd4ZvTK6f2WDboIxLxX6Z9E38npsSIdbHS5Y6jAAj62okexVaQY+470ZE0LYizyu /FwRY47JdT6gWxzfM/g5rPHTHccSvE2Axdm4duhSijP4BJY2+MARniitDSYBFHAxfALGT2PjL2AB KkvFrAfyrAcmnCPC19MCNRg81aFsQv4sz3g65/c+tP2zAdu9TNUzqqJaIk+nmIovQXXSTRpK8XZI 9vBxH3mSItQGJ6ALGF0QUFbgbtQ3uV5uZHYbI0AAAABaZVhJZk1NACoAAAAIAAUBEgADAAAAAQAB AAABGgAFAAAAAQAAAEoBGwAFAAAAAQAAAFIBKAADAAAAAQABAAACEwADAAAAAQABAAAAAAAAAAAA SAAAAAEAAABIAAAAAZSByS0AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDktMTNUMTY6MDY6MjMr MDA6MDAR2B4SAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA5LTEzVDE2OjA2OjIzKzAwOjAwYIWm rgAAABd0RVh0ZXhpZjpZQ2JDclBvc2l0aW9uaW5nADGsD4BjAAAAAElFTkSuQmCC X-Now-Playing: Jana Rush's _Pariah_: "No Fuks Given" Date: Tue, 13 Sep 2022 18:15:19 +0200 Message-ID: <87zgf3w8rs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I was surprised that these new tests didn't yield any new warnings. :-) Ah, nevermind -- I was testing the bootstrap on the wrong (un-updated) machine. Now I'm seeing the warnings in a non-nativecomp build, too. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > I was surprised that these new tests didn't yield any new warnings. :-) Ah, nevermind -- I was testing the bootstrap on the wrong (un-updated) machine. Now I'm seeing the warnings in a non-nativecomp build, too. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 17:43:55 2022 Received: (at 51368) by debbugs.gnu.org; 2 Oct 2022 21:43:55 +0000 Received: from localhost ([127.0.0.1]:48232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of6kc-0000rm-DO for submit@debbugs.gnu.org; Sun, 02 Oct 2022 17:43:54 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:33441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of6kZ-0000rX-8S for 51368@debbugs.gnu.org; Sun, 02 Oct 2022 17:43:52 -0400 Received: (Authenticated sender: self@gkayaalp.com) by mail.gandi.net (Postfix) with ESMTPSA id 4C2FB1C0002 for <51368@debbugs.gnu.org>; Sun, 2 Oct 2022 21:43:41 +0000 (UTC) From: =?utf-8?Q?G=C3=B6ktu=C4=9F_Kayaalp?= To: 51368@debbugs.gnu.org Subject: 29.0.50; `cl-case' should error on incorrect use Date: Mon, 03 Oct 2022 00:39:39 +0300 Message-ID: <87r0zpj46c.fsf@gkayaalp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51368 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, I noticed the change associated with this bug (6d8f5161ead689b7a2e44a7de0a695f0ab4c833b) today building Emacs and testing it against my packages; it seems that it=E2=80=99s broken a few packages, at least org-checklist and pdf-tools[1]. I usually go thru the diff of NEWS and the new commits when I build Emacs but I doubt there=E2=80=99s a NEWS entry for this breaking change. Is it possible that (i) a relevant NEWS entry is added and/or (ii) maybe this error is made non-fatal, at least for a while? [1] I=E2=80=99ll probably send patches to these packages, but I=E2=80=99m n= ot sure if org-checklist is maintained by anyone. --=20 =C4=B0. G=C3=B6ktu=C4=9F Kayaalp / @cadadr / pgp: 024C 30DD 597D 142B 49AC 40EB 465C D949 B101 2427 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 04:48:29 2023 Received: (at 51368-done) by debbugs.gnu.org; 3 Sep 2023 08:48:29 +0000 Received: from localhost ([127.0.0.1]:39298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcimT-0000RH-5k for submit@debbugs.gnu.org; Sun, 03 Sep 2023 04:48:29 -0400 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:55747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcimN-0000Q4-Tw for 51368-done@debbugs.gnu.org; Sun, 03 Sep 2023 04:48:27 -0400 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2bcb89b4767so6095381fa.3 for <51368-done@debbugs.gnu.org>; Sun, 03 Sep 2023 01:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693730887; x=1694335687; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=SmXA1uI9YXG+LUWSzIIt7tzU2sPS0oihoOLNBwG5YMA=; b=LZ5PjRYjXIG+dpXL8XZxClL50qQRNjzjIW4tV4ZUzehm4CYNk0wHj6m286Ta9ft9i3 +pbunWenlxCDHXmkBTczFaxu2WBvxBK2NLp14AfAY/BFYqhpb/o82P+DlnfjVxVIQ8RI Z28E6yMdFAhVADEgHcWHjd4+znzOudg8OUIbqEdb078TZB8n32fvfFMgeH0+ZbyyOYNs zKAZ/RAUetTC8xXZbArBwcNj0aRyvz7Jx267lR+9WGUYYV19OXG2W8Xla5fCXoHfn8PD H7fgiIkm9oKyimxcC5KtbeIR7MUn4Gw4AmTp3TGmYyvZmXqmcYeo5xK9GxBozrJvCzlL 6QlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693730887; x=1694335687; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SmXA1uI9YXG+LUWSzIIt7tzU2sPS0oihoOLNBwG5YMA=; b=e5lOumsAa/hPcukxBtCD4WzSWJiFaFdducB2+cSxZx69ZuihR9knIb56Rr5eJxdZFz ZsUqyfpvYbpZThwHQJA5bzINgAukxSEv+4vIntnp0ACfpitKY57abRIiL9cvgL9qz7Bv 0f5huhY6Pes5CyWH/dcFQW6P8gBtGjy72L+c+NsbKUW4UtItlZ16m0DIGHKVilsKh0A7 QHSHLTg2P5XkAS6YIGTlgIGRgbu6md/C9/qv50JYkg2cdU3boSITL5C/2M4fRRA7vZdA 1Yxx+S5elqd+tfKHXXXyu2LoCQP4DREyOfjYUXVjopCVPGfqlYae0DxO4unlhGuMHohA UJlg== X-Gm-Message-State: AOJu0YyR8ZDImjUMDYwCjRsqPeRHH7OmMac4WBaO3thRB2qi3DDvQB6G 7iOZHk7iOY+sSWmVmZ2Fm6Vo0DtrWqp4AoBoVJklLR5mHsM= X-Google-Smtp-Source: AGHT+IGtqbeE/PHHF5TgzJ9rfQveXIXUJGJzyjW3rx/bUj474tT3oAkAieRo+IpOr9G//URNYLMNXB6ILicZepFPyf4= X-Received: by 2002:a05:6512:3c9f:b0:4ff:7046:984a with SMTP id h31-20020a0565123c9f00b004ff7046984amr5520773lfv.7.1693730887498; Sun, 03 Sep 2023 01:48:07 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 01:48:07 -0700 From: Stefan Kangas In-Reply-To: <87o7vjxpwl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Sep 2022 17:19:54 +0200") References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> <87o7vjxpwl.fsf@gnus.org> MIME-Version: 1.0 Date: Sun, 3 Sep 2023 01:48:07 -0700 Message-ID: Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51368-done Cc: 51368-done@debbugs.gnu.org, Philipp Stephani , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Stefan Monnier writes: > >> BTW, there's a third issue which is that >> >> (cl-case EXP >> ((a b) FOO) >> ((a c) BAR)) >> >> won't warn about the duplicate `a`. >> >> After fixing this, many/most uses of `quote` will already emit >> a warning, so maybe it would make the quote/function part of your second >> patch unnecessary. > > I think it's nice to have an explicit error case for the quote case so > that the warning can be better, though, so I've pushed Philipps patches > to Emacs 29. > > But this test case should also emit a warning. Philipp, you don't > happen to have a fix for that one, too? =F0=9F=98=80 If I'm reading this right, it seems like the patches here were pushed to master, but the bug was left open. I'm therefore closing this bug report. If this conclusion is incorrect, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 03 09:40:26 2023 Received: (at 51368) by debbugs.gnu.org; 3 Sep 2023 13:40:27 +0000 Received: from localhost ([127.0.0.1]:40023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnL0-0001o7-Kd for submit@debbugs.gnu.org; Sun, 03 Sep 2023 09:40:26 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:46368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnKw-0001no-7C for 51368@debbugs.gnu.org; Sun, 03 Sep 2023 09:40:25 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-500c7796d8eso957731e87.1 for <51368@debbugs.gnu.org>; Sun, 03 Sep 2023 06:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693748405; x=1694353205; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=3zqYftnagsSStAs0TE3UGnNqNqNZU17TZ+K5d8pddd4=; b=r+armEAC7zHyt1TZ8SlpHZLGTu8wGwbeAIw1KjJqLmdDAfulilhrtke222bblo9bah wcKnXeyTZRy9weOzphbqzjiLCpuSRaaQ5/+WXxplUdzHAAIQ+6n4s56evrAJI1rdM3/U FtKnrB27BdA8xAAEWjyDDZMdOz1SP9IgcuRNWOUE3JN59vPIBVdQ2Dr9Fm6Z+u3367H0 iV4OfmGYhNVz0NCsqjp0+WjRi7IkOAybwYs58Bst07TLXyk+6y+rhcR8xev714M7pq6X SKiInj3S19O8u3QLsqcdmWxYdGBTeTdWc1kBFLJqczN3XRHKSJKqCXNr04sUqH/Qhu9d Kdjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693748405; x=1694353205; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3zqYftnagsSStAs0TE3UGnNqNqNZU17TZ+K5d8pddd4=; b=HBOCtfkVPfz80lKLhC4H+lLKfUqzOCfmfKloaYYY6gItk1o/egyxhdbJrdfAqNItDp Nc3ybLdVrFolS00nlq2VjCLBRKk2a1hJF6urQrJrfmY/8u2jebXhSztQO42mvjSCr1UN DbkGA0+411iLyD500T92rw8DXVGJfEpDl623e6yttSh65W8eDfwMB2Q67ah1ayL6NyOk zYF0DTKI2+bdh7F9mYYU+I3piWdSoCctteoaMR+h+iz92cE9uBMDZDiyN/virCNYPXlF psX8cSwBI7L1DJG99cR/cbayIIK3O1XyR8lQyxickK+OWGJ3uEWJhgRICkKC/AwuWmQg 8PNw== X-Gm-Message-State: AOJu0Yy+mpBsS8LC5vcNet5Z47wZHKyeoWBqKoBJE9+Q35vzD0BVaUcI 6CF133gJ49dZM0frt8xeOtTs0NyfcoE= X-Google-Smtp-Source: AGHT+IGcEc579j8T21CM/OrF65JgaELn2pjZajevFLORx8qxOx/mXREi1MPEbTJ6YdLUGyD3YUgWTQ== X-Received: by 2002:a05:6512:3b8a:b0:4f8:7055:6f7e with SMTP id g10-20020a0565123b8a00b004f870556f7emr5651580lfv.44.1693748405260; Sun, 03 Sep 2023 06:40:05 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id f6-20020ac25326000000b004fe5688b5dcsm1272755lfh.150.2023.09.03.06.40.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Sep 2023 06:40:04 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use Message-Id: <03810284-957B-4ABD-8013-E9746FAFC17E@gmail.com> Date: Sun, 3 Sep 2023 15:40:03 +0200 To: Stefan Kangas X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, Philipp Stephani , Lars Ingebrigtsen , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > (cl-case EXP > ((a b) FOO) > ((a c) BAR)) >=20 > won't warn about the duplicate `a`. I was curious how common this could be so I locally added a warning to = the back-end in bytecomp that generates switches (attached), and = bootstrapped Emacs. Results: ---------------- In gnus-cloud-decode-data: lisp/gnus/gnus-cloud.el:154:6: Warning: Duplicated value in =E2=80=98cond=E2= =80=99: base64-gzip In netrc-parse: lisp/obsolete/netrc.el:106:22: Warning: Duplicated value in =E2=80=98cond=E2= =80=99: "macdef" In org-read-date-analyze: lisp/org/org.el:14041:15: Warning: Duplicated value in =E2=80=98cond=E2=80= =99: "" In org-html-latex-fragment: lisp/org/ox-html.el:3099:8: Warning: Duplicated value in =E2=80=98cond=E2=80= =99: t ----------------- None of these are from `cl-case`. (`pcase` doesn't typically warn either = but just drops the duplicate silently.) I probably won't keep the warning because it's in the back-end and was = very much a hack. --Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2 Content-Disposition: attachment; filename=bytecomp-cond-switch-dup-warn.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="bytecomp-cond-switch-dup-warn.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 7feaf118b86..6bb95e7865b 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -4621,7 +4621,10 @@ byte-compile--cond-switch-prefix (setq switch-var var) (setq switch-test (byte-compile--common-test switch-test fn)) - (unless (member value keys) + (if (member value keys) + (byte-compile-warn-x + (car clauses) + "Duplicated value in `cond': %S" value) (push value keys) (push (cons (list value) (or body '(t))) cases)) t)))) @@ -4632,7 +4635,10 @@ byte-compile--cond-switch-prefix (setq switch-var var) (setq switch-test (byte-compile--common-test switch-test 'eq)) - (unless (memq nil keys) + (if (memq nil keys) + (byte-compile-warn-x + (car clauses) + "Duplicated value in `cond': nil") (push nil keys) (push (cons (list nil) (or body '(t))) cases)) t))) @@ -4655,7 +4661,10 @@ byte-compile--cond-switch-prefix (member . equal)))))) (let ((vals nil)) (dolist (elem value) - (unless (funcall fn elem keys) + (if (funcall fn elem keys) + (byte-compile-warn-x + (car clauses) + "Duplicated value in `cond': %S" elem) (push elem vals))) (when vals (setq keys (append vals keys)) --Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 01 13:04:15 2023 Received: (at 51368) by debbugs.gnu.org; 1 Oct 2023 17:04:15 +0000 Received: from localhost ([127.0.0.1]:35228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmzrb-0006ws-9x for submit@debbugs.gnu.org; Sun, 01 Oct 2023 13:04:15 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:53605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmzrZ-0006wa-Nt for 51368@debbugs.gnu.org; Sun, 01 Oct 2023 13:04:14 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c16757987fso163859301fa.3 for <51368@debbugs.gnu.org>; Sun, 01 Oct 2023 10:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696179831; x=1696784631; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hy6Ck4d5iRGvVYI34I5Gmp/ym76zZr6bwg+NDiwCAFE=; b=ZLNwzmx0aD2VQ6AT+G/hcUdD4eXimekIyBVrTpvoo96Bkpfg8yZIO+t5fAvjC6XVCC Zon6480EbkwJ3s9/Z8qFlS9SeZz1+UgnB91YS4hntZOq5cN7ftak9pBfjTv+Q9296J9b Spm0SxTq2odZt6sJSw9UXS6CGrzSaVrOvEqtVSetpuX+6yYIFvrFXnP7N4fq4UBhhxjA DK1MJRHTp9KGGJMqU+pW62pjl2siAVegto0/iaTwTroIq7MDIDV9iB8oTqaQWieEDYa8 zy/x4ls0bMaB/sRgg1d4bSR0DwloraRm4sqd4o0e0mG2WBPbkSCwib3rEIWwHoHQ9+8H BE9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696179831; x=1696784631; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Hy6Ck4d5iRGvVYI34I5Gmp/ym76zZr6bwg+NDiwCAFE=; b=d5RWjsp+dxnjwzZcO1EbEk5fiGvGmIZv5zIHgSqpvle2TVYIkognqUg8PllHsZOHrO 3A57O8zsJG4pBhU39eEkb7cTeKLmyMyI/bFNFGs8xObZv6aoMS8cYOT/U3JTdTuIbKVt /TFXjLVlpyeKD+fZQ5WgwMRgq4dflHXH0MemO/caZcutOLVeJq7G0DduqeWp7eyQy9fj NlSklyc2BS7tRbYO3X7Tri+6eB6m3WZfrjl3te37yRs0eyPzxVVCCn6o8uJlZJERpWOj lxa3odgapP0wA8AhqBeyfb9YwTuxLN/dmj8JZ8/+pvkcV4dk4IQNwn/VY5TqLRog29Ew dr6g== X-Gm-Message-State: AOJu0Yz4NlMm6uzkwNLWNVbXWaOgpXJyJArHrGYEMMVbo4heOyBSFcof 75owaGkyWRCOeXcPvIzE3bVdk2UlFXediJuslRw= X-Google-Smtp-Source: AGHT+IFjYKb8aNMf9u2tfGLcyxQHu8VokYZzyRpObMDgAceKTcVsResCO3hcltRAdzRn8REUFN32qBRhUqQx9sBTz8U= X-Received: by 2002:a2e:a554:0:b0:2c2:97b9:4a95 with SMTP id e20-20020a2ea554000000b002c297b94a95mr2836878ljn.15.1696179831224; Sun, 01 Oct 2023 10:03:51 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 1 Oct 2023 10:03:50 -0700 From: Stefan Kangas In-Reply-To: <03810284-957B-4ABD-8013-E9746FAFC17E@gmail.com> References: <03810284-957B-4ABD-8013-E9746FAFC17E@gmail.com> MIME-Version: 1.0 Date: Sun, 1 Oct 2023 10:03:50 -0700 Message-ID: Subject: Re: bug#51368: 29.0.50; `cl-case' should error on incorrect use To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51368 Cc: 51368@debbugs.gnu.org, Philipp Stephani , Lars Ingebrigtsen , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: >> (cl-case EXP >> ((a b) FOO) >> ((a c) BAR)) >> >> won't warn about the duplicate `a`. > > I was curious how common this could be so I locally added a warning to th= e back-end in bytecomp that generates switches (attached), and bootstrapped= Emacs. Results: > > ---------------- > In gnus-cloud-decode-data: > lisp/gnus/gnus-cloud.el:154:6: Warning: Duplicated value in =E2=80=98cond= =E2=80=99: base64-gzip > > In netrc-parse: > lisp/obsolete/netrc.el:106:22: Warning: Duplicated value in =E2=80=98cond= =E2=80=99: "macdef" > > In org-read-date-analyze: > lisp/org/org.el:14041:15: Warning: Duplicated value in =E2=80=98cond=E2= =80=99: "" > > In org-html-latex-fragment: > lisp/org/ox-html.el:3099:8: Warning: Duplicated value in =E2=80=98cond=E2= =80=99: t > ----------------- Thanks, I added FIXMEs for them on master. From unknown Sun Jun 22 22:42:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Oct 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator