GNU bug report logs - #51364
[PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input

Previous Next

Full log

Message #18 received at 51364-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 51364-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an
 input
Date: Thu, 4 Nov 2021 15:05:19 +0200

[Message part 1 (text/plain, inline)]

On Tue, Nov 02, 2021 at 07:13:10PM -0400, Morgan.J.Smith <at> outlook.com wrote:
> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
> 
> * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck)
> [inputs]: Add shellcheck.
> [arguments]: Add substitute-shellcheck-path phase.
> ---
> 
> Sorry for the late reply, I didn't see this in my email.
> 
> People would still have been able to set the variable from their configuration.  The value I'm editing just determines the default value.  However, I think I came up with a nice solution that should make everyone happy.  It first checks if there is shellcheck in your path and only hard codes the path if you don't have it.  Apparently Emacs even re-evaluates defcustoms in certain situations so this *might* even work if someone installs shellcheck after this file has been loaded.

Looks good to me. Patch pushed.

You also might've missed the email because my self-hosted email server
sometimes gets blocked. I've added you to X-Debbugs-CC so you should get
this email directly.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.