Subject: bug#51364: closed (Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 04 Nov 2021 13:06:02 +0000

Your bug report

#51364: [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
51364: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51364
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input
From: Efraim Flashner <[email-masked]>
To: [email-masked]
Date: Thu, 4 Nov 2021 15:05:19 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Tue, Nov 02, 2021 at 07:13:10PM -0400, [email-masked] wrote:
> From: Morgan Smith <[email-masked]>
> 
> * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck)
> [inputs]: Add shellcheck.
> [arguments]: Add substitute-shellcheck-path phase.
> ---
> 
> Sorry for the late reply, I didn't see this in my email.
> 
> People would still have been able to set the variable from their configuration.  The value I'm editing just determines the default value.  However, I think I came up with a nice solution that should make everyone happy.  It first checks if there is shellcheck in your path and only hard codes the path if you don't have it.  Apparently Emacs even re-evaluates defcustoms in certain situations so this *might* even work if someone installs shellcheck after this file has been loaded.

Looks good to me. Patch pushed.

You also might've missed the email because my self-hosted email server
sometimes gets blocked. I've added you to X-Debbugs-CC so you should get
this email directly.

-- 
Efraim Flashner   <[email-masked]>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input
From: [email-masked]
To: [email-masked]
Cc: Morgan Smith <[email-masked]>
Date: Sat, 23 Oct 2021 18:21:28 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Morgan Smith <[email-masked]>

* gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck)
[inputs]: Add shellcheck.
[arguments]: Add substitute-shellcheck-path phase.
---
 gnu/packages/emacs-xyz.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index aeb6aa4aba..602e6067a4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1649,6 +1649,18 @@ (define-public emacs-flymake-shellcheck
          (sha256
           (base32 "04yfb4sy41spjzk9mhm4gy0h8vnjx09p2g6nm1yzgd9a5ph9sqgl"))))
       (build-system emacs-build-system)
+      (arguments
+       '(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'substitute-shellcheck-path
+             (lambda* (#:key inputs #:allow-other-keys)
+               (chmod "flymake-shellcheck.el" #o644)
+               (emacs-substitute-variables "flymake-shellcheck.el"
+                 ("flymake-shellcheck-path"
+                  (string-append (assoc-ref inputs "shellcheck")
+                                 "/bin/shellcheck"))))))))
+      (inputs
+       `(("shellcheck" ,shellcheck)))
       (home-page "https://github.com/federicotdn/flymake-shellcheck")
       (synopsis "Flymake backend for Bash/Sh powered by ShellCheck")
       (description
-- 
2.33.1