From unknown Sun Jun 22 07:56:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51364] [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Resent-From: Morgan.J.Smith@outlook.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Oct 2021 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51364@debbugs.gnu.org Cc: Morgan Smith X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163502771014821 (code B ref -1); Sat, 23 Oct 2021 22:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Oct 2021 22:21:50 +0000 Received: from localhost ([127.0.0.1]:37536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mePOg-0003qy-Ed for submit@debbugs.gnu.org; Sat, 23 Oct 2021 18:21:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:45992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mePOb-0003qo-M1 for submit@debbugs.gnu.org; Sat, 23 Oct 2021 18:21:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mePOb-0008HI-7v for guix-patches@gnu.org; Sat, 23 Oct 2021 18:21:45 -0400 Received: from mail-bn8nam12olkn2059.outbound.protection.outlook.com ([40.92.21.59]:61536 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mePOX-0002uA-L4 for guix-patches@gnu.org; Sat, 23 Oct 2021 18:21:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gsFnTklkOLAp39L/hJHs/tCgf6aTuYKNJ825pY1z2m/cCQl6+WXHUb8wp8qFiBcZw1IfCP215zIBSJN7jrCmRZfAx8L0EckOF3M49Lr5h3g0k6d2TduKbPmuJWio1Jsmyi8LR5v+4T7KFHwJSTgINSzqPMGrwP4fOmu898lSZGD/HdMkpUsmd/TbLF46SBp3UdI8TPi4TNqWBxP9d31+fdwn3GCMdQKAr1QtBFGmvKF4cWxrhw0hyHDJCTAbWUgroYQvg2z+BWmogVKLj0HgZNuXigmNOm0mDyln8FBn9c06lXlUsxjfXrbvIQg8CDUqHX4f6SwRJMrBZRkX/ddmRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wjmTG5HCAHRe+sKhPvaHdOyWj9O0J+Ic4lIVu7IOOQY=; b=F/6r6T6Fo31hAPYdGie0FMY3ql8Tea4wgiuRD4VA+jjZFvbmTET6TCZq5/5wXISFlleBNt1cbK9SCKhCK+Sx3cVaprav+WgmTBrCaO0rPEtvf+HTBDBbDa0Ou61UAJbKNPRuPxgnJcEyThw1mzZhkNPpCtCEkNLuo50h5N8vdnqo2qquoqrpoAaowNMB2aWJt5mThqG9qnPwXCY1rDJg60M7rCBjDXa9fUuqkUc1nABjp9YfAYizP5ZD0/CTHctvbzDC8x2KQHQnSzKdLcimnBXM6Oz9tSDs/HqOqaQ1J14BHwimFbaXZ2QFJqpkIOEGnNbmo0WY1aR2f8fz9cohfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjmTG5HCAHRe+sKhPvaHdOyWj9O0J+Ic4lIVu7IOOQY=; b=IF04tUVUA3at2dT86J9mN64X62UfoskQAwbkHup3y0dqOD/aSB2qRN28daGBzDgB62fSSD2KSFdaRjWLsZgQrWDjQyZl53FIsmzzChzk/o6t/u2YGyxxqJTXiCWby33AC717IGbWucny3dZo5n+PxgIyM7UHmj/mZ3DA2QpAgJcjbv+3DCAuIptQwFg4RLx/N/SVhJlFVHoInszyDoP9ptDydCX7NuaarzT3URhDGAwZS3YGYfe2eV4YX3k5Ry9GTEpXBWtXAQwwhzX3wVul2iHpbN4E9knKDNek3fmKUd1Ez1fHJIWEDwyUc7+RjhDiLt9JkTaUWKumyMiAq3NIVg== Received: from BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) by BYAPR05MB6327.namprd05.prod.outlook.com (2603:10b6:a03:e4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.13; Sat, 23 Oct 2021 22:21:38 +0000 Received: from BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154]) by BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154%6]) with mapi id 15.20.4628.018; Sat, 23 Oct 2021 22:21:38 +0000 From: Morgan.J.Smith@outlook.com Date: Sat, 23 Oct 2021 18:21:28 -0400 Message-ID: X-Mailer: git-send-email 2.33.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [Vkon4T496UZAgz7ZYzvucpGhFxi5Vztg] X-ClientProxiedBy: YQBPR0101CA0125.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5::28) To BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) X-Microsoft-Original-Message-ID: <20211023222128.15520-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from workpad.hitronhub.home (170.52.80.188) by YQBPR0101CA0125.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Sat, 23 Oct 2021 22:21:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b14941c6-4bef-46dd-ebbe-08d996737b29 X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UJHbwLX8nOd1NuluPmVMpAOCqFXfPrB9V88F8xgVsKNs96Fgp0qtzGdOygHGDvckUAuTJv8VQcYqpYCDbK9q2pIoPiCOhpidrrZFy+1ns2P2xxr3kdixeAhBlbM0g6mEKSuklcTei695nDsJdLXINo8LsuS/WJMtPen602rzewsOQgbojpJ4K+lEKeYnw8Htp6chXexjqFZ+9/sagmFHhbNSK+xG2QJbYqkgkLIOpg2NiOhF4yWBAY9HMNL+LP8OKTsBPBu72UO53xUtaEIqlNXdpb/5hYR+Iw1FeFAdNNlb0R0oLT26FSedBoSIuAzAHF5T9GLyplyt4YvgjN9ObGyRLtxd4RmL5Hw23kogdKwBc6yBEX4UbpuhuNNauTtkt1fsGELRwV3YYj9qsN4Wn2Z/qsaqH/A+1vl6DDIwAdnsyHITGLspPxNLU01RWJmWDIpWtDE/b6sz5hHWapjY+Bl7MptYRoXsa7OkqBXpaRKZpu+BLLxnC7tdDbtpZOyF2Lvg1WCDNaYj3MFsIMoSdwQMa5fp5pGuqrUHwMWi9fFivPE0SmOyKt3bsnpH+QtcM/vIM/o5LFhtQbM79GmTKnoB1fTUKXrXg4BOxlbntdzIpiA2wF3nCM3D4Ncv9uwJQLA3aEwMcQuLsQfC+MxRWbuVjCJIELqv4kEqfRBcD43PFumufqMHwVR9YnsBD4NvW5D7vruW8aRxg== X-MS-TrafficTypeDiagnostic: BYAPR05MB6327: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xL+leovv7KD8zlxxPS2QSh23buoWFVcuoQhABjQiF4Y8krNoHbwGDxIKjdoAibIYVdNmqGqgjZ7egn51PeH5On/spkA/4/pxy8nYmI+QPEK/I0UJQaWtz6KAMn2/CK55M81nsXv8S6mLGRDto4273Cnpj0JLSJoN9qTE9VRQSTuZ7IUSMKVd45m5KFxSn6a19VHByCDvij4Aoc+BbTAt8dTpFNlNETIIikrTKbtfcsXivy3GtfLEDtq5S9sliGtq0N4oNyCkVxA0gwk/ig+/IPC2Yg9gj14T8xRKpIR7gGMOZ9ti+9SVJpfwJZaUEA7pmGlzqceVPCeTiEqyMukprL5ldY3tGYekd3jvRc2PhggrtTLoinl9XNQNj0AU2hHiivCf3vRvLVoaSCwsz0MXf0S5dYJK5CbKS9QCaVI11/lbUFhGqYMVKkdu+8MvzIlu7NTbvLBKagz7VO1ki00eqnhnYNUjMAZCfPxr1WQgxv1OQ540B0plrBIa5855wxsg509K//ad23dz8uruH8j60We3i3LFx7J03/t+ekRaQNvpNdeulW9XNYbn12qeXGKEAIG0qLke9+Gx7s69C2YulA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jnhjuAE3Qs2/FpDmoDiNWMWEdMu0fxgKup5vQclqv/L5Gpq2mCLP4stxTjzAFtjiRDCnlVUWPYalR0XTLdm7tQs9zTSyBwvLCa/CjDnqjI59vY1DHMisBV+IEK1wMvE9gZPhdh7vo63MikEP31ZZyjA+ERc3z2hdUnEUIQ3qLXzFiRR6wrlgfcMoNa+xKqnbSdw0m/dR8gRFbG30R+PF1A9hWsIr40hYNn2rQQbbydPaUbP3zHW4quqXSdvyIYOa9n2EUNaw8GgKZDgAaEVVVGPSSUwoSWsrH+CMRwpxCtU+rIZ3kuQzZpPFJOR3WlBR+BxE6QVMzXD89HsCApJUWr8qKOh4DFKQpttW15byiH+weIdzBLUlySanpWmFNq7Up9pNWSm1dEs2aQqQfQkDBz3s2IU+F1y6H8BtMpdngN6a3a7n+317Q4CgmXSBWrqcDSq0UIYmoZeIiuWo1Eq4qCtjDuY/o2b5D2ZzI57q0YsL7WaVhrAVV260JL4umn+rWIXgNlJJRK88PjjfNQ38KTyhd3WQ1bekNvhOMC5byH3A4ngY/5RV88a1ejUWxhMAiVu/+bUUDLeiz54C05vU96Fqb+y68QbCP1b76kJaKn3mgGs+zZUi2ib9aBWQOUIagk/U6BwQXPtzfRv1SwuaFQzf05dWfoqtEED90pt0jCGBPt/nKRi3FnWvb5IDaoMqwQGZqiwOIghSEJy6KURE6g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b14941c6-4bef-46dd-ebbe-08d996737b29 X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB4023.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2021 22:21:38.4384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB6327 Received-SPF: pass client-ip=40.92.21.59; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Morgan Smith * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) [inputs]: Add shellcheck. [arguments]: Add substitute-shellcheck-path phase. --- gnu/packages/emacs-xyz.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index aeb6aa4aba..602e6067a4 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1649,6 +1649,18 @@ (define-public emacs-flymake-shellcheck (sha256 (base32 "04yfb4sy41spjzk9mhm4gy0h8vnjx09p2g6nm1yzgd9a5ph9sqgl")))) (build-system emacs-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'substitute-shellcheck-path + (lambda* (#:key inputs #:allow-other-keys) + (chmod "flymake-shellcheck.el" #o644) + (emacs-substitute-variables "flymake-shellcheck.el" + ("flymake-shellcheck-path" + (string-append (assoc-ref inputs "shellcheck") + "/bin/shellcheck")))))))) + (inputs + `(("shellcheck" ,shellcheck))) (home-page "https://github.com/federicotdn/flymake-shellcheck") (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") (description -- 2.33.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 23 18:24:16 2021 Received: (at control) by debbugs.gnu.org; 23 Oct 2021 22:24:16 +0000 Received: from localhost ([127.0.0.1]:37542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mePR1-0003vs-TF for submit@debbugs.gnu.org; Sat, 23 Oct 2021 18:24:16 -0400 Received: from mail-bn8nam12olkn2063.outbound.protection.outlook.com ([40.92.21.63]:36832 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mePQz-0003va-Rd for control@debbugs.gnu.org; Sat, 23 Oct 2021 18:24:14 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PpmDymAO64omsneB+L/MBCv/CGmjw3CpbBXC/2K83/yURcu+rGZJoax4b2jBEaN7bcaY4VxrALSjQzCMiAldGkJF5Z7KH5Cvbxn79VrIZl8+rl4CvkchHSDRFAJmK2LboLr1GcsIe+KNT2D5q9ZiP6MN7Cgm4xSAluWYWfUSwkfDQBTZySxa39FD/6ni0smnx6+zqZymTkIbksa9BCBoVBHJPQOFlAqw+k9cTbrPKLnTHNxjBKh1SGqIOfb6Uqq4FYYRA+LpiOiIQc3lcWFZHvzFkfAEtIKyGpiUD4b7iUWWDUtP/U97b45SZXThZywCINr1QFX2goWzJIJxh1zzjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yWtYfI37pQGaBgc6vR5KN++PuSoocEXutLSX4XTCaFc=; b=UWlHdjylyw1ARFSOWKi8lVI//YhjQwe51p5VhdEfF3Xp1b0/10BBxftwJUMjVFiL1hYvZbT9nai+9aU4scZVUGHIPRbAOmHNCx+eNHC+pO3cCde0+K6ZJmJGFSbudYr7JWEUhdFABh721UcffK2+aOpoCjrCBPIbv2nif7QKNyM9RD4jM0k6Rsp+fPNiEWwYIFaqnOp5nAsMoucqMFsd/1Ds7rSE2XEq0/k+kaBfi7vksEZCGGTH0ilxH+mrtOzVFSGeDqKzLcic0yHRtslM/IaF2B4FnUfs8X//akJZ5qacNZ/kv7jJ1JdKXbDtd213Zpgr/XUCRPsqX5otQB24UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yWtYfI37pQGaBgc6vR5KN++PuSoocEXutLSX4XTCaFc=; b=VxGIc2bXpmgKXT4KxhKh+JKTVK7PyO9IMBztTZD20q85kUeKr9E+7qw/JxhV4iDjbLVVbSx3D9abIj5au59xmtNDg/1+LbQOUcEucsXVKnoDW1j1lPrxUOaN3C+ii2qWe9xrM28fW7OXoz5Us5vWVr+EQJCculhi0upebBgIITSnz7LpmUfpDsW/a0jLkWqXZig+xY38vt8jxQ7FXVQiWCG/PYog5o22Y2Ci+K3yjzyOjl6oEmy32iKDk2xEmXtpf+SirvYl8ozUmE4DkjjqbM0fWUkpU53EHibMMmaVSOjnPxVYxj1v+I1D6lhnSQvJQr1/YKm5sr1jeC2dUw1UlA== Received: from BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) by BYAPR05MB6327.namprd05.prod.outlook.com (2603:10b6:a03:e4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.13; Sat, 23 Oct 2021 22:24:07 +0000 Received: from BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154]) by BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154%6]) with mapi id 15.20.4628.018; Sat, 23 Oct 2021 22:24:06 +0000 From: Morgan Smith To: control@debbugs.gnu.org Subject: control message for bug #51364 Date: Sat, 23 Oct 2021 18:24:04 -0400 Message-ID: Content-Type: text/plain X-TMN: [oAtuBvqaO86uzvnfQj7PIwDzXIbUDTP0] X-ClientProxiedBy: YQBPR01CA0112.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::12) To BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) X-Microsoft-Original-Message-ID: <87mtmz9y7v.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from workpad (170.52.80.188) by YQBPR01CA0112.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Sat, 23 Oct 2021 22:24:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d5dedbf-6649-4078-5d76-08d99673d3ae X-MS-TrafficTypeDiagnostic: BYAPR05MB6327: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iQ5NQOIOb1CXXRjoo6RPjpIqtmVrjAjMIKb7hTrWJl0Nt+53ys5ZseFYdYjqdRN86KNx295UCZFWilez9H1S6LUhmO50YehI0rvx/8mUhc5MoSKGD739kNxfmU62xacFB1nOt7iFDIux2VWVHg649qaSzFHbuIPic71nE/lOeoVoeicvo4NFmdWLio22nlV3Ui4kVIydm1vO8+TqfxjKXhohyXx0g32W/MDel+PSsDrTz4RdSsgiqa7FjpPCMW2M2GW4m6MAqs8XP5aViWkRUpeREXQQHQ5T5jVBnYfjkOKMqiPoLSbI5GLlJ+HIYbC9rvzadF6kxvmFR2bxHM6OYVjD5FwN08RDUhZi6+G2X2oSw2kZkwf/+bVofDc8jRX/Ctr2xu2OfagYOZIxkPbUcfTt9sjWipG8J9l4uWz4SbU= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: M2lgtpLLLWtuoQ12GtI8PgDlZzjXq80o7ruznphGh9A+eSWcyz/Jk145TYBotzhKx8oY/gNcSRTBb2/xHu/l1kxm/KuOXZhzLP1AuyySjqXG1gBVmLYbf2WG3Dw91oU1BBXFvhbVrIH6WtYYqOrPJFQZAgMaDTSQAeiYbB7m2G/cym6M8JDvVsYyiP3FC1wvsyzoZWcnkh9VGyUuxovaGJkt//t6uju69pTh6njMquyohxctA1Ps0zbeUYiiyTUKp/cqcMNjAsmGCTjFHtAyBJmBMtwNWf+ZX7eWrGT1o0ULET1l6Km3Ak9YYaY88WSC7sBLrrb1Pw/B/7aeePWO3ReyfXUalDuwfcx71Cv7pXnly7D73zwfHExqw+993RySv0sYPTCmiKOAbYxYHjMl4nusTjmfLZZImusi5t19sn/QGSCAGmtQ1NdSKBskWAs8GWY9covTFqSlSeuIGEcuyINpfDRqDKhIzfVuaJOtn3c9mEapmOCNj9cCcmCxDzD8ag82IhP8XDy+NVR0nInLSGTeiuDed3yBMCcPUHPl0xBBW3/5cGlzLdOn4JrUtg3Z2UQhRfrzxp7RJg+Iy+8AjI0Q9E1OKvJopD5H8baFyF1gA87Zrf4yYqyQpjfsN5ha0X8D3cMeg6WUOXgC3z2pKNbU98KYBXSECjTFxShiTbKn36wWHtdj9NFRUllaiYo3dMPWsi1UMGD8mG791ja8ig== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d5dedbf-6649-4078-5d76-08d99673d3ae X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB4023.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2021 22:24:06.8289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB6327 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 51364 40429 quit From unknown Sun Jun 22 07:56:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51364] [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Oct 2021 11:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan.J.Smith@outlook.com Cc: 51364@debbugs.gnu.org Received: via spool by 51364-submit@debbugs.gnu.org id=B51364.163516202120327 (code B ref 51364); Mon, 25 Oct 2021 11:41:01 +0000 Received: (at 51364) by debbugs.gnu.org; 25 Oct 2021 11:40:21 +0000 Received: from localhost ([127.0.0.1]:41750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meyKz-0005Hn-DO for submit@debbugs.gnu.org; Mon, 25 Oct 2021 07:40:21 -0400 Received: from flashner.co.il ([178.62.234.194]:44040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meyKx-0005HV-GT for 51364@debbugs.gnu.org; Mon, 25 Oct 2021 07:40:20 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id 42C224004A; Mon, 25 Oct 2021 11:40:13 +0000 (UTC) Date: Mon, 25 Oct 2021 14:39:40 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Morgan.J.Smith@outlook.com, 51364@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4OYT0zaN2xcFVJfW" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --4OYT0zaN2xcFVJfW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 23, 2021 at 06:21:28PM -0400, Morgan.J.Smith@outlook.com wrote: > From: Morgan Smith >=20 > * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) > [inputs]: Add shellcheck. > [arguments]: Add substitute-shellcheck-path phase. > --- > gnu/packages/emacs-xyz.scm | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index aeb6aa4aba..602e6067a4 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -1649,6 +1649,18 @@ (define-public emacs-flymake-shellcheck > (sha256 > (base32 "04yfb4sy41spjzk9mhm4gy0h8vnjx09p2g6nm1yzgd9a5ph9sqgl"= )))) > (build-system emacs-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'substitute-shellcheck-path > + (lambda* (#:key inputs #:allow-other-keys) > + (chmod "flymake-shellcheck.el" #o644) This line I'd change to (make-file-writable "flymake-shellcheck.el") > + (emacs-substitute-variables "flymake-shellcheck.el" > + ("flymake-shellcheck-path" > + (string-append (assoc-ref inputs "shellcheck") > + "/bin/shellcheck")))))))) > + (inputs > + `(("shellcheck" ,shellcheck))) > (home-page "https://github.com/federicotdn/flymake-shellcheck") > (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") > (description > --=20 > 2.33.1 >=20 I'm not sure about hardcoding the path to shellcheck and removing the option to override it in the normal way of the file, by setting flymake-shellcheck-path=C2=B9. I am not sure of the exact return value of (executable-find "shellcheck") but it seems safer to replace that. Can you send an updated patch? =C2=B9 I assume, I don't actually use emacs --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --4OYT0zaN2xcFVJfW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmF2l3wACgkQQarn3Mo9 g1Eo4A/+IZ2xBPwxB8WbjWMa5NXZ10/s10IrFIwxgCUOXLJ8DB1Q3Dj+F+2MGBsF AIN+48J/nPRV/e1M9P5QaucSf90gST7sqlY0NesUHnPRhzLpiqLStH9NT0s+EZ4n QqW3WRnI2uRGvV2IUvgrw52ZpaiPQnDak2tVjKzRoaw6lUKwf9sqlR8m3gbgkrp/ QyuU9FapurPwI+YBPHY7C8SbUxUn+Dd1WUv/mBEyEw4+/E2hgw9+jHNwYnCz0QAI omdUCh6mMCsBJuu+SEea1VXrIttQzXtByK1OSucVRAvFlMj7a+nMrhmjQjOHwmAu onUcSvQNrbd6FFWn+g917MvsEMm6U0yP2HzRSKnhlZrqSkgEmzdK31NeG9mB307q cwg2nd4IeYLc4kFzJon3YeWU5cTb0y+AOqzt7Q4Zz/VbFkGFx2vVSeBv+0XmiLXv Riwdsrm+XQ6ARApS0T6xO6qRbCXPq6DQF+DMjUNvodd7mjALM1myVvyCPji2pHjd deEVY2hA/k6VcQvKZtBqkvz3YhWNyCvelGGv0UC+Ha0V26MOm+WaQ8HURjJyNk/v MKGpMCvhMsAjcwSd4pLhvsVTfQw9QNRvoP4QI+Ybhhse8Mq16e7UKcU7oI09SDfL PWg5R5Qe/Lj5U1SFLXhITLrfh+K2EPHxymVD3vHtRwmh28/Ew5Q= =WUG6 -----END PGP SIGNATURE----- --4OYT0zaN2xcFVJfW-- From unknown Sun Jun 22 07:56:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51364] [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input References: In-Reply-To: Resent-From: Morgan.J.Smith@outlook.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Nov 2021 23:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51364@debbugs.gnu.org Cc: Morgan Smith Received: via spool by 51364-submit@debbugs.gnu.org id=B51364.163589548126437 (code B ref 51364); Tue, 02 Nov 2021 23:25:01 +0000 Received: (at 51364) by debbugs.gnu.org; 2 Nov 2021 23:24:41 +0000 Received: from localhost ([127.0.0.1]:38311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi38y-0006sL-MX for submit@debbugs.gnu.org; Tue, 02 Nov 2021 19:24:40 -0400 Received: from mail-dm6nam11olkn2096.outbound.protection.outlook.com ([40.92.19.96]:30464 helo=NAM11-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi38w-0006s6-5z for 51364@debbugs.gnu.org; Tue, 02 Nov 2021 19:24:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MnZlZgm682/WKuQloaALvA0fVYpuNKn1y15PgLesZ67MbnnraQsOYCbmQg6BsOQXAq3d8SDcjkpE+eroTKKUde/HN+wGtw0/zTNIFeb70sJY+v4Iy9mB8yB7jINACQ1scUAtRVudA098kla3Szsfcd31f+sJ2eRw/APQ/XM0VFvOkobZdnrFZwv+UCP4+VzRHBo75oxeTTtP+URnDFG3mzeHk+V5dg37vijmf+YfWjKoqQ3o5Pdz7RJew3vqJhstL9YGkie7N998ypeMjdR0e+2FzRLQ3mj7IpyrcXGO1ut4JFNWldGTQw2y2zZ2kgVYPeHdSjyALiQjWwqBsfAXLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I90Fcf+uEtyi0jJsQmlOLt/c3HVCBecGTp6fRSqjDTg=; b=k2/nU3Jbm0g5O/SXJl+Rv2Vh0t0iW5zm6W6T5rsQS4F0xHs9sthdfR98Pm5hSQBG8QzAWlRDAlzI1NhsxeFdQALugmxtxDtHDC38tmfISM2MOIgn+QFpZogAguMV2DAnmVhhL/51G9VnKRdm9IKVzNGmd+ZwCchjUBGLe3xPk0imDsAXHwXLDL2tAEVe3FannXIveaWRGnBm4p6B6bRmQtnQb/ROC+K+fXnB8RKKOCxUpXDTZiWOhnkzZXA8TRf/uUFjR1PpKyuG4+iy6/Wk+4C0dMx+5zAdtvlsqV7n6ce4R0tGXMzHVMFrlqwBCvTZ2F2Pd125ZNOwBO7fDc0i3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I90Fcf+uEtyi0jJsQmlOLt/c3HVCBecGTp6fRSqjDTg=; b=u5QUfgC1ZwFF69R/vmP+8wEZDSv58P1MzyCS0S3mNtk+aAf62pyhLAy6TsvOiXYyP1qS89YWWi/8cTWJmMGMlaR4sK9IdtyswBEK95gXFO+TMt22AWNp1Bh2+GAfvr+fmRdvaDY4PxtidfC6BjOZzBz5OZQ2lfBcvfBG1o/mqn0UFJuhf7tm5syl+m+EuLguAZmVZpekKTCchAh7NLPcecxHXJ2Z5F4esMmAAfXnXV9pm4MSoNvLg7jPjEgR8rRAGXIU2BrtdPYEmHa45kCQitGAh0cIn5DqSyR7TFX25ADAiGySqAQ2R7FZITnHpPtCceGECkkY8C/xfmPcUqTfAg== Received: from BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) by SJ0PR05MB7359.namprd05.prod.outlook.com (2603:10b6:a03:28b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.4; Tue, 2 Nov 2021 23:24:31 +0000 Received: from BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154]) by BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154%6]) with mapi id 15.20.4669.010; Tue, 2 Nov 2021 23:24:31 +0000 From: Morgan.J.Smith@outlook.com Date: Tue, 2 Nov 2021 19:23:50 -0400 Message-ID: X-Mailer: git-send-email 2.33.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [JVfNUe2S9KYQpDsbxj+n4g/sd+6wMDbp] X-ClientProxiedBy: YQBPR0101CA0223.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:66::12) To BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) X-Microsoft-Original-Message-ID: <20211102232349.30593-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from workpad.hitronhub.home (170.52.80.188) by YQBPR0101CA0223.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:66::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Tue, 2 Nov 2021 23:24:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e2128192-434a-449d-bfae-08d99e57ec68 X-MS-Exchange-SLBlob-MailProps: NS9Gj58uCj2rFEzRidwWlqhcSEBHqh7oS6GBr/u+jalse6DP4B5faCYqH+3aPLjCDDew+vwHIx9Hjns1Cw2kyZYLE+nVELIK++AK41/gKrcAn0pjin/Qv6LsqfRIyHwFesObU4rDpHeQ6lQDQPPcTiNy1g5orHzC7ZRhetBtalRVpAFnnWROpzQC5U1rvhaFX6q6yeBvOMgGPK3wrYlBcDVecoNulIN5TDElGj+LEzvwr0YNf10FliAUhdQmjAa1yqa9tF5VV0RG4V4Xv0dGm1o95oywFm/6gYjeZ9aobetLIMV8AyexlZ+6HgOCLEZab4ClRrrLx4teP2QyknMrqB/yQ/icH1YenHdV7WvVcdmN/WT/a/ro4Y4E0xHcswSjESZhORkcCpIOeAL0J0m6JvDEnxUo3NEjLf8kr/w1toA4ePbBEjMDs+0aDydkqAtr///Pk4PfNfghBs37LG+lj9EZPrL6XG6adluTGKGtm86VwxoYs70EFN2w1JANweo75u8WCOdQukZyikqE5TB64Gv5il5Gv6V6DZFI973XjeQq2D4dksWJYhI459NlYts3vuMiuzrId/Lqt0wY4KbcsNJR7KVtF/LEbTd6SDw6ZFV/ad2mqw709Ba458tO306mqVSfqLixynFLaYONVpDE9fZSZ43gZ0QSmUwy+lj9FVsfgQhwiaCAEL2U2xW4t9zqR+M3TO4YbcDbdgiJqi0Tdg== X-MS-TrafficTypeDiagnostic: SJ0PR05MB7359: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z1jcwlk6Zy8bgemRGY6gsp6TzGdtSfpyUNFlW7uFe6DnuNctabF6wftHETXJuCYVFldrK+4MP3zhIo26qgtQpxWAEzOGYA4s0nApnfd7WL4cci3BeQq/EMKd64H+CRu5gk0tM0B4VqcfO4fsAu3w1gNqZLT7VOC6N8jtb+xu66jMG/YhaEpaufgJUhTkHDjvIApqe5o4Xqxh497okbu0Nr6TC+4ghNRk02z/sp7TsQN6Pm/1EzaiGamyEm6Rc1tjNByjsiytIlaFWCkqpsL7JNLRw2+H9AGYMb/lHVsXdn2URCoCgL5Ua7QwE5K5os/YIiBwRCUkgNN65zPTy4N9lJQi5Qodgr3haVoC8kNgWklsLjDQWyYQBaL3zA/2XKn9IWH56ItlxNL8Jg9KeP9H3HKsoCs4y2R3Lp+GDUKggJLrrs2+z5NaE8ENlYAuuYdJWKQo8AWiD0iZIDKut4KcAbhGoa/YOSHRKkFg85em03xOEIp1MYkU6kDVmEGziwi7Y1C/AjpH5SLCzkY1Vqs0Y9xN6m7gY4pw6gHUeCUIC+sXsujdZXQ5lE8UqkWE2X8XPwnCEB2vWt9vDe1kxYGBLA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sfnJrnwlTsSdX6w77U+8TfiHq6fUPhm9Gcv7Dfd8iIrFa4HWiJzuKrK6l6SwSM3i4VMBR4CJiJa9kUicLPAsO+KTW3U1iXNltIpC/K4V+GvUsvXHYpQt6wztY6nB8WC1PZKqZySqwgPM4A5JNnvzqEGnKVH0LsbDnUhQsWR0IL/MJwPrd/6Tzn/wOSTtV3IbQLNiNYDQ/GZpJBQQYHFrPprt95/NvudIUyvRNrV6cC7Yn3AEG5q9QgohvIyRR7dNRfMDCxOtHVxr6VKm5dqaSFkMr8Znw63A6tC/tQ8D5gC9VE/3vv+s0BFkB5FgAclcuTlQIaHNZKOjPw8CALF2pfKUrAEcVRAQNo7VEcSGYXuB7/kXiNUIRW+oQZVNgihgSLvk/kV4C/MDOMiuo/aYm0vFUgNZVtUvS59MKzf90B4jOX+evB0Vf8Y1VS/feBFZyYzEQbCjvbVNGj1QZndwy0wQnH2ayqS042T9PFrmMJ5LQZZD/sjPSD3Wew1V7KQd2H/aHYqHWL8z4H8M6vHq71dq4eR0SmWNY91ioRm2KmZyOvh6j6BcWbPq69u8LiIanuU5KdzgG9tuJoIKGViiq16sMbirNafqRjkMF9giEeJdKF8giQwtUW1SSWz2YeI9JLGfjvGSxXPtUZxER0oAU1l4xM7KBwUaHjRnzLl7d9JjS/k8O1tVxfUiOFONMdTI+kgt2uO7I4oBH5a8D6EUwg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2128192-434a-449d-bfae-08d99e57ec68 X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB4023.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 23:24:31.8005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR05MB7359 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Morgan Smith * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) [inputs]: Add shellcheck. [arguments]: Add substitute-shellcheck-path phase. --- Sorry for the late reply, I didn't see this in my email. People would still have been able to set the variable from their configuration. The value I'm editing just determines the default value. However, I think I came up with a nice solution that should make everyone happy. It first checks if there is shellcheck in your path and only hard codes the path if you don't have it. Apparently Emacs even re-evaluates defcustoms in certain situations so this *might* even work if someone installs shellcheck after this file has been loaded. gnu/packages/emacs-xyz.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 624fe957e3..dad555cae3 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1649,6 +1649,19 @@ (define-public emacs-flymake-shellcheck (sha256 (base32 "04yfb4sy41spjzk9mhm4gy0h8vnjx09p2g6nm1yzgd9a5ph9sqgl")))) (build-system emacs-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'substitute-shellcheck-path + (lambda* (#:key inputs #:allow-other-keys) + (make-file-writable "flymake-shellcheck.el") + (emacs-substitute-sexps "flymake-shellcheck.el" + ("defcustom flymake-shellcheck-path" + `(or (executable-find "shellcheck") + ,(string-append (assoc-ref inputs "shellcheck") + "/bin/shellcheck"))))))))) + (inputs + `(("shellcheck" ,shellcheck))) (home-page "https://github.com/federicotdn/flymake-shellcheck") (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") (description -- 2.33.1 From unknown Sun Jun 22 07:56:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Morgan.J.Smith@outlook.com Subject: bug#51364: closed (Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input) Message-ID: References: X-Gnu-PR-Message: they-closed 51364 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 51364@debbugs.gnu.org Date: Thu, 04 Nov 2021 13:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1636031162-31498-1" This is a multi-part message in MIME format... ------------=_1636031162-31498-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51364: [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51364@debbugs.gnu.org. --=20 51364: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51364 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1636031162-31498-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51364-done) by debbugs.gnu.org; 4 Nov 2021 13:06:00 +0000 Received: from localhost ([127.0.0.1]:42237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1micRL-0008Bo-Mh for submit@debbugs.gnu.org; Thu, 04 Nov 2021 09:05:59 -0400 Received: from flashner.co.il ([178.62.234.194]:34812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1micRJ-0008BZ-RX for 51364-done@debbugs.gnu.org; Thu, 04 Nov 2021 09:05:58 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id C1B46407BF for <51364-done@debbugs.gnu.org>; Thu, 4 Nov 2021 13:05:51 +0000 (UTC) Date: Thu, 4 Nov 2021 15:05:19 +0200 From: Efraim Flashner To: 51364-done@debbugs.gnu.org Subject: Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Message-ID: Mail-Followup-To: Efraim Flashner , 51364-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tC9JSoq157iwn7ta" Content-Disposition: inline In-Reply-To: X-Debbugs-CC: Morgan.J.Smith@outlook.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51364-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --tC9JSoq157iwn7ta Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 02, 2021 at 07:13:10PM -0400, Morgan.J.Smith@outlook.com wrote: > From: Morgan Smith >=20 > * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) > [inputs]: Add shellcheck. > [arguments]: Add substitute-shellcheck-path phase. > --- >=20 > Sorry for the late reply, I didn't see this in my email. >=20 > People would still have been able to set the variable from their configur= ation. The value I'm editing just determines the default value. However, = I think I came up with a nice solution that should make everyone happy. It= first checks if there is shellcheck in your path and only hard codes the p= ath if you don't have it. Apparently Emacs even re-evaluates defcustoms in= certain situations so this *might* even work if someone installs shellchec= k after this file has been loaded. Looks good to me. Patch pushed. You also might've missed the email because my self-hosted email server sometimes gets blocked. I've added you to X-Debbugs-CC so you should get this email directly. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --tC9JSoq157iwn7ta Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmGD2o8ACgkQQarn3Mo9 g1HRcg/8DEepcYsz/5J1aFw4FkpPU9155/wxIQJExcPHy44LZGrUvnDhVFuK5a6m RLDwANkaYSfERfu97NQlHNVk7T1hULm9T74Sns3h3H998NUUR2/FBBaXf0wYd4Wj GC2emy96FIynFwxlNGlDgN2iaikBIt/dt/2IcA/jopDPBSpFOmu5R6uDJbao4zkm Cea4RdkptM3C7wTetH5oZPYnxmAQ55xTupr2hAq0G/Ngp5UJHjdC002ROebu/tYO HkpNoQxks/uXon3TN3by49OWp2dvZXUUFBKOomUNhp6E1MC3qSw7BseJQdSGW64b wGwruPix7bXseJyjSMawsMgrHPbtJg/a/YSHUEE9aSPyWMtARO12NLQogRw3HKuH ABMlXWHTYCB8XdIUxDuu+obYjfL3O6BOHnVoWFiYXXtp3i7/yPxWm1ijGsi3rstF aptD35puMYRcI9sb0K1TjmLO1ACoPma0TFfQEDTbgChQfni7lRT4Oq32kbMdGLEz ZLb1QXdsPJQW9+atE396N9WbMm90FN1jMWveFFBr6ex3IsjIf+rcdUfYb9ViGlQt sBc0bhD1YxtMCjN5qlK/496nVWqcCpATaxh9npvcbvcAX4EvKM3O+Pkg11+w4Vj7 MeDNWPWIiJP3m52y5GQfnRfLa5lwrANP4NR5e0VDLQw4w1+9+JA= =lCPX -----END PGP SIGNATURE----- --tC9JSoq157iwn7ta-- ------------=_1636031162-31498-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Oct 2021 22:21:50 +0000 Received: from localhost ([127.0.0.1]:37536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mePOg-0003qy-Ed for submit@debbugs.gnu.org; Sat, 23 Oct 2021 18:21:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:45992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mePOb-0003qo-M1 for submit@debbugs.gnu.org; Sat, 23 Oct 2021 18:21:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mePOb-0008HI-7v for guix-patches@gnu.org; Sat, 23 Oct 2021 18:21:45 -0400 Received: from mail-bn8nam12olkn2059.outbound.protection.outlook.com ([40.92.21.59]:61536 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mePOX-0002uA-L4 for guix-patches@gnu.org; Sat, 23 Oct 2021 18:21:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gsFnTklkOLAp39L/hJHs/tCgf6aTuYKNJ825pY1z2m/cCQl6+WXHUb8wp8qFiBcZw1IfCP215zIBSJN7jrCmRZfAx8L0EckOF3M49Lr5h3g0k6d2TduKbPmuJWio1Jsmyi8LR5v+4T7KFHwJSTgINSzqPMGrwP4fOmu898lSZGD/HdMkpUsmd/TbLF46SBp3UdI8TPi4TNqWBxP9d31+fdwn3GCMdQKAr1QtBFGmvKF4cWxrhw0hyHDJCTAbWUgroYQvg2z+BWmogVKLj0HgZNuXigmNOm0mDyln8FBn9c06lXlUsxjfXrbvIQg8CDUqHX4f6SwRJMrBZRkX/ddmRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wjmTG5HCAHRe+sKhPvaHdOyWj9O0J+Ic4lIVu7IOOQY=; b=F/6r6T6Fo31hAPYdGie0FMY3ql8Tea4wgiuRD4VA+jjZFvbmTET6TCZq5/5wXISFlleBNt1cbK9SCKhCK+Sx3cVaprav+WgmTBrCaO0rPEtvf+HTBDBbDa0Ou61UAJbKNPRuPxgnJcEyThw1mzZhkNPpCtCEkNLuo50h5N8vdnqo2qquoqrpoAaowNMB2aWJt5mThqG9qnPwXCY1rDJg60M7rCBjDXa9fUuqkUc1nABjp9YfAYizP5ZD0/CTHctvbzDC8x2KQHQnSzKdLcimnBXM6Oz9tSDs/HqOqaQ1J14BHwimFbaXZ2QFJqpkIOEGnNbmo0WY1aR2f8fz9cohfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjmTG5HCAHRe+sKhPvaHdOyWj9O0J+Ic4lIVu7IOOQY=; b=IF04tUVUA3at2dT86J9mN64X62UfoskQAwbkHup3y0dqOD/aSB2qRN28daGBzDgB62fSSD2KSFdaRjWLsZgQrWDjQyZl53FIsmzzChzk/o6t/u2YGyxxqJTXiCWby33AC717IGbWucny3dZo5n+PxgIyM7UHmj/mZ3DA2QpAgJcjbv+3DCAuIptQwFg4RLx/N/SVhJlFVHoInszyDoP9ptDydCX7NuaarzT3URhDGAwZS3YGYfe2eV4YX3k5Ry9GTEpXBWtXAQwwhzX3wVul2iHpbN4E9knKDNek3fmKUd1Ez1fHJIWEDwyUc7+RjhDiLt9JkTaUWKumyMiAq3NIVg== Received: from BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) by BYAPR05MB6327.namprd05.prod.outlook.com (2603:10b6:a03:e4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.13; Sat, 23 Oct 2021 22:21:38 +0000 Received: from BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154]) by BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::745d:ce8d:67ec:5154%6]) with mapi id 15.20.4628.018; Sat, 23 Oct 2021 22:21:38 +0000 From: Morgan.J.Smith@outlook.com To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Date: Sat, 23 Oct 2021 18:21:28 -0400 Message-ID: X-Mailer: git-send-email 2.33.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [Vkon4T496UZAgz7ZYzvucpGhFxi5Vztg] X-ClientProxiedBy: YQBPR0101CA0125.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5::28) To BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) X-Microsoft-Original-Message-ID: <20211023222128.15520-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from workpad.hitronhub.home (170.52.80.188) by YQBPR0101CA0125.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Sat, 23 Oct 2021 22:21:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b14941c6-4bef-46dd-ebbe-08d996737b29 X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UJHbwLX8nOd1NuluPmVMpAOCqFXfPrB9V88F8xgVsKNs96Fgp0qtzGdOygHGDvckUAuTJv8VQcYqpYCDbK9q2pIoPiCOhpidrrZFy+1ns2P2xxr3kdixeAhBlbM0g6mEKSuklcTei695nDsJdLXINo8LsuS/WJMtPen602rzewsOQgbojpJ4K+lEKeYnw8Htp6chXexjqFZ+9/sagmFHhbNSK+xG2QJbYqkgkLIOpg2NiOhF4yWBAY9HMNL+LP8OKTsBPBu72UO53xUtaEIqlNXdpb/5hYR+Iw1FeFAdNNlb0R0oLT26FSedBoSIuAzAHF5T9GLyplyt4YvgjN9ObGyRLtxd4RmL5Hw23kogdKwBc6yBEX4UbpuhuNNauTtkt1fsGELRwV3YYj9qsN4Wn2Z/qsaqH/A+1vl6DDIwAdnsyHITGLspPxNLU01RWJmWDIpWtDE/b6sz5hHWapjY+Bl7MptYRoXsa7OkqBXpaRKZpu+BLLxnC7tdDbtpZOyF2Lvg1WCDNaYj3MFsIMoSdwQMa5fp5pGuqrUHwMWi9fFivPE0SmOyKt3bsnpH+QtcM/vIM/o5LFhtQbM79GmTKnoB1fTUKXrXg4BOxlbntdzIpiA2wF3nCM3D4Ncv9uwJQLA3aEwMcQuLsQfC+MxRWbuVjCJIELqv4kEqfRBcD43PFumufqMHwVR9YnsBD4NvW5D7vruW8aRxg== X-MS-TrafficTypeDiagnostic: BYAPR05MB6327: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xL+leovv7KD8zlxxPS2QSh23buoWFVcuoQhABjQiF4Y8krNoHbwGDxIKjdoAibIYVdNmqGqgjZ7egn51PeH5On/spkA/4/pxy8nYmI+QPEK/I0UJQaWtz6KAMn2/CK55M81nsXv8S6mLGRDto4273Cnpj0JLSJoN9qTE9VRQSTuZ7IUSMKVd45m5KFxSn6a19VHByCDvij4Aoc+BbTAt8dTpFNlNETIIikrTKbtfcsXivy3GtfLEDtq5S9sliGtq0N4oNyCkVxA0gwk/ig+/IPC2Yg9gj14T8xRKpIR7gGMOZ9ti+9SVJpfwJZaUEA7pmGlzqceVPCeTiEqyMukprL5ldY3tGYekd3jvRc2PhggrtTLoinl9XNQNj0AU2hHiivCf3vRvLVoaSCwsz0MXf0S5dYJK5CbKS9QCaVI11/lbUFhGqYMVKkdu+8MvzIlu7NTbvLBKagz7VO1ki00eqnhnYNUjMAZCfPxr1WQgxv1OQ540B0plrBIa5855wxsg509K//ad23dz8uruH8j60We3i3LFx7J03/t+ekRaQNvpNdeulW9XNYbn12qeXGKEAIG0qLke9+Gx7s69C2YulA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jnhjuAE3Qs2/FpDmoDiNWMWEdMu0fxgKup5vQclqv/L5Gpq2mCLP4stxTjzAFtjiRDCnlVUWPYalR0XTLdm7tQs9zTSyBwvLCa/CjDnqjI59vY1DHMisBV+IEK1wMvE9gZPhdh7vo63MikEP31ZZyjA+ERc3z2hdUnEUIQ3qLXzFiRR6wrlgfcMoNa+xKqnbSdw0m/dR8gRFbG30R+PF1A9hWsIr40hYNn2rQQbbydPaUbP3zHW4quqXSdvyIYOa9n2EUNaw8GgKZDgAaEVVVGPSSUwoSWsrH+CMRwpxCtU+rIZ3kuQzZpPFJOR3WlBR+BxE6QVMzXD89HsCApJUWr8qKOh4DFKQpttW15byiH+weIdzBLUlySanpWmFNq7Up9pNWSm1dEs2aQqQfQkDBz3s2IU+F1y6H8BtMpdngN6a3a7n+317Q4CgmXSBWrqcDSq0UIYmoZeIiuWo1Eq4qCtjDuY/o2b5D2ZzI57q0YsL7WaVhrAVV260JL4umn+rWIXgNlJJRK88PjjfNQ38KTyhd3WQ1bekNvhOMC5byH3A4ngY/5RV88a1ejUWxhMAiVu/+bUUDLeiz54C05vU96Fqb+y68QbCP1b76kJaKn3mgGs+zZUi2ib9aBWQOUIagk/U6BwQXPtzfRv1SwuaFQzf05dWfoqtEED90pt0jCGBPt/nKRi3FnWvb5IDaoMqwQGZqiwOIghSEJy6KURE6g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b14941c6-4bef-46dd-ebbe-08d996737b29 X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB4023.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2021 22:21:38.4384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB6327 Received-SPF: pass client-ip=40.92.21.59; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: Morgan Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Morgan Smith * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) [inputs]: Add shellcheck. [arguments]: Add substitute-shellcheck-path phase. --- gnu/packages/emacs-xyz.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index aeb6aa4aba..602e6067a4 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1649,6 +1649,18 @@ (define-public emacs-flymake-shellcheck (sha256 (base32 "04yfb4sy41spjzk9mhm4gy0h8vnjx09p2g6nm1yzgd9a5ph9sqgl")))) (build-system emacs-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'substitute-shellcheck-path + (lambda* (#:key inputs #:allow-other-keys) + (chmod "flymake-shellcheck.el" #o644) + (emacs-substitute-variables "flymake-shellcheck.el" + ("flymake-shellcheck-path" + (string-append (assoc-ref inputs "shellcheck") + "/bin/shellcheck")))))))) + (inputs + `(("shellcheck" ,shellcheck))) (home-page "https://github.com/federicotdn/flymake-shellcheck") (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") (description -- 2.33.1 ------------=_1636031162-31498-1-- From unknown Sun Jun 22 07:56:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "LaFreniere, Joseph" Subject: bug#40429: closed (Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input) Message-ID: References: <87o8s7p8lq.fsf@odyssey.lafreniere.xyz> X-Gnu-PR-Message: they-closed 40429 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 40429@debbugs.gnu.org Date: Thu, 04 Nov 2021 13:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1636031162-31498-3" This is a multi-part message in MIME format... ------------=_1636031162-31498-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51364: [PATCH] gnu: Add emacs-flymake-shellcheck. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 40429@debbugs.gnu.org. --=20 51364: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51364 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1636031162-31498-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51364-done) by debbugs.gnu.org; 4 Nov 2021 13:06:00 +0000 Received: from localhost ([127.0.0.1]:42237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1micRL-0008Bo-Mh for submit@debbugs.gnu.org; Thu, 04 Nov 2021 09:05:59 -0400 Received: from flashner.co.il ([178.62.234.194]:34812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1micRJ-0008BZ-RX for 51364-done@debbugs.gnu.org; Thu, 04 Nov 2021 09:05:58 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id C1B46407BF for <51364-done@debbugs.gnu.org>; Thu, 4 Nov 2021 13:05:51 +0000 (UTC) Date: Thu, 4 Nov 2021 15:05:19 +0200 From: Efraim Flashner To: 51364-done@debbugs.gnu.org Subject: Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Message-ID: Mail-Followup-To: Efraim Flashner , 51364-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tC9JSoq157iwn7ta" Content-Disposition: inline In-Reply-To: X-Debbugs-CC: Morgan.J.Smith@outlook.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51364-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --tC9JSoq157iwn7ta Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 02, 2021 at 07:13:10PM -0400, Morgan.J.Smith@outlook.com wrote: > From: Morgan Smith >=20 > * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck) > [inputs]: Add shellcheck. > [arguments]: Add substitute-shellcheck-path phase. > --- >=20 > Sorry for the late reply, I didn't see this in my email. >=20 > People would still have been able to set the variable from their configur= ation. The value I'm editing just determines the default value. However, = I think I came up with a nice solution that should make everyone happy. It= first checks if there is shellcheck in your path and only hard codes the p= ath if you don't have it. Apparently Emacs even re-evaluates defcustoms in= certain situations so this *might* even work if someone installs shellchec= k after this file has been loaded. Looks good to me. Patch pushed. You also might've missed the email because my self-hosted email server sometimes gets blocked. I've added you to X-Debbugs-CC so you should get this email directly. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --tC9JSoq157iwn7ta Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmGD2o8ACgkQQarn3Mo9 g1HRcg/8DEepcYsz/5J1aFw4FkpPU9155/wxIQJExcPHy44LZGrUvnDhVFuK5a6m RLDwANkaYSfERfu97NQlHNVk7T1hULm9T74Sns3h3H998NUUR2/FBBaXf0wYd4Wj GC2emy96FIynFwxlNGlDgN2iaikBIt/dt/2IcA/jopDPBSpFOmu5R6uDJbao4zkm Cea4RdkptM3C7wTetH5oZPYnxmAQ55xTupr2hAq0G/Ngp5UJHjdC002ROebu/tYO HkpNoQxks/uXon3TN3by49OWp2dvZXUUFBKOomUNhp6E1MC3qSw7BseJQdSGW64b wGwruPix7bXseJyjSMawsMgrHPbtJg/a/YSHUEE9aSPyWMtARO12NLQogRw3HKuH ABMlXWHTYCB8XdIUxDuu+obYjfL3O6BOHnVoWFiYXXtp3i7/yPxWm1ijGsi3rstF aptD35puMYRcI9sb0K1TjmLO1ACoPma0TFfQEDTbgChQfni7lRT4Oq32kbMdGLEz ZLb1QXdsPJQW9+atE396N9WbMm90FN1jMWveFFBr6ex3IsjIf+rcdUfYb9ViGlQt sBc0bhD1YxtMCjN5qlK/496nVWqcCpATaxh9npvcbvcAX4EvKM3O+Pkg11+w4Vj7 MeDNWPWIiJP3m52y5GQfnRfLa5lwrANP4NR5e0VDLQw4w1+9+JA= =lCPX -----END PGP SIGNATURE----- --tC9JSoq157iwn7ta-- ------------=_1636031162-31498-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Apr 2020 15:35:28 +0000 Received: from localhost ([127.0.0.1]:44595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKkpU-00033Z-Fr for submit@debbugs.gnu.org; Sat, 04 Apr 2020 11:35:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:60612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKkpS-00033J-3I for submit@debbugs.gnu.org; Sat, 04 Apr 2020 11:35:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46511) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKkpQ-0004v6-LG for guix-patches@gnu.org; Sat, 04 Apr 2020 11:35:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKkpP-0003c6-4H for guix-patches@gnu.org; Sat, 04 Apr 2020 11:35:24 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:40862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jKkpO-0003bI-KM for guix-patches@gnu.org; Sat, 04 Apr 2020 11:35:23 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id 4475052B for ; Sat, 4 Apr 2020 17:35:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:from:from:received:received:received; s= dkim20160331; t=1586014518; x=1587828919; bh=r1Z5Nv58l/GSafeLB9Q mYx9jEIzphsGZyWV2WPJHPTk=; b=irVWcjtFhVCP6aoi6MZwjdJ0sE7EnNLyFTs bRNnKh8XIX3UYcYHp4boEW757tdl9DfhUzwg394uIPTd3SINCz2cX5jgZnef31nY aegozsoLp9q90xSTGFlvYYDMkSt0Yghnyk5sjx8tvCXynkosElGbdTMiQq4CpW9T lECy1ioscYKmxhayPPPPKu86i6NeI2mtnBCKDIIXQnnm1vEKRma8v0SDEbZ+AGyv 7hE+B7WPac1t7rPZN5QiDktwTTBjAsQb6DX1XRKQelc9gQO7cdzDgYSVEgk7L2jK K/iEOGuh7njtpWxEhlMYTWEhoNBGpord//++mgW6vkttZBzVkqoGownJ4d3BZQix jICaBa8MfzboHqjWYCjPsNfS7N0AcemDqTsq5Cjv+FjfGml4YfOP/cG0osMHXSiH mjtjhPULERekg4ZQ9JrnpiEseLxVPvpSXYtdyFDp5j0wXrtfkm8N1+5fXL6z5zHE 2P4VbnhKEVw77VH6NQc8T3Fewt4A0w2hm3uEbRldAXQavpX28HlJf890zWY/jEGv w+x3EWPLYxFihsVMUKY9kLyO/DlUDzFzGbelyo1tcsuir0ToBJXYTww8+agGXAEg VblmRgXbNi66Gcijkf0NUD8uMlgwgsqKKfsceL8lWtUFrVrRuS0U/iTyJszNFqVc 33+7xivk= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yr1G7yL96lkB for ; Sat, 4 Apr 2020 17:35:18 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 8F2F94A3 for ; Sat, 4 Apr 2020 17:35:18 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 46EE32033 for ; Sat, 4 Apr 2020 17:35:18 +0200 (CEST) From: "LaFreniere, Joseph" To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-flymake-shellcheck. Date: Sat, 04 Apr 2020 10:35:13 -0500 Message-ID: <87o8s7p8lq.fsf@odyssey.lafreniere.xyz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 95.128.36.41 X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Patch file is attached. -- Joseph LaFreniere From 53688eb572a104972eadd2d0d8568452e41b2f70 Mon Sep 17 00:00:00 2001 From: Joseph LaFreniere Date: Sat, 4 Apr 2020 09:50:56 -0500 Subject: [PATCH] gnu: Add emacs-flymake-shel [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: kolabnow.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=joseph%40lafreniere.xyz; ip=209.51.188.17; r=debbugs.gnu.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.3 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: lafreniere.xyz (xyz)] 0.9 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.3 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) --=-=-= Content-Type: text/plain; format=flowed Patch file is attached. -- Joseph LaFreniere --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-flymake-shellcheck.patch >From 53688eb572a104972eadd2d0d8568452e41b2f70 Mon Sep 17 00:00:00 2001 From: Joseph LaFreniere Date: Sat, 4 Apr 2020 09:50:56 -0500 Subject: [PATCH] gnu: Add emacs-flymake-shellcheck. * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable. --- gnu/packages/emacs-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index cd2562103c..eb62bc578b 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -163,6 +163,7 @@ #:use-module (gnu packages sqlite) #:use-module (gnu packages gnupg) #:use-module (gnu packages video) + #:use-module (gnu packages haskell-apps) #:use-module (gnu packages haskell-xyz) #:use-module (gnu packages wordnet) #:use-module (gnu packages photo) @@ -3548,6 +3549,43 @@ It also provides an easy way to find synonyms and antonyms for a given word (to avoid repetitions for example).") (license license:gpl3+))) +(define-public emacs-flymake-shellcheck + (let ((version "0.1") + (revision "0") + (commit "bb413006afc23105a0f84df6fb82504a06483a55")) + (package + (name "emacs-flymake-shellcheck") + (version (git-version version revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/federicotdn/flymake-shellcheck.git") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "09cqn0255pxim34v5zfypbzr4clfd2ajlsyxpc9h64wg6v9876y5")))) + (build-system emacs-build-system) + (inputs + `(("shellcheck" ,shellcheck))) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'hardcode-shellcheck-path + (lambda _ + (let ((file "flymake-shellcheck.el")) + (chmod file #o644) + (emacs-substitute-sexps file + ("(defcustom flymake-shellcheck-path" + (which "shellcheck"))))))))) + (home-page "https://github.com/federicotdn/flymake-shellcheck") + (synopsis "A bash/sh Flymake backend powered by ShellCheck") + (description + "This package adds a @code{shellcheck} backend to Flymake. The +recommended usage is to add @code{flymake-shellcheck-load} to +@code{sh-mode-hook}.") + (license license:gpl3+)))) + (define-public emacs-flycheck-rust (package (name "emacs-flycheck-rust") -- 2.26.0 --=-=-=-- ------------=_1636031162-31498-3--