GNU bug report logs - #51359
[PATCH 0/1] home-state-service-type and tests suite

Previous Next

Full log

Message #16 received at 51359 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Oleg Pykhalov <go.wigust <at> gmail.com>, 51359 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: Re: [bug#51359] [PATCH 0/1] home-state-service-type and tests suite
Date: Wed, 08 Jun 2022 19:10:28 +0300

[Message part 1 (text/plain, inline)]

On 2021-10-23 21:04, Oleg Pykhalov wrote:

> Hi Guix,
>
> This patch adds support for home-state-service-type which copied from the rde
> project [1].  The introduction to home state services in documentation is
> copied from discussion [2].
>
> Tests passed:
>
>     make check-system TESTS="home-state-git"
>     make check-system TESTS="home-state-rsync"
>
> [1] https://github.com/abcdw/rde/
> [2] https://lists.sr.ht/~abcdw/rde-devel/%3C87pmzze9nn.fsf%40trop.in%3E#%3CCABrWRW1Fq-8mS=MbWJedUpayj1vFg-YE0oNF3zVTYWBMnp29Lg <at> mail.gmail.com%3E
>
> Oleg Pykhalov (1):
>   home: services: Add state services.
>
>  doc/guix.texi                         |  32 ++
>  gnu/home.scm                          |  12 +
>  gnu/home/services/state.scm           | 210 ++++++++++++
>  gnu/home/services/utils.scm           |  81 ++++-
>  gnu/home/services/version-control.scm | 442 ++++++++++++++++++++++++++
>  gnu/local.mk                          |   2 +
>  gnu/tests/rsync.scm                   | 158 ++++++++-
>  gnu/tests/version-control.scm         | 140 +++++++-
>  guix/scripts/home.scm                 | 100 +++++-
>  9 files changed, 1163 insertions(+), 14 deletions(-)
>  create mode 100644 gnu/home/services/state.scm
>  create mode 100644 gnu/home/services/version-control.scm

Hi Oleg!

Thank you for the patch, but states are very WIP and not ready for
upstream yet IMO.  Also, I would like to reevaluate implementation of
git service-type and probably merge it separately.

Sorry for replying slowly :)  

Hope I will get back to states in foreseable future and will carefully
rethink, refactor and cleanup the code.

BTW, do you use states?  Can you share your experience with it?

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.