GNU bug report logs - #5135
[PATCH] rcirc: Option to sort NAMES listing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5135 in the body.
You can then email your comments to 5135 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] Option to sort NAMES listing
Date: Sun, 6 Dec 2009 18:16:00 +0100

[Message part 1 (text/plain, inline)]

Package: emacs,rcirc
Tags: patch
Version: 22.1
Severity: wishlist

This patch adds the user option to sort nickname listings in the way
that many other IRC clients sort them.

Details:
* Added rcirc-nickname<, a function which acts like string< but for
IRC nicknames, making @ less than + and comparing case-insensitively.
* Added rcirc-sort-nicknames-join, a function which takes a string of
IRC nicknames and a separator, sorts the nicknames and returns the
result.
* Added rcirc-sort-nicknames, a customizable variable which when
non-nil will make rcirc sort any NAMES responses. nil by default.
* Changed rcirc-handler-366 (RPL_ENDOFNAMES) to respect rcirc-sort-nicknames.

Notes:
Sorting of half-ops has not been tested, since this is a rarely used
feature of IRC. For what it's worth, half-op nicknames are prefixed
with %. Sorting of voiced users (+) works as intended by default, so
the only special case is @ < +. If someone implements support for
half-ops it should be @ < % < + < *.

-- 
Deniz Dogan

[rcirc-sort-nicknames.diff (application/octet-stream, attachment)]

Message #8 received at 5135 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ryan Yeske <rcyeske <at> gmail.com>
Cc: 5135 <at> debbugs.gnu.org, Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
Subject: Re: [PATCH] Option to sort NAMES listing
Date: Sat, 10 Apr 2010 20:02:20 -0400

Hi Ryan,

Could you review the patch to rcirc at

  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5135

?  Thanks.

Message #11 received at 5135 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
Cc: 5135 <at> debbugs.gnu.org, Ryan Yeske <rcyeske <at> gmail.com>
Subject: Re: [gnu.org #565169] Deniz Dogan EMACS Assignment
Date: Thu, 03 Jun 2010 10:56:32 -0400

Deniz Dogan <deniz.a.m.dogan <at> gmail.com> writes:

> This patch adds the user option to sort nickname listings in the way
> that many other IRC clients sort them.
>
> Details:
> * Added rcirc-nickname<, a function which acts like string< but for
> IRC nicknames, making  <at>  less than + and comparing case-insensitively.
> * Added rcirc-sort-nicknames-join, a function which takes a string of
> IRC nicknames and a separator, sorts the nicknames and returns the
> result.
> * Added rcirc-sort-nicknames, a customizable variable which when
> non-nil will make rcirc sort any NAMES responses. nil by default.
> * Changed rcirc-handler-366 (RPL_ENDOFNAMES) to respect rcirc-sort-nicknames.

If most IRC clients sort nicknames this way, it may not be necessary to
create a new option `rcirc-sort-nicknames'.  We should just perform the
sorting automatically.  What do you think?  (I don't know enough about
"typical" IRC behavior to say).

Also, your docstrings need work.  Please read the Documentation node in
the Elisp manual:

     When you write a documentation string, make the first line a
     complete sentence (or two complete sentences) since some
     commands, such as `apropos', show only the first line of a
     multi-line documentation string.

Message #16 received at 5135-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
Cc: Chong Yidong <cyd <at> stupidchicken.com>
Subject: Re: [gnu.org #565169] Deniz Dogan EMACS Assignment
Date: Thu, 03 Jun 2010 11:28:18 -0400

> Chong, here is the patch: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5135

Installed, thanks,


        Stefan

Message #19 received at 5135 <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 5135 <at> debbugs.gnu.org, Ryan Yeske <rcyeske <at> gmail.com>
Subject: Re: [gnu.org #565169] Deniz Dogan EMACS Assignment
Date: Thu, 3 Jun 2010 17:53:43 +0200

2010/6/3 Chong Yidong <cyd <at> stupidchicken.com>:
> Deniz Dogan <deniz.a.m.dogan <at> gmail.com> writes:
>
>> This patch adds the user option to sort nickname listings in the way
>> that many other IRC clients sort them.
>>
>> Details:
>> * Added rcirc-nickname<, a function which acts like string< but for
>> IRC nicknames, making  <at>  less than + and comparing case-insensitively.
>> * Added rcirc-sort-nicknames-join, a function which takes a string of
>> IRC nicknames and a separator, sorts the nicknames and returns the
>> result.
>> * Added rcirc-sort-nicknames, a customizable variable which when
>> non-nil will make rcirc sort any NAMES responses. nil by default.
>> * Changed rcirc-handler-366 (RPL_ENDOFNAMES) to respect rcirc-sort-nicknames.
>
> If most IRC clients sort nicknames this way, it may not be necessary to
> create a new option `rcirc-sort-nicknames'.  We should just perform the
> sorting automatically.  What do you think?  (I don't know enough about
> "typical" IRC behavior to say).
>

I'm all for making this option the default - I see no reason why
people would not want to sort the nicknames. Pretty much every IRC
client used today sorts the nicknames like this. I just figured maybe
some people get annoyed by the (almost infinitely small) overhead it
takes to perform the actual sorting. rcirc users like to keep it
minimalistic I have found.

> Also, your docstrings need work.  Please read the Documentation node in
> the Elisp manual:
>
>     When you write a documentation string, make the first line a
>     complete sentence (or two complete sentences) since some
>     commands, such as `apropos', show only the first line of a
>     multi-line documentation string.
>

Sorry about that, I will take that part of the manual into account in
any future patches.

By the way, it seems Stefan already applied this patch, so I don't
know where to go from here...

Cheers,
Deniz

Message #22 received at 5135 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Yeske <rcyeske <at> gmail.com>
To: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
Cc: 5135 <at> debbugs.gnu.org, Chong Yidong <cyd <at> stupidchicken.com>
Subject: Re: [gnu.org #565169] Deniz Dogan EMACS Assignment
Date: Thu, 03 Jun 2010 09:01:44 -0700

Deniz Dogan <deniz.a.m.dogan <at> gmail.com> writes:

> 2010/6/3 Chong Yidong <cyd <at> stupidchicken.com>:
>> If most IRC clients sort nicknames this way, it may not be necessary to
>> create a new option `rcirc-sort-nicknames'.  We should just perform the
>> sorting automatically.  What do you think?  (I don't know enough about
>> "typical" IRC behavior to say).
>>
>
> I'm all for making this option the default - I see no reason why
> people would not want to sort the nicknames. Pretty much every IRC
> client used today sorts the nicknames like this. I just figured maybe
> some people get annoyed by the (almost infinitely small) overhead it
> takes to perform the actual sorting. rcirc users like to keep it
> minimalistic I have found.

I have no issue with the overhead if it is truly minimal.  I never saw
any reason to sort the list of nicks.  They are sorted in "server order"
which I think shows how long everyone has been in the channel relative
to eachother.

I like to keep the number of configurable options down to a minimum, so
I'm happy to make this sorting the default, and remove
`rcirc-sort-nicknames'.

Ryan

Message #25 received at 5135 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ryan Yeske <rcyeske <at> gmail.com>
Cc: 5135 <at> debbugs.gnu.org, Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
Subject: Re: bug#5135: [gnu.org #565169] Deniz Dogan EMACS Assignment
Date: Thu, 03 Jun 2010 13:23:07 -0400

Ryan Yeske <rcyeske <at> gmail.com> writes:

> I have no issue with the overhead if it is truly minimal.  I never saw
> any reason to sort the list of nicks.  They are sorted in "server order"
> which I think shows how long everyone has been in the channel relative
> to eachother.
>
> I like to keep the number of configurable options down to a minimum, so
> I'm happy to make this sorting the default, and remove
> `rcirc-sort-nicknames'.

OK, let's make it always sort then.  I've commited to trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.