Subject: Re: bug#51346: [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags

From: Ludovic Courtès <[email-masked]>
Date: Mon, 15 Nov 2021 12:04:24 +0100

Josselin Poiret <[email-masked]> skribis:

> +   (lambda (swap)
> +     (define requirements
> +       (cond ((swap-space? swap)
> +              (map dependency->shepherd-service-name
> +                   (swap-space-dependencies swap)))
> +             ; TODO Remove after deprecation
> +             ((and (string? swap) (string-prefix? "/dev/mapper/" swap))
> +              (list (symbol-append 'device-mapping-
> +                                   (string->symbol (basename swap)))))

BTW, shouldn’t we emit a deprecation warning when (string? swap)?

If we do, it should contain source location info, as discussed at
<https://lists.gnu.org/archive/html/guix-devel/2021-09/msg00314.html>.

The whole series LGTM modulo the minor issues I commented on; could you
send a last version?

If Tobias agrees, we can apply that last version as soon as we get it.
I’d even apply it to ‘master’; why did you target ‘core-updates-frozen’?

Thanks!

Ludo’.