GNU bug report logs - #51340
27.2; Bad indentation and fontification of advice functions

Previous Next

Full log

Message #16 received at 51340 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: "51340 <at> debbugs.gnu.org" <51340 <at> debbugs.gnu.org>,
 Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#51340: 27.2; Bad indentation and fontification of advice
 functions
Date: Sun, 24 Oct 2021 20:29:45 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> I don't really care much.  Mainly wanted to draw some
> attention to the (minor) "problem", which could use
> some love.
>
> (advice-add 
>  'foobar-mode :around 'my-foobar-around-advice)
>
> (advice-add 'foobar-mode 
>             :around 'my-foobar-around-advice)
>
> (advice-add 'foobar-mode :around
>  'my-foobar-around-advice)
>
> (add-function :before-until (local 'something)
>               #'some-function)
>
> (add-function where isearch-filter-predicate pred
>               (append (and (or name  ...)
>                            `((name . ...)))
>                       (and ...
>                            (or ...)
>                            (let ((foo  ...))
>                              (unless (or ...)
>                                (setq foo  ))
>                              (and ...)))))

The second, fourth and fifth indentations are the same -- and are the
ones that make the most sense.  And happily, that's the way this indents
today, so I don't think there's anything here to fix, so I'm closing
this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.