GNU bug report logs - #51324
28.0.50; Should `message-mark-inserted-region' insert a newline before the end tag?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51324 in the body.
You can then email your comments to 51324 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bodertz <bodertz <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Should `message-mark-inserted-region' insert a newline
 before the end tag?
Date: Thu, 21 Oct 2021 16:27:43 -0600

The function `message-mark-inserted-region', bound to {C-c M-m} in
message-mode, inserts "cut here" text around the region.  By default,
the end tag is inserted directly after the text in the region, resulting
in:

    <mark-here-beg-text>
    text in the region<mark-here-end-text>

The text inserted is customizable by changing the values of either or
both of `message-mark-insert-beginning' and `message-mark-insert-end',
so what the defaults are doesn't matter much, but I think it would make
more sense for the default end tag to include a newline at the
beginning, or for the function `message-mark-inserted-region' to insert
a newline before the end tag:

    <mark-here-beg-text>
    text in the region
    <mark-here-end-text>

`message-mark-insert-beginning' already includes a newline at the end,
so I think making `message-mark-insert-end' include a newline at the
beginning makes sense.  Otherwise, a user will have to insert the
newline manually every time, since I don't think the anyone ever wants
to see it without the newline:

    --8<---------------cut here---------------start------------->8---
    text in the region--8<---------------cut here---------------end--------------->8---



The same issue applies when using the prefix argument to use so-called
verbatim marks:

    #v+
    text in the region#v-

This looks wrong to me, but maybe it isn't.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#51324: 28.0.50;
 Should `message-mark-inserted-region' insert a newline before the end
 tag?
Date: Thu, 21 Oct 2021 16:33:22 -0700

Bodertz <bodertz <at> gmail.com> writes:

> The function `message-mark-inserted-region', bound to {C-c M-m} in
> message-mode, inserts "cut here" text around the region.  By default,
> the end tag is inserted directly after the text in the region, resulting
> in:
>
>     <mark-here-beg-text>
>     text in the region<mark-here-end-text>
>
> The text inserted is customizable by changing the values of either or
> both of `message-mark-insert-beginning' and `message-mark-insert-end',
> so what the defaults are doesn't matter much, but I think it would make
> more sense for the default end tag to include a newline at the
> beginning, or for the function `message-mark-inserted-region' to insert
> a newline before the end tag:
>
>     <mark-here-beg-text>
>     text in the region
>     <mark-here-end-text>
>
> `message-mark-insert-beginning' already includes a newline at the end,
> so I think making `message-mark-insert-end' include a newline at the
> beginning makes sense.  Otherwise, a user will have to insert the
> newline manually every time, since I don't think the anyone ever wants
> to see it without the newline:
>
>     --8<---------------cut here---------------start------------->8---
>     text in the region--8<---------------cut here---------------end--------------->8---
>
>
>
> The same issue applies when using the prefix argument to use so-called
> verbatim marks:
>
>     #v+
>     text in the region#v-
>
> This looks wrong to me, but maybe it isn't.

Skeletons are unfashionable these days, but they provide nice facilities
for these situations: wrapping the region, and adding a newline only if
there isn't one.

Message #11 received at 51324 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Bodertz <bodertz <at> gmail.com>
Cc: 51324 <at> debbugs.gnu.org
Subject: Re: bug#51324: 28.0.50; Should `message-mark-inserted-region'
 insert a newline before the end tag?
Date: Fri, 22 Oct 2021 16:38:44 +0200

Bodertz <bodertz <at> gmail.com> writes:

> The function `message-mark-inserted-region', bound to {C-c M-m} in
> message-mode, inserts "cut here" text around the region.  By default,
> the end tag is inserted directly after the text in the region, resulting
> in:
>
>     <mark-here-beg-text>
>     text in the region<mark-here-end-text>

This is now fixed in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 51324 <at> debbugs.gnu.org (full text, mbox):

From: Bodertz <bodertz <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51324 <at> debbugs.gnu.org
Subject: Re: bug#51324: 28.0.50; Should `message-mark-inserted-region'
 insert a newline before the end tag?
Date: Fri, 22 Oct 2021 09:52:43 -0600

Apologies for the noise then.

Message #19 received at 51324 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Bodertz <bodertz <at> gmail.com>
Cc: 51324 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#51324: 28.0.50; Should `message-mark-inserted-region'
 insert a newline before the end tag?
Date: Fri, 22 Oct 2021 18:07:58 +0200

>>>>> On Fri, 22 Oct 2021 09:52:43 -0600, Bodertz <bodertz <at> gmail.com> said:

    Bodertz> Apologies for the noise then.

I think thereʼs a misunderstanding: you noticed and reported a bug,
and Lars fixed it. No need to apologize, applause all round.

Robert

-- 

Message #22 received at 51324 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 51324 <at> debbugs.gnu.org, Bodertz <bodertz <at> gmail.com>
Subject: Re: bug#51324: 28.0.50; Should `message-mark-inserted-region'
 insert a newline before the end tag?
Date: Fri, 22 Oct 2021 18:44:17 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

> I think thereʼs a misunderstanding: you noticed and reported a bug,
> and Lars fixed it. No need to apologize, applause all round.

Perhaps I should switch to saying "I've now fixed this"?  Sounds so
self-aggrandising, but it's less ambiguous...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 51324 <at> debbugs.gnu.org (full text, mbox):

From: Bodertz <bodertz <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51324 <at> debbugs.gnu.org, Robert Pluim <rpluim <at> gmail.com>
Subject: Re: bug#51324: 28.0.50; Should `message-mark-inserted-region'
 insert a newline before the end tag?
Date: Fri, 22 Oct 2021 10:51:51 -0600

No need.  I imagine I just skipped over the 'now'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.