GNU bug report logs - #51321
29.0.50; date in modelines

Previous Next

Full log

Message #58 received at 51321 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>,
 nisoni <at> algon.dk, 51321 <at> debbugs.gnu.org, Alan Third <alan <at> idiocy.org>
Subject: Re: bug#51321: 29.0.50; date in modelines
Date: Sat, 30 Oct 2021 08:41:00 -0700

Daniel Martín <mardani29 <at> yahoo.es> writes:

>> I've attached a patch that solves the issue.  If you think it's a good
>> idea, please install it for me.  Thanks.

This patch LGTM.  I think it should be safe for emacs-28, and I've
copied in Alan Third so that he can hopefully take a look.

>>From c27c60d344da64dac42c452e3a3aa7c35522a007 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= <mardani29 <at> yahoo.es>
> Date: Sat, 23 Oct 2021 14:44:31 +0200
> Subject: [PATCH] Set LC_ALL to the current locale in the NS port
>
> * src/nsterm.m (ns_init_locale): If not already set, set LC_ALL to the
> current locale ID so that dates, currencies, etc. use the settings
> configured in the operating system.  (Bug#51321)
> ---
>  src/nsterm.m | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/nsterm.m b/src/nsterm.m
> index aa29c13eb2..19ed750d21 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -543,8 +543,10 @@ - (NSColor *)colorUsingDefaultColorSpace
>        NSString *localeID = [NSString stringWithFormat:@"%@.UTF-8",
>                                       [locale localeIdentifier]];
>
> -      /* Set LANG to locale, but not if LANG is already set.  */
> +      /* Set LANG and LC_ALL to locale, but not if the variables are
> +         already set.  */
>        setenv("LANG", [localeID UTF8String], 0);
> +      setenv("LC_ALL", [localeID UTF8String], 0);
>      }
>    @catch (NSException *e)
>      {

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.