GNU bug report logs - #51314
[PATCH 00/29] Add Octoprint (web UI for 3d printers).

Previous Next

Full log

View this message in rfc822 format

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 51314 <at> debbugs.gnu.org
Subject: [bug#51314] [PATCH 00/29] Add Octoprint (web UI for 3d printers).
Date: Mon, 8 Nov 2021 22:38:10 +0200

[Message part 1 (text/plain, inline)]

On Thu, Oct 21, 2021 at 03:51:00AM +0000, Vinicius Monego wrote:
> This patchset adds the Octoprint web UI to control 3d printers.
> 
> Octoprint itself bundles font-awesome. I removed it in a snippet, don't know how much it would affect usability. I haven't found other bundles with license issues.
> 
> Some of the updates have newer versions but I'm updating to "older" versions to maintain compatibility with octoprint. See the comment in the octoprint package.

Looking at some of the comments here¹ it looks like they're using old
versions mostly to retain python2 compatibility. On the other hand they
also have a comment about not having checked newer versions yet for for
breaking changes, which IMO is their job. Other than flask-login and
netaddr I don't see a reason to not try with some of the newer versions
of the packages. I would feel better if they only marked their own
dependencies and not transitive dependencies.

I think it makes sense to try newer versions and to add older versions
on an as-needed basis, especially since some of these packages are
likely to be upgraded again at some point before the next version of
octoprint.

¹ https://github.com/OctoPrint/OctoPrint/blob/1.7.0/setup.py#L17

> 
> Vinicius Monego (29):
>   gnu: Add python-filetype.
>   gnu: Add python-immutabledict.
>   gnu: Add python-emoji.
>   gnu: Add python-cachelib.
>   gnu: Add python-sarge.
>   gnu: Add python-pylru.
>   gnu: python-flask: Update to 1.1.4.
>   gnu: python-flask: Respect #:tests?.
>   gnu: Add python-pyscss.
>   gnu: Add python-flask-assets.
>   gnu: Add python-zipstream-new.
>   gnu: Add python-executing.
>   gnu: Add python-sentry-sdk.
>   gnu: Add python-pytest-doctest-custom.
>   gnu: Add python-sgmllib3k.
>   gnu: python-feedparser: Update to 6.0.8.
>   gnu: python-feedparser: Enable tests.
>   gnu: python-netifaces: Update to 0.11.0.
>   gnu: python-websocket-client: Update to 0.59.0.
>   gnu: python-pkginfo: Update to 1.7.1.
>   gnu: python-watchdog: Update to 0.10.7.
>   gnu: python-colorlog: Update to 5.0.1.
>   gnu: python-zeroconf: Update to 0.33.4.
>   gnu: python-wrapt: Update to 1.12.1.
>   gnu: python-wrapt: Enable tests.
>   gnu: Add octoprint-pisupport.
>   gnu: Add octoprint-firmwarecheck.
>   gnu: Add octoprint-filecheck.
>   gnu: Add octoprint.
> 
>  gnu/packages/printers.scm     | 181 +++++++++++++++-
>  gnu/packages/python-check.scm |  29 +++
>  gnu/packages/python-web.scm   |  96 ++++++++-
>  gnu/packages/python-xyz.scm   | 381 ++++++++++++++++++++++++++++++----
>  gnu/packages/web.scm          |  15 +-
>  5 files changed, 645 insertions(+), 57 deletions(-)
> 
> 
> base-commit: 2782cb38a3bc68c530d6e95f6834ae0cb7ed16aa
> prerequisite-patch-id: 01467a57e2c7d6c0266979c26fc35408e886972b
> -- 
> 2.30.2
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.