From unknown Fri Aug 15 19:32:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 51270@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163457814420035 (code B ref -1); Mon, 18 Oct 2021 17:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Oct 2021 17:29:04 +0000 Received: from localhost ([127.0.0.1]:48455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcWRc-0005D4-0j for submit@debbugs.gnu.org; Mon, 18 Oct 2021 13:29:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:45468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcWRZ-0005Cf-9q for submit@debbugs.gnu.org; Mon, 18 Oct 2021 13:29:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcWRY-0002ZK-No for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 13:29:01 -0400 Received: from mout01.posteo.de ([185.67.36.65]:59759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcWRU-0006lu-17 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 13:29:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4E5FB240026 for ; Mon, 18 Oct 2021 19:28:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634578131; bh=Eb1zY82hFsw9DAyPA73L0OOxYsMusjFhG6rm9q+gOWI=; h=From:To:Subject:Date:From; b=n5AlvxRcnd1aHQCHU4c/DhQh/Co/hoCWY9LE+eehKD8mzKWAcvt1s+fg7FaPuW+Cl 0SQBT2/Hm1UWY3e4zcYVQvzuTNmTV8jN13YoQs1nfnIBXQCtPkdUDIhCLWT43LTqHq Aap5e0EvjpyPeNmn52cXWbkxQU60f7qN+5bR7mRXZAK/8dimAMPC4B3QizbmPA7D9Y wcrohwRJCkhni/tj3pM1eMNOfLgXY51zfmgSvKnQYMur4FDtGVmOlsMxbjPFOPiLQq pxsxOJ/529Eo+vCZ4G8fATxVhIzCOwY2y1tK6Oiu4t70LO8RnZvDi7UTnF7HxzXFOr k/wZaJUqFgIFg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HY3kp4vhqz6tmL for ; Mon, 18 Oct 2021 19:28:50 +0200 (CEST) From: Ingo Lohmar Date: Mon, 18 Oct 2021 10:13:04 +0000 Message-ID: <87sfwyej4f.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=ingo.lohmar@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) This appears to be a packaging bug: The xref core package has changed its version number from 1.2.2 to 1.3.0 in 35a752863afc9f9075473e34c395d36e0bd18bff. The breakage happens because xref 1.3.0 has been published on GNU ELPA https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as the latest version, don't know why). I am using the "eglot" package, which requires xref (at a lower minimum version), and when upgrading packages this morning, I got xref 1.3.0. After that, everything related to etags fell apart (company backends, after-save hooks to regenerate tags etc) with error messages about undefined xref-location classes (and more). Brief analysis: The new xref version switches from eieio to cl-defstruct, which means that older etags (not a core package) code breaks, because it relies on the xref-location class. This seems to be in violation of the comment in xref.el: "Avoid functionality that is not compatible with the version of Emacs recorded above." (the version "recorded above" is 26.1) I am not really clear on how the "core package" idea is supposed to work. One solution would be to "un-publish" xref 1.3.0. A more general approach would introduce semantic versioning to package.el, and the above change would require a version 2.0.0 in that world. In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-09-02 built on t14s-il Repository revision: 4c49ec7f865bdad1629d2f125f71f4e506b258f2 Repository branch: feature/pgtk Windowing system distributor 'System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --without-gsettings --with-pgtk' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l [...] Memory information: ((conses 16 1269822 164531) (symbols 48 46201 11) (strings 32 209533 58772) (string-bytes 1 7112283) (vectors 16 94542) (vector-slots 8 1961389 54375) (floats 8 959 1792) (intervals 56 129413 1921) (buffers 992 56)) From unknown Fri Aug 15 19:32:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar , 51270@debbugs.gnu.org Received: via spool by 51270-submit@debbugs.gnu.org id=B51270.16345895505876 (code B ref 51270); Mon, 18 Oct 2021 20:40:02 +0000 Received: (at 51270) by debbugs.gnu.org; 18 Oct 2021 20:39:10 +0000 Received: from localhost ([127.0.0.1]:48720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZPa-0001Wi-01 for submit@debbugs.gnu.org; Mon, 18 Oct 2021 16:39:10 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:39749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZPX-0001WK-85 for 51270@debbugs.gnu.org; Mon, 18 Oct 2021 16:39:09 -0400 Received: by mail-lj1-f172.google.com with SMTP id r6so1975728ljg.6 for <51270@debbugs.gnu.org>; Mon, 18 Oct 2021 13:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MLwrCjIXBROnDu31wDpY4b7UpkwJiVohoaspbAMdf7s=; b=Utv/pimWbH+l9F8riahR5RBqaDKXp/MJeoOpQmDj9dsjQ0y3SFRzuzsSgjNs32vCtm hwLpj0n4q7J+VOwallrNkHIYwpFopx+UioqIpJ22qCxdRowhBnrgmZnNaGpjmE1uJw3X o5rRhwJlb694VKrN2PvHx4LrIAJGSu6LLkfit+y3x5r4Y/BfujiW3W8FhXVEvNyTXa39 OboG0QQo580hPv70vp1nAzTLpDvJc28WdxpwSuzmSkcnbssoy2mVvQkGDLFONU1AJNUS pwhBnVl4cloyOB969qDKVbWseP7MayguRbn7yJiPcSjFcucWy1qyjC2ND8DX39DXlFtt PvlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MLwrCjIXBROnDu31wDpY4b7UpkwJiVohoaspbAMdf7s=; b=rsM03XvEF4jftResUIMdlKb4CAbkRVtt8w/ZfuhzjhK7r0EXkRU0qo4b/wYeqHk7g2 CHbRzQWyo3DEi0OJYHfTEOFapMfq696kgRGNXVpKj4AZAapDNbdcSmXQvucddthcHifv UPwB7qPyktfLHdlHUiXUE5/TvQNZW6AGpDOaK8h5+MhG3QRNXzRSUZO9qctYMJeGUAZo n5+1SWREyXObCKuGztc2OArkzmzRse3SE32+Iy2u0slSW/wdjKCqylM7tgglk/OGUJMb Z1mYambbf8ps0QZNyqysgBwdFNqmlyL88D/2CVjdAIpHcCQ1608P8ECGXV3lh8A7IqKo Fd6g== X-Gm-Message-State: AOAM530yybDT9VYl+dm0rBSNyPCPs6AJKDHdVphqh42KjbsOJqPp2PDr Y4hL4hkJ0kew56KJhkmdHA/wvuAXe3A= X-Google-Smtp-Source: ABdhPJzHWQwt8JJ5G2nh9Ts3hUni4P5h7joPjBgCqlUK8b1s1rDFeY/JBEk2t5BwYQNRuiMJms1GZg== X-Received: by 2002:a2e:5cc7:: with SMTP id q190mr2140380ljb.494.1634589541151; Mon, 18 Oct 2021 13:39:01 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id b18sm1844579lji.99.2021.10.18.13.39.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 13:39:00 -0700 (PDT) References: <87sfwyej4f.fsf@kenko.localhost.com> From: Dmitry Gutov Message-ID: <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> Date: Mon, 18 Oct 2021 23:38:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87sfwyej4f.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi! On 18.10.2021 13:13, Ingo Lohmar wrote: > > This appears to be a packaging bug: The xref core package has changed > its version number from 1.2.2 to 1.3.0 in > 35a752863afc9f9075473e34c395d36e0bd18bff. > > The breakage happens because xref 1.3.0 has been published on GNU ELPA > https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as > the latest version, don't know why). I am using the "eglot" package, > which requires xref (at a lower minimum version), and when upgrading > packages this morning, I got xref 1.3.0. Which version of Emacs are you using? I understand Emacs 26 might have a problem with :noinline instructions in the new struct definitions. But as for loading eieio and defining the xref-location class, the top-level version check at the beginning of xref.el should supposedly help. It looks like: (eval-and-compile (when (version< emacs-version "28") ;; etags.el in Emacs 26 and 27 uses EIEIO, and its location type ;; inherits from `xref-location'. (require 'eieio) (with-no-warnings (defclass xref-location () () :documentation "...")))) > After that, everything related to etags fell apart (company backends, > after-save hooks to regenerate tags etc) with error messages about > undefined xref-location classes (and more). A backtrace example with an error could help as well. > Brief analysis: The new xref version switches from eieio to > cl-defstruct, which means that older etags (not a core package) code > breaks, because it relies on the xref-location class. This seems to be > in violation of the comment in xref.el: "Avoid functionality that is not > compatible with the version of Emacs recorded above." (the version > "recorded above" is 26.1) > > I am not really clear on how the "core package" idea is supposed to > work. One solution would be to "un-publish" xref 1.3.0. A more general > approach would introduce semantic versioning to package.el, and the > above change would require a version 2.0.0 in that world. Yes, it is definitely a problem. Semantic versioning wouldn't help, though. Emacs repositories don't retain non-latest versions of packages, and we don't have a way to specify an upper bound on a dependency either. From unknown Fri Aug 15 19:32:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov , 51270@debbugs.gnu.org Received: via spool by 51270-submit@debbugs.gnu.org id=B51270.16345915839141 (code B ref 51270); Mon, 18 Oct 2021 21:14:02 +0000 Received: (at 51270) by debbugs.gnu.org; 18 Oct 2021 21:13:03 +0000 Received: from localhost ([127.0.0.1]:48748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZw8-0002Mq-DQ for submit@debbugs.gnu.org; Mon, 18 Oct 2021 17:13:03 -0400 Received: from mout02.posteo.de ([185.67.36.66]:46239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZw5-0002Ma-AK for 51270@debbugs.gnu.org; Mon, 18 Oct 2021 17:12:46 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id DE97A240103 for <51270@debbugs.gnu.org>; Mon, 18 Oct 2021 23:12:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634591558; bh=7BCFDDmVR5t1FKR/pP112JCwePfS5mJeN0n/94txn7U=; h=From:To:Subject:Date:From; b=JYqbH82VRBulFTPIYdLpqLQF3T0/eyKAoknEVTIq/DGTFycMAhdS/TPCu2tyzzBFY uR+itHB0qKRAB3U/K1CYwirp85UdXxcoR6Cclwhk8fSWav59zl0d/+P5Uso9VPlYsO 10SgHYRMxpt+Vg2C3HgcJzgEwLXfaJ5z4wKQwsd9VciXQe/6WcL/Rg6B7O54OUUFR3 jGHy0w+43IUMd9OkJYZr69HkxXRlVOirKvGpZbaEEfPPN+1nJiCpSuPv90GWVI+c0f KHABhQsofsCKIddRugWagkMPu8Wh5kbLNKuaq6W9NWmrMdZpuvtEDyQ0MTBStWBQjz fY038LqmQY1zA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HY8j15jGTz9rxP; Mon, 18 Oct 2021 23:12:37 +0200 (CEST) From: Ingo Lohmar In-Reply-To: <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> References: <87sfwyej4f.fsf@kenko.localhost.com> <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> Date: Mon, 18 Oct 2021 21:12:37 +0000 Message-ID: <87mtn6ca0q.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Oct 18 2021 23:38 (+0300), Dmitry Gutov wrote: >> The breakage happens because xref 1.3.0 has been published on GNU ELPA >> https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as >> the latest version, don't know why). I am using the "eglot" package, >> which requires xref (at a lower minimum version), and when upgrading >> packages this morning, I got xref 1.3.0. > > Which version of Emacs are you using? I understand Emacs 26 might have a > problem with :noinline instructions in the new struct definitions. I am using the feature/pgtk branch, which is currently based on an older master (roughly 3m ago) it seems. > But as for loading eieio and defining the xref-location class, the > top-level version check at the beginning of xref.el should supposedly > help. It looks like: > > (eval-and-compile > (when (version< emacs-version "28") > ;; etags.el in Emacs 26 and 27 uses EIEIO, and its location type > ;; inherits from `xref-location'. > (require 'eieio) > (with-no-warnings > (defclass xref-location () () > :documentation "...")))) Ah, I did not look at the 1.3.0 file. So the above will help for all released emacs versions, but will just not run for a non-recent master of Emacs 28, get it. I don't have a backtrace yet, but can provide one if it's helpful for related questions. I guess I will just manually move xref-1.3.0 out of the way until I can update to a newer Emacs master (which will then include the coordinated xref/etags changes). Yeah, the packaging story is not really robust yet. I only mentioned "semantic versioning" as a general concept, but I am aware that the package repositories and the dependency format are just not prepared to make use of it anyway. Thanks for your help! From unknown Fri Aug 15 19:32:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar , 51270@debbugs.gnu.org Received: via spool by 51270-submit@debbugs.gnu.org id=B51270.163459325411685 (code B ref 51270); Mon, 18 Oct 2021 21:41:02 +0000 Received: (at 51270) by debbugs.gnu.org; 18 Oct 2021 21:40:54 +0000 Received: from localhost ([127.0.0.1]:48779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcaNJ-00032P-SE for submit@debbugs.gnu.org; Mon, 18 Oct 2021 17:40:54 -0400 Received: from mail-lf1-f48.google.com ([209.85.167.48]:34315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcaNH-00032B-Ah for 51270@debbugs.gnu.org; Mon, 18 Oct 2021 17:40:52 -0400 Received: by mail-lf1-f48.google.com with SMTP id t9so2797512lfd.1 for <51270@debbugs.gnu.org>; Mon, 18 Oct 2021 14:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DAPlMQB58lg0FZ5cnRpbvoZunvFLbQ8+yJsbQDE5dRQ=; b=OvBVhaXNnS8qzgRaUlCsJTDIGzdRakdXDt7hSgh55X8QnKpESSYhkybZlXIu0YI5Na UfRL4jp1NAxP+O1FPQDJIcfaCpUuy7yBVilTqDP3Op3301K0sf4z2YoccJ1XpLkQxIhV RkGMaBAA/XyZ6G4mrzH6+7byuCGh9EnFFWjgXVI+vc3/XM+mMpTRBkGjVJoZyJzJ6J1B 1M4sJJCV0RfMujOChN/23lsFW83MgH8szK1APMxxFNalk6qdsz7zPK19h37NQCmcC7LN OvR+7/KOYfQ/KGeA2a5EpVsOpRhh6v0zNHpXR1O0BX2/9XFZTLLjAjVjV348RbA3Fzrn otzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DAPlMQB58lg0FZ5cnRpbvoZunvFLbQ8+yJsbQDE5dRQ=; b=3vgP7n+13sW8ffL1kEwDDtV8bx+D6zpAw2IdIXZhhvQlW3U0DRZdCLKgjm65GRTDio cK3BMfFEXdNYuyJPZdgKwOcrjvIv90h1vHzLF4dz5CSQZ529ikfLRjVw/n05aDnYc4Qc Adx0eDbffTPbS8IU3TJSEKZSj7mKd3Ig7J6TBBL3t8IwZtJzyT669u5wRJai12UTm6/H 1LHEVMFKRdMsH13DYtnmzPHax9KmCjnRmhwKTwZYudciIYO09dzAJGUIk1JYG/pu74MT hHj/DiMXlA3OEsxO62dGPMEoxkQk+L41sNZgxf/Jtxy8dKVHXqnVExH6rGlGGbksRX/c qRqQ== X-Gm-Message-State: AOAM5313jXND/gAect5gUjWlBcvq9awLnt4RV6hbUn6DI2JBhsPdI0/K 6iX+fBfFBGTc89a1Q8gzqlq0ctsLfhg= X-Google-Smtp-Source: ABdhPJzxBkquEu+C1QOeJmIMthGWL5A4SlN2uLnb2ziT75p6H4jzPE9+fbZbkml2mcI/kZnLC8tQqw== X-Received: by 2002:a05:6512:b8b:: with SMTP id b11mr2152511lfv.177.1634593245244; Mon, 18 Oct 2021 14:40:45 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id x10sm1498510lfr.72.2021.10.18.14.40.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 14:40:44 -0700 (PDT) References: <87sfwyej4f.fsf@kenko.localhost.com> <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> <87mtn6ca0q.fsf@kenko.localhost.com> From: Dmitry Gutov Message-ID: Date: Tue, 19 Oct 2021 00:40:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87mtn6ca0q.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 19.10.2021 00:12, Ingo Lohmar wrote: > On Mon, Oct 18 2021 23:38 (+0300), Dmitry Gutov wrote: > >>> The breakage happens because xref 1.3.0 has been published on GNU ELPA >>> https://elpa.gnu.org/p [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.48 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.48 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.1 NICE_REPLY_A Looks like a legit reply (A) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 19.10.2021 00:12, Ingo Lohmar wrote: > On Mon, Oct 18 2021 23:38 (+0300), Dmitry Gutov wrote: > >>> The breakage happens because xref 1.3.0 has been published on GNU ELPA >>> https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as >>> the latest version, don't know why). I am using the "eglot" package, >>> which requires xref (at a lower minimum version), and when upgrading >>> packages this morning, I got xref 1.3.0. >> >> Which version of Emacs are you using? I understand Emacs 26 might have a >> problem with :noinline instructions in the new struct definitions. > > I am using the feature/pgtk branch, which is currently based on an older > master (roughly 3m ago) it seems. Ah, that's what it is! >> But as for loading eieio and defining the xref-location class, the >> top-level version check at the beginning of xref.el should supposedly >> help. It looks like: >> >> (eval-and-compile >> (when (version< emacs-version "28") >> ;; etags.el in Emacs 26 and 27 uses EIEIO, and its location type >> ;; inherits from `xref-location'. >> (require 'eieio) >> (with-no-warnings >> (defclass xref-location () () >> :documentation "...")))) > > Ah, I did not look at the 1.3.0 file. So the above will help for all > released emacs versions, but will just not run for a non-recent master > of Emacs 28, get it. Yes, an update to a more recent emacs-28 should fix it. pgtk is indeed a fair bit out of date. Perhaps we could compare the version more finely to "28.0.60", to cut off most older builds. That 3 month old version advertises itself as "28.0.50", right? > I don't have a backtrace yet, but can provide one if it's helpful for > related questions. I guess I will just manually move xref-1.3.0 out of > the way until I can update to a newer Emacs master (which will then > include the coordinated xref/etags changes). Sounds good. And pgtk might as well do a merge from master (it won't be in Emacs 28 apparently). From unknown Fri Aug 15 19:32:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov , 51270@debbugs.gnu.org Received: via spool by 51270-submit@debbugs.gnu.org id=B51270.163466345626336 (code B ref 51270); Tue, 19 Oct 2021 17:11:02 +0000 Received: (at 51270) by debbugs.gnu.org; 19 Oct 2021 17:10:56 +0000 Received: from localhost ([127.0.0.1]:51875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcsdc-0006qh-Fc for submit@debbugs.gnu.org; Tue, 19 Oct 2021 13:10:56 -0400 Received: from mout01.posteo.de ([185.67.36.65]:60787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcsda-0006qT-70 for 51270@debbugs.gnu.org; Tue, 19 Oct 2021 13:10:55 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id AF702240026 for <51270@debbugs.gnu.org>; Tue, 19 Oct 2021 19:10:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634663447; bh=tTTzvwNo2nCF0SRQIat7uf1CDGhKc3yWmYm8tJqr5eY=; h=From:To:Subject:Date:From; b=N0aRHXg98mfz77DScA95MKzAV3JiAKLJX016MU4ZMCje0sdG81y4t3/+lRq4HpdVr G8u+0NaGagp29tis+puPHhwlicyTUFhONXxLn6xRivO+GNaPJ6luP14NCg/opFHxGE 2EsMNnv5VBECCRsIDGYSI0bJr7+/Amloy6VEGwxbYJjGFGbx5ffOsDq+Djhricgt19 oe/CCbO7kCw8qIbW6MAQ7GxYa5CJ8aD6G6oj0q/3OU7woxjnfA1CzxsXP0j4gzEemC c8Z75u6CYigp6pAylEQhTZrrmAG0vgL7Xsyu1jwhruWwtABwLdaoir5mAycrglwrOw xZAV4GbfvTSQw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HYgHV59wqz9rxB; Tue, 19 Oct 2021 19:10:46 +0200 (CEST) From: Ingo Lohmar In-Reply-To: References: <87sfwyej4f.fsf@kenko.localhost.com> <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> <87mtn6ca0q.fsf@kenko.localhost.com> Date: Tue, 19 Oct 2021 17:10:46 +0000 Message-ID: <87k0i9c549.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Tue, Oct 19 2021 00:40 (+0300), Dmitry Gutov wrote: > > Yes, an update to a more recent emacs-28 should fix it. pgtk is indeed a > fair bit out of date. > > Perhaps we could compare the version more finely to "28.0.60", to cut > off most older builds. That 3 month old version advertises itself as > "28.0.50", right? It does, so the finer comparison should help all but very few edge cases. Looking forward to xref-1.3.1 (or something like that)! From unknown Fri Aug 15 19:32:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ingo Lohmar Subject: bug#51270: closed (Re: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags) Message-ID: References: <87sfwyej4f.fsf@kenko.localhost.com> X-Gnu-PR-Message: they-closed 51270 X-Gnu-PR-Package: emacs Reply-To: 51270@debbugs.gnu.org Date: Tue, 19 Oct 2021 22:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1634681162-22860-1" This is a multi-part message in MIME format... ------------=_1634681162-22860-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51270: 28.0.50; xref core package 1.3.0 published, breaks etags which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51270@debbugs.gnu.org. --=20 51270: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51270 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1634681162-22860-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51270-done) by debbugs.gnu.org; 19 Oct 2021 22:05:56 +0000 Received: from localhost ([127.0.0.1]:52190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcxF5-0005wR-V4 for submit@debbugs.gnu.org; Tue, 19 Oct 2021 18:05:56 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:33361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcxF4-0005wE-OA for 51270-done@debbugs.gnu.org; Tue, 19 Oct 2021 18:05:55 -0400 Received: by mail-lj1-f172.google.com with SMTP id d13so8923180ljg.0 for <51270-done@debbugs.gnu.org>; Tue, 19 Oct 2021 15:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bfiyVm8w/8/Mlosl8wtWk2Bl4kXcmTLj/WJUzcO8fHA=; b=Ckw/tcjx5GCs4/BjeLz5XgLb09wM+xNxr+I4pojmDQuFYKOdZxYjWta4Bu6IfP6VMu C6nnHJ+/0pVo6u+foQuPL8b65lwldqpcHgEHL6UKr/Xj84sSbG+BiBRQmWtlTX4RHYtw nqUFI8HiRQsaHfk8PkVZw5ioxCnDaPnEh+zjskv55YY1fHptwxtH4o7Ed2f3mw5uR+SQ 4BKv/zNHNfxpe4cXVk3akdfXJBDXv5skzJX0nxNS7MU6zyu+DIUMXhWyqPQf8zxVups+ 5MNz/dc7mvjlzNBCQQfLxhqFJV+xvgkoLPecz+o+LrK/RDs+2TYXiMm7wxrwkRj69mlB 4mDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bfiyVm8w/8/Mlosl8wtWk2Bl4kXcmTLj/WJUzcO8fHA=; b=iU4AqPvFbkzKj8Li7Xs5caDue1THaA+DVj+SnRaJIVS+yyscCSAW17PedY8kFifWCr Eb5z35Jx+PBcrAHgYmYMTXCyQQP0PzutkG30a0poqRnCRheKiA+rdfFi03YQy0PtBRFi GW5RFOn/MZiOM202Ol2c59vWTfOfkCOYzEp3enKL8CQdpoxqrfCKe/vuLJ9iOp+/mM4w yK0RpZhsJeuFTwU2qKcEaKtt5v++8ZetRL8PeHCq7Z1jKBGMO/jcbdFZCMCrUsN3TpEQ 7a8l42mLgh7wAGqaXY/N2G7/CpYR/K44sUsLYq9OGvB+K/lRGkRbQ6EKI6eka5o8Sgph T4xQ== X-Gm-Message-State: AOAM532EceZYnKJLFMR1c4QtDhBgco6071hEpLsLTumPWZIyYFta0Ux0 DTvnArX03AzKN86/0WXnqNBGL4/qfn8= X-Google-Smtp-Source: ABdhPJydVUY8+Ka5CIRdWDW77pbauyvLL++15ah1hcBCmTADRn9Fv5X8fFxe4YtvvZImhNJ+gk1uFA== X-Received: by 2002:a05:651c:54d:: with SMTP id q13mr9304716ljp.202.1634681147125; Tue, 19 Oct 2021 15:05:47 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id c1sm25146ljr.111.2021.10.19.15.05.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Oct 2021 15:05:46 -0700 (PDT) Subject: Re: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags To: Ingo Lohmar , 51270-done@debbugs.gnu.org References: <87sfwyej4f.fsf@kenko.localhost.com> <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> <87mtn6ca0q.fsf@kenko.localhost.com> <87k0i9c549.fsf@kenko.localhost.com> From: Dmitry Gutov Message-ID: Date: Wed, 20 Oct 2021 01:05:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87k0i9c549.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 51270-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 19.10.2021 20:10, Ingo Lohmar wrote: > On Tue, Oct 19 2021 00:40 (+0300), Dmitry Gutov wrote: >> Yes, an update to a more recent emacs-28 should fix it. pgtk is indeed a >> fair bit out of date. >> >> Perhaps we could compare the version more finely to "28.0.60", to cut >> off most older builds. That 3 month old version advertises itself as >> "28.0.50", right? > It does, so the finer comparison should help all but very few edge > cases. Looking forward to xref-1.3.1 (or something like that)! 1.3.1 is out already, so this will be 1.3.2. Done, and closing. ------------=_1634681162-22860-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Oct 2021 17:29:04 +0000 Received: from localhost ([127.0.0.1]:48455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcWRc-0005D4-0j for submit@debbugs.gnu.org; Mon, 18 Oct 2021 13:29:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:45468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcWRZ-0005Cf-9q for submit@debbugs.gnu.org; Mon, 18 Oct 2021 13:29:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcWRY-0002ZK-No for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 13:29:01 -0400 Received: from mout01.posteo.de ([185.67.36.65]:59759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcWRU-0006lu-17 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 13:29:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4E5FB240026 for ; Mon, 18 Oct 2021 19:28:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634578131; bh=Eb1zY82hFsw9DAyPA73L0OOxYsMusjFhG6rm9q+gOWI=; h=From:To:Subject:Date:From; b=n5AlvxRcnd1aHQCHU4c/DhQh/Co/hoCWY9LE+eehKD8mzKWAcvt1s+fg7FaPuW+Cl 0SQBT2/Hm1UWY3e4zcYVQvzuTNmTV8jN13YoQs1nfnIBXQCtPkdUDIhCLWT43LTqHq Aap5e0EvjpyPeNmn52cXWbkxQU60f7qN+5bR7mRXZAK/8dimAMPC4B3QizbmPA7D9Y wcrohwRJCkhni/tj3pM1eMNOfLgXY51zfmgSvKnQYMur4FDtGVmOlsMxbjPFOPiLQq pxsxOJ/529Eo+vCZ4G8fATxVhIzCOwY2y1tK6Oiu4t70LO8RnZvDi7UTnF7HxzXFOr k/wZaJUqFgIFg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HY3kp4vhqz6tmL for ; Mon, 18 Oct 2021 19:28:50 +0200 (CEST) From: Ingo Lohmar To: bug-gnu-emacs@gnu.org Subject: 28.0.50; xref core package 1.3.0 published, breaks etags Date: Mon, 18 Oct 2021 10:13:04 +0000 Message-ID: <87sfwyej4f.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=ingo.lohmar@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) This appears to be a packaging bug: The xref core package has changed its version number from 1.2.2 to 1.3.0 in 35a752863afc9f9075473e34c395d36e0bd18bff. The breakage happens because xref 1.3.0 has been published on GNU ELPA https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as the latest version, don't know why). I am using the "eglot" package, which requires xref (at a lower minimum version), and when upgrading packages this morning, I got xref 1.3.0. After that, everything related to etags fell apart (company backends, after-save hooks to regenerate tags etc) with error messages about undefined xref-location classes (and more). Brief analysis: The new xref version switches from eieio to cl-defstruct, which means that older etags (not a core package) code breaks, because it relies on the xref-location class. This seems to be in violation of the comment in xref.el: "Avoid functionality that is not compatible with the version of Emacs recorded above." (the version "recorded above" is 26.1) I am not really clear on how the "core package" idea is supposed to work. One solution would be to "un-publish" xref 1.3.0. A more general approach would introduce semantic versioning to package.el, and the above change would require a version 2.0.0 in that world. In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-09-02 built on t14s-il Repository revision: 4c49ec7f865bdad1629d2f125f71f4e506b258f2 Repository branch: feature/pgtk Windowing system distributor 'System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --without-gsettings --with-pgtk' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l [...] Memory information: ((conses 16 1269822 164531) (symbols 48 46201 11) (strings 32 209533 58772) (string-bytes 1 7112283) (vectors 16 94542) (vector-slots 8 1961389 54375) (floats 8 959 1792) (intervals 56 129413 1921) (buffers 992 56)) ------------=_1634681162-22860-1--