GNU bug report logs - #51262
[PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry'

Previous Next

Full log

Message #8 received at 51262 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Jan Synáček <jan.synacek <at> gmail.com>
Cc: 51262 <at> debbugs.gnu.org
Subject: Re: bug#51262: [PATCH] Don't use color escape sequences in
 `vc-git-expanded-log-entry'
Date: Mon, 18 Oct 2021 22:16:11 -0700

Jan Synáček <jan.synacek <at> gmail.com> writes:

> From acbfec361709c5eebafb9a957e76f70500083cf0 Mon Sep 17 00:00:00 2001
> From: Jan Synacek <jan.synacek <at> gmail.com>
> Date: Mon, 18 Oct 2021 12:34:38 +0200
> Subject: [PATCH] Don't use color escape sequences in
>  `vc-git-expanded-log-entry'
>
> * lisp/vc/vc-git.el (vc-git-expanded-log-entry): Use --no-color in git
> invocation.
>
> Copyright-paperwork-exempt: yes
> ---
>  lisp/vc/vc-git.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
> index 35c0838dd6..3f89fad235 100644
> --- a/lisp/vc/vc-git.el
> +++ b/lisp/vc/vc-git.el
> @@ -1323,7 +1323,7 @@ vc-git-show-log-entry
>
>  (defun vc-git-expanded-log-entry (revision)
>    (with-temp-buffer
> -    (apply #'vc-git-command t nil nil (list "log" revision "-1" "--"))
> +    (apply #'vc-git-command t nil nil (list "log" revision "-1"  "--no-color" "--"))
>      (goto-char (point-min))
>      (unless (eobp)
>        ;; Indent the expanded log entry.

Thanks for the patch.

Could you add some details here, such as what problem it is supposed to
fix?  How can I reproduce the issue here, starting from emacs -Q?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.