From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 18 06:46:11 2021 Received: (at submit) by debbugs.gnu.org; 18 Oct 2021 10:46:11 +0000 Received: from localhost ([127.0.0.1]:46055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcQ9f-0000gS-Op for submit@debbugs.gnu.org; Mon, 18 Oct 2021 06:46:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:45838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcQ9a-0000gA-Qx for submit@debbugs.gnu.org; Mon, 18 Oct 2021 06:46:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcQ9a-0005wg-J8 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 06:46:02 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:41535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcQ9Z-00008V-26 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 06:46:02 -0400 Received: by mail-wr1-x435.google.com with SMTP id t2so40558277wrb.8 for ; Mon, 18 Oct 2021 03:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=4EJNnuYXb/Wku5AmgHYZhkmlXmwggGSv3yGnZscJVnc=; b=Gb3U0AHAyML4SSxMAU74IQFxyU5gwLnHfs7VleqsDJ+XqoUpzA9R2uFt4L89WF2RlA EidFUkVFopkqXJeIoMxNe08DTNGIvlPpLYhhQ6KuVVbk/V2pPCmhm/IwNJZVZH1oG73N pwId931FdZIMfriIAS6BH+vobxHXNa2eRNwHXZQFWeDHyJwdRPIfKu/2RLP+71MNBT8p jyqqHvVauG2GgHHE2HHwj3U0zOddwWxwJrt4S/H/S+bXFsVwHS097fOCFDeKhGKan6Ku OQYp93DU8AlloZgrhKd/1vNySKe/Ur/oa13PB2NpvjeG8U3DsyZL2cEIigBv1D14Tjbr TJRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=4EJNnuYXb/Wku5AmgHYZhkmlXmwggGSv3yGnZscJVnc=; b=BG/2ekpBKICZMf/A/H8S6p42efigMu2bO7k7en/sK2Y+Ry8eNBdkNRb60HC//mAy+X tV8GizSVAIwbKr4wFfrKqmiwQNWQKar2RlQSSY+I5sb69qkn/1T7recPeqNw2UT92S1z Em2HA/cOfXAyX/Nh9P2NlQ1Kq7vheV+jN2gQwnli20y+koyRskK5CRmAD86GzzNRdDSb uw6c4neaLyuBhpxhbIqwSUgUV0nD5kxLyAV/2VSoJMSn3p0LwUIzyQwnazlnRsuhGKNP 9cOEAUH9FmFxVoY6WDxuGpjdK5HqrwOXCGf4XxHDCj/tGwc4eajzAhuJeVQz3a0dMocA MB4Q== X-Gm-Message-State: AOAM532NkByK9smVgzb01i4YLhv3AgNlL7b8+N65nxilDgyhFsfOdwsW GyiF7JQhZwKmp+aQgtqLmlESpoakP/H54iQdnPjh01Bx X-Google-Smtp-Source: ABdhPJzjt5KpLRA72aYW/lJBYW0WJ4t/Q2zB8uaLitphq2Zv4eB4IJ2JNbleY9jDphJteZrbId3+8hgqApmJ+MbnW1Y= X-Received: by 2002:adf:a350:: with SMTP id d16mr34678749wrb.136.1634553958705; Mon, 18 Oct 2021 03:45:58 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= Date: Mon, 18 Oct 2021 12:45:48 +0200 Message-ID: Subject: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000133e8e05ce9e40e5" Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=jan.synacek@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000133e8e05ce9e40e5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 LS0gDQpKYW4gU3luw6HEjWVrDQo= --000000000000133e8e05ce9e40e5 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-use-color-escape-sequences-in-vc-git-expanded-.patch" Content-Disposition: attachment; filename="0001-Don-t-use-color-escape-sequences-in-vc-git-expanded-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kuwj7oac0 RnJvbSBhY2JmZWMzNjE3MDljNWVlYmFmYjlhOTU3ZTc2ZjcwNTAwMDgzY2YwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW4gU3luYWNlayA8amFuLnN5bmFjZWtAZ21haWwuY29tPgpE YXRlOiBNb24sIDE4IE9jdCAyMDIxIDEyOjM0OjM4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRG9u J3QgdXNlIGNvbG9yIGVzY2FwZSBzZXF1ZW5jZXMgaW4KIGB2Yy1naXQtZXhwYW5kZWQtbG9nLWVu dHJ5JwoKKiBsaXNwL3ZjL3ZjLWdpdC5lbCAodmMtZ2l0LWV4cGFuZGVkLWxvZy1lbnRyeSk6IFVz ZSAtLW5vLWNvbG9yIGluIGdpdAppbnZvY2F0aW9uLgoKQ29weXJpZ2h0LXBhcGVyd29yay1leGVt cHQ6IHllcwotLS0KIGxpc3AvdmMvdmMtZ2l0LmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC92Yy92Yy1naXQu ZWwgYi9saXNwL3ZjL3ZjLWdpdC5lbAppbmRleCAzNWMwODM4ZGQ2Li4zZjg5ZmFkMjM1IDEwMDY0 NAotLS0gYS9saXNwL3ZjL3ZjLWdpdC5lbAorKysgYi9saXNwL3ZjL3ZjLWdpdC5lbApAQCAtMTMy Myw3ICsxMzIzLDcgQEAgdmMtZ2l0LXNob3ctbG9nLWVudHJ5CiAKIChkZWZ1biB2Yy1naXQtZXhw YW5kZWQtbG9nLWVudHJ5IChyZXZpc2lvbikKICAgKHdpdGgtdGVtcC1idWZmZXIKLSAgICAoYXBw bHkgIyd2Yy1naXQtY29tbWFuZCB0IG5pbCBuaWwgKGxpc3QgImxvZyIgcmV2aXNpb24gIi0xIiAi LS0iKSkKKyAgICAoYXBwbHkgIyd2Yy1naXQtY29tbWFuZCB0IG5pbCBuaWwgKGxpc3QgImxvZyIg cmV2aXNpb24gIi0xIiAgIi0tbm8tY29sb3IiICItLSIpKQogICAgIChnb3RvLWNoYXIgKHBvaW50 LW1pbikpCiAgICAgKHVubGVzcyAoZW9icCkKICAgICAgIDs7IEluZGVudCB0aGUgZXhwYW5kZWQg bG9nIGVudHJ5LgotLSAKMi4zMy4wCgo= --000000000000133e8e05ce9e40e5-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 01:16:21 2021 Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 05:16:21 +0000 Received: from localhost ([127.0.0.1]:49086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mchU4-0003px-Tf for submit@debbugs.gnu.org; Tue, 19 Oct 2021 01:16:21 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:45658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mchU1-0003pJ-EV for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 01:16:17 -0400 Received: by mail-pg1-f175.google.com with SMTP id f5so18262161pgc.12 for <51262@debbugs.gnu.org>; Mon, 18 Oct 2021 22:16:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=jMyyBk1Vc4UZpozWoI7YkG0ybOhQRJiiqEfqPT+yJ+M=; b=F08g4gw7Pz3uNpZ+1vOfm1dFxQdH5cWxhM19H7O3av/CiQ6Du4dOw8hT54fJGtHZUk HbnW0HtvOza3Nmfc5M9FeuFwiZbxXOkg5V40WKfc0eXgRAk4TOErLpIVyG5Ci7KUeNk4 ZSjq9RYRKvTp17eVFGihy1XK5BENFCKRqum7Rit6IYwOytJBfZ/Sfm8h7na+U2uNTDKp MBKJNSmjNsR92YRkewEYQ+RZacxE0/2CBbB+23k96al4YtY/gOXmQPBb+X72AjUXMTOZ 4WHJZEgDAjV6JrXIEVRZlJd0Yi0UBLfQdMiSdZf38S1pDPIITIx11cYJpnlHWRAjEns8 ksuA== X-Gm-Message-State: AOAM532jciVpuV7TY0hfqdXbS7unuRYw78VnWNJ41OoPYOUBZR2pHyIz LdfOFwwv/d4EuFA5Jx+lhBRPt5qFlNr2kmN2xtgxTRmV X-Google-Smtp-Source: ABdhPJwBoyeMrNWcF/Ixu7Cd7xrMzFzsmZWReYhacTwaZC2GbFKQ5GonlhVg+7CbFtrgW76bS2GPI9NLD8KpXxhDcd4= X-Received: by 2002:a63:9d06:: with SMTP id i6mr27248207pgd.42.1634620571832; Mon, 18 Oct 2021 22:16:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 18 Oct 2021 22:16:11 -0700 From: Stefan Kangas In-Reply-To: =?UTF-8?Q?=3CCACA=2B5f3dQ69DkeFf997zrs8wAQFYd1GJ5cGt6icEBYeH1w?= =?UTF-8?Q?P30A=40mail=2Egmail=2Ecom=3E_=28=22Jan_Syn=C3=A1=C4=8Dek=22=27s_message_of_=22Mon=2C_18_?= =?UTF-8?Q?Oct_2021_12=3A45=3A48_=2B0200=22=29?= References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 18 Oct 2021 22:16:11 -0700 Message-ID: Subject: Re: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' To: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51262 Cc: 51262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Jan Syn=C3=A1=C4=8Dek writes: > From acbfec361709c5eebafb9a957e76f70500083cf0 Mon Sep 17 00:00:00 2001 > From: Jan Synacek > Date: Mon, 18 Oct 2021 12:34:38 +0200 > Subject: [PATCH] Don't use color escape sequences in > `vc-git-expanded-log-entry' > > * lisp/vc/vc-git.el (vc-git-expanded-log-entry): Use --no-color in git > invocation. > > Copyright-paperwork-exempt: yes > --- > lisp/vc/vc-git.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index 35c0838dd6..3f89fad235 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1323,7 +1323,7 @@ vc-git-show-log-entry > > (defun vc-git-expanded-log-entry (revision) > (with-temp-buffer > - (apply #'vc-git-command t nil nil (list "log" revision "-1" "--")) > + (apply #'vc-git-command t nil nil (list "log" revision "-1" "--no-c= olor" "--")) > (goto-char (point-min)) > (unless (eobp) > ;; Indent the expanded log entry. Thanks for the patch. Could you add some details here, such as what problem it is supposed to fix? How can I reproduce the issue here, starting from emacs -Q? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 04:15:43 2021 Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 08:15:43 +0000 Received: from localhost ([127.0.0.1]:49328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckHf-00024u-J5 for submit@debbugs.gnu.org; Tue, 19 Oct 2021 04:15:43 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:39934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckHd-00024e-Vj for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 04:15:42 -0400 Received: by mail-wr1-f41.google.com with SMTP id r18so46157147wrg.6 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 01:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9KrQ3XDtBbseaGJ6in3aDZuxBUuWtKJVA5mz+zMU2bI=; b=jwYjEJz+bU+cHHh9/y6gnnRpA6wvI7Xw9F/yBwqsKUfKxuargn0si97KKLi//bT7GR DJVKccjttN4wp0pJ1Mn2cBnanZmk8cfGUnwY6gS2KPPnz+DjP6DadcrRSehQU80n/g1z qPcJgJSl3eZdYYqDwcf0O+Eixa8EvtyMVrF7B8jcEUgoAIKOhLY79L7Si3qyURNRAiuQ EKspWMyjeNPZF0IeNPh4OPYbqJj0JhkkmT/3kDG4swcMfwZTS6fOwtUitX8KjhZRBVzN UlwBS7CpB6ZI0+W+BkVNVFflqSHAJH2NML35I1pg7K3Vov3PKVXWRtdEYvtR7jyPvVzc vUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9KrQ3XDtBbseaGJ6in3aDZuxBUuWtKJVA5mz+zMU2bI=; b=MwxdXcQ0F7ToDCR6MOa9tzI3IdglUIkUcYGDUX/qcNtjvmCmkbNqo4TBscrEp+wM50 QyhjGSH58TzUyB6e9rkHDtE22A5JYDevcB89CYOKYoM6fybsdK16ikSrVhKjKjZmvBK4 KeI+5CzoLLvf+ZLcjYeNmci0ZGYFfPJWPmfdZiIi/MoD2uL+oQbyYuPDychDbAIWVAEI 6Yl519nSxXQ/RUuQOCWYxNQLfrMkbFSxgAHjbbohU35UXpxwMBZsc5zHZZO2PTpRFGFt q7zJVPPtr/wTYADX8FL08vLFNgs6SvnPWpptcLTINXShxDzYgQr0Was4e9/OhCcXneq/ g1SA== X-Gm-Message-State: AOAM532btCbw8te/lh+Fi5hx08u1zOzRvXaDEaOFw8IF3Pg28Gy0JbZM WMbgp6Cl57r6/RbSvDff3iRktyU0bHrti/oCQ1M= X-Google-Smtp-Source: ABdhPJwR+A2BiVJlHlbNQ86vtDoKqsLt+IxBVA9gzTw87jpMt61ysJElmfS9N7yfRpMlgoYo6tnypystL92IX/V+964= X-Received: by 2002:a5d:6484:: with SMTP id o4mr43757033wri.337.1634631336027; Tue, 19 Oct 2021 01:15:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= Date: Tue, 19 Oct 2021 10:15:25 +0200 Message-ID: Subject: Re: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' To: Stefan Kangas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51262 Cc: 51262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Oct 19, 2021 at 7:16 AM Stefan Kangas wrote: > ... > > Could you add some details here, such as what problem it is supposed to > fix? How can I reproduce the issue here, starting from emacs -Q? Sure. Sorry for not doing it earlier. For some reason, I assumed that this = was obvious. Here's the reproducer (built from the latest commit on the emacs-28 branch)= : 1) mkdir /tmp/test 2) cd /tmp/test/ 3) git init 4) echo data > file.txt 5) git add file.txt 6) git commit -m "first commit" 7) emacs -Q 8) 9) 10) This is what I see on my system (I hope that gmail doesn't remove the escap= es): * (HEAD -> master)520684e..: Jan Synacek 2021-10-19 first commit ^[[33mcommit 520684e773918234874a35738b094ca39b63a822^[ [m Author: Jan Synacek Date: Tue Oct 19 10:04:02 2021 +0200 first commit It might be dependent on git configuration, but I think it's safe to assume= that there might be escape sequences and simply use --no-color. And that's what my patch does. Regards, --=20 Jan Syn=C3=A1=C4=8Dek From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 04:34:04 2021 Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 08:34:05 +0000 Received: from localhost ([127.0.0.1]:49362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckZQ-0002Zx-Jj for submit@debbugs.gnu.org; Tue, 19 Oct 2021 04:34:04 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:44591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckZO-0002ZL-OH for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 04:34:03 -0400 Received: by mail-pg1-f174.google.com with SMTP id c4so11632865pgv.11 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 01:34:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z1H1HlRfGxNyoGeoBt8tqIdccqvOvjr90a2oKzJh6NE=; b=IohRFOPvoveMSccJeTaxcY1BiAA7Mj8UCNYAJ71j16d2dR0lndzTTRbWhdd+8Ot08T 5Z+9Lfkh9lGgczbPDmmp8PXOtTjd5js18P11+9hewTM6lfCNFPxhu5l6ro3nNQrrRSfX sRCY1HwAJjfs1cr7hnwA+L1UWg2CqttX+oW/VzbEKfjrtfU0ItJVCOU69oH2NdU/pCP4 b8Vv7eEIsKCMAoCD1gljFQxZFHhyC9llsHr+6t8hHiY5PzYb3bHKIf9qXyKDcYD1rR/X Hi94fQQRVUSRrZcPbK8zRrKDXwVWLKnf20wwrmF43lY1HqiqBWhsTQVPdUJlyxDrLshs MJOg== X-Gm-Message-State: AOAM530hLbCL1FE9/5+VJ/rjrsY/Ur63u3cldNg2W9icONSGBTMkW0Kw zLPMJSVahGnhZfCC1f1mtV4JHrC5georQzc8ecI= X-Google-Smtp-Source: ABdhPJywd7za0ijviUxczKm8INB4zBr1SCxxI0E6Q3E7pWWdBwPm4KyHAFNjJCs4z0klT+RFHqCapO1aUlhR3vS5SJg= X-Received: by 2002:a05:6a00:1950:b0:44d:9402:3396 with SMTP id s16-20020a056a00195000b0044d94023396mr27114531pfk.70.1634632436758; Tue, 19 Oct 2021 01:33:56 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 Oct 2021 01:33:56 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Tue, 19 Oct 2021 01:33:56 -0700 Message-ID: Subject: Re: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' To: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51262 Cc: 51262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Jan Syn=C3=A1=C4=8Dek writes: > Sure. Sorry for not doing it earlier. For some reason, I assumed that thi= s was > obvious. Thanks. > Here's the reproducer (built from the latest commit on the emacs-28 branc= h): (I just used the emacs.git repository here.) > 7) emacs -Q > 8) > 9) > 10) > > This is what I see on my system (I hope that gmail doesn't remove the esc= apes): > > * (HEAD -> master)520684e..: Jan Synacek 2021-10-19 first commit > ^[[33mcommit 520684e773918234874a35738b094ca39b63a822^[ [m > Author: Jan Synacek > Date: Tue Oct 19 10:04:02 2021 +0200 > > first commit Here, I actually see the colours, and no escape sequences. The question is what is different in our setups. Could you post the output of M-x report-emacs-bug? Is there anything in your ~/.gitconfig that could be causing this? > It might be dependent on git configuration, but I think it's safe to assu= me that > there might be escape sequences and simply use --no-color. And that's wha= t > my patch does. I agree that you shouldn't need to see those escape sequences, but it would be better if we could narrow it down so we don't have to remove colours for everyone. The first step is to try to figure out what it is that makes you see control sequences where I get colours. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 04:54:03 2021 Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 08:54:03 +0000 Received: from localhost ([127.0.0.1]:49386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcksl-000384-0L for submit@debbugs.gnu.org; Tue, 19 Oct 2021 04:54:03 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:42534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcksg-00037W-Bs for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 04:54:02 -0400 Received: by mail-wr1-f52.google.com with SMTP id v17so46297002wrv.9 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 01:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=45qez4I9YxaZKlawLyZwMIgs/qQBMi0JM1rOQXenSIQ=; b=POobRIGJtnJ0KzhJc6wQ++o+i1yU4u59RcwmDUxUZGSyhbadrI6J0MiXx+FArfisv0 scSuN+N5t4bMogHdsQVCjP6hOwv83gB0deJ8gWwu95FFoal/auhj9t1VDXeVcKJF7Xea 2R72nT1rxpeiM0xM9b9ZcG6LO0+lf8v0tZ3a7CRvlgINE4/NYHjUiZR6g3OoTitDaLaS X0eCs3LFaRZF2yJyNzT6e/LOCbRopya3z/pxIwfjakcslRNln21+taVbyMXZRtD8On5s Nd1T3b//34H8AYimzFg+tVZ2JxKWd5bsm392GUaVoNVw/5D1LP3lZXnDU2gC5UlbyNrH +krA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=45qez4I9YxaZKlawLyZwMIgs/qQBMi0JM1rOQXenSIQ=; b=ZN6FPGVkj0KMusJ+d7oIZvOS86uN9IkMZy1XcA8MDQN89ijxXRwp5jlAwQJ6AyAma0 cau8lgivOxef16Q52wy+xWdlGRGEWRWja5TX4+iwgSzmyCJJ7YMsdt1EdkB2zLT2Phfz PuVQILQiJ7fqb+NoF2n0dq2eqLiaUyR+plnyfYKXx/+R0VuqAre/drFL6rU3x1woYz50 TvoVdI/n6ofJCikPgTSVDV7Ss3f2QtruFRP4/Y0Hs97g66uUQfDTEKDQQFL0Rs8pfUSK WU3ZkLYkNJUEi8W78lSayz76/Iik9wv0TC8m5M0KOeu33PyXmqfru560b/Nz87LC09dl K3BQ== X-Gm-Message-State: AOAM533zoDLoDrUtFhRWtzHxoNNib444+FXEo/Xt9mXhL674orS3VUA/ RfwT6lKbfvWWp4JGz5+NV6UmPVxVaKJG8N5/QHk= X-Google-Smtp-Source: ABdhPJwisxeqUb5r3PaiiU+/c/KWvr1OWLrmwvZ5j+3fCgFHb7OGPKEFDMBMBnlfP9NxlBskQiZ+5EiE/hC+2VOh6FE= X-Received: by 2002:a5d:6484:: with SMTP id o4mr43958273wri.337.1634633632513; Tue, 19 Oct 2021 01:53:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= Date: Tue, 19 Oct 2021 10:53:41 +0200 Message-ID: Subject: Re: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' To: Stefan Kangas Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51262 Cc: 51262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Oct 19, 2021 at 10:33 AM Stefan Kangas wrote: > > ... > > This is what I see on my system (I hope that gmail doesn't remove the escapes): > > > > * (HEAD -> master)520684e..: Jan Synacek 2021-10-19 first commit > > ^[[33mcommit 520684e773918234874a35738b094ca39b63a822^[ [m > > Author: Jan Synacek > > Date: Tue Oct 19 10:04:02 2021 +0200 > > > > first commit > > Here, I actually see the colours, and no escape sequences. Colors as in interpreted escape sequences? > The question is what is different in our setups. Could you post the > output of M-x report-emacs-bug? Is there anything in your ~/.gitconfig > that could be causing this? > > > It might be dependent on git configuration, but I think it's safe to assume that > > there might be escape sequences and simply use --no-color. And that's what > > my patch does. > > I agree that you shouldn't need to see those escape sequences, but it > would be better if we could narrow it down so we don't have to remove > colours for everyone. The first step is to try to figure out what it is > that makes you see control sequences where I get colours. It looks like the following part of my ~/.gitconfig triggers the issue: ... [color] ui = always ... Here's the outupt of report-emacs-bug: In GNU Emacs 28.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-10-19 built on jsynacek-home Repository revision: 66fbd5527335cb3136b65ed3644e5a8b151add32 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Arch Linux Configured using: 'configure --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core eieio-loaddefs password-cache json map text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail comp comp-cstr warnings subr-x rx cl-seq cl-macs rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils add-log log-view pcvs-util cl-extra help-mode seq byte-opt gv bytecomp byte-compile cconv vc-mtn vc-hg vc-git diff-mode easy-mmode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc vc-dispatcher dired-aux cl-loaddefs cl-lib dired dired-loaddefs iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 109429 5832) (symbols 48 9402 1) (strings 32 28203 1960) (string-bytes 1 908834) (vectors 16 19670) (vector-slots 8 345815 11442) (floats 8 30 53) (intervals 56 354 0) (buffers 992 14)) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 14:01:10 2021 Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 18:01:10 +0000 Received: from localhost ([127.0.0.1]:51914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mctQE-000878-Ax for submit@debbugs.gnu.org; Tue, 19 Oct 2021 14:01:10 -0400 Received: from mail-pj1-f45.google.com ([209.85.216.45]:56015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mctQ8-00086L-IP for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 14:01:09 -0400 Received: by mail-pj1-f45.google.com with SMTP id om14so540021pjb.5 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 11:01:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=YclT5OSLDft3DnUWF1tknHSxiaNccpBwzqyoAk6K0RM=; b=VuSlNGgKQfU8QTnoawho6UXjWkWRwWih1OzTUESFqVO9IW62xXOYa09lLnZ8TB6yTr 2u+T2NmQoulcprNewTBSgIyDmKMdKSDEST+Qm7YWUlcsC/U+NBaMXz/U1K9SslyVHHhc cq94lEFbUJfBIlo/d7aTlFi5waBtPAoRCg/kkcqO/QoAM0ReMOleMIcEgct8Pq7PtZ8r 1H19fqeSTnPWqTuylYsgrZCgc5FTP61Gfuz5gQkquL9YYlRTO3RlkLkzAXkqR3P9vMLm nLa0Ch9z/2NCelDLKotA2bk2+3rAQPuL8qOL+QCWqa8ATRpXGybV8cNKs10YaR1BCIoT rjfA== X-Gm-Message-State: AOAM533F8htN83M55pnCmP8jKp3j1uXjkCd2ISnZmJPhi2ZTA4QtMGqh uulvTmObUC+jxHmbJiDF8sH/4XKACYLqBXDNFPo= X-Google-Smtp-Source: ABdhPJzhp3RfKAwVxUrMDJvwql5hefQDfzpUp26M2BP9idiOteQtCArqDHL//GXCXdOY0OquU2Wf1iOByvPcu6+GdoI= X-Received: by 2002:a17:902:c1cb:b0:13f:8e99:2158 with SMTP id c11-20020a170902c1cb00b0013f8e992158mr28094231plc.32.1634666458483; Tue, 19 Oct 2021 11:00:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 Oct 2021 11:00:57 -0700 From: Stefan Kangas In-Reply-To: =?UTF-8?B?PENBQ0ErNWYwTVRBM3hTNVk3WFJDdStUa3JtbnVMQmpoUlQteXlLV19rNG1EV04t?= =?UTF-8?B?ODB0Z0BtYWlsLmdtYWlsLmNvbT4gKCJKYW4gU3luw6HEjWVrIidzIG1lc3NhZ2Ugb2YgIlR1ZSwgMTkg?= =?UTF-8?B?T2N0IDIwMjEgMTA6NTM6NDEgKzAyMDAiKQ==?= References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 19 Oct 2021 11:00:57 -0700 Message-ID: Subject: Re: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' To: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51262 Cc: 51262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 51262 28.1 thanks Jan Syn=C3=A1=C4=8Dek writes: > It looks like the following part of my ~/.gitconfig triggers the issue: > ... > [color] > ui =3D always Aha, so that's the culprit. Presumably without that, git detects that it's a "dumb" terminal and doesn't output any color escape sequences. > Colors as in interpreted escape sequences? That was my first assumption, but it's actually just font-locking. It seems like your proposed patch does fix the reported issue, and I could see no other adverse effects; the colors are there there even with your patch. I have therefore now pushed this to the emacs-28 branch (commit 5c1a575ef4) with some minor touch-ups to the commit message. I'm therefore closing this bug report. Thanks again for the bug report and patch! From unknown Sat Jun 14 19:13:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 Nov 2021 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator