GNU bug report logs - #51176
eww switch buffer by title

Previous Next

Full log

Message #53 received at 51176 <at> debbugs.gnu.org (full text, mbox):

From: miha <at> kamnitnik.top
To: Protesilaos Stavrou <info <at> protesilaos.com>, Lars Ingebrigtsen
 <larsi <at> gnus.org>
Cc: 51176 <at> debbugs.gnu.org, Yuchen Pei <hi <at> ypei.me>,
 Abhiseck Paira <abhiseckpaira <at> disroot.org>, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#51176: eww switch buffer by title
Date: Fri, 15 Oct 2021 10:32:55 +0200

[Message part 1 (text/plain, inline)]

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Hello again!
>
> Please find attached the patch which implements a renaming scheme for
> EWW buffers.

Thanks.

> I include Abhiseck, the co-author of this patch, in Cc.
>
> What do you think?
>
> We had entertained the notion of a single defcustom with more options,
> but ultimately decided against it on the grounds that it was more
> complex.
>
> -- 
> Protesilaos Stavrou
> https://protesilaos.com
> @@ -556,6 +580,8 @@ (defun eww-render (status url &optional point buffer encode)
> +            (and eww-auto-rename-buffer-flag
> +                 (funcall eww-auto-rename-buffer-function))
>  	    (run-hooks 'eww-after-render-hook)))

With your patch, the buffer isn't renamed if the user presses "l" or "r"
to go backward and forward in history. I suggest calling your rename
function from 'eww-update-header-line-format' instead.

Best regards.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.