Subject: bug#51173: 28.0.60; gnus-article-describe-key doesn't work

From: Juri Linkov <[email-masked]>
Date: Tue, 30 Nov 2021 10:54:27 +0200

>>   mouse-minibuffer-check(19)
>>   mouse-set-point(19)
>>   help--analyze-key("\23" [19] nil)
>
> Hpw 'bout the patch below?

I confirm that the patch fixes this regression,
while not breaking other cases.

Maybe this patch also obsoletes this code in the same place:

                       ;; Clicks on the menu bar produce "event" that
                       ;; is just '(menu-bar)', for which
                       ;; `mouse-set-point' is not useful.
                       (and (not (windowp (posn-window (event-start event))))
                            (not (framep (posn-window (event-start event)))))

While testing with this code removed, clicks on the menu bar still work
without errors.

> Or maybe the use of `mouse-minibuffer-check` in `mouse-set-point` should
> be moved to its interactive spec?

I agree with Eli that more cardinal changes could be tried only in master.