From unknown Mon Aug 18 07:45:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51172: Fix null-dereference warnings when compiling Emacs with GCC Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Oct 2021 00:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 51172@debbugs.gnu.org X-Debbugs-Original-To: Emacs bug reports Received: via spool by submit@debbugs.gnu.org id=B.163408531411268 (code B ref -1); Wed, 13 Oct 2021 00:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Oct 2021 00:35:14 +0000 Received: from localhost ([127.0.0.1]:56315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maSEj-0002vf-Qi for submit@debbugs.gnu.org; Tue, 12 Oct 2021 20:35:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:56210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maSEh-0002vV-Iy for submit@debbugs.gnu.org; Tue, 12 Oct 2021 20:35:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maSEg-0004zy-A0 for bug-gnu-emacs@gnu.org; Tue, 12 Oct 2021 20:35:10 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maSEc-0004zF-PW for bug-gnu-emacs@gnu.org; Tue, 12 Oct 2021 20:35:09 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 220CD1600AE for ; Tue, 12 Oct 2021 17:35:04 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id R6_Up2ScXSN1 for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 622E01600F1 for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DfQaV3QSnqyY for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 39C111600AE for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Fw7dwaWYqJog3cfHBy63dj3c" Message-ID: <8f0a62f5-dd46-ca3b-a1e7-3a1b9b85da49@cs.ucla.edu> Date: Tue, 12 Oct 2021 17:34:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------Fw7dwaWYqJog3cfHBy63dj3c Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The attached patch against emacs-28 suppresses the final remaining GCC 11.2.1 diagnostics that are emitted after emacs-28 is configured with --enable-gcc-warnings on x86-64. The patch is benign, and it's conceivable that changing xmalloc etc. to always return nonnull fixes unlikely and obscure bugs (though I haven't checked this). However, I didn't install the patch into the emacs-28 branch on the off-chance that Eli would prefer this sort of thing to be installed into the master branch. --------------Fw7dwaWYqJog3cfHBy63dj3c Content-Type: text/x-patch; charset=UTF-8; name="0001-Pacify-GCC-Wanalyzer-possible-null-dereference.patch" Content-Disposition: attachment; filename*0="0001-Pacify-GCC-Wanalyzer-possible-null-dereference.patch" Content-Transfer-Encoding: base64 RnJvbSAyYWNjZjQ5NzUzZmUxNTFhNTNkNDg1YzQ3NTZkZGM5MmQ1M2QwYjNmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDEyIE9jdCAyMDIxIDE3OjI1OjU0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gUGFjaWZ5IEdDQyAtV2FuYWx5emVyLXBvc3NpYmxlLW51bGwtZGVyZWZlcmVuY2UKTUlN RS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04 CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKClRoaXMgZml4ZXMgdGhlIG9ubHkg cmVtYWluaW5nIEdDQyBkaWFnbm9zdGljcyB3aGVuIGVtYWNzLTI4IGlzCmNvbmZpZ3VyZWQg d2l0aCAtLWVuYWJsZS1nY2Mtd2FybmluZ3MuICBJdCBkb2VzIHNvIGJ5IGFkZGluZwpBVFRS SUJVVEVfUkVUVVJOU19OT05OVUxMIHNvIHRoYXQgR0NDIGtub3dzIGNlcnRhaW4gZnVuY3Rp b25zCnJldHVybiBub25udWxsLiAgSXQgYWxzbyBhcnJhbmdlcyBmb3IgdGhyZWUgb2YgdGhv c2UgZnVuY3Rpb25zIHRvCmFsd2F5cyByZXR1cm4gbm9ubnVsbDsgSSB0aG91Z2h0IHRoZXNl IGZ1bmN0aW9ucyBhbHJlYWR5IHdlcmUKZG9pbmcgc28sIGJ1dCBhcHBhcmVudGx5IG5vdCwg YW5kIGl0IGlzIGNvbmNlaXZhYmxlICh0aG91Z2ggSQpoYXZlbuKAmXQgY2hlY2tlZCB0aGlz KSB0aGF0IGNoYW5naW5nIHRoZXNlIGZ1bmN0aW9ucyB0byBhbHdheXMKcmV0dXJuIG5vbm51 bGwgZXZlbiBvbiBub24tR05VIHBsYXRmb3JtcyBtYXkgZml4IHVubGlrZWx5CnBvcnRhYmls aXR5IGJ1Z3MgZWxzZXdoZXJlIGluIEVtYWNzLiAgSSB1c2VkIEdDQyAxMS4yLjEgMjAyMTA3 MjgKKFJlZCBIYXQgMTEuMi4xLTEpIG9uIHg4Ni02NCB3aGVuIGNoZWNraW5nIHRoZSBkaWFn bm9zdGljcy4KKiBzcmMvYWxsb2MuYyAoeG1hbGxvYywgeHphbGxvYywgeHJlYWxsb2MpOiBE b27igJl0IHdvcnJ5IGFib3V0IHRoZQpzcGVjaWFsIGNhc2Ugd2hlcmUgU0laRSA9PSAwLCBz aW5jZSBsbWFsbG9jIGFuZCBscmVhbGxvYyBub3cKcmV0dXJuIG51bGwgb25seSBvbiBhbGxv Y2F0aW9uIGZhaWx1cmUuCihsbWFsbG9jLCBscmVhbGxvYyk6IFJldHVybiBudWxsIG9ubHkg b24gYWxsb2NhdGlvbiBmYWlsdXJlLAppbnN0ZWFkIG9mIGhhdmluZyBzcGVjaWFsIGNhc2Vz IHRoYXQgdHJlYXQgbWFsbG9jICgwKSBhbmQKcmVhbGxvYyAoWCwgMCkgYXMgc3VjY2Vzc2Vz IGV2ZW4gd2hlbiB0aGV5IHJldHVybiBudWxsLgoqIHNyYy9saXNwLmg6IEFkZCBBVFRSSUJV VEVfUkVUVVJOU19OT05OVUxMIHRvIGEgZmV3IGZ1bmN0aW9ucwp0aGF0IGFsd2F5cyByZXR1 cm4gbm9ubnVsbCBwb2ludGVycywgc28gdGhhdCBnY2MgLWZhbmFseXplcgpkb2VzIG5vdCBp c3N1ZSBkaWFnbm9zdGljcyBsaWtlIOKAnGFsbG9jLmM6IEluIGZ1bmN0aW9uCuKAmGFsbG9j YXRlX3ZlY3Rvcl9ibG9ja+KAmTogYWxsb2MuYzoyOTg1OjE1OiB3YXJuaW5nOiBkZXJlZmVy ZW5jZSBvZgpwb3NzaWJseS1OVUxMIOKAmGJsb2Nr4oCZIFtDV0UtNjkwXSBbLVdhbmFseXpl ci1wb3NzaWJsZS1udWxsLWRlcmVmZXJlbmNlXeKAnQphcyBwZXIgPGh0dHBzOi8vY3dlLm1p dHJlLm9yZy9kYXRhL2RlZmluaXRpb25zLzY5MC5odG1sPi4KLS0tCiBzcmMvYWxsb2MuYyB8 IDQwICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KIHNyYy9saXNw LmggIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDM1IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9hbGxvYy5jIGIvc3JjL2FsbG9jLmMKaW5kZXggMGMw NGQ1Y2RlMC4uYjFmODA2NGE5ZCAxMDA2NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3Jj L2FsbG9jLmMKQEAgLTc2NSw3ICs3NjUsNyBAQCB4bWFsbG9jIChzaXplX3Qgc2l6ZSkKICAg dmFsID0gbG1hbGxvYyAoc2l6ZSwgZmFsc2UpOwogICBNQUxMT0NfVU5CTE9DS19JTlBVVDsK IAotICBpZiAoIXZhbCAmJiBzaXplKQorICBpZiAoIXZhbCkKICAgICBtZW1vcnlfZnVsbCAo c2l6ZSk7CiAgIE1BTExPQ19QUk9CRSAoc2l6ZSk7CiAgIHJldHVybiB2YWw7CkBAIC03ODIs NyArNzgyLDcgQEAgeHphbGxvYyAoc2l6ZV90IHNpemUpCiAgIHZhbCA9IGxtYWxsb2MgKHNp emUsIHRydWUpOwogICBNQUxMT0NfVU5CTE9DS19JTlBVVDsKIAotICBpZiAoIXZhbCAmJiBz aXplKQorICBpZiAoIXZhbCkKICAgICBtZW1vcnlfZnVsbCAoc2l6ZSk7CiAgIE1BTExPQ19Q Uk9CRSAoc2l6ZSk7CiAgIHJldHVybiB2YWw7CkBAIC03OTYsMTUgKzc5NiwxNSBAQCB4cmVh bGxvYyAodm9pZCAqYmxvY2ssIHNpemVfdCBzaXplKQogICB2b2lkICp2YWw7CiAKICAgTUFM TE9DX0JMT0NLX0lOUFVUOwotICAvKiBXZSBtdXN0IGNhbGwgbWFsbG9jIGV4cGxpY2l0bHkg d2hlbiBCTE9DSyBpcyAwLCBzaW5jZSBzb21lCi0gICAgIHJlYWxsb2NzIGRvbid0IGRvIHRo aXMuICAqLworICAvKiBDYWxsIG1hbGxvYyB3aGVuIEJMT0NLIGlzIG51bGwsCisgICAgIHNp bmNlIGxyZWFsbG9jIGRvZXMgbm90IGFsbG93IGEgbnVsbCBCTE9DSy4gICovCiAgIGlmICgh IGJsb2NrKQogICAgIHZhbCA9IGxtYWxsb2MgKHNpemUsIGZhbHNlKTsKICAgZWxzZQogICAg IHZhbCA9IGxyZWFsbG9jIChibG9jaywgc2l6ZSk7CiAgIE1BTExPQ19VTkJMT0NLX0lOUFVU OwogCi0gIGlmICghdmFsICYmIHNpemUpCisgIGlmICghdmFsKQogICAgIG1lbW9yeV9mdWxs IChzaXplKTsKICAgTUFMTE9DX1BST0JFIChzaXplKTsKICAgcmV0dXJuIHZhbDsKQEAgLTk4 OCw4ICs5ODgsNyBAQCByZWNvcmRfeG1hbGxvYyAoc2l6ZV90IHNpemUpCiAKIC8qIExpa2Ug bWFsbG9jIGJ1dCB1c2VkIGZvciBhbGxvY2F0aW5nIExpc3AgZGF0YS4gIE5CWVRFUyBpcyB0 aGUKICAgIG51bWJlciBvZiBieXRlcyB0byBhbGxvY2F0ZSwgVFlQRSBkZXNjcmliZXMgdGhl IGludGVuZGVkIHVzZSBvZiB0aGUKLSAgIGFsbG9jYXRlZCBtZW1vcnkgYmxvY2sgKGZvciBz dHJpbmdzLCBmb3IgY29uc2VzLCAuLi4pLgotICAgTkJZVEVTIG11c3QgYmUgcG9zaXRpdmUu ICAqLworICAgYWxsb2NhdGVkIG1lbW9yeSBibG9jayAoZm9yIHN0cmluZ3MsIGZvciBjb25z ZXMsIC4uLikuICAqLwogCiAjaWYgISBVU0VfTFNCX1RBRwogdm9pZCAqbGlzcF9tYWxsb2Nf bG9zZXIgRVhURVJOQUxMWV9WSVNJQkxFOwpAQCAtMTMzMCwxNiArMTMyOSwyMCBAQCBsYWxp Z25lZCAodm9pZCAqcCwgc2l6ZV90IHNpemUpCiAJICB8fCBzaXplICUgTElTUF9BTElHTk1F TlQgIT0gMCk7CiB9CiAKLS8qIExpa2UgbWFsbG9jIGFuZCByZWFsbG9jIGV4Y2VwdCB0aGF0 IGlmIFNJWkUgaXMgTGlzcC1hbGlnbmVkLCBtYWtlCi0gICBzdXJlIHRoZSByZXN1bHQgaXMg dG9vLCBpZiBuZWNlc3NhcnkgYnkgcmVhbGxvY2F0aW5nICh0eXBpY2FsbHkKLSAgIHdpdGgg bGFyZ2VyIGFuZCBsYXJnZXIgc2l6ZXMpIHVudGlsIHRoZSBhbGxvY2F0b3IgcmV0dXJucyBh Ci0gICBMaXNwLWFsaWduZWQgcG9pbnRlci4gIENvZGUgdGhhdCBuZWVkcyB0byBhbGxvY2F0 ZSBDIGhlYXAgbWVtb3J5CisvKiBMaWtlIG1hbGxvYyBhbmQgcmVhbGxvYyBleGNlcHQgcmV0 dXJuIG51bGwgb25seSBvbiBmYWlsdXJlLAorICAgdGhlIHJlc3VsdCBpcyBMaXNwLWFsaWdu ZWQgaWYgU0laRSBpcywgYW5kIGxyZWFsbG9jJ3MgcG9pbnRlcgorICAgYXJndW1lbnQgbXVz dCBiZSBub25udWxsLiAgQ29kZSBhbGxvY2F0aW5nIEMgaGVhcCBtZW1vcnkKICAgIGZvciBh IExpc3Agb2JqZWN0IHNob3VsZCB1c2Ugb25lIG9mIHRoZXNlIGZ1bmN0aW9ucyB0byBvYnRh aW4gYQogICAgcG9pbnRlciBQOyB0aGF0IHdheSwgaWYgVCBpcyBhbiBlbnVtIExpc3BfVHlw ZSB2YWx1ZSBhbmQgTCA9PQogICAgbWFrZV9saXNwX3B0ciAoUCwgVCksIHRoZW4gWFBOVFIg KEwpID09IFAgYW5kIFhUWVBFIChMKSA9PSBULgogCisgICBJZiBDTEVBUklULCBhcnJhbmdl IGZvciB0aGUgYWxsb2NhdGVkIG1lbW9yeSB0byBiZSBjbGVhcmVkLgorICAgVGhpcyBtaWdo dCB1c2UgY2FsbG9jLCBhcyBjYWxsb2MgY2FuIGJlIGZhc3RlciB0aGFuIG1hbGxvYyttZW1z ZXQuCisKICAgIE9uIHR5cGljYWwgbW9kZXJuIHBsYXRmb3JtcyB0aGVzZSBmdW5jdGlvbnMn IGxvb3BzIGRvIG5vdCBpdGVyYXRlLgotICAgT24gbm93LXJhcmUgKGFuZCBwZXJoYXBzIG5v bmV4aXN0ZW50KSBwbGF0Zm9ybXMsIHRoZSBsb29wcyBpbgorICAgT24gbm93LXJhcmUgKGFu ZCBwZXJoYXBzIG5vbmV4aXN0ZW50KSBwbGF0Zm9ybXMsIHRoZSBjb2RlIGNhbiBsb29wLAor ICAgcmVhbGxvY2F0aW5nICh0eXBpY2FsbHkgd2l0aCBsYXJnZXIgYW5kIGxhcmdlciBzaXpl cykgdW50aWwgdGhlCisgICBhbGxvY2F0b3IgcmV0dXJucyBhIExpc3AtYWxpZ25lZCBwb2lu dGVyLiAgVGhpcyBsb29wIGluCiAgICB0aGVvcnkgY291bGQgcmVwZWF0IGZvcmV2ZXIuICBJ ZiBhbiBpbmZpbml0ZSBsb29wIGlzIHBvc3NpYmxlIG9uIGEKICAgIHBsYXRmb3JtLCBhIGJ1 aWxkIHdvdWxkIHN1cmVseSBsb29wIGFuZCB0aGUgYnVpbGRlciBjYW4gdGhlbiBzZW5kCiAg ICB1cyBhIGJ1ZyByZXBvcnQuICBBZGRpbmcgYSBjb3VudGVyIHRvIHRyeSB0byBkZXRlY3Qg YW55IHN1Y2ggbG9vcApAQCAtMTM1Myw4ICsxMzU2LDEzIEBAIGxtYWxsb2MgKHNpemVfdCBz aXplLCBib29sIGNsZWFyaXQpCiAgIGlmICghIE1BTExPQ19JU19MSVNQX0FMSUdORUQgJiYg c2l6ZSAlIExJU1BfQUxJR05NRU5UID09IDApCiAgICAgewogICAgICAgdm9pZCAqcCA9IGFs aWduZWRfYWxsb2MgKExJU1BfQUxJR05NRU5ULCBzaXplKTsKLSAgICAgIGlmIChjbGVhcml0 ICYmIHApCi0JbWVtY2xlYXIgKHAsIHNpemUpOworICAgICAgaWYgKHApCisJeworCSAgaWYg KGNsZWFyaXQpCisJICAgIG1lbWNsZWFyIChwLCBzaXplKTsKKwl9CisgICAgICBlbHNlIGlm ICghIChNQUxMT0NfMF9JU19OT05OVUxMIHx8IHNpemUpKQorCXJldHVybiBhbGlnbmVkX2Fs bG9jIChMSVNQX0FMSUdOTUVOVCwgTElTUF9BTElHTk1FTlQpOwogICAgICAgcmV0dXJuIHA7 CiAgICAgfQogI2VuZGlmCkBAIC0xMzYyLDcgKzEzNzAsNyBAQCBsbWFsbG9jIChzaXplX3Qg c2l6ZSwgYm9vbCBjbGVhcml0KQogICB3aGlsZSAodHJ1ZSkKICAgICB7CiAgICAgICB2b2lk ICpwID0gY2xlYXJpdCA/IGNhbGxvYyAoMSwgc2l6ZSkgOiBtYWxsb2MgKHNpemUpOwotICAg ICAgaWYgKGxhbGlnbmVkIChwLCBzaXplKSkKKyAgICAgIGlmIChsYWxpZ25lZCAocCwgc2l6 ZSkgJiYgKE1BTExPQ18wX0lTX05PTk5VTEwgfHwgc2l6ZSB8fCBwKSkKIAlyZXR1cm4gcDsK ICAgICAgIGZyZWUgKHApOwogICAgICAgc2l6ZV90IGJpZ2dlciA9IHNpemUgKyBMSVNQX0FM SUdOTUVOVDsKQEAgLTEzNzcsNyArMTM4NSw3IEBAIGxyZWFsbG9jICh2b2lkICpwLCBzaXpl X3Qgc2l6ZSkKICAgd2hpbGUgKHRydWUpCiAgICAgewogICAgICAgcCA9IHJlYWxsb2MgKHAs IHNpemUpOwotICAgICAgaWYgKGxhbGlnbmVkIChwLCBzaXplKSkKKyAgICAgIGlmIChsYWxp Z25lZCAocCwgc2l6ZSkgJiYgKHNpemUgfHwgcCkpCiAJcmV0dXJuIHA7CiAgICAgICBzaXpl X3QgYmlnZ2VyID0gc2l6ZSArIExJU1BfQUxJR05NRU5UOwogICAgICAgaWYgKHNpemUgPCBi aWdnZXIpCmRpZmYgLS1naXQgYS9zcmMvbGlzcC5oIGIvc3JjL2xpc3AuaAppbmRleCA0ODBj Mzg5YTNiLi4zMTY1NmJiM2IxIDEwMDY0NAotLS0gYS9zcmMvbGlzcC5oCisrKyBiL3NyYy9s aXNwLmgKQEAgLTM5NDcsNyArMzk0Nyw4IEBAIGJ1aWxkX3N0cmluZyAoY29uc3QgY2hhciAq c3RyKQogCiBleHRlcm4gTGlzcF9PYmplY3QgcHVyZV9jb25zIChMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpOwogZXh0ZXJuIExpc3BfT2JqZWN0IG1ha2VfdmVjdG9yIChwdHJkaWZmX3Qs IExpc3BfT2JqZWN0KTsKLWV4dGVybiBzdHJ1Y3QgTGlzcF9WZWN0b3IgKmFsbG9jYXRlX25p bF92ZWN0b3IgKHB0cmRpZmZfdCk7CitleHRlcm4gc3RydWN0IExpc3BfVmVjdG9yICphbGxv Y2F0ZV9uaWxfdmVjdG9yIChwdHJkaWZmX3QpCisgIEFUVFJJQlVURV9SRVRVUk5TX05PTk5V TEw7CiAKIC8qIE1ha2UgYW4gdW5pbml0aWFsaXplZCB2ZWN0b3IgZm9yIFNJWkUgb2JqZWN0 cy4gIE5PVEU6IHlvdSBtdXN0CiAgICBiZSBzdXJlIHRoYXQgR0MgY2Fubm90IGhhcHBlbiB1 bnRpbCB0aGUgdmVjdG9yIGlzIGNvbXBsZXRlbHkKQEAgLTM5NjAsNyArMzk2MSw4IEBAIGJ1 aWxkX3N0cmluZyAoY29uc3QgY2hhciAqc3RyKQogCiAgICBhbGxvY2F0ZV92ZWN0b3IgaGFz IGEgc2ltaWxhciBwcm9ibGVtLiAgKi8KIAotZXh0ZXJuIHN0cnVjdCBMaXNwX1ZlY3RvciAq YWxsb2NhdGVfdmVjdG9yIChwdHJkaWZmX3QpOworZXh0ZXJuIHN0cnVjdCBMaXNwX1ZlY3Rv ciAqYWxsb2NhdGVfdmVjdG9yIChwdHJkaWZmX3QpCisgIEFUVFJJQlVURV9SRVRVUk5TX05P Tk5VTEw7CiAKIElOTElORSBMaXNwX09iamVjdAogbWFrZV91bmluaXRfdmVjdG9yIChwdHJk aWZmX3Qgc2l6ZSkKQEAgLTM5OTIsNyArMzk5NCw4IEBAIG1ha2VfbmlsX3ZlY3RvciAocHRy ZGlmZl90IHNpemUpCiB9CiAKIGV4dGVybiBzdHJ1Y3QgTGlzcF9WZWN0b3IgKmFsbG9jYXRl X3BzZXVkb3ZlY3RvciAoaW50LCBpbnQsIGludCwKLQkJCQkJCSAgZW51bSBwdmVjX3R5cGUp OworCQkJCQkJICBlbnVtIHB2ZWNfdHlwZSkKKyAgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVM TDsKIAogLyogQWxsb2NhdGUgdW5pbml0aWFsaXplZCBwc2V1ZG92ZWN0b3Igd2l0aCBubyBM aXNwX09iamVjdCBzbG90cy4gICovCiAKQEAgLTQwMjQsNyArNDAyNyw3IEBAICNkZWZpbmUg QUxMT0NBVEVfWkVST0VEX1BTRVVET1ZFQ1RPUih0eXBlLCBmaWVsZCwgdGFnKQkJICAgICAg IFwKIGV4dGVybiB2b2lkIGluaXRfYWxsb2Nfb25jZSAodm9pZCk7CiBleHRlcm4gdm9pZCBp bml0X2FsbG9jICh2b2lkKTsKIGV4dGVybiB2b2lkIHN5bXNfb2ZfYWxsb2MgKHZvaWQpOwot ZXh0ZXJuIHN0cnVjdCBidWZmZXIgKiBhbGxvY2F0ZV9idWZmZXIgKHZvaWQpOworZXh0ZXJu IHN0cnVjdCBidWZmZXIgKmFsbG9jYXRlX2J1ZmZlciAodm9pZCkgQVRUUklCVVRFX1JFVFVS TlNfTk9OTlVMTDsKIGV4dGVybiBpbnQgdmFsaWRfbGlzcF9vYmplY3RfcCAoTGlzcF9PYmpl Y3QpOwogCiAvKiBEZWZpbmVkIGluIGdtYWxsb2MuYy4gICovCkBAIC00MTgyLDcgKzQxODUs OCBAQCB4c2lnbmFsIChMaXNwX09iamVjdCBlcnJvcl9zeW1ib2wsIExpc3BfT2JqZWN0IGRh dGEpCiAgICAgKExpc3BfT2JqZWN0ICgqKSAocHRyZGlmZl90LCBMaXNwX09iamVjdCAqKSwg cHRyZGlmZl90LCBMaXNwX09iamVjdCAqLAogICAgICBMaXNwX09iamVjdCwgTGlzcF9PYmpl Y3QgKCopIChMaXNwX09iamVjdCwgcHRyZGlmZl90LCBMaXNwX09iamVjdCAqKSk7CiBleHRl cm4gTGlzcF9PYmplY3QgaW50ZXJuYWxfY2F0Y2hfYWxsIChMaXNwX09iamVjdCAoKikgKHZv aWQgKiksIHZvaWQgKiwgTGlzcF9PYmplY3QgKCopIChlbnVtIG5vbmxvY2FsX2V4aXQsIExp c3BfT2JqZWN0KSk7Ci1leHRlcm4gc3RydWN0IGhhbmRsZXIgKnB1c2hfaGFuZGxlciAoTGlz cF9PYmplY3QsIGVudW0gaGFuZGxlcnR5cGUpOworZXh0ZXJuIHN0cnVjdCBoYW5kbGVyICpw dXNoX2hhbmRsZXIgKExpc3BfT2JqZWN0LCBlbnVtIGhhbmRsZXJ0eXBlKQorICBBVFRSSUJV VEVfUkVUVVJOU19OT05OVUxMOwogZXh0ZXJuIHN0cnVjdCBoYW5kbGVyICpwdXNoX2hhbmRs ZXJfbm9zaWduYWwgKExpc3BfT2JqZWN0LCBlbnVtIGhhbmRsZXJ0eXBlKTsKIGV4dGVybiB2 b2lkIHNwZWNiaW5kIChMaXNwX09iamVjdCwgTGlzcF9PYmplY3QpOwogZXh0ZXJuIHZvaWQg cmVjb3JkX3Vud2luZF9wcm90ZWN0ICh2b2lkICgqKSAoTGlzcF9PYmplY3QpLCBMaXNwX09i amVjdCk7CkBAIC00MzIzLDkgKzQzMjcsMTAgQEAgWE1PRFVMRV9GVU5DVElPTiAoTGlzcF9P YmplY3QgbykKIAogLyogRGVmaW5lZCBpbiBmaWxlaW8uYy4gICovCiAKLWV4dGVybiBjaGFy ICpzcGxpY2VfZGlyX2ZpbGUgKGNoYXIgKiwgY2hhciBjb25zdCAqLCBjaGFyIGNvbnN0ICop OworZXh0ZXJuIGNoYXIgKnNwbGljZV9kaXJfZmlsZSAoY2hhciAqLCBjaGFyIGNvbnN0ICos IGNoYXIgY29uc3QgKikKKyAgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKIGV4dGVybiBi b29sIGZpbGVfbmFtZV9hYnNvbHV0ZV9wIChjb25zdCBjaGFyICopOwotZXh0ZXJuIGNoYXIg Y29uc3QgKmdldF9ob21lZGlyICh2b2lkKTsKK2V4dGVybiBjaGFyIGNvbnN0ICpnZXRfaG9t ZWRpciAodm9pZCkgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKIGV4dGVybiBMaXNwX09i amVjdCBleHBhbmRfYW5kX2Rpcl90b19maWxlIChMaXNwX09iamVjdCk7CiBleHRlcm4gTGlz cF9PYmplY3Qgd3JpdGVfcmVnaW9uIChMaXNwX09iamVjdCwgTGlzcF9PYmplY3QsIExpc3Bf T2JqZWN0LAogCQkJCSBMaXNwX09iamVjdCwgTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LApA QCAtNDQ3OSw3ICs0NDg0LDcgQEAgZmFzdF9zdHJpbmdfbWF0Y2hfaWdub3JlX2Nhc2UgKExp c3BfT2JqZWN0IHJlZ2V4cCwgTGlzcF9PYmplY3Qgc3RyaW5nKQogSU5MSU5FIHZvaWQgc3lu Y2hyb25pemVfc3lzdGVtX21lc3NhZ2VzX2xvY2FsZSAodm9pZCkge30KIElOTElORSB2b2lk IHN5bmNocm9uaXplX3N5c3RlbV90aW1lX2xvY2FsZSAodm9pZCkge30KICNlbmRpZgotZXh0 ZXJuIGNoYXIgKmVtYWNzX3N0cmVycm9yIChpbnQpOworZXh0ZXJuIGNoYXIgKmVtYWNzX3N0 cmVycm9yIChpbnQpIEFUVFJJQlVURV9SRVRVUk5TX05PTk5VTEw7CiBleHRlcm4gdm9pZCBz aHV0X2Rvd25fZW1hY3MgKGludCwgTGlzcF9PYmplY3QpOwogCiAvKiBUcnVlIG1lYW5zIGRv bid0IGRvIGludGVyYWN0aXZlIHJlZGlzcGxheSBhbmQgZG9uJ3QgY2hhbmdlIHR0eSBtb2Rl cy4gICovCkBAIC00NTQ1LDcgKzQ1NTAsNyBAQCAjZGVmaW5lIERBRU1PTl9SVU5OSU5HICh3 MzJfZGFlbW9uX2V2ZW50ICE9IElOVkFMSURfSEFORExFX1ZBTFVFKQogCiBleHRlcm4gaW50 IGVtYWNzX3NwYXduIChwaWRfdCAqLCBpbnQsIGludCwgaW50LCBjaGFyICoqLCBjaGFyICoq LAogICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqLCBjb25zdCBjaGFyICos IGNvbnN0IHNpZ3NldF90ICopOwotZXh0ZXJuIGNoYXIgKiptYWtlX2Vudmlyb25tZW50X2Js b2NrIChMaXNwX09iamVjdCk7CitleHRlcm4gY2hhciAqKm1ha2VfZW52aXJvbm1lbnRfYmxv Y2sgKExpc3BfT2JqZWN0KSBBVFRSSUJVVEVfUkVUVVJOU19OT05OVUxMOwogZXh0ZXJuIHZv aWQgaW5pdF9jYWxscHJvY18xICh2b2lkKTsKIGV4dGVybiB2b2lkIGluaXRfY2FsbHByb2Mg KHZvaWQpOwogZXh0ZXJuIHZvaWQgc2V0X2luaXRpYWxfZW52aXJvbm1lbnQgKHZvaWQpOwpA QCAtNDgxNCwxNyArNDgxOSwyNCBAQCBTVUJSX05BVElWRV9DT01QSUxFRF9EWU5QIChMaXNw X09iamVjdCBhKQogZXh0ZXJuIGNoYXIgbXlfZW5kYnNzW107CiBleHRlcm4gY2hhciAqbXlf ZW5kYnNzX3N0YXRpYzsKIAotZXh0ZXJuIHZvaWQgKnhtYWxsb2MgKHNpemVfdCkgQVRUUklC VVRFX01BTExPQ19TSVpFICgoMSkpOwotZXh0ZXJuIHZvaWQgKnh6YWxsb2MgKHNpemVfdCkg QVRUUklCVVRFX01BTExPQ19TSVpFICgoMSkpOwotZXh0ZXJuIHZvaWQgKnhyZWFsbG9jICh2 b2lkICosIHNpemVfdCkgQVRUUklCVVRFX0FMTE9DX1NJWkUgKCgyKSk7CitleHRlcm4gdm9p ZCAqeG1hbGxvYyAoc2l6ZV90KQorICBBVFRSSUJVVEVfTUFMTE9DX1NJWkUgKCgxKSkgQVRU UklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKK2V4dGVybiB2b2lkICp4emFsbG9jIChzaXplX3Qp CisgIEFUVFJJQlVURV9NQUxMT0NfU0laRSAoKDEpKSBBVFRSSUJVVEVfUkVUVVJOU19OT05O VUxMOworZXh0ZXJuIHZvaWQgKnhyZWFsbG9jICh2b2lkICosIHNpemVfdCkKKyAgQVRUUklC VVRFX0FMTE9DX1NJWkUgKCgyKSkgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKIGV4dGVy biB2b2lkIHhmcmVlICh2b2lkICopOwotZXh0ZXJuIHZvaWQgKnhubWFsbG9jIChwdHJkaWZm X3QsIHB0cmRpZmZfdCkgQVRUUklCVVRFX01BTExPQ19TSVpFICgoMSwyKSk7CitleHRlcm4g dm9pZCAqeG5tYWxsb2MgKHB0cmRpZmZfdCwgcHRyZGlmZl90KQorICBBVFRSSUJVVEVfTUFM TE9DX1NJWkUgKCgxLDIpKSBBVFRSSUJVVEVfUkVUVVJOU19OT05OVUxMOwogZXh0ZXJuIHZv aWQgKnhucmVhbGxvYyAodm9pZCAqLCBwdHJkaWZmX3QsIHB0cmRpZmZfdCkKLSAgQVRUUklC VVRFX0FMTE9DX1NJWkUgKCgyLDMpKTsKLWV4dGVybiB2b2lkICp4cGFsbG9jICh2b2lkICos IHB0cmRpZmZfdCAqLCBwdHJkaWZmX3QsIHB0cmRpZmZfdCwgcHRyZGlmZl90KTsKLQotZXh0 ZXJuIGNoYXIgKnhzdHJkdXAgKGNvbnN0IGNoYXIgKikgQVRUUklCVVRFX01BTExPQzsKLWV4 dGVybiBjaGFyICp4bGlzcHN0cmR1cCAoTGlzcF9PYmplY3QpIEFUVFJJQlVURV9NQUxMT0M7 CisgIEFUVFJJQlVURV9BTExPQ19TSVpFICgoMiwzKSkgQVRUUklCVVRFX1JFVFVSTlNfTk9O TlVMTDsKK2V4dGVybiB2b2lkICp4cGFsbG9jICh2b2lkICosIHB0cmRpZmZfdCAqLCBwdHJk aWZmX3QsIHB0cmRpZmZfdCwgcHRyZGlmZl90KQorICBBVFRSSUJVVEVfUkVUVVJOU19OT05O VUxMOworCitleHRlcm4gY2hhciAqeHN0cmR1cCAoY2hhciBjb25zdCAqKQorICBBVFRSSUJV VEVfTUFMTE9DIEFUVFJJQlVURV9SRVRVUk5TX05PTk5VTEw7CitleHRlcm4gY2hhciAqeGxp c3BzdHJkdXAgKExpc3BfT2JqZWN0KQorICBBVFRSSUJVVEVfTUFMTE9DIEFUVFJJQlVURV9S RVRVUk5TX05PTk5VTEw7CiBleHRlcm4gdm9pZCBkdXBzdHJpbmcgKGNoYXIgKiosIGNoYXIg Y29uc3QgKik7CiAKIC8qIE1ha2UgREVTVCBhIGNvcHkgb2YgU1RSSU5HJ3MgZGF0YS4gIFJl dHVybiBhIHBvaW50ZXIgdG8gREVTVCdzIHRlcm1pbmF0aW5nCkBAIC00ODc0LDcgKzQ4ODYs OCBAQCAjZGVmaW5lIGVhYnMoeCkgICAgICAgICAoKHgpIDwgMCA/IC0oeCkgOiAoeCkpCiAK IGVudW0gTUFYX0FMTE9DQSB7IE1BWF9BTExPQ0EgPSAxNiAqIDEwMjQgfTsKIAotZXh0ZXJu IHZvaWQgKnJlY29yZF94bWFsbG9jIChzaXplX3QpIEFUVFJJQlVURV9BTExPQ19TSVpFICgo MSkpOworZXh0ZXJuIHZvaWQgKnJlY29yZF94bWFsbG9jIChzaXplX3QpCisgIEFUVFJJQlVU RV9BTExPQ19TSVpFICgoMSkpIEFUVFJJQlVURV9SRVRVUk5TX05PTk5VTEw7CiAKICNkZWZp bmUgVVNFX1NBRkVfQUxMT0NBCQkJXAogICBwdHJkaWZmX3Qgc2FfYXZhaWwgPSBNQVhfQUxM T0NBOwlcCi0tIAoyLjMxLjEKCg== --------------Fw7dwaWYqJog3cfHBy63dj3c-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 20:45:42 2021 Received: (at control) by debbugs.gnu.org; 13 Oct 2021 00:45:42 +0000 Received: from localhost ([127.0.0.1]:56347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maSOs-0003Ct-DS for submit@debbugs.gnu.org; Tue, 12 Oct 2021 20:45:42 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maSOr-0003Cg-1N for control@debbugs.gnu.org; Tue, 12 Oct 2021 20:45:41 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 647471600AE for ; Tue, 12 Oct 2021 17:45:35 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qafkUPW1r-BC for ; Tue, 12 Oct 2021 17:45:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CA76A1600EB for ; Tue, 12 Oct 2021 17:45:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8FGi3pDzke4V for ; Tue, 12 Oct 2021 17:45:34 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B17C81600AE for ; Tue, 12 Oct 2021 17:45:34 -0700 (PDT) Message-ID: <3b929f57-cdbd-210c-3733-0f663883d225@cs.ucla.edu> Date: Tue, 12 Oct 2021 17:45:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Content-Language: en-US To: GNU bug control From: Paul Eggert Subject: 51172 has a patch Organization: UCLA Computer Science Department Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 51172 patch From unknown Mon Aug 18 07:45:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51172: Fix null-dereference warnings when compiling Emacs with GCC Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Oct 2021 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 51172@debbugs.gnu.org Received: via spool by 51172-submit@debbugs.gnu.org id=B51172.163412729129021 (code B ref 51172); Wed, 13 Oct 2021 12:15:02 +0000 Received: (at 51172) by debbugs.gnu.org; 13 Oct 2021 12:14:51 +0000 Received: from localhost ([127.0.0.1]:58858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mad9m-0007Y0-Ti for submit@debbugs.gnu.org; Wed, 13 Oct 2021 08:14:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mad9i-0007Xk-Nw for 51172@debbugs.gnu.org; Wed, 13 Oct 2021 08:14:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56290) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mad9c-0008Q9-Mm; Wed, 13 Oct 2021 08:14:40 -0400 Received: from [87.69.77.57] (port=2427 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mad9b-0004tO-TV; Wed, 13 Oct 2021 08:14:40 -0400 Date: Wed, 13 Oct 2021 15:14:34 +0300 Message-Id: <834k9lp1ed.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8f0a62f5-dd46-ca3b-a1e7-3a1b9b85da49@cs.ucla.edu> (message from Paul Eggert on Tue, 12 Oct 2021 17:34:11 -0700) References: <8f0a62f5-dd46-ca3b-a1e7-3a1b9b85da49@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 12 Oct 2021 17:34:11 -0700 > From: Paul Eggert > > The attached patch against emacs-28 suppresses the final remaining GCC > 11.2.1 diagnostics that are emitted after emacs-28 is configured with > --enable-gcc-warnings on x86-64. > > The patch is benign, and it's conceivable that changing xmalloc etc. to > always return nonnull fixes unlikely and obscure bugs (though I haven't > checked this). However, I didn't install the patch into the emacs-28 > branch on the off-chance that Eli would prefer this sort of thing to be > installed into the master branch. Yes, please install on master. We don't expect users to configure the released Emacs with --enable-gcc-warnings, and the changes are non-trivial. > - /* We must call malloc explicitly when BLOCK is 0, since some > - reallocs don't do this. */ > + /* Call malloc when BLOCK is null, > + since lrealloc does not allow a null BLOCK. */ Typo in this comment: "malloc" should be "lmalloc". Thanks. From unknown Mon Aug 18 07:45:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#51172: closed (Re: bug#51172: Fix null-dereference warnings when compiling Emacs with GCC) Message-ID: References: <8f0a62f5-dd46-ca3b-a1e7-3a1b9b85da49@cs.ucla.edu> X-Gnu-PR-Message: they-closed 51172 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 51172@debbugs.gnu.org Date: Wed, 13 Oct 2021 18:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1634151002-25685-1" This is a multi-part message in MIME format... ------------=_1634151002-25685-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51172: Fix null-dereference warnings when compiling Emacs with GCC which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51172@debbugs.gnu.org. --=20 51172: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51172 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1634151002-25685-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51172-done) by debbugs.gnu.org; 13 Oct 2021 18:49:47 +0000 Received: from localhost ([127.0.0.1]:33428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majJz-0006fN-Ap for submit@debbugs.gnu.org; Wed, 13 Oct 2021 14:49:47 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majJx-0006en-Lc for 51172-done@debbugs.gnu.org; Wed, 13 Oct 2021 14:49:45 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4D52E16006F; Wed, 13 Oct 2021 11:49:40 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mGquHKGU_8Nv; Wed, 13 Oct 2021 11:49:39 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8575E1600FF; Wed, 13 Oct 2021 11:49:39 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id A3Sz_A0VbO-a; Wed, 13 Oct 2021 11:49:39 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 49A6016006F; Wed, 13 Oct 2021 11:49:39 -0700 (PDT) To: Eli Zaretskii References: <8f0a62f5-dd46-ca3b-a1e7-3a1b9b85da49@cs.ucla.edu> <834k9lp1ed.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: bug#51172: Fix null-dereference warnings when compiling Emacs with GCC Message-ID: Date: Wed, 13 Oct 2021 11:49:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <834k9lp1ed.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 51172-done Cc: 51172-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) On 10/13/21 5:14 AM, Eli Zaretskii wrote: > Yes, please install on master. Thanks, done, and closing the bug report. I also got another diagnostic=20 in the master branch, and fixed that in a separate commit. ------------=_1634151002-25685-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Oct 2021 00:35:14 +0000 Received: from localhost ([127.0.0.1]:56315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maSEj-0002vf-Qi for submit@debbugs.gnu.org; Tue, 12 Oct 2021 20:35:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:56210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maSEh-0002vV-Iy for submit@debbugs.gnu.org; Tue, 12 Oct 2021 20:35:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maSEg-0004zy-A0 for bug-gnu-emacs@gnu.org; Tue, 12 Oct 2021 20:35:10 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maSEc-0004zF-PW for bug-gnu-emacs@gnu.org; Tue, 12 Oct 2021 20:35:09 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 220CD1600AE for ; Tue, 12 Oct 2021 17:35:04 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id R6_Up2ScXSN1 for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 622E01600F1 for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DfQaV3QSnqyY for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 39C111600AE for ; Tue, 12 Oct 2021 17:35:02 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Fw7dwaWYqJog3cfHBy63dj3c" Message-ID: <8f0a62f5-dd46-ca3b-a1e7-3a1b9b85da49@cs.ucla.edu> Date: Tue, 12 Oct 2021 17:34:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Content-Language: en-US To: Emacs bug reports From: Paul Eggert Subject: Fix null-dereference warnings when compiling Emacs with GCC Organization: UCLA Computer Science Department Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------Fw7dwaWYqJog3cfHBy63dj3c Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The attached patch against emacs-28 suppresses the final remaining GCC 11.2.1 diagnostics that are emitted after emacs-28 is configured with --enable-gcc-warnings on x86-64. The patch is benign, and it's conceivable that changing xmalloc etc. to always return nonnull fixes unlikely and obscure bugs (though I haven't checked this). However, I didn't install the patch into the emacs-28 branch on the off-chance that Eli would prefer this sort of thing to be installed into the master branch. --------------Fw7dwaWYqJog3cfHBy63dj3c Content-Type: text/x-patch; charset=UTF-8; name="0001-Pacify-GCC-Wanalyzer-possible-null-dereference.patch" Content-Disposition: attachment; filename*0="0001-Pacify-GCC-Wanalyzer-possible-null-dereference.patch" Content-Transfer-Encoding: base64 RnJvbSAyYWNjZjQ5NzUzZmUxNTFhNTNkNDg1YzQ3NTZkZGM5MmQ1M2QwYjNmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDEyIE9jdCAyMDIxIDE3OjI1OjU0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gUGFjaWZ5IEdDQyAtV2FuYWx5emVyLXBvc3NpYmxlLW51bGwtZGVyZWZlcmVuY2UKTUlN RS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04 CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKClRoaXMgZml4ZXMgdGhlIG9ubHkg cmVtYWluaW5nIEdDQyBkaWFnbm9zdGljcyB3aGVuIGVtYWNzLTI4IGlzCmNvbmZpZ3VyZWQg d2l0aCAtLWVuYWJsZS1nY2Mtd2FybmluZ3MuICBJdCBkb2VzIHNvIGJ5IGFkZGluZwpBVFRS SUJVVEVfUkVUVVJOU19OT05OVUxMIHNvIHRoYXQgR0NDIGtub3dzIGNlcnRhaW4gZnVuY3Rp b25zCnJldHVybiBub25udWxsLiAgSXQgYWxzbyBhcnJhbmdlcyBmb3IgdGhyZWUgb2YgdGhv c2UgZnVuY3Rpb25zIHRvCmFsd2F5cyByZXR1cm4gbm9ubnVsbDsgSSB0aG91Z2h0IHRoZXNl IGZ1bmN0aW9ucyBhbHJlYWR5IHdlcmUKZG9pbmcgc28sIGJ1dCBhcHBhcmVudGx5IG5vdCwg YW5kIGl0IGlzIGNvbmNlaXZhYmxlICh0aG91Z2ggSQpoYXZlbuKAmXQgY2hlY2tlZCB0aGlz KSB0aGF0IGNoYW5naW5nIHRoZXNlIGZ1bmN0aW9ucyB0byBhbHdheXMKcmV0dXJuIG5vbm51 bGwgZXZlbiBvbiBub24tR05VIHBsYXRmb3JtcyBtYXkgZml4IHVubGlrZWx5CnBvcnRhYmls aXR5IGJ1Z3MgZWxzZXdoZXJlIGluIEVtYWNzLiAgSSB1c2VkIEdDQyAxMS4yLjEgMjAyMTA3 MjgKKFJlZCBIYXQgMTEuMi4xLTEpIG9uIHg4Ni02NCB3aGVuIGNoZWNraW5nIHRoZSBkaWFn bm9zdGljcy4KKiBzcmMvYWxsb2MuYyAoeG1hbGxvYywgeHphbGxvYywgeHJlYWxsb2MpOiBE b27igJl0IHdvcnJ5IGFib3V0IHRoZQpzcGVjaWFsIGNhc2Ugd2hlcmUgU0laRSA9PSAwLCBz aW5jZSBsbWFsbG9jIGFuZCBscmVhbGxvYyBub3cKcmV0dXJuIG51bGwgb25seSBvbiBhbGxv Y2F0aW9uIGZhaWx1cmUuCihsbWFsbG9jLCBscmVhbGxvYyk6IFJldHVybiBudWxsIG9ubHkg b24gYWxsb2NhdGlvbiBmYWlsdXJlLAppbnN0ZWFkIG9mIGhhdmluZyBzcGVjaWFsIGNhc2Vz IHRoYXQgdHJlYXQgbWFsbG9jICgwKSBhbmQKcmVhbGxvYyAoWCwgMCkgYXMgc3VjY2Vzc2Vz IGV2ZW4gd2hlbiB0aGV5IHJldHVybiBudWxsLgoqIHNyYy9saXNwLmg6IEFkZCBBVFRSSUJV VEVfUkVUVVJOU19OT05OVUxMIHRvIGEgZmV3IGZ1bmN0aW9ucwp0aGF0IGFsd2F5cyByZXR1 cm4gbm9ubnVsbCBwb2ludGVycywgc28gdGhhdCBnY2MgLWZhbmFseXplcgpkb2VzIG5vdCBp c3N1ZSBkaWFnbm9zdGljcyBsaWtlIOKAnGFsbG9jLmM6IEluIGZ1bmN0aW9uCuKAmGFsbG9j YXRlX3ZlY3Rvcl9ibG9ja+KAmTogYWxsb2MuYzoyOTg1OjE1OiB3YXJuaW5nOiBkZXJlZmVy ZW5jZSBvZgpwb3NzaWJseS1OVUxMIOKAmGJsb2Nr4oCZIFtDV0UtNjkwXSBbLVdhbmFseXpl ci1wb3NzaWJsZS1udWxsLWRlcmVmZXJlbmNlXeKAnQphcyBwZXIgPGh0dHBzOi8vY3dlLm1p dHJlLm9yZy9kYXRhL2RlZmluaXRpb25zLzY5MC5odG1sPi4KLS0tCiBzcmMvYWxsb2MuYyB8 IDQwICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KIHNyYy9saXNw LmggIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDM1IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9hbGxvYy5jIGIvc3JjL2FsbG9jLmMKaW5kZXggMGMw NGQ1Y2RlMC4uYjFmODA2NGE5ZCAxMDA2NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3Jj L2FsbG9jLmMKQEAgLTc2NSw3ICs3NjUsNyBAQCB4bWFsbG9jIChzaXplX3Qgc2l6ZSkKICAg dmFsID0gbG1hbGxvYyAoc2l6ZSwgZmFsc2UpOwogICBNQUxMT0NfVU5CTE9DS19JTlBVVDsK IAotICBpZiAoIXZhbCAmJiBzaXplKQorICBpZiAoIXZhbCkKICAgICBtZW1vcnlfZnVsbCAo c2l6ZSk7CiAgIE1BTExPQ19QUk9CRSAoc2l6ZSk7CiAgIHJldHVybiB2YWw7CkBAIC03ODIs NyArNzgyLDcgQEAgeHphbGxvYyAoc2l6ZV90IHNpemUpCiAgIHZhbCA9IGxtYWxsb2MgKHNp emUsIHRydWUpOwogICBNQUxMT0NfVU5CTE9DS19JTlBVVDsKIAotICBpZiAoIXZhbCAmJiBz aXplKQorICBpZiAoIXZhbCkKICAgICBtZW1vcnlfZnVsbCAoc2l6ZSk7CiAgIE1BTExPQ19Q Uk9CRSAoc2l6ZSk7CiAgIHJldHVybiB2YWw7CkBAIC03OTYsMTUgKzc5NiwxNSBAQCB4cmVh bGxvYyAodm9pZCAqYmxvY2ssIHNpemVfdCBzaXplKQogICB2b2lkICp2YWw7CiAKICAgTUFM TE9DX0JMT0NLX0lOUFVUOwotICAvKiBXZSBtdXN0IGNhbGwgbWFsbG9jIGV4cGxpY2l0bHkg d2hlbiBCTE9DSyBpcyAwLCBzaW5jZSBzb21lCi0gICAgIHJlYWxsb2NzIGRvbid0IGRvIHRo aXMuICAqLworICAvKiBDYWxsIG1hbGxvYyB3aGVuIEJMT0NLIGlzIG51bGwsCisgICAgIHNp bmNlIGxyZWFsbG9jIGRvZXMgbm90IGFsbG93IGEgbnVsbCBCTE9DSy4gICovCiAgIGlmICgh IGJsb2NrKQogICAgIHZhbCA9IGxtYWxsb2MgKHNpemUsIGZhbHNlKTsKICAgZWxzZQogICAg IHZhbCA9IGxyZWFsbG9jIChibG9jaywgc2l6ZSk7CiAgIE1BTExPQ19VTkJMT0NLX0lOUFVU OwogCi0gIGlmICghdmFsICYmIHNpemUpCisgIGlmICghdmFsKQogICAgIG1lbW9yeV9mdWxs IChzaXplKTsKICAgTUFMTE9DX1BST0JFIChzaXplKTsKICAgcmV0dXJuIHZhbDsKQEAgLTk4 OCw4ICs5ODgsNyBAQCByZWNvcmRfeG1hbGxvYyAoc2l6ZV90IHNpemUpCiAKIC8qIExpa2Ug bWFsbG9jIGJ1dCB1c2VkIGZvciBhbGxvY2F0aW5nIExpc3AgZGF0YS4gIE5CWVRFUyBpcyB0 aGUKICAgIG51bWJlciBvZiBieXRlcyB0byBhbGxvY2F0ZSwgVFlQRSBkZXNjcmliZXMgdGhl IGludGVuZGVkIHVzZSBvZiB0aGUKLSAgIGFsbG9jYXRlZCBtZW1vcnkgYmxvY2sgKGZvciBz dHJpbmdzLCBmb3IgY29uc2VzLCAuLi4pLgotICAgTkJZVEVTIG11c3QgYmUgcG9zaXRpdmUu ICAqLworICAgYWxsb2NhdGVkIG1lbW9yeSBibG9jayAoZm9yIHN0cmluZ3MsIGZvciBjb25z ZXMsIC4uLikuICAqLwogCiAjaWYgISBVU0VfTFNCX1RBRwogdm9pZCAqbGlzcF9tYWxsb2Nf bG9zZXIgRVhURVJOQUxMWV9WSVNJQkxFOwpAQCAtMTMzMCwxNiArMTMyOSwyMCBAQCBsYWxp Z25lZCAodm9pZCAqcCwgc2l6ZV90IHNpemUpCiAJICB8fCBzaXplICUgTElTUF9BTElHTk1F TlQgIT0gMCk7CiB9CiAKLS8qIExpa2UgbWFsbG9jIGFuZCByZWFsbG9jIGV4Y2VwdCB0aGF0 IGlmIFNJWkUgaXMgTGlzcC1hbGlnbmVkLCBtYWtlCi0gICBzdXJlIHRoZSByZXN1bHQgaXMg dG9vLCBpZiBuZWNlc3NhcnkgYnkgcmVhbGxvY2F0aW5nICh0eXBpY2FsbHkKLSAgIHdpdGgg bGFyZ2VyIGFuZCBsYXJnZXIgc2l6ZXMpIHVudGlsIHRoZSBhbGxvY2F0b3IgcmV0dXJucyBh Ci0gICBMaXNwLWFsaWduZWQgcG9pbnRlci4gIENvZGUgdGhhdCBuZWVkcyB0byBhbGxvY2F0 ZSBDIGhlYXAgbWVtb3J5CisvKiBMaWtlIG1hbGxvYyBhbmQgcmVhbGxvYyBleGNlcHQgcmV0 dXJuIG51bGwgb25seSBvbiBmYWlsdXJlLAorICAgdGhlIHJlc3VsdCBpcyBMaXNwLWFsaWdu ZWQgaWYgU0laRSBpcywgYW5kIGxyZWFsbG9jJ3MgcG9pbnRlcgorICAgYXJndW1lbnQgbXVz dCBiZSBub25udWxsLiAgQ29kZSBhbGxvY2F0aW5nIEMgaGVhcCBtZW1vcnkKICAgIGZvciBh IExpc3Agb2JqZWN0IHNob3VsZCB1c2Ugb25lIG9mIHRoZXNlIGZ1bmN0aW9ucyB0byBvYnRh aW4gYQogICAgcG9pbnRlciBQOyB0aGF0IHdheSwgaWYgVCBpcyBhbiBlbnVtIExpc3BfVHlw ZSB2YWx1ZSBhbmQgTCA9PQogICAgbWFrZV9saXNwX3B0ciAoUCwgVCksIHRoZW4gWFBOVFIg KEwpID09IFAgYW5kIFhUWVBFIChMKSA9PSBULgogCisgICBJZiBDTEVBUklULCBhcnJhbmdl IGZvciB0aGUgYWxsb2NhdGVkIG1lbW9yeSB0byBiZSBjbGVhcmVkLgorICAgVGhpcyBtaWdo dCB1c2UgY2FsbG9jLCBhcyBjYWxsb2MgY2FuIGJlIGZhc3RlciB0aGFuIG1hbGxvYyttZW1z ZXQuCisKICAgIE9uIHR5cGljYWwgbW9kZXJuIHBsYXRmb3JtcyB0aGVzZSBmdW5jdGlvbnMn IGxvb3BzIGRvIG5vdCBpdGVyYXRlLgotICAgT24gbm93LXJhcmUgKGFuZCBwZXJoYXBzIG5v bmV4aXN0ZW50KSBwbGF0Zm9ybXMsIHRoZSBsb29wcyBpbgorICAgT24gbm93LXJhcmUgKGFu ZCBwZXJoYXBzIG5vbmV4aXN0ZW50KSBwbGF0Zm9ybXMsIHRoZSBjb2RlIGNhbiBsb29wLAor ICAgcmVhbGxvY2F0aW5nICh0eXBpY2FsbHkgd2l0aCBsYXJnZXIgYW5kIGxhcmdlciBzaXpl cykgdW50aWwgdGhlCisgICBhbGxvY2F0b3IgcmV0dXJucyBhIExpc3AtYWxpZ25lZCBwb2lu dGVyLiAgVGhpcyBsb29wIGluCiAgICB0aGVvcnkgY291bGQgcmVwZWF0IGZvcmV2ZXIuICBJ ZiBhbiBpbmZpbml0ZSBsb29wIGlzIHBvc3NpYmxlIG9uIGEKICAgIHBsYXRmb3JtLCBhIGJ1 aWxkIHdvdWxkIHN1cmVseSBsb29wIGFuZCB0aGUgYnVpbGRlciBjYW4gdGhlbiBzZW5kCiAg ICB1cyBhIGJ1ZyByZXBvcnQuICBBZGRpbmcgYSBjb3VudGVyIHRvIHRyeSB0byBkZXRlY3Qg YW55IHN1Y2ggbG9vcApAQCAtMTM1Myw4ICsxMzU2LDEzIEBAIGxtYWxsb2MgKHNpemVfdCBz aXplLCBib29sIGNsZWFyaXQpCiAgIGlmICghIE1BTExPQ19JU19MSVNQX0FMSUdORUQgJiYg c2l6ZSAlIExJU1BfQUxJR05NRU5UID09IDApCiAgICAgewogICAgICAgdm9pZCAqcCA9IGFs aWduZWRfYWxsb2MgKExJU1BfQUxJR05NRU5ULCBzaXplKTsKLSAgICAgIGlmIChjbGVhcml0 ICYmIHApCi0JbWVtY2xlYXIgKHAsIHNpemUpOworICAgICAgaWYgKHApCisJeworCSAgaWYg KGNsZWFyaXQpCisJICAgIG1lbWNsZWFyIChwLCBzaXplKTsKKwl9CisgICAgICBlbHNlIGlm ICghIChNQUxMT0NfMF9JU19OT05OVUxMIHx8IHNpemUpKQorCXJldHVybiBhbGlnbmVkX2Fs bG9jIChMSVNQX0FMSUdOTUVOVCwgTElTUF9BTElHTk1FTlQpOwogICAgICAgcmV0dXJuIHA7 CiAgICAgfQogI2VuZGlmCkBAIC0xMzYyLDcgKzEzNzAsNyBAQCBsbWFsbG9jIChzaXplX3Qg c2l6ZSwgYm9vbCBjbGVhcml0KQogICB3aGlsZSAodHJ1ZSkKICAgICB7CiAgICAgICB2b2lk ICpwID0gY2xlYXJpdCA/IGNhbGxvYyAoMSwgc2l6ZSkgOiBtYWxsb2MgKHNpemUpOwotICAg ICAgaWYgKGxhbGlnbmVkIChwLCBzaXplKSkKKyAgICAgIGlmIChsYWxpZ25lZCAocCwgc2l6 ZSkgJiYgKE1BTExPQ18wX0lTX05PTk5VTEwgfHwgc2l6ZSB8fCBwKSkKIAlyZXR1cm4gcDsK ICAgICAgIGZyZWUgKHApOwogICAgICAgc2l6ZV90IGJpZ2dlciA9IHNpemUgKyBMSVNQX0FM SUdOTUVOVDsKQEAgLTEzNzcsNyArMTM4NSw3IEBAIGxyZWFsbG9jICh2b2lkICpwLCBzaXpl X3Qgc2l6ZSkKICAgd2hpbGUgKHRydWUpCiAgICAgewogICAgICAgcCA9IHJlYWxsb2MgKHAs IHNpemUpOwotICAgICAgaWYgKGxhbGlnbmVkIChwLCBzaXplKSkKKyAgICAgIGlmIChsYWxp Z25lZCAocCwgc2l6ZSkgJiYgKHNpemUgfHwgcCkpCiAJcmV0dXJuIHA7CiAgICAgICBzaXpl X3QgYmlnZ2VyID0gc2l6ZSArIExJU1BfQUxJR05NRU5UOwogICAgICAgaWYgKHNpemUgPCBi aWdnZXIpCmRpZmYgLS1naXQgYS9zcmMvbGlzcC5oIGIvc3JjL2xpc3AuaAppbmRleCA0ODBj Mzg5YTNiLi4zMTY1NmJiM2IxIDEwMDY0NAotLS0gYS9zcmMvbGlzcC5oCisrKyBiL3NyYy9s aXNwLmgKQEAgLTM5NDcsNyArMzk0Nyw4IEBAIGJ1aWxkX3N0cmluZyAoY29uc3QgY2hhciAq c3RyKQogCiBleHRlcm4gTGlzcF9PYmplY3QgcHVyZV9jb25zIChMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpOwogZXh0ZXJuIExpc3BfT2JqZWN0IG1ha2VfdmVjdG9yIChwdHJkaWZmX3Qs IExpc3BfT2JqZWN0KTsKLWV4dGVybiBzdHJ1Y3QgTGlzcF9WZWN0b3IgKmFsbG9jYXRlX25p bF92ZWN0b3IgKHB0cmRpZmZfdCk7CitleHRlcm4gc3RydWN0IExpc3BfVmVjdG9yICphbGxv Y2F0ZV9uaWxfdmVjdG9yIChwdHJkaWZmX3QpCisgIEFUVFJJQlVURV9SRVRVUk5TX05PTk5V TEw7CiAKIC8qIE1ha2UgYW4gdW5pbml0aWFsaXplZCB2ZWN0b3IgZm9yIFNJWkUgb2JqZWN0 cy4gIE5PVEU6IHlvdSBtdXN0CiAgICBiZSBzdXJlIHRoYXQgR0MgY2Fubm90IGhhcHBlbiB1 bnRpbCB0aGUgdmVjdG9yIGlzIGNvbXBsZXRlbHkKQEAgLTM5NjAsNyArMzk2MSw4IEBAIGJ1 aWxkX3N0cmluZyAoY29uc3QgY2hhciAqc3RyKQogCiAgICBhbGxvY2F0ZV92ZWN0b3IgaGFz IGEgc2ltaWxhciBwcm9ibGVtLiAgKi8KIAotZXh0ZXJuIHN0cnVjdCBMaXNwX1ZlY3RvciAq YWxsb2NhdGVfdmVjdG9yIChwdHJkaWZmX3QpOworZXh0ZXJuIHN0cnVjdCBMaXNwX1ZlY3Rv ciAqYWxsb2NhdGVfdmVjdG9yIChwdHJkaWZmX3QpCisgIEFUVFJJQlVURV9SRVRVUk5TX05P Tk5VTEw7CiAKIElOTElORSBMaXNwX09iamVjdAogbWFrZV91bmluaXRfdmVjdG9yIChwdHJk aWZmX3Qgc2l6ZSkKQEAgLTM5OTIsNyArMzk5NCw4IEBAIG1ha2VfbmlsX3ZlY3RvciAocHRy ZGlmZl90IHNpemUpCiB9CiAKIGV4dGVybiBzdHJ1Y3QgTGlzcF9WZWN0b3IgKmFsbG9jYXRl X3BzZXVkb3ZlY3RvciAoaW50LCBpbnQsIGludCwKLQkJCQkJCSAgZW51bSBwdmVjX3R5cGUp OworCQkJCQkJICBlbnVtIHB2ZWNfdHlwZSkKKyAgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVM TDsKIAogLyogQWxsb2NhdGUgdW5pbml0aWFsaXplZCBwc2V1ZG92ZWN0b3Igd2l0aCBubyBM aXNwX09iamVjdCBzbG90cy4gICovCiAKQEAgLTQwMjQsNyArNDAyNyw3IEBAICNkZWZpbmUg QUxMT0NBVEVfWkVST0VEX1BTRVVET1ZFQ1RPUih0eXBlLCBmaWVsZCwgdGFnKQkJICAgICAg IFwKIGV4dGVybiB2b2lkIGluaXRfYWxsb2Nfb25jZSAodm9pZCk7CiBleHRlcm4gdm9pZCBp bml0X2FsbG9jICh2b2lkKTsKIGV4dGVybiB2b2lkIHN5bXNfb2ZfYWxsb2MgKHZvaWQpOwot ZXh0ZXJuIHN0cnVjdCBidWZmZXIgKiBhbGxvY2F0ZV9idWZmZXIgKHZvaWQpOworZXh0ZXJu IHN0cnVjdCBidWZmZXIgKmFsbG9jYXRlX2J1ZmZlciAodm9pZCkgQVRUUklCVVRFX1JFVFVS TlNfTk9OTlVMTDsKIGV4dGVybiBpbnQgdmFsaWRfbGlzcF9vYmplY3RfcCAoTGlzcF9PYmpl Y3QpOwogCiAvKiBEZWZpbmVkIGluIGdtYWxsb2MuYy4gICovCkBAIC00MTgyLDcgKzQxODUs OCBAQCB4c2lnbmFsIChMaXNwX09iamVjdCBlcnJvcl9zeW1ib2wsIExpc3BfT2JqZWN0IGRh dGEpCiAgICAgKExpc3BfT2JqZWN0ICgqKSAocHRyZGlmZl90LCBMaXNwX09iamVjdCAqKSwg cHRyZGlmZl90LCBMaXNwX09iamVjdCAqLAogICAgICBMaXNwX09iamVjdCwgTGlzcF9PYmpl Y3QgKCopIChMaXNwX09iamVjdCwgcHRyZGlmZl90LCBMaXNwX09iamVjdCAqKSk7CiBleHRl cm4gTGlzcF9PYmplY3QgaW50ZXJuYWxfY2F0Y2hfYWxsIChMaXNwX09iamVjdCAoKikgKHZv aWQgKiksIHZvaWQgKiwgTGlzcF9PYmplY3QgKCopIChlbnVtIG5vbmxvY2FsX2V4aXQsIExp c3BfT2JqZWN0KSk7Ci1leHRlcm4gc3RydWN0IGhhbmRsZXIgKnB1c2hfaGFuZGxlciAoTGlz cF9PYmplY3QsIGVudW0gaGFuZGxlcnR5cGUpOworZXh0ZXJuIHN0cnVjdCBoYW5kbGVyICpw dXNoX2hhbmRsZXIgKExpc3BfT2JqZWN0LCBlbnVtIGhhbmRsZXJ0eXBlKQorICBBVFRSSUJV VEVfUkVUVVJOU19OT05OVUxMOwogZXh0ZXJuIHN0cnVjdCBoYW5kbGVyICpwdXNoX2hhbmRs ZXJfbm9zaWduYWwgKExpc3BfT2JqZWN0LCBlbnVtIGhhbmRsZXJ0eXBlKTsKIGV4dGVybiB2 b2lkIHNwZWNiaW5kIChMaXNwX09iamVjdCwgTGlzcF9PYmplY3QpOwogZXh0ZXJuIHZvaWQg cmVjb3JkX3Vud2luZF9wcm90ZWN0ICh2b2lkICgqKSAoTGlzcF9PYmplY3QpLCBMaXNwX09i amVjdCk7CkBAIC00MzIzLDkgKzQzMjcsMTAgQEAgWE1PRFVMRV9GVU5DVElPTiAoTGlzcF9P YmplY3QgbykKIAogLyogRGVmaW5lZCBpbiBmaWxlaW8uYy4gICovCiAKLWV4dGVybiBjaGFy ICpzcGxpY2VfZGlyX2ZpbGUgKGNoYXIgKiwgY2hhciBjb25zdCAqLCBjaGFyIGNvbnN0ICop OworZXh0ZXJuIGNoYXIgKnNwbGljZV9kaXJfZmlsZSAoY2hhciAqLCBjaGFyIGNvbnN0ICos IGNoYXIgY29uc3QgKikKKyAgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKIGV4dGVybiBi b29sIGZpbGVfbmFtZV9hYnNvbHV0ZV9wIChjb25zdCBjaGFyICopOwotZXh0ZXJuIGNoYXIg Y29uc3QgKmdldF9ob21lZGlyICh2b2lkKTsKK2V4dGVybiBjaGFyIGNvbnN0ICpnZXRfaG9t ZWRpciAodm9pZCkgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKIGV4dGVybiBMaXNwX09i amVjdCBleHBhbmRfYW5kX2Rpcl90b19maWxlIChMaXNwX09iamVjdCk7CiBleHRlcm4gTGlz cF9PYmplY3Qgd3JpdGVfcmVnaW9uIChMaXNwX09iamVjdCwgTGlzcF9PYmplY3QsIExpc3Bf T2JqZWN0LAogCQkJCSBMaXNwX09iamVjdCwgTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LApA QCAtNDQ3OSw3ICs0NDg0LDcgQEAgZmFzdF9zdHJpbmdfbWF0Y2hfaWdub3JlX2Nhc2UgKExp c3BfT2JqZWN0IHJlZ2V4cCwgTGlzcF9PYmplY3Qgc3RyaW5nKQogSU5MSU5FIHZvaWQgc3lu Y2hyb25pemVfc3lzdGVtX21lc3NhZ2VzX2xvY2FsZSAodm9pZCkge30KIElOTElORSB2b2lk IHN5bmNocm9uaXplX3N5c3RlbV90aW1lX2xvY2FsZSAodm9pZCkge30KICNlbmRpZgotZXh0 ZXJuIGNoYXIgKmVtYWNzX3N0cmVycm9yIChpbnQpOworZXh0ZXJuIGNoYXIgKmVtYWNzX3N0 cmVycm9yIChpbnQpIEFUVFJJQlVURV9SRVRVUk5TX05PTk5VTEw7CiBleHRlcm4gdm9pZCBz aHV0X2Rvd25fZW1hY3MgKGludCwgTGlzcF9PYmplY3QpOwogCiAvKiBUcnVlIG1lYW5zIGRv bid0IGRvIGludGVyYWN0aXZlIHJlZGlzcGxheSBhbmQgZG9uJ3QgY2hhbmdlIHR0eSBtb2Rl cy4gICovCkBAIC00NTQ1LDcgKzQ1NTAsNyBAQCAjZGVmaW5lIERBRU1PTl9SVU5OSU5HICh3 MzJfZGFlbW9uX2V2ZW50ICE9IElOVkFMSURfSEFORExFX1ZBTFVFKQogCiBleHRlcm4gaW50 IGVtYWNzX3NwYXduIChwaWRfdCAqLCBpbnQsIGludCwgaW50LCBjaGFyICoqLCBjaGFyICoq LAogICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqLCBjb25zdCBjaGFyICos IGNvbnN0IHNpZ3NldF90ICopOwotZXh0ZXJuIGNoYXIgKiptYWtlX2Vudmlyb25tZW50X2Js b2NrIChMaXNwX09iamVjdCk7CitleHRlcm4gY2hhciAqKm1ha2VfZW52aXJvbm1lbnRfYmxv Y2sgKExpc3BfT2JqZWN0KSBBVFRSSUJVVEVfUkVUVVJOU19OT05OVUxMOwogZXh0ZXJuIHZv aWQgaW5pdF9jYWxscHJvY18xICh2b2lkKTsKIGV4dGVybiB2b2lkIGluaXRfY2FsbHByb2Mg KHZvaWQpOwogZXh0ZXJuIHZvaWQgc2V0X2luaXRpYWxfZW52aXJvbm1lbnQgKHZvaWQpOwpA QCAtNDgxNCwxNyArNDgxOSwyNCBAQCBTVUJSX05BVElWRV9DT01QSUxFRF9EWU5QIChMaXNw X09iamVjdCBhKQogZXh0ZXJuIGNoYXIgbXlfZW5kYnNzW107CiBleHRlcm4gY2hhciAqbXlf ZW5kYnNzX3N0YXRpYzsKIAotZXh0ZXJuIHZvaWQgKnhtYWxsb2MgKHNpemVfdCkgQVRUUklC VVRFX01BTExPQ19TSVpFICgoMSkpOwotZXh0ZXJuIHZvaWQgKnh6YWxsb2MgKHNpemVfdCkg QVRUUklCVVRFX01BTExPQ19TSVpFICgoMSkpOwotZXh0ZXJuIHZvaWQgKnhyZWFsbG9jICh2 b2lkICosIHNpemVfdCkgQVRUUklCVVRFX0FMTE9DX1NJWkUgKCgyKSk7CitleHRlcm4gdm9p ZCAqeG1hbGxvYyAoc2l6ZV90KQorICBBVFRSSUJVVEVfTUFMTE9DX1NJWkUgKCgxKSkgQVRU UklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKK2V4dGVybiB2b2lkICp4emFsbG9jIChzaXplX3Qp CisgIEFUVFJJQlVURV9NQUxMT0NfU0laRSAoKDEpKSBBVFRSSUJVVEVfUkVUVVJOU19OT05O VUxMOworZXh0ZXJuIHZvaWQgKnhyZWFsbG9jICh2b2lkICosIHNpemVfdCkKKyAgQVRUUklC VVRFX0FMTE9DX1NJWkUgKCgyKSkgQVRUUklCVVRFX1JFVFVSTlNfTk9OTlVMTDsKIGV4dGVy biB2b2lkIHhmcmVlICh2b2lkICopOwotZXh0ZXJuIHZvaWQgKnhubWFsbG9jIChwdHJkaWZm X3QsIHB0cmRpZmZfdCkgQVRUUklCVVRFX01BTExPQ19TSVpFICgoMSwyKSk7CitleHRlcm4g dm9pZCAqeG5tYWxsb2MgKHB0cmRpZmZfdCwgcHRyZGlmZl90KQorICBBVFRSSUJVVEVfTUFM TE9DX1NJWkUgKCgxLDIpKSBBVFRSSUJVVEVfUkVUVVJOU19OT05OVUxMOwogZXh0ZXJuIHZv aWQgKnhucmVhbGxvYyAodm9pZCAqLCBwdHJkaWZmX3QsIHB0cmRpZmZfdCkKLSAgQVRUUklC VVRFX0FMTE9DX1NJWkUgKCgyLDMpKTsKLWV4dGVybiB2b2lkICp4cGFsbG9jICh2b2lkICos IHB0cmRpZmZfdCAqLCBwdHJkaWZmX3QsIHB0cmRpZmZfdCwgcHRyZGlmZl90KTsKLQotZXh0 ZXJuIGNoYXIgKnhzdHJkdXAgKGNvbnN0IGNoYXIgKikgQVRUUklCVVRFX01BTExPQzsKLWV4 dGVybiBjaGFyICp4bGlzcHN0cmR1cCAoTGlzcF9PYmplY3QpIEFUVFJJQlVURV9NQUxMT0M7 CisgIEFUVFJJQlVURV9BTExPQ19TSVpFICgoMiwzKSkgQVRUUklCVVRFX1JFVFVSTlNfTk9O TlVMTDsKK2V4dGVybiB2b2lkICp4cGFsbG9jICh2b2lkICosIHB0cmRpZmZfdCAqLCBwdHJk aWZmX3QsIHB0cmRpZmZfdCwgcHRyZGlmZl90KQorICBBVFRSSUJVVEVfUkVUVVJOU19OT05O VUxMOworCitleHRlcm4gY2hhciAqeHN0cmR1cCAoY2hhciBjb25zdCAqKQorICBBVFRSSUJV VEVfTUFMTE9DIEFUVFJJQlVURV9SRVRVUk5TX05PTk5VTEw7CitleHRlcm4gY2hhciAqeGxp c3BzdHJkdXAgKExpc3BfT2JqZWN0KQorICBBVFRSSUJVVEVfTUFMTE9DIEFUVFJJQlVURV9S RVRVUk5TX05PTk5VTEw7CiBleHRlcm4gdm9pZCBkdXBzdHJpbmcgKGNoYXIgKiosIGNoYXIg Y29uc3QgKik7CiAKIC8qIE1ha2UgREVTVCBhIGNvcHkgb2YgU1RSSU5HJ3MgZGF0YS4gIFJl dHVybiBhIHBvaW50ZXIgdG8gREVTVCdzIHRlcm1pbmF0aW5nCkBAIC00ODc0LDcgKzQ4ODYs OCBAQCAjZGVmaW5lIGVhYnMoeCkgICAgICAgICAoKHgpIDwgMCA/IC0oeCkgOiAoeCkpCiAK IGVudW0gTUFYX0FMTE9DQSB7IE1BWF9BTExPQ0EgPSAxNiAqIDEwMjQgfTsKIAotZXh0ZXJu IHZvaWQgKnJlY29yZF94bWFsbG9jIChzaXplX3QpIEFUVFJJQlVURV9BTExPQ19TSVpFICgo MSkpOworZXh0ZXJuIHZvaWQgKnJlY29yZF94bWFsbG9jIChzaXplX3QpCisgIEFUVFJJQlVU RV9BTExPQ19TSVpFICgoMSkpIEFUVFJJQlVURV9SRVRVUk5TX05PTk5VTEw7CiAKICNkZWZp bmUgVVNFX1NBRkVfQUxMT0NBCQkJXAogICBwdHJkaWZmX3Qgc2FfYXZhaWwgPSBNQVhfQUxM T0NBOwlcCi0tIAoyLjMxLjEKCg== --------------Fw7dwaWYqJog3cfHBy63dj3c-- ------------=_1634151002-25685-1--