From unknown Sat Aug 09 04:49:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51139 <51139@debbugs.gnu.org> To: bug#51139 <51139@debbugs.gnu.org> Subject: Status: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds Reply-To: bug#51139 <51139@debbugs.gnu.org> Date: Sat, 09 Aug 2025 11:49:06 +0000 retitle 51139 29.0.50; MH-E and edmacro byte-compile warnings in nox builds reassign 51139 emacs submitter 51139 "Basil L. Contovounesios" severity 51139 minor tag 51139 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 17:17:36 2021 Received: (at submit) by debbugs.gnu.org; 11 Oct 2021 21:17:36 +0000 Received: from localhost ([127.0.0.1]:32840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma2fv-00071s-IP for submit@debbugs.gnu.org; Mon, 11 Oct 2021 17:17:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:43968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma2ft-00071k-JI for submit@debbugs.gnu.org; Mon, 11 Oct 2021 17:17:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ma2ft-000711-Az for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 17:17:33 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:37878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ma2fn-0005MH-Ko for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 17:17:32 -0400 Received: by mail-wr1-x435.google.com with SMTP id e12so60220147wra.4 for ; Mon, 11 Oct 2021 14:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:user-agent:mime-version; bh=MQy+2ByPdJFzWHZVMNlUtn9qjoSuZAVwSr0rM1UCfvQ=; b=LHGiiw3jUPavgbukGTIWLuZyWx/pzF4alg7ly2n8zhLRYBeYGWo9YxwnYJ4/bdPf4l CNUdT9jNbVMfNvE2PuwQlRiXbe6MS9jBI8o1hm0uDlzhfvMps3sEEtFWEuRsu/rSSrEZ ql+RQwCZz4TeaL4eYHHTRjzh+BWnApc4hNYGAkiVTGq6Tr8iqX4sJMfLXjXMNAQOv2Cv oWiJNI87h2B8+eUIx/3oF6j6t/DgXCfrSn3rV5p/Q/eCDM5Fa7cn5CHfpgRE/kv8bO7v Tk/TH5KzD3ELTVoRVQ90pWjd2WuSzfh88mbklxrVb3w3ccHqQsFiCnU0Sf3eMy3yEjJT 2Xbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=MQy+2ByPdJFzWHZVMNlUtn9qjoSuZAVwSr0rM1UCfvQ=; b=bF3y7GoP6pbhZ8phFTaNLSvktgrRFgModZV7gUer5tD2kzmCyFltHMzgSS33dQZNcX Iv+LrSiUc/ZpnmsAa3OJoqUEy4HWgwgN4ctRDMxEVJ3X6MP7VecabV+vJO8GPxyKxD7p 4/U5bpr8RnTIrGXkud9rMyaYVbAtcXXbfacxtn1JcSnZZNHthTyMsph0JEaq5Bvk0nrg 45tDxGLnaMgZNVQeo21XBTect8fX2XrpZBoap0l6UeRdgjo/inQC6QN15UYN1mNGFgJp hg0V8+fTWqBYd/17jzjluR0l9c8lkIeQCNunEaTpxdSzQ4Cd+H9P8SBnMlrL+yN5hohD AuhQ== X-Gm-Message-State: AOAM532+IRbUl6/W5o2FCjjI4SVZLTIhF5NKoJJurB42ry2lQxfdTh3z Irp43cS0sxy54L8lw/Omalv7B7tki0cdKQ== X-Google-Smtp-Source: ABdhPJyjLYXKRbkesdKTQ4DgcxbpjWuDg89qSi2ieDEDgAw5Rs2gxf7VN2Ms/GkpMz5IYjQylm1vwQ== X-Received: by 2002:a05:600c:209:: with SMTP id 9mr1484410wmi.42.1633987041821; Mon, 11 Oct 2021 14:17:21 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id l2sm1046109wmi.1.2021.10.11.14.17.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 14:17:21 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds X-Debbugs-Cc: Dave Gillespie , Bill Wohler Date: Mon, 11 Oct 2021 22:17:19 +0100 Message-ID: <87tuhnl0rk.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=contovob@tcd.ie; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Severity: minor Tags: patch I see the following byte-compilation warnings in --without-x builds: --8<---------------cut here---------------start------------->8--- In edmacro-fix-menu-commands: edmacro.el:622:34: Warning: reference to free variable =E2=80=98mouse-wheel-down-event=E2=80=99 edmacro.el:622:57: Warning: reference to free variable =E2=80=98mouse-wheel= -up-event=E2=80=99 edmacro.el:623:34: Warning: reference to free variable =E2=80=98mouse-wheel-right-event=E2=80=99 edmacro.el:624:34: Warning: reference to free variable =E2=80=98mouse-wheel-left-event=E2=80=99 In end of data: mh-e/mh-compat.el:96:5: Warning: the function =E2=80=98image-search-load-pa= th=E2=80=99 is not known to be defined. mh-e/mh-compat.el:93:5: Warning: the function =E2=80=98image-load-path-for-= library=E2=80=99 is not known to be defined. In mh-logo-display: mh-e/mh-utils.el:129:40: Warning: Unused lexical variable `image-load-path' In mh-tool-bar-folder-buttons-init: mh-e/mh-tool-bar.el:302:1: Warning: Unused lexical variable `image-load-pat= h' In mh-tool-bar-letter-buttons-init: mh-e/mh-tool-bar.el:384:3: Warning: Unused lexical variable `image-load-pat= h' In end of data: mh-e/mh-utils.el:128:24: Warning: the function =E2=80=98image-load-path-for= -library=E2=80=99 is not known to be defined. In end of data: mh-e/mh-tool-bar.el:302:1: Warning: the function =E2=80=98image-load-path-f= or-library=E2=80=99 is not known to be defined. --8<---------------cut here---------------end--------------->8--- The MH-E warnings are seen on master, whereas the edmacro ones are also on emacs-28 (details of both configurations follow my signature). I assume the warnings are not important enough to install anything on emacs-28, so I attach a patch against master for both sets of warnings. WDYT? Thanks, --=20 Basil --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-byte-compilation-warnings-in-nox-builds.patch >From 3b5b2a942f14d6512a848cf6cafa4d8a7d5610de Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Mon, 11 Oct 2021 19:14:23 +0100 Subject: [PATCH] Fix byte-compilation warnings in nox builds * lisp/edmacro.el (edmacro-fix-menu-commands): Load mwheel to pacify undefined variable warnings in without-x builds. * lisp/mh-e/mh-compat.el: Declare image.el functions that are not preloaded in without-x builds. * lisp/mh-e/mh-utils.el (mh--with-image-load-path): New macro. (mh-logo-display): * lisp/mh-e/mh-tool-bar.el (mh-tool-bar-folder-buttons-init) (mh-tool-bar-letter-buttons-init): Use it to pacify byte-compilation warnings about image.el definitions not preloaded without-x. --- lisp/edmacro.el | 6 ++++++ lisp/mh-e/mh-compat.el | 4 ++++ lisp/mh-e/mh-tool-bar.el | 12 ++---------- lisp/mh-e/mh-utils.el | 37 ++++++++++++++++++++++++------------- 4 files changed, 36 insertions(+), 23 deletions(-) diff --git a/lisp/edmacro.el b/lisp/edmacro.el index e90b3a006e..a4eb574a4c 100644 --- a/lisp/edmacro.el +++ b/lisp/edmacro.el @@ -604,6 +604,12 @@ edmacro-sanitize-for-string (defun edmacro-fix-menu-commands (macro &optional noerror) (if (vectorp macro) (let (result) + ;; Not preloaded in without-x builds. + (require 'mwheel) + (defvar mouse-wheel-down-event) + (defvar mouse-wheel-left-event) + (defvar mouse-wheel-right-event) + (defvar mouse-wheel-up-event) ;; Make a list of the elements. (setq macro (append macro nil)) (dolist (ev macro) diff --git a/lisp/mh-e/mh-compat.el b/lisp/mh-e/mh-compat.el index 659c4354b1..37a12de075 100644 --- a/lisp/mh-e/mh-compat.el +++ b/lisp/mh-e/mh-compat.el @@ -89,9 +89,13 @@ 'mh-face-background (define-obsolete-function-alias 'mh-font-lock-add-keywords #'font-lock-add-keywords "29.1") +;; Not preloaded in without-x builds. +(declare-function image-load-path-for-library "image") (define-obsolete-function-alias 'mh-image-load-path-for-library #'image-load-path-for-library "29.1") +;; Not preloaded in without-x builds. +(declare-function image-search-load-path "image") (define-obsolete-function-alias 'mh-image-search-load-path #'image-search-load-path "29.1") diff --git a/lisp/mh-e/mh-tool-bar.el b/lisp/mh-e/mh-tool-bar.el index 805408cfc7..d199cdb872 100644 --- a/lisp/mh-e/mh-tool-bar.el +++ b/lisp/mh-e/mh-tool-bar.el @@ -213,11 +213,7 @@ mh-tool-bar-define ;; Tool bar initialization functions (defun mh-tool-bar-folder-buttons-init () (when (mh-buffer-exists-p 'mh-folder-mode) - (let* ((load-path (image-load-path-for-library "mh-e" - "mh-logo.xpm")) - (image-load-path (cons (car load-path) - (when (boundp 'image-load-path) - image-load-path)))) + (mh--with-image-load-path (setq mh-folder-tool-bar-map (let ((tool-bar-map (make-sparse-keymap))) ,@(nreverse folder-button-setter) @@ -236,11 +232,7 @@ mh-tool-bar-define tool-bar-map))))) (defun mh-tool-bar-letter-buttons-init () (when (mh-buffer-exists-p 'mh-letter-mode) - (let* ((load-path (image-load-path-for-library "mh-e" - "mh-logo.xpm")) - (image-load-path (cons (car load-path) - (when (boundp 'image-load-path) - image-load-path)))) + (mh--with-image-load-path (setq mh-letter-tool-bar-map (let ((tool-bar-map (make-sparse-keymap))) ,@(nreverse letter-button-setter) diff --git a/lisp/mh-e/mh-utils.el b/lisp/mh-e/mh-utils.el index 93bc7f8d39..b64e6e49c1 100644 --- a/lisp/mh-e/mh-utils.el +++ b/lisp/mh-e/mh-utils.el @@ -119,24 +119,35 @@ mh-replace-string ;;; Logo Display +;;;###mh-autoload +(defmacro mh--with-image-load-path (&rest body) + "Load `image' and eval BODY with `image-load-path' set appropriately." + (declare (debug t) (indent 0)) + `(mh-do-in-gnu-emacs + ;; Not preloaded in without-x builds. + (require 'image) + (defvar image-load-path) + (declare-function image-load-path-for-library "image") + (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm")) + (image-load-path (cons (car load-path) + (and (boundp 'image-load-path) + image-load-path)))) + ,@body))) + (defvar mh-logo-cache nil) ;;;###mh-autoload (defun mh-logo-display () "Modify mode line to display MH-E logo." - (mh-do-in-gnu-emacs - (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm")) - (image-load-path (cons (car load-path) - (when (boundp 'image-load-path) - image-load-path)))) - (add-text-properties - 0 2 - `(display ,(or mh-logo-cache - (setq mh-logo-cache - (mh-funcall-if-exists - find-image '((:type xpm :ascent center - :file "mh-logo.xpm")))))) - (car mode-line-buffer-identification))))) + (mh--with-image-load-path + (add-text-properties + 0 2 + `(display ,(or mh-logo-cache + (setq mh-logo-cache + (mh-funcall-if-exists + find-image '(( :type xpm :ascent center + :file "mh-logo.xpm" )))))) + (car mode-line-buffer-identification)))) -- 2.33.0 --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu) of 2021-10-11 built on tia Repository revision: 2810fe6bfca182e4376d818b5510507d5ff7e1b5 Repository branch: master System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-nox --enable-checking=structs --with-file-notification=yes --with-x-toolkit=no --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm gv subr-x byte-opt bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 multi-tty make-network-process emacs) In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu) of 2021-10-11 built on tia Repository revision: b3d0f53b296a0876ec7a55ae840868e65ed54e14 Repository branch: emacs-28 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-28-nox --enable-checking=structs --with-file-notification=yes --with-x-toolkit=no --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 multi-tty make-network-process emacs) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 17:25:45 2021 Received: (at control) by debbugs.gnu.org; 11 Oct 2021 21:25:45 +0000 Received: from localhost ([127.0.0.1]:32858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma2np-0007Fy-BD for submit@debbugs.gnu.org; Mon, 11 Oct 2021 17:25:45 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:37771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma2nn-0007Fl-Tu for control@debbugs.gnu.org; Mon, 11 Oct 2021 17:25:44 -0400 Received: by mail-wr1-f51.google.com with SMTP id e12so60271147wra.4 for ; Mon, 11 Oct 2021 14:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version; bh=/p0Fs3EH2cAnYRocbgAxAmwfA3uydQ3P8ReDm6Z7bP8=; b=LO4x1Xtv4uwAttInSKCg1L718OSPY8YIusDF+udgsmazxxgTE2DiNoSu4r6UFnUIUU 5fZ1LAjRscJR2ZB4GsEfFK++u2M3iYmJFpOYMEI/LFqj8DATr3Xf7oE+MTxTbKHOwtbs tOZkg47jOdIeLREtx76Gitvh5kmAoLNMXi2OXS0IinNN77WKe0JYxEzlsmQAIWyyta8T u2vPK0IMhzSjG/I988APwyEYpjgu6QBhuOUCrLsCrI/TNdq5xfFBvqPO0Y/zU3yy3D8C vQV5wqkEIzjBmTa1QfG6oXf9+ZCwbRrg0N+k1u2WBEJDwpNPAo6QJE0D+ajZ2TbdO2XE 3AFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=/p0Fs3EH2cAnYRocbgAxAmwfA3uydQ3P8ReDm6Z7bP8=; b=NiZjsi9nG6v0lY5Q9zo2foBL1xFHlRIxUvm8846p0eiT/nmh0suzzZBMqmuvf0CG71 98UO/gfd+n8yXLf3UKJvAUOPjljuwO0QKn+dfI9m+haA/8SUvYswKZRqwLwcGBwm2XBu c5lD8BoBqRV8t13zw7St8iBaHpFNl97MkZ6To2ZlaBuEKkEfEKvHrqIU4G2B1UhwB90t 2c9LbUtn1wys+umggZfh+NTToqX0JP/h/I/UXmyk173nKTXgHhMfJyt8PkPqjH4IdxGg Ng8yov+q9Bh1/OtJOz/OyTCuaROZYl3GqX33Z5HAV+LEtnO2HO2wiicvriFHNdM6dGQE fGPA== X-Gm-Message-State: AOAM531unvnzOymbC5BJtaIFknM7mnW8TUE33t7k3lpaTVTRLvozP/17 D3U2KBEhZwBDn+PDqUwdzqeQrinnn+DXdQ== X-Google-Smtp-Source: ABdhPJzR9qgZL3d4FJQsJUlj/TxVvj4Wdf/G3VXxjhYoOQRLd44truNxFGl2sdi8Oa4CSSWw4UY6TQ== X-Received: by 2002:a7b:c383:: with SMTP id s3mr1545695wmj.60.1633987537609; Mon, 11 Oct 2021 14:25:37 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id o26sm633045wmc.17.2021.10.11.14.25.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 14:25:37 -0700 (PDT) From: "Basil L. Contovounesios" To: control@debbugs.gnu.org Subject: control message for bug #51139 Date: Mon, 11 Oct 2021 22:25:36 +0100 Message-ID: <87r1crl0dr.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) found 51139 28.0.60 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 17:49:35 2021 Received: (at 51139) by debbugs.gnu.org; 11 Oct 2021 21:49:35 +0000 Received: from localhost ([127.0.0.1]:32936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma3As-0001iL-SJ for submit@debbugs.gnu.org; Mon, 11 Oct 2021 17:49:35 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:42512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma3Aq-0001i3-Ap for 51139@debbugs.gnu.org; Mon, 11 Oct 2021 17:49:33 -0400 Received: by mail-wr1-f49.google.com with SMTP id v17so60341402wrv.9 for <51139@debbugs.gnu.org>; Mon, 11 Oct 2021 14:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=guSY0eJ9HrB6XYutkE/VN9aBZT4vHxYkpg1b5gyRhLg=; b=O6aaG/BlO5phRldeTLyTAIm1o6rdofNepFF5UA0EelZE0f+BPU8euFMc9BZ6oBTP9s RYimNVvZW+bRIP9WnCD7HFY2ZdUB5vkaaCvfXiaVp3wAUfbpBMq/+w6cP6eBP2vRfzTh 17+/jA27n+nA95jyQfIvp5lf5EmtnSbW9te9E3wfutLTxr14iElHmDyTTDzZT9kpJg5Y oyLbziV+XK26L4aoYiZyrCVrT8NjzeKp+S8BCnuLdViGrcAC6MFvWbpIeiihL4vN/OX2 hcDWwP9aRqJMIY+ghpIxMee/qzpyUgX7kEueJJrO+gg1sgljSjs32zcMzdQ1864WxuYI 1uvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=guSY0eJ9HrB6XYutkE/VN9aBZT4vHxYkpg1b5gyRhLg=; b=K9IZP+9VuqmWSlOqUOtIultj6a3dx7i8cvJT5yegHRcPVu9w2d2NihLyLr6U57TGpS 06yL065ZdzhIB0fjTGlltS7eDfaQfdLdjnAJOhRAf56DkBfYzYcYnZssQhcoW6ZRomGa fAviWNKBOsyVt9npWtISqq2xJz/Ft4O12JKWJWI8ynyFyFKZSR1Rg4u/7HhbEPMUGe4W HL0hXlpcnWq8e0MAKMf5aizHLarL5ZxVRD58PR30Nw9lECiTgKQFDdmfhW3aYF/sXWIJ F6Q3b/cpBkHgW4FDcmqaC14/4jK7+r7CK6gexNvYdNp/msqxiwxQVnNJtIe3Uv2KNfMp zpkw== X-Gm-Message-State: AOAM5330BeeY8yuOOYkUaeYeY24v/QyhkahfVH9haz+5OUJE9481vjKc M9dVbqRAlYN0vZTpUowww3TJY8hQ04Zb2w== X-Google-Smtp-Source: ABdhPJz7VFdcVUmjjNeiBu1fZHIovF75MkickBhMszp8OkG54unG1ysoWNr8yScfQXJLCzDsZ1NHSw== X-Received: by 2002:adf:a28b:: with SMTP id s11mr27566443wra.153.1633988966094; Mon, 11 Oct 2021 14:49:26 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id z5sm807853wmp.26.2021.10.11.14.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 14:49:25 -0700 (PDT) From: "Basil L. Contovounesios" To: 51139@debbugs.gnu.org Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds References: <87tuhnl0rk.fsf@tcd.ie> Date: Mon, 11 Oct 2021 22:49:24 +0100 In-Reply-To: <87tuhnl0rk.fsf@tcd.ie> (Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors's message of "Mon, 11 Oct 2021 22:17:19 +0100") Message-ID: <87a6jfkza3.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51139 Cc: Dave Gillespie , Bill Wohler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote: > I assume the warnings are not important enough to install anything on > emacs-28, so I attach a patch against master for both sets of warnings. > WDYT? Heh, no sooner had I submitted the patch than it already had conflicts against master after the following change: Remove redundant calls to 'mh-do-in-gnu-emacs' 76d75df8e7 2021-10-11 22:57:43 +0200 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=76d75df8e7 So I've respun it in the attached. -- Basil --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-byte-compilation-warnings-in-nox-builds.patch >From bad4d4ac2abf48ef3c31ba9172c703d1117350cd Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Mon, 11 Oct 2021 19:14:23 +0100 Subject: [PATCH] Fix byte-compilation warnings in nox builds For discussion, see bug#51139. * lisp/edmacro.el (edmacro-fix-menu-commands): Load mwheel to pacify free variable warnings in without-x builds. * lisp/mh-e/mh-compat.el: Declare image.el functions that are not preloaded in without-x builds. * lisp/mh-e/mh-utils.el (mh--with-image-load-path): New macro. (mh-logo-display): * lisp/mh-e/mh-tool-bar.el (mh-tool-bar-folder-buttons-init) (mh-tool-bar-letter-buttons-init): Use it to pacify byte-compilation warnings about image.el definitions not preloaded without-x. --- lisp/edmacro.el | 6 ++++++ lisp/mh-e/mh-compat.el | 4 ++++ lisp/mh-e/mh-tool-bar.el | 12 ++---------- lisp/mh-e/mh-utils.el | 24 ++++++++++++++++++------ 4 files changed, 30 insertions(+), 16 deletions(-) diff --git a/lisp/edmacro.el b/lisp/edmacro.el index e90b3a006e..a4eb574a4c 100644 --- a/lisp/edmacro.el +++ b/lisp/edmacro.el @@ -604,6 +604,12 @@ edmacro-sanitize-for-string (defun edmacro-fix-menu-commands (macro &optional noerror) (if (vectorp macro) (let (result) + ;; Not preloaded in without-x builds. + (require 'mwheel) + (defvar mouse-wheel-down-event) + (defvar mouse-wheel-left-event) + (defvar mouse-wheel-right-event) + (defvar mouse-wheel-up-event) ;; Make a list of the elements. (setq macro (append macro nil)) (dolist (ev macro) diff --git a/lisp/mh-e/mh-compat.el b/lisp/mh-e/mh-compat.el index 839379857f..561e2ec7c8 100644 --- a/lisp/mh-e/mh-compat.el +++ b/lisp/mh-e/mh-compat.el @@ -87,9 +87,13 @@ 'mh-face-background (define-obsolete-function-alias 'mh-font-lock-add-keywords #'font-lock-add-keywords "29.1") +;; Not preloaded in without-x builds. +(declare-function image-load-path-for-library "image") (define-obsolete-function-alias 'mh-image-load-path-for-library #'image-load-path-for-library "29.1") +;; Not preloaded in without-x builds. +(declare-function image-search-load-path "image") (define-obsolete-function-alias 'mh-image-search-load-path #'image-search-load-path "29.1") diff --git a/lisp/mh-e/mh-tool-bar.el b/lisp/mh-e/mh-tool-bar.el index 06b94b6bf8..88e5c0e7bb 100644 --- a/lisp/mh-e/mh-tool-bar.el +++ b/lisp/mh-e/mh-tool-bar.el @@ -213,11 +213,7 @@ mh-tool-bar-define ;; Tool bar initialization functions (defun mh-tool-bar-folder-buttons-init () (when (mh-buffer-exists-p 'mh-folder-mode) - (let* ((load-path (image-load-path-for-library "mh-e" - "mh-logo.xpm")) - (image-load-path (cons (car load-path) - (when (boundp 'image-load-path) - image-load-path)))) + (mh--with-image-load-path (setq mh-folder-tool-bar-map (let ((tool-bar-map (make-sparse-keymap))) ,@(nreverse folder-button-setter) @@ -236,11 +232,7 @@ mh-tool-bar-define tool-bar-map))))) (defun mh-tool-bar-letter-buttons-init () (when (mh-buffer-exists-p 'mh-letter-mode) - (let* ((load-path (image-load-path-for-library "mh-e" - "mh-logo.xpm")) - (image-load-path (cons (car load-path) - (when (boundp 'image-load-path) - image-load-path)))) + (mh--with-image-load-path (setq mh-letter-tool-bar-map (let ((tool-bar-map (make-sparse-keymap))) ,@(nreverse letter-button-setter) diff --git a/lisp/mh-e/mh-utils.el b/lisp/mh-e/mh-utils.el index 4f211c1286..3f1bcbdcc0 100644 --- a/lisp/mh-e/mh-utils.el +++ b/lisp/mh-e/mh-utils.el @@ -119,22 +119,34 @@ mh-replace-string ;;; Logo Display +;;;###mh-autoload +(defmacro mh--with-image-load-path (&rest body) + "Load `image' and eval BODY with `image-load-path' set appropriately." + (declare (debug t) (indent 0)) + `(progn + ;; Not preloaded in without-x builds. + (require 'image) + (defvar image-load-path) + (declare-function image-load-path-for-library "image") + (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm")) + (image-load-path (cons (car load-path) + (and (boundp 'image-load-path) + image-load-path)))) + ,@body))) + (defvar mh-logo-cache nil) ;;;###mh-autoload (defun mh-logo-display () "Modify mode line to display MH-E logo." - (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm")) - (image-load-path (cons (car load-path) - (when (boundp 'image-load-path) - image-load-path)))) + (mh--with-image-load-path (add-text-properties 0 2 `(display ,(or mh-logo-cache (setq mh-logo-cache (mh-funcall-if-exists - find-image '((:type xpm :ascent center - :file "mh-logo.xpm")))))) + find-image '(( :type xpm :ascent center + :file "mh-logo.xpm" )))))) (car mode-line-buffer-identification)))) -- 2.33.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 20:21:44 2021 Received: (at 51139) by debbugs.gnu.org; 12 Oct 2021 00:21:44 +0000 Received: from localhost ([127.0.0.1]:33022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma5Y7-0007XZ-VL for submit@debbugs.gnu.org; Mon, 11 Oct 2021 20:21:44 -0400 Received: from mail-pj1-f43.google.com ([209.85.216.43]:53104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma5Y6-0007XM-Iv for 51139@debbugs.gnu.org; Mon, 11 Oct 2021 20:21:43 -0400 Received: by mail-pj1-f43.google.com with SMTP id oa4so13711022pjb.2 for <51139@debbugs.gnu.org>; Mon, 11 Oct 2021 17:21:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=pIWoJgns23+P0i77jMw4VPErSFWLVDo2dgZfg1SATyE=; b=GVKZzI7gtwk4CmwfUh+ZZv5mRizRzZWhQ1/BOB7cmUnJZ2Bpj1W2Stp+lxfU2UbEN7 gUSRFpViffbjO5qILyEUpgqTTMxio9l8BHbBa7htDZUth+damzN+Z+SBI2ElM6WiOfX/ B4e4yaPM2vtlD90XuFKt5hkFSycYSJhFooLPTHkWl0swq6/cDGLnIZfJwAulK/l76tFh D5eTEl0EmBJmOKII8/LUrAhvn4XKXLbEBXSnvYGaU1IP3tWcaphxNYZUYndoE9KhfScd UdcJbaPL/TiEFkDqq6XlMLT4SXPqLfWYRBVxjMc07PGRnBnXTs2dm1V7TwC3SAuQSUQu H7ag== X-Gm-Message-State: AOAM532+3L+mhnJO7xAjloE/Kupmf0ClYbRG6ZNksNPJi99wu52ERKDb wLnpLpua+HSEeTXoDrISxv9h9nvQNeVhqudTMuc= X-Google-Smtp-Source: ABdhPJzju6ES3AclxgpjKTBbyOHOvhsPBfAuSbBhcGPnGCzDrK319PbnG0KrIdeRaKoHDo91L58wT3qnJt/HL2rNuk0= X-Received: by 2002:a17:90a:5583:: with SMTP id c3mr2311569pji.133.1633998096689; Mon, 11 Oct 2021 17:21:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Oct 2021 17:21:36 -0700 From: Stefan Kangas In-Reply-To: <87a6jfkza3.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 11 Oct 2021 22:49:24 +0100") References: <87tuhnl0rk.fsf@tcd.ie> <87a6jfkza3.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 11 Oct 2021 17:21:36 -0700 Message-ID: Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds To: "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51139 Cc: 51139@debbugs.gnu.org, Dave Gillespie , Bill Wohler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) "Basil L. Contovounesios" writes: > Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote: > >> I assume the warnings are not important enough to install anything on >> emacs-28, so I attach a patch against master for both sets of warnings. >> WDYT? I guess warnings are indeed not important enough for emacs-28, especially if they only affect nox builds. But I'll leave that to the maintainers to decide. > Heh, no sooner had I submitted the patch than it already had conflicts > against master after the following change: I only hope you don't need to re-spin it again after my most recent push... > So I've respun it in the attached. Thanks, LGTM, but maybe someone else wants to take a look as well. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 08:41:21 2021 Received: (at 51139) by debbugs.gnu.org; 12 Oct 2021 12:41:21 +0000 Received: from localhost ([127.0.0.1]:36304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maH5t-00017K-AL for submit@debbugs.gnu.org; Tue, 12 Oct 2021 08:41:21 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:46850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maH5q-00016Y-Ra for 51139@debbugs.gnu.org; Tue, 12 Oct 2021 08:41:19 -0400 Received: by mail-wr1-f49.google.com with SMTP id k7so66424186wrd.13 for <51139@debbugs.gnu.org>; Tue, 12 Oct 2021 05:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UYF2IaE1X8ORdRkcnz2eixlrPJGkNEChcA4O5FdWRuY=; b=NInV/FwTW6cqH+Ucn0mDPXQ84CmrPjmG2B+uMPd5/625bmFK7onk/NPnp98jEzh/Y1 PPWP7691RgEhJf6OhZzIL+Va0bWZAZU69jR2uh1/yDYLOBGy1+1GiaCX80AHYnMLTL/W itDlzShnxpW07WOVZTk0G9e3qn8qGFa6wjzJ+UhYbtZXouo5dceNjKnmBv2MRmQlg4aO zevq+MivXO4URRfpAIgoUFyskgQgYN2uh+ephcdh8t7UhRxe5f6bv+9nWJCEtNsggVlo hqFGEFtgs999MTQasGtevZcp7HPI/Eyl/1Tg3nkmK1WWHG8qnm6ouPMF0eOj2YDVh2Dd 38pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UYF2IaE1X8ORdRkcnz2eixlrPJGkNEChcA4O5FdWRuY=; b=dTUNw+QIoO1+QR3cf7sDYAxeNMLZKRw2DAMPx2J2PtpXtRGAW5QrrOgzBc26wkBr+c n+W1RlH0sG6O0gzQbFAXARXcs5/BdeTg80DwkgGtTXuJr0PBaLfhh2lc0oL6dhjgqyry p5Vm7sdEisg8i029bhlVjEliKZ9z1JulhmSLwkimD/QHiLRsJ03OHevYl3tygYTrzPwn bA5U3RHvHWAaEXgmpMZgmm2njw6okIms/Pg9+OSHX6ToaPGDrqUrhMKTu+eFfHUhaH+O peUML6UnwlHsfza+jOE+bPmobwtdy3CLNhV/tyNbeHpYOd96qmmiLmtCMiStBsxlwNbj V8fw== X-Gm-Message-State: AOAM533+sfmLnTaBVyMJFKMX6xqtoKWa7T3xBJvMR+w5H0MxRihAzwQi 3DYbHPyUyrS+sU+2zccoC31ldg== X-Google-Smtp-Source: ABdhPJwXVerKyscvxIyl0LFW+BCXACAGqtJAITKc508n8HxOdc/vlkXJFqTP/6IgL99WosyQN4trPw== X-Received: by 2002:adf:9b8e:: with SMTP id d14mr31962695wrc.288.1634042472843; Tue, 12 Oct 2021 05:41:12 -0700 (PDT) Received: from localhost ([80.233.59.176]) by smtp.gmail.com with ESMTPSA id o26sm2478007wmc.17.2021.10.12.05.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 05:41:12 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds References: <87tuhnl0rk.fsf@tcd.ie> <87a6jfkza3.fsf@tcd.ie> Date: Tue, 12 Oct 2021 13:41:11 +0100 In-Reply-To: (Stefan Kangas's message of "Mon, 11 Oct 2021 17:21:36 -0700") Message-ID: <87fst6xvo8.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51139 Cc: 51139@debbugs.gnu.org, Bill Wohler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas [2021-10-11 17:21 -0700] wrote: > "Basil L. Contovounesios" writes: > >> Heh, no sooner had I submitted the patch than it already had conflicts >> against master after the following change: > > I only hope you don't need to re-spin it again after my most recent > push... Where would the fun in that be ;). The patch still applies cleanly at the time of writing. It looks like your changes have dropped support for old Emacs versions, though, meaning I can safely incorporate bound-and-true-p in the patch. >> So I've respun it in the attached. > > Thanks, LGTM, but maybe someone else wants to take a look as well. Thanks, I'll give this a bit more time to ferment (and foment) before pushing. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 08:46:27 2021 Received: (at 51139) by debbugs.gnu.org; 12 Oct 2021 12:46:27 +0000 Received: from localhost ([127.0.0.1]:36467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maHAp-0002c7-11 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 08:46:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maHAn-0002W3-07 for 51139@debbugs.gnu.org; Tue, 12 Oct 2021 08:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oGJqakCqmu4POp8bDYPS0qqn2L6UGvFI1HcFZjhnsAM=; b=s8AHyCMOrP0oUxQF3yXVQnLNWH xePHAXsvQcZQtlxYVrkcARYswADaKJgi6/DuqJPvFQQVDt6K9wk53uHce3eDxPJ3WzJWtsiyeWWGV eeWmpldcS0hPI1r1TVqq3Yy9BdbwIa1qABhZ/R1Y2ZXF+YW80nEwAviEzzTPOKfbi8aU=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maHAa-00053w-3S; Tue, 12 Oct 2021 14:46:14 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds References: <87tuhnl0rk.fsf@tcd.ie> X-Now-Playing: Mochipet's _Godzillafather Rick Owens Fogachine_: "Godzillafather Rick Owens Fogachine (Runway Mix)" Date: Tue, 12 Oct 2021 14:46:11 +0200 In-Reply-To: <87tuhnl0rk.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 11 Oct 2021 22:17:19 +0100") Message-ID: <87ily2csx8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > I assume the warnings are not important enough to install anything on > emacs-28, so I attach a patch against master for both sets of warnings. > WDYT? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51139 Cc: 51139@debbugs.gnu.org, Dave Gillespie , Bill Wohler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > I assume the warnings are not important enough to install anything on > emacs-28, so I attach a patch against master for both sets of warnings. > WDYT? Looks good to me (but in master). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 09:06:25 2021 Received: (at 51139) by debbugs.gnu.org; 12 Oct 2021 13:06:25 +0000 Received: from localhost ([127.0.0.1]:37043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maHU8-0004Se-Mw for submit@debbugs.gnu.org; Tue, 12 Oct 2021 09:06:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maHU6-0004SM-Vc for 51139@debbugs.gnu.org; Tue, 12 Oct 2021 09:06:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37860) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maHU0-00084y-JD; Tue, 12 Oct 2021 09:06:16 -0400 Received: from [87.69.77.57] (port=4069 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maHU0-0003kr-6t; Tue, 12 Oct 2021 09:06:16 -0400 Date: Tue, 12 Oct 2021 16:06:08 +0300 Message-Id: <83k0iiqtof.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <87tuhnl0rk.fsf@tcd.ie> (bug-gnu-emacs@gnu.org) Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds References: <87tuhnl0rk.fsf@tcd.ie> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51139 Cc: 51139@debbugs.gnu.org, daveg@synaptics.com, wohler@newt.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Dave Gillespie , Bill Wohler > Date: Mon, 11 Oct 2021 22:17:19 +0100 > From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I see the following byte-compilation warnings in --without-x builds: > > --8<---------------cut here---------------start------------->8--- > In edmacro-fix-menu-commands: > edmacro.el:622:34: Warning: reference to free variable > ‘mouse-wheel-down-event’ > edmacro.el:622:57: Warning: reference to free variable ‘mouse-wheel-up-event’ > edmacro.el:623:34: Warning: reference to free variable > ‘mouse-wheel-right-event’ > edmacro.el:624:34: Warning: reference to free variable > ‘mouse-wheel-left-event’ > > In end of data: > mh-e/mh-compat.el:96:5: Warning: the function ‘image-search-load-path’ is not > known to be defined. > mh-e/mh-compat.el:93:5: Warning: the function ‘image-load-path-for-library’ is > not known to be defined. > In mh-logo-display: > mh-e/mh-utils.el:129:40: Warning: Unused lexical variable `image-load-path' > In mh-tool-bar-folder-buttons-init: > mh-e/mh-tool-bar.el:302:1: Warning: Unused lexical variable `image-load-path' > In mh-tool-bar-letter-buttons-init: > mh-e/mh-tool-bar.el:384:3: Warning: Unused lexical variable `image-load-path' > In end of data: > mh-e/mh-utils.el:128:24: Warning: the function ‘image-load-path-for-library’ > is not known to be defined. > In end of data: > mh-e/mh-tool-bar.el:302:1: Warning: the function ‘image-load-path-for-library’ > is not known to be defined. > --8<---------------cut here---------------end--------------->8--- > > The MH-E warnings are seen on master, whereas the edmacro ones are also > on emacs-28 (details of both configurations follow my signature). > > I assume the warnings are not important enough to install anything on > emacs-28, so I attach a patch against master for both sets of warnings. > WDYT? It's okay to install trivial changes on emacs-28 to shut up those warnings. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 11:59:10 2021 Received: (at 51139) by debbugs.gnu.org; 12 Oct 2021 15:59:10 +0000 Received: from localhost ([127.0.0.1]:50027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maKBK-0002WX-L3 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 11:59:10 -0400 Received: from mail-pj1-f42.google.com ([209.85.216.42]:54268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maKBJ-0002W9-9P for 51139@debbugs.gnu.org; Tue, 12 Oct 2021 11:59:09 -0400 Received: by mail-pj1-f42.google.com with SMTP id ls18so16008548pjb.3 for <51139@debbugs.gnu.org>; Tue, 12 Oct 2021 08:59:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=Vylv7/lFYJVN+srMUaXToR7qcHWzKJ4JdZFS3BgsxGs=; b=Ma2dFtL+XeLOxx6+s+WgXpA5HLbwfOs/TRStpzwfdKJi5HP1lNI3OO7sOBiy3FiSxr 9XCaJen9YO1iUQee+hJmKnhj0AxTiks+3L+z+2pStfYrgTinz3B5bkvKbULabt8r+FiD BG/RMajGsxfc7IX5//jA7rmMushsEs1aZBWrUOKVudJij4I6yQzR8zwtvWhZshvEamn4 mWilCNLUA7vr0xDWgls8Ojuhic08ljUBDLMg2J3oTC+4BfOT0D6J8a738Vaa5WQeFVes dDl9W/VCbIiCQzxaDqIES5AkqClk2fO1TRxADQZw+4IInekG7g0iS9P0dWr8Rf928pAo W7ig== X-Gm-Message-State: AOAM532NW8nGRviU/LbyWE6YE6jTz3xMzB19Q8bSrsCFFl8C+rrTF61f ZE1TZUleI6b4kz3lfiT3X5qeeT5pL0cBjtXgTvc= X-Google-Smtp-Source: ABdhPJzaD4KjuwyRwi/ONDgGvYKzCJIbXDXt1+7dVQiOdGpJAPrBjmQY+C6ciS50n+DhFX+ReSyaN4FCmcgbl80zsHM= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr30551831pls.71.1634054343383; Tue, 12 Oct 2021 08:59:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Oct 2021 08:59:02 -0700 From: Stefan Kangas In-Reply-To: <87fst6xvo8.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 12 Oct 2021 13:41:11 +0100") References: <87tuhnl0rk.fsf@tcd.ie> <87a6jfkza3.fsf@tcd.ie> <87fst6xvo8.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 12 Oct 2021 08:59:02 -0700 Message-ID: Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds To: "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51139 Cc: 51139@debbugs.gnu.org, Bill Wohler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) "Basil L. Contovounesios" writes: > It looks like your changes have dropped support for old Emacs versions, > though, meaning I can safely incorporate bound-and-true-p in the patch. Yup, MH-E is no longer distributed separately from Emacs according to: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51056#14 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 17:51:39 2021 Received: (at 51139) by debbugs.gnu.org; 12 Oct 2021 21:51:39 +0000 Received: from localhost ([127.0.0.1]:54985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maPgQ-0003ZH-UZ for submit@debbugs.gnu.org; Tue, 12 Oct 2021 17:51:39 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:44007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maPgN-0003Yq-Uf for 51139@debbugs.gnu.org; Tue, 12 Oct 2021 17:51:37 -0400 Received: by mail-wr1-f46.google.com with SMTP id r7so1512300wrc.10 for <51139@debbugs.gnu.org>; Tue, 12 Oct 2021 14:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=caa3FwM3MdxDFtKhIjat+Y3bQgXrKalW88230FdytNM=; b=JS43jfzBfQKEo2knwwNwrLGR6Q6KTicP7Ja39srtYQfgGgAbCtpSek8+O5SoATwQOr XB1l8jl0rFwInDehalwls5nw77cjEqOk8iUGOg9qVELe8sc8wmZUhe65f9UdP+ECFZ7Z wAD6KuDfkEOqx1DgzqSuYZoqHBCddifRcZaLN3QA8R0PahYtHvqJKHU3GP4wIjGS1rLK OtRTB/UIr73hT/QQKjNKAzvvaiNSkKnqb+Cqfbn+//PfJXnTmMKEzY4pAhJEr2R1Oip+ I1az8FjvyyKPF/wmE1Q8+BDF8dt7NmLkUIVKZUgbZ5v/y4fe5oRJlc/nTvEjMM4Uk7JX SEFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=caa3FwM3MdxDFtKhIjat+Y3bQgXrKalW88230FdytNM=; b=cXaOW5MH4eHENuePEZZsHQioFlZYfONUDCVHPshZeToknvl77vmROP9KWnHm3XR8bD a6Q7ohcALvKCKpkVYdkWO9GJM098A/Rv2p85NvB4iXRNTM5vHA8CNTwVVMqJXD6yiIPm cMAFZE5JRs9cxJ6dz46NX5WlXuNcHgJZ2LihDuvb8yAsUkilXpmKt87Ivxl+xwjU7PUv DFjyWUohmbXsiimJ43YNQYnkwm+IQy+7VDtHhR0l2jS8MK/MSyoMhFyoJ/9PzsNkjm0/ ISAgkhjy42f4wyTg1CAogZYvTYKpo0D8oqABNRToPrzIMVaw/Prb9csg3cvF0K+NBxBW DV2w== X-Gm-Message-State: AOAM533k/ZEGDu6SuJfLMUtw+aRPl5UV5s4R+BkNrnKd08rWP+03ZMIk Xl4+s826pVteq8MmHLetu+g8/g== X-Google-Smtp-Source: ABdhPJyVxFhAr/ACXvOsTDvuzqfvf90MTDQvJKBsDwuMO45QB5jauYvcL2jWdDd8ps8Usx+fVtrQvA== X-Received: by 2002:a5d:63ca:: with SMTP id c10mr29686545wrw.407.1634075490159; Tue, 12 Oct 2021 14:51:30 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id z5sm4340952wmp.26.2021.10.12.14.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 14:51:29 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds References: <87tuhnl0rk.fsf@tcd.ie> <87ily2csx8.fsf@gnus.org> Date: Tue, 12 Oct 2021 22:51:28 +0100 In-Reply-To: <87ily2csx8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 12 Oct 2021 14:46:11 +0200") Message-ID: <87pms9ewtb.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51139 Cc: 51139@debbugs.gnu.org, Dave Gillespie , Bill Wohler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 51139 29.1 quit Lars Ingebrigtsen [2021-10-12 14:46 +0200] wrote: > "Basil L. Contovounesios" writes: > >> I assume the warnings are not important enough to install anything on >> emacs-28, so I attach a patch against master for both sets of warnings. >> WDYT? > > Looks good to me (but in master). Thanks, done. Fix byte-compilation warnings in nox builds bcb43fbc95 2021-10-12 22:32:03 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=bcb43fbc95 -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 18:57:46 2021 Received: (at 51139) by debbugs.gnu.org; 24 Oct 2021 22:57:47 +0000 Received: from localhost ([127.0.0.1]:41259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1memR0-0003hu-Kn for submit@debbugs.gnu.org; Sun, 24 Oct 2021 18:57:46 -0400 Received: from se6-iad1.servconfig.com ([144.208.77.50]:43973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1memQy-0003hm-Us for 51139@debbugs.gnu.org; Sun, 24 Oct 2021 18:57:46 -0400 Received: from ecbiz204.inmotionhosting.com ([198.46.81.33]) by se6-iad1.servconfig.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1memQt-000rFx-I9; Sun, 24 Oct 2021 18:57:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-ID:Content-Type:MIME-Version:References: In-reply-to:Subject:From:cc:To:Sender:Reply-To:Content-Transfer-Encoding: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uoIR7PNGw71QB+JA/+nynyxmzHQjZ4cuETjSAGoUdJ0=; b=AHvkwrLhavSsz5BLNXKlliieu4 /S05Ltf8UZA0LSWfmKmVbp+UD3Bjit0Q16APvALlGRj5VQrl5l+7sz+h/xLaeVEx5M4srR4oqAZ7g mZvWoI18i1Z59IlyNLBlvh0LbuL1dLAy7DnHNopUl+LJ3CrfpJceXCPoXsx/TJrYb/FH/n28fhGFD ZVfZxoqUdSuqmPcm4ZaxaFA+dB5Ystv8AQ22axyxGGgHjG/eTaRTpBg85yGtzvbLaSsijXHeLBTWZ CnJsRi2832HiJNBhH3FhbGGABurdqoe8EPq7u+nuFsZXC2vABB4IJxk0wyrtzk/ghK9Qeiw1fDz47 9gNaw8fQ==; Received: from [67.180.9.78] (port=41768 helo=olgas.newt.com) by ecbiz204.inmotionhosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1memQs-008UHZ-EX; Sun, 24 Oct 2021 18:57:38 -0400 Received: by olgas.newt.com (Postfix, from userid 1000) id A6D2F38014C; Sun, 24 Oct 2021 15:57:37 -0700 (PDT) To: Stefan Kangas From: Bill Wohler Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds In-reply-to: References: <87tuhnl0rk.fsf@tcd.ie> <87a6jfkza3.fsf@tcd.ie> Comments: In-reply-to Stefan Kangas message dated "Mon, 11 Oct 2021 17:21:36 -0700." Organization: Newt Software X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4174817.1635116257.1@olgas.newt.com> Date: Sun, 24 Oct 2021 15:57:37 -0700 Message-ID: <4174818.1635116257@olgas.newt.com> X-Get-Message-Sender-Via: ecbiz204.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz204.inmotionhosting.com: wohler@newt.com X-Originating-IP: 198.46.81.33 X-SpamExperts-Domain: ecbiz204.inmotionhosting.com X-SpamExperts-Username: 198.46.81.33 Authentication-Results: servconfig.com; auth=pass smtp.auth=198.46.81.33@ecbiz204.inmotionhosting.com X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.11) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT9UQH3tM27ax8lrF2r2m2HYPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5y0W1CIjLnh3zadRM2Y8iCcHeCwJ9I0DHFQi0JFRjCbiB5E Dccoacf7Ff+pR6ciZvwPuURbWk5IGAt4ErS951OcdE5nRl5c/7Fv7vqeTq/ccN3uWPxLc0PS2jR6 oIt+4YPMa/SbiULewxCZwUj78mcWcBAM/mbsWZf7TpyxnxseLdJgJYPBDt0LiUyTMDYm/pdAEvdl YOvVlene5we7iME7qi7AB5Nu7G5PyMYaa2xMz8JG4stXp3VIAuwo5+yZ1nRSwTHU8FzoG+u1bWvS v9I56JWy0gryioZgSgzleQe3vGVBapgDZRcc6jBP7xBVd8bGqqLq1mqfP4rTv5j2D5aOq+q1XPjS gYCrnIBvTFe8mnNVJBqo7HIsiC3qxMPBVxZwvSfE38dBQz1AyVOSufEGax/4hIM385pzFwSMDKHj 6O7rHPLlkg+Kb8pW3Wt3FISsZm+FB8yckvFZiHWxnQEMkunODYtbvP72vAmOyjpz9dv5vPrmU8uF cfiUrAVqSBk5Fu/nq1mfdqvGyP7QRMmuysatj2pSf8Y/sjw2Tx7jGlOIjEOAq7+zlZIMXkjo8jed yeqIoZhC5dHoyWeT+unFGJ9FFggCAznkY0NIg+2syDmktWjR/MYq8yY3VVTv1Rkhaep+euoQTJhd J2HwLe1ODFo7FFfy37M2HNlMXbrVTDoTmUx4E3O/ov/E/pka7aEtS2nKTQh6ycymJVvBdfE5Yg1P R2vYIIrzHiR4zSVuQOUaPmyGf2RpDAe2+GxbbXWJ5a1SXsXEWTe2oL85zR2dnqlRrAzOTcIqqzy+ TSxKPtc0EnI+TKo06CaSOtR2uDvFMAjVBN/Cg2hvWaJoPQmHUV8ShebT8U8Xw9HTDfreWR3jtq+R ZAV4Tmx13eTR2lhM8jeeJSytG/Wf88r2kBubw4sFChcve9ROq6NugqFoiq8NOkem8ZrIsOxSJo9M gnux/ZWhKk0p7EUea7B7TmRSGggrgV1gqyIQsozLFOWHQjkW7+erWZ92q8bI/tBEya4oggaqweLz Jh6Y5sesEwwcQhLi9oJFAzc6V7cDXIvM+WZnEFi54XA0ckc4cXzuLXL2OKHH5lr9xXvSM4nM3avg X-Report-Abuse-To: spam@se1-lax1.servconfig.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51139 Cc: "Basil L. Contovounesios" , 51139@debbugs.gnu.org, Dave Gillespie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas wrote: > "Basil L. Contovounesios" writes: > > > Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote: > > > >> I assume the warnings are not important enough to install anything on > >> emacs-28, so I attach a patch against master for both sets of warnings. > >> WDYT? > > I guess warnings are indeed not important enough for emacs-28, > especially if they only affect nox builds. But I'll leave that to the > maintainers to decide. > > > Heh, no sooner had I submitted the patch than it already had conflicts > > against master after the following change: > > I only hope you don't need to re-spin it again after my most recent > push... > > > So I've respun it in the attached. > > Thanks, LGTM, but maybe someone else wants to take a look as well. LGTM too, and so far MH-E on master is still working... Thanks all! -- Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD From unknown Sat Aug 09 04:49:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Nov 2021 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator