Subject: [bug#51113] [PATCH] gnu: Add snooze.

From: jgart <[email-masked]>
Date: Tue, 19 Oct 2021 02:16:20 -0400

On Wed, 13 Oct 2021 21:28:48 +0200 Nicolas Goaziou <[email-masked]> wrote:
> Hello,
> 
> jgart via Guix-patches via <[email-masked]> writes:
> 
> > * gnu/packages/suckless.scm (snooze): New variable.
> 
> Thank you. Some comments follow.
> 
> > +    (arguments
> > +     `(#:tests? #f
> 
> Could you add a comment explaining why tests are disabled? I assume
> upstream does not provide any.
> 
> > +       #:make-flags
> > +       (list (string-append "CC=" ,(cc-for-target))
> > +             (string-append "DESTDIR=" %output)
> > +             "PREFIX=")
> 
> It may be worth explaining in a comment why PREFIX is reset.
> 
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (delete 'configure))))
> > +    (home-page "https://github.com/leahneukirchen/snooze")
> > +    (synopsis "Run a command at a particular time")
> > +    (description
> > +"@command{snooze} is a new tool for waiting until a particular time and then
> > +running a command.")
> 
> I would remove "new" from the description.
> 
> Otherwise, LGTM. Could you send an updated patch?

Hi Nicolas,

I forgot to CC you.

The updated patch is above. Thank you for taking the time to review the patch.

all best,

jgart