From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 10 03:53:58 2021 Received: (at submit) by debbugs.gnu.org; 10 Oct 2021 07:53:58 +0000 Received: from localhost ([127.0.0.1]:54403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZTeg-0008EG-Hm for submit@debbugs.gnu.org; Sun, 10 Oct 2021 03:53:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:47608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZTef-0008E9-Ku for submit@debbugs.gnu.org; Sun, 10 Oct 2021 03:53:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZTef-00083f-Cz for guix-patches@gnu.org; Sun, 10 Oct 2021 03:53:57 -0400 Received: from mx1.dismail.de ([78.46.223.134]:13240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZTec-00024h-V2 for guix-patches@gnu.org; Sun, 10 Oct 2021 03:53:57 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 3e34bb08 for ; Sun, 10 Oct 2021 09:53:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=qhiMq1qWm8tzygjbw0UybLsA5P726w7CpQrmoHMOJ30=; b= lE9UA/ArujoCsvFl96f9OPTx1fEQgmioQ1VVrpTB/2qIbnAbzUrFCoqbH4pk+hEn BDCFs4ILvfk/8wzeBhKD2tgQ9RkrJ/aD7v08WH4fTTdft6cK9T0pBrlW63HNlYfs e3I2rAZrXWA1XuDa7nLMpaJfCpCoByI0VE+eTIj7ckwh9pTJUPYVwIcRA8NAP0do LMqAw1F3wH/awe+++JZUjYJWEZkOuXnd0UiY9TfNnwHFJpXuomaJzKFyyPs7CFHN LRBhHi+24eYW2bC2Zpcn4ZHfboqxIrfOLLEJyeWPkVXrFX2G9Lx4DavCH0UjhKAG uMOcMpJWuPOP2pKW1xOcQg== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 1dc979d3 for ; Sun, 10 Oct 2021 09:53:49 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 10017320 for ; Sun, 10 Oct 2021 09:53:49 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 96048cd2 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sun, 10 Oct 2021 09:53:48 +0200 (CEST) From: jgart To: guix-patches@gnu.org Subject: [PATCH] gnu: Add snooze. Date: Sun, 10 Oct 2021 03:53:39 -0400 Message-Id: <20211010075339.22230-1-jgart@dismail.de> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/suckless.scm (snooze): New variable. --- gnu/packages/suckless.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index b24eced379..1643c89990 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -873,6 +873,37 @@ It is a front end for ii-like chat programs. It uses @code{tail -f} to get the chat output in the background.") (license license:isc)))) +(define-public snooze + (package + (name "snooze") + (version "0.5") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/leahneukirchen/snooze") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "02ng3r1gzgpyjia4b60i11dj5bhn3xjsdcbwmxaam6dzb33dmgib")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f + #:make-flags + (list (string-append "CC=" ,(cc-for-target)) + (string-append "DESTDIR=" %output) + "PREFIX=") + #:phases + (modify-phases %standard-phases + (delete 'configure)))) + (home-page "https://github.com/leahneukirchen/snooze") + (synopsis "Run a command at a particular time") + (description +"@command{snooze} is a new tool for waiting until a particular time and then +running a command.") + (license license:cc0))) + (define-public scron (package (name "scron") -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 15:28:56 2021 Received: (at submit) by debbugs.gnu.org; 13 Oct 2021 19:28:56 +0000 Received: from localhost ([127.0.0.1]:33515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majvs-0008R0-Dl for submit@debbugs.gnu.org; Wed, 13 Oct 2021 15:28:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:43760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majvr-0008Qk-AA for submit@debbugs.gnu.org; Wed, 13 Oct 2021 15:28:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1majvr-0001is-0r for guix-patches@gnu.org; Wed, 13 Oct 2021 15:28:55 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1majvo-0003Gj-Rn for guix-patches@gnu.org; Wed, 13 Oct 2021 15:28:54 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 47E67FF802; Wed, 13 Oct 2021 19:28:48 +0000 (UTC) From: Nicolas Goaziou To: jgart via Guix-patches via Subject: Re: [bug#51113] [PATCH] gnu: Add snooze. References: <20211010075339.22230-1-jgart@dismail.de> Date: Wed, 13 Oct 2021 21:28:48 +0200 In-Reply-To: <20211010075339.22230-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Sun, 10 Oct 2021 03:53:39 -0400") Message-ID: <87mtnc7mhb.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@nicolasgoaziou.fr; helo=relay9-d.mail.gandi.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: jgart , 51113@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, jgart via Guix-patches via writes: > * gnu/packages/suckless.scm (snooze): New variable. Thank you. Some comments follow. > + (arguments > + `(#:tests? #f Could you add a comment explaining why tests are disabled? I assume upstream does not provide any. > + #:make-flags > + (list (string-append "CC=" ,(cc-for-target)) > + (string-append "DESTDIR=" %output) > + "PREFIX=") It may be worth explaining in a comment why PREFIX is reset. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure)))) > + (home-page "https://github.com/leahneukirchen/snooze") > + (synopsis "Run a command at a particular time") > + (description > +"@command{snooze} is a new tool for waiting until a particular time and then > +running a command.") I would remove "new" from the description. Otherwise, LGTM. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 17:30:23 2021 Received: (at 51113) by debbugs.gnu.org; 13 Oct 2021 21:30:23 +0000 Received: from localhost ([127.0.0.1]:33771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1malpO-00022W-SM for submit@debbugs.gnu.org; Wed, 13 Oct 2021 17:30:23 -0400 Received: from mx1.dismail.de ([78.46.223.134]:22962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1malpM-00022F-Md for 51113@debbugs.gnu.org; Wed, 13 Oct 2021 17:30:22 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id cecd6f25; Wed, 13 Oct 2021 23:30:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=yzdxLoT1lXGzeqvip6zbG7KjSub+UdF3b9CF2dNMhHg=; b= LaDr5SDehiyj6S0ycn9GAWiASkTlcXyshBaagNQsmby9thr2UjxKq8Uf9uB2/Zgp LKmCxLfhehYRrcC3Nwc5aP77149k+hfC/LBLBrCblOug7GbFx0B/Y674xCiv1uon IA5V9Med8k920QWHfrnOjD8/UWkEKVcFAaeLZaRyrmvL2ucrhx5VLIdv0iD1uKSA paO/6gx3OrXgP44hMhaEIVFMAv5giLuGbEYJJdCsKSMdBgdgY7smGsBGxdgLBU1q MtSbXqcaEBFrgwf2CKMbrW2Oli+RfbAlWbN1HMyXTaJ+HIukxGqJ2URnkVoAsiHQ 7yJSpeXq+J2SyyYggdHKwg== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id c22f37c7; Wed, 13 Oct 2021 23:30:11 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id ddabde7f; Wed, 13 Oct 2021 23:30:11 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 179b714e (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 13 Oct 2021 23:30:11 +0200 (CEST) From: jgart To: 51113@debbugs.gnu.org Subject: [PATCH] gnu: Add snooze. Date: Wed, 13 Oct 2021 17:28:09 -0400 Message-Id: <20211013212808.10334-1-jgart@dismail.de> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51113 Cc: jgart , Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Nicolas, thanks for reviewing the patch. Here's a new patch with your suggestions. * gnu/packages/suckless.scm (snooze): New variable. --- gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index b24eced379..d207a2300b 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -873,6 +873,39 @@ It is a front end for ii-like chat programs. It uses @code{tail -f} to get the chat output in the background.") (license license:isc)))) +(define-public snooze + (package + (name "snooze") + (version "0.5") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/leahneukirchen/snooze") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "02ng3r1gzgpyjia4b60i11dj5bhn3xjsdcbwmxaam6dzb33dmgib")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; There are no tests. + #:make-flags + (list (string-append "CC=" ,(cc-for-target)) + (string-append "DESTDIR=" %output) + ;; Set prefix path to root of package path in store instead + ;; of /usr/local. + (string-append "PREFIX=" %output)) + #:phases + (modify-phases %standard-phases + (delete 'configure)))) + (home-page "https://github.com/leahneukirchen/snooze") + (synopsis "Run a command at a particular time") + (description +"@command{snooze} is a tool for waiting until a particular time and then +running a command.") + (license license:cc0))) + (define-public scron (package (name "scron") -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 02:16:31 2021 Received: (at 51113) by debbugs.gnu.org; 19 Oct 2021 06:16:31 +0000 Received: from localhost ([127.0.0.1]:49170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mciQI-0007YC-PO for submit@debbugs.gnu.org; Tue, 19 Oct 2021 02:16:30 -0400 Received: from mx1.dismail.de ([78.46.223.134]:21853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mciQH-0007Xy-Pw for 51113@debbugs.gnu.org; Tue, 19 Oct 2021 02:16:30 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 055d8cac; Tue, 19 Oct 2021 08:16:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=kX06ry28eqGotHY1niY3W29239FCGhH5R5s+x7IJrNk=; b=ENF 8196pzVfMHjV8FoBks6YW/Fb1KhgR1Lw84oXPdYaWkfg1Z7MSs/vcRQPBntyt2nz TkxPvkPDPDPKpepodRSCnXFAkcyH2SEGBVi63xv+NJr73loO7hD43476jl4+/91W mCONTrzL+Gbbq7yLPlCdUyrTmdo+3YuJmjXiFyWbPDUUms0iCppGZHqmZRhSR9MC Pe6/spUzfqxEFc3gQm0LTrxF48FIM6V5TPVcmXTEYJccMz1itKmIe0n5YxLVvBnL VUNgUlIc8o5znFQkCNl3YBbKkOWEv4fykDRH5/R21s60M8t8NOK4pZFrM1NM/KMv vmKMlgjgDSz+LArVA+g== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 72434834; Tue, 19 Oct 2021 08:16:23 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 098414bb; Tue, 19 Oct 2021 08:16:23 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id b52d3dc4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 19 Oct 2021 08:16:22 +0200 (CEST) Date: Tue, 19 Oct 2021 02:16:20 -0400 Message-ID: <20211019021620.GB8758@gac.attlocal.net> From: jgart To: Nicolas Goaziou Subject: Re: [bug#51113] [PATCH] gnu: Add snooze. In-Reply-To: <87mtnc7mhb.fsf@nicolasgoaziou.fr> References: <20211010075339.22230-1-jgart@dismail.de> <87mtnc7mhb.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51113 Cc: 51113@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 13 Oct 2021 21:28:48 +0200 Nicolas Goaziou wrote: > Hello, > > jgart via Guix-patches via writes: > > > * gnu/packages/suckless.scm (snooze): New variable. > > Thank you. Some comments follow. > > > + (arguments > > + `(#:tests? #f > > Could you add a comment explaining why tests are disabled? I assume > upstream does not provide any. > > > + #:make-flags > > + (list (string-append "CC=" ,(cc-for-target)) > > + (string-append "DESTDIR=" %output) > > + "PREFIX=") > > It may be worth explaining in a comment why PREFIX is reset. > > > + #:phases > > + (modify-phases %standard-phases > > + (delete 'configure)))) > > + (home-page "https://github.com/leahneukirchen/snooze") > > + (synopsis "Run a command at a particular time") > > + (description > > +"@command{snooze} is a new tool for waiting until a particular time and then > > +running a command.") > > I would remove "new" from the description. > > Otherwise, LGTM. Could you send an updated patch? Hi Nicolas, I forgot to CC you. The updated patch is above. Thank you for taking the time to review the patch. all best, jgart From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 21 18:13:34 2021 Received: (at 51113-done) by debbugs.gnu.org; 21 Oct 2021 22:13:34 +0000 Received: from localhost ([127.0.0.1]:58855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdgJa-0001Qi-Lv for submit@debbugs.gnu.org; Thu, 21 Oct 2021 18:13:34 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdgJW-0001QO-Q4 for 51113-done@debbugs.gnu.org; Thu, 21 Oct 2021 18:13:33 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5259620004; Thu, 21 Oct 2021 22:13:23 +0000 (UTC) From: Nicolas Goaziou To: jgart Subject: Re: [PATCH] gnu: Add snooze. References: <20211013212808.10334-1-jgart@dismail.de> Date: Fri, 22 Oct 2021 00:13:20 +0200 In-Reply-To: <20211013212808.10334-1-jgart@dismail.de> (jgart@dismail.de's message of "Wed, 13 Oct 2021 17:28:09 -0400") Message-ID: <87k0i6vxfj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51113-done Cc: 51113-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, jgart writes: > Hi Nicolas, thanks for reviewing the patch. > > Here's a new patch with your suggestions. > > * gnu/packages/suckless.scm (snooze): New variable. Applied. Thank you. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 26 18:28:07 2021 Received: (at 51113) by debbugs.gnu.org; 26 Oct 2021 22:28:07 +0000 Received: from localhost ([127.0.0.1]:47791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfUvP-0000Mm-2F for submit@debbugs.gnu.org; Tue, 26 Oct 2021 18:28:07 -0400 Received: from tobias.gr ([80.241.217.52]:54104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfUvN-0000MT-1h; Tue, 26 Oct 2021 18:28:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=dgbnmNFX1LZn3 YbonfFw/oF2HLaFTR99dEDvbsSGC84=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=Sq/AnUKnr04lECIG4+wWeaMMQh0A+PnnmoFMnp 6OzJsSQHH7mZs5MYqUIXECBjjNjaCoipF+AxA830wrPVfgre7/Ohj+TD1YMnZ1xNk0kJkf x20xO3pUK4UVu242UMYKQ8XeTq/eGbG9aW+Dyhk0XvVU0w8SfbNuv3QwfDMPgdXnqc1/tW EuagyzqPD8Exvh1XxvEpLsA6qlAnICtA7Clt3TkrKHNfGNdVPZ7vVnp8RzUe6sAwPC89k7 sTWrwVGEwZbcqkfDnWmVlc4YYP4Ev2YW7sP+Sf1CgoZOYmgdgTIT2jrrwWpzbythpUQXOS gtPNCnUJYqOKtQxO5fG84AHg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 97beeb09 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 26 Oct 2021 22:27:57 +0000 (UTC) References: From: Tobias Geerinckx-Rice To: Christopher Howard Subject: Re: bug#51424: snooze: malformed installation path Date: Wed, 27 Oct 2021 00:13:47 +0200 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87a6ivl8u0.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51113 Cc: 51113@debbugs.gnu.org, jgart , 51424-done@debbugs.gnu.org, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Christopher, jgart, Nicolas, Christopher Howard =E5=86=99=E9=81=93=EF=BC=9A > the path to the binary is malformed: Indeed it was. DESTDIR does not mean =E2=80=98final destination=E2=80=99; it's meant as a= =20 temporary install-time =E2=80=98staging=E2=80=99 directory whose contents a= re=20 expected to move back to / later. For example, =E2=80=98make install=20 DESTDIR=3D/tmp/my-package-manager-output && cd=20 /tmp/my-package-manager-output && tar cf foo.pkg .=E2=80=99. Guix does=20 not use this packaging method. Setting DESTDIR in Guix is almost always a bug. The few places in=20 Guix where it is used are using it as a hack around buggy build=20 systems. It just happens to work (because, well, the build=20 system's buggy). When reviewing patches, I find the =E2=80=98tree=E2=80=99 command very usef= ul to=20 immediately spot such weirdness. Much more so than =E2=80=98ls -R=E2=80=99= .=20 YMMV. Fixed in commit 89d8417b371f3918f0508bbc561675ec100a6add. Thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYXiBBw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15/ToBAJ3U9FOfWPmJV6XU2d5P/nEIpIL8yc6flqYYyBS4 /VR+APwPjRMOfR4OzxYDAtIDRwqc6FsQI2ZHv/kZvqGOe1GsDA== =B9PA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 26 20:03:36 2021 Received: (at 51113) by debbugs.gnu.org; 27 Oct 2021 00:03:36 +0000 Received: from localhost ([127.0.0.1]:47928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfWPo-0005DF-Ba for submit@debbugs.gnu.org; Tue, 26 Oct 2021 20:03:36 -0400 Received: from mx1.dismail.de ([78.46.223.134]:6322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfWPm-0005Ct-5G; Tue, 26 Oct 2021 20:03:35 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 92cf1404; Wed, 27 Oct 2021 02:03:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=LaNT1AWOrQFwX4QL6x3IsVKagjr2M89hyGKoPRn8/ts=; b=Ai4 CTfwEQx+086mgjDrkMENL+uBKHQdrUFGWnS3g0qYrxOfAtxC0ebnn1iaxkor2kPJ YdqML0WgEUeBDXQ/EjAh8sZcEcajA7rU3polVJ8qOjdZc8PeAFH1c9DqsySYyFa4 MOE1e1l0oviR77nCGP8d55ZB5as4vE92DbKb71fUCFLCxZQ72CrcSBykVUDcpz4c IeidW3G3SsjUNy6Ynnh3jU2KJRvbttVeCZvfyDbZ8Kc2McmWzwEH8cQTiS9TBWrY 6LpSLcxQXvfP9CuC3cZxv8DEFF8H2HRjQgc3iUpERxbr/p6RQ6KhnipLPxFHavyJ pMQZhT2JxH4JaD86xBg== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 45e62a3a; Wed, 27 Oct 2021 02:03:26 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id dd6b5e45; Wed, 27 Oct 2021 02:03:26 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id a418518c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 27 Oct 2021 02:03:25 +0200 (CEST) Date: Tue, 26 Oct 2021 20:03:22 -0400 Message-ID: <20211026200322.GB9051@gac.attlocal.net> From: jgart To: Tobias Geerinckx-Rice Subject: Re: bug#51424: snooze: malformed installation path In-Reply-To: <87a6ivl8u0.fsf@nckx> References: <87a6ivl8u0.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51113 Cc: Christopher Howard , 51113@debbugs.gnu.org, 51424-done@debbugs.gnu.org, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 27 Oct 2021 00:13:47 +0200 Tobias Geerinckx-Rice wrote: > Christopher, jgart, Nicolas, > > Christopher Howard 写道： > > the path to the binary is malformed: > > Indeed it was. > > DESTDIR does not mean ‘final destination’; it's meant as a > temporary install-time ‘staging’ directory whose contents are > expected to move back to / later. For example, ‘make install > DESTDIR=/tmp/my-package-manager-output && cd > /tmp/my-package-manager-output && tar cf foo.pkg .’. Guix does > not use this packaging method. > > Setting DESTDIR in Guix is almost always a bug. The few places in > Guix where it is used are using it as a hack around buggy build > systems. It just happens to work (because, well, the build > system's buggy). > > Fixed in commit 89d8417b371f3918f0508bbc561675ec100a6add. > > Thanks! > > T G-R > When reviewing patches, I find the ‘tree’ command very useful to > immediately spot such weirdness. Much more so than ‘ls -R’. > YMMV. I use nnn or another file manager like broot sometimes but this one escaped me. Thanks for fixing that. I was actually going to send a patch fix for it but had not found the time. I noticed it after the patch was accepted. Thanks! all best, jgart From unknown Sat Jun 21 03:17:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 24 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator