From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 08 18:59:18 2021 Received: (at submit) by debbugs.gnu.org; 8 Oct 2021 22:59:19 +0000 Received: from localhost ([127.0.0.1]:52071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYypi-0006PJ-OB for submit@debbugs.gnu.org; Fri, 08 Oct 2021 18:59:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:43272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYyph-0006PB-GH for submit@debbugs.gnu.org; Fri, 08 Oct 2021 18:59:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYypg-0006O8-RE for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 18:59:17 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYypc-0007Ai-Pg for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 18:59:15 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2564F16008A; Fri, 8 Oct 2021 15:59:07 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id usIl2bwtqMBD; Fri, 8 Oct 2021 15:59:06 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7152D1600A7; Fri, 8 Oct 2021 15:59:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uz86geS1Ordk; Fri, 8 Oct 2021 15:59:06 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4CBE516008A; Fri, 8 Oct 2021 15:59:06 -0700 (PDT) To: Emacs bug reports and feature requests From: Paul Eggert Organization: UCLA Computer Science Department Subject: comp-tests.elc messes up after reconfiguring for different machine Message-ID: Date: Fri, 8 Oct 2021 15:59:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When trying out the emacs-28 branch on both 32- and 64-bit platforms, I=20 had test failures that I tracked down to this line: test/src/comp-tests.el:933: (integer ,most-negative-fixnum=20 ,most-positive-fixnum)) My problem was that I'd built test/src/comp-tests.elc on a 32-bit=20 platform (using "./configure CC=3D'gcc -m32'" on an x86-64 machine) so=20 that .elc file had been built assuming 32-bit values for=20 most-negative-fixnum and most-positive fixnum. When I then re-ran=20 'configure' for a 64-bit platform the .elc files were not automatically=20 rebuilt for it (they're supposed to be machine-independent, right?) and=20 so the optimizations were incorrect for a 64-bit platform and the tests=20 failed. What's a good way to fix this problem, while still testing everything=20 that comp-tests.el wants to test? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 07:16:08 2022 Received: (at 51104) by debbugs.gnu.org; 12 Sep 2022 11:16:08 +0000 Received: from localhost ([127.0.0.1]:44325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhQ7-0006yt-Q4 for submit@debbugs.gnu.org; Mon, 12 Sep 2022 07:16:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhQ5-0006y0-IV for 51104@debbugs.gnu.org; Mon, 12 Sep 2022 07:16:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=H7V4GdpzKv5gz25UglxHMOzBclvzqluPH1qPBaMRKVE=; b=W3yrpAZ/51Z7BUFPC7baMdnaZc zkWVU6CpghbjMV7TJwxOiI0xuA4XSSf/RG9zt1LawSC05jwsWMv8/FNhhrQnj47HuKoTmrHiTcqw/ UM64oMuNRLZkc8d3DzVcPn2qs+aaZyjDFXPJL9Ph1SgIVeVFSsydwACREwDlurB2cYnM=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhPw-0005a2-QC; Mon, 12 Sep 2022 13:15:59 +0200 From: Lars Ingebrigtsen To: Paul Eggert Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine In-Reply-To: (Paul Eggert's message of "Fri, 8 Oct 2021 15:59:06 -0700") References: X-Now-Playing: Django Django's _Django Django (Remaster)_: "Zumm Zumm" Date: Mon, 12 Sep 2022 13:15:56 +0200 Message-ID: <87h71c972r.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Paul Eggert writes: > When trying out the emacs-28 branch on both 32- and 64-bit platforms, > I had test failures that I tracked down to this line: > > test/src/comp-tests.el:933: (integer ,most-negative-fixnum > ,most-p [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Paul Eggert writes: > When trying out the emacs-28 branch on both 32- and 64-bit platforms, > I had test failures that I tracked down to this line: > > test/src/comp-tests.el:933: (integer ,most-negative-fixnum > ,most-positive-fixnum)) > > My problem was that I'd built test/src/comp-tests.elc on a 32-bit > platform (using "./configure CC='gcc -m32'" on an x86-64 machine) so > that .elc file had been built assuming 32-bit values for > most-negative-fixnum and most-positive fixnum. When I then re-ran > 'configure' for a 64-bit platform the .elc files were not > automatically rebuilt for it (they're supposed to be > machine-independent, right?) and so the optimizations were incorrect > for a 64-bit platform and the tests failed. > > What's a good way to fix this problem, while still testing everything > that comp-tests.el wants to test? This was a year ago, but the code in question seems unchanged now on "master": ;; 14 ((defun comp-tests-ret-type-spec-f (x) (comp-hint-fixnum x)) (integer ,most-negative-fixnum ,most-positive-fixnum)) So I guess the problem is still present? (I haven't tested myself.) Andrea, do you see any way to fix this test for this 32-bit/64-bit scenarion? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 07:16:15 2022 Received: (at control) by debbugs.gnu.org; 12 Sep 2022 11:16:15 +0000 Received: from localhost ([127.0.0.1]:44328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhQF-0006zC-5m for submit@debbugs.gnu.org; Mon, 12 Sep 2022 07:16:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhQD-0006yv-C7 for control@debbugs.gnu.org; Mon, 12 Sep 2022 07:16:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RbwoXK7nFjJ/sobAv4ybS2dvgmt6pr3JSBAxFi83fQw=; b=E74qw8t8uTmsoQ2Bnuqismq1eS 0r9zMVo5CoeKrjCVpgky1c5nTWIWwXP491L3ny5G1jMZ78VcOkDQlCBEzzGe6+ICR1u1ut/vvuX6v e88NhD6TDOwepTldZNQUxFdCzxS3jrL7+gySrQZc0LRzEhbh/0dLayhWaSPzrh1vVoEs=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhQ5-0005aG-OG for control@debbugs.gnu.org; Mon, 12 Sep 2022 13:16:07 +0200 Date: Mon, 12 Sep 2022 13:16:05 +0200 Message-Id: <87fsgw972i.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51104 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: severity 51104 minor quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 51104 minor quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 07:16:19 2022 Received: (at control) by debbugs.gnu.org; 12 Sep 2022 11:16:19 +0000 Received: from localhost ([127.0.0.1]:44331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhQJ-0006za-DO for submit@debbugs.gnu.org; Mon, 12 Sep 2022 07:16:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhQH-0006z3-6B for control@debbugs.gnu.org; Mon, 12 Sep 2022 07:16:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S7jDKWIqYKEJvbbda0xdz0huZd0ZJRR2sb6gDFhWHpI=; b=PnV7aE3Mi46A62ypmSCyb+AyT+ Ws1Vn+dWRRgvd2GRQVGLotJyouLZdlL4X+mIdmRBdKgW3+sdNiL5CcAPFer4uC7z+oBQ9MFYnTlxW BzyvJKALtHs37xUdKEhKkLH9a+vVY8xEaA7FBW6fdr0SO08QG2Ab2X/fjoRvyUK8iLR4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhQ9-0005aM-HF for control@debbugs.gnu.org; Mon, 12 Sep 2022 13:16:11 +0200 Date: Mon, 12 Sep 2022 13:16:09 +0200 Message-Id: <87edwg972e.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51104 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 51104 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 51104 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 07:44:05 2022 Received: (at 51104) by debbugs.gnu.org; 12 Sep 2022 11:44:05 +0000 Received: from localhost ([127.0.0.1]:44406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhrB-0001TR-9w for submit@debbugs.gnu.org; Mon, 12 Sep 2022 07:44:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhr9-0001St-1h for 51104@debbugs.gnu.org; Mon, 12 Sep 2022 07:44:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXhr1-0003t7-QI; Mon, 12 Sep 2022 07:43:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iSP0SXugFWOdFA9CdonKFl+CejDONSP+5f75p0eG3cY=; b=d5nGTPovNTM/ vj/zFLv50alwuGwdMJ7mRB1tvCoJu4PlpQRpsuqNU3sk1lOCKv55TGgkzbvRvgVzgj3fU37w1rb8r AIAWZjPrmdpcD7srqj30pZmbyT6ngLRCjSgQ28kGouKLmQzkrJQ0/WBZ/yfHS6K/VNyZNmBcwtmZY W9zflFciIPCkHTwQ1jlr6po5FuXX6QKLCzEvGhuDsH77zuv3xFoB9pf5n0dIYWV8WDhBj7puNlzTy OnOVRO2Hup6SUKOg2K41+bDVtpN6gGIXy4jdNyKmdnGgOfBetKGf9k6vIKdDjKSWai8biwMXBkXFv WrwWtjzSY1pkRUqR+NBKQg==; Received: from [87.69.77.57] (port=4188 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXhr0-000530-Ju; Mon, 12 Sep 2022 07:43:55 -0400 Date: Mon, 12 Sep 2022 14:43:40 +0300 Message-Id: <838rmo95sj.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87h71c972r.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 12 Sep 2022 13:15:56 +0200) Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine References: <87h71c972r.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, eggert@cs.ucla.edu, andrea_corallo@yahoo.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 51104@debbugs.gnu.org, Andrea Corallo > From: Lars Ingebrigtsen > Date: Mon, 12 Sep 2022 13:15:56 +0200 > > Paul Eggert writes: > > > When trying out the emacs-28 branch on both 32- and 64-bit platforms, > > I had test failures that I tracked down to this line: > > > > test/src/comp-tests.el:933: (integer ,most-negative-fixnum > > ,most-positive-fixnum)) > > > > My problem was that I'd built test/src/comp-tests.elc on a 32-bit > > platform (using "./configure CC='gcc -m32'" on an x86-64 machine) so > > that .elc file had been built assuming 32-bit values for > > most-negative-fixnum and most-positive fixnum. When I then re-ran > > 'configure' for a 64-bit platform the .elc files were not > > automatically rebuilt for it (they're supposed to be > > machine-independent, right?) and so the optimizations were incorrect > > for a 64-bit platform and the tests failed. > > > > What's a good way to fix this problem, while still testing everything > > that comp-tests.el wants to test? > > This was a year ago, but the code in question seems unchanged now on > "master": > > ;; 14 > ((defun comp-tests-ret-type-spec-f (x) > (comp-hint-fixnum x)) > (integer ,most-negative-fixnum ,most-positive-fixnum)) > > So I guess the problem is still present? (I haven't tested myself.) > > Andrea, do you see any way to fix this test for this 32-bit/64-bit > scenarion? Is comp-tests.el supposed to run when Emacs is built without native-compilation? if so, what does it test in that case? And if comp-tests.el is supposed to run only in a native-compilation build, then I'd expect to see comp-test.eln run, not comp-test.elc, and *.eln files are architecture-specific to begin with. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 11:30:31 2022 Received: (at 51104) by debbugs.gnu.org; 12 Sep 2022 15:30:31 +0000 Received: from localhost ([127.0.0.1]:47612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXlOI-0002Gy-QS for submit@debbugs.gnu.org; Mon, 12 Sep 2022 11:30:31 -0400 Received: from mx.sdf.org ([205.166.94.24]:62668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXlOH-0002Gq-0a for 51104@debbugs.gnu.org; Mon, 12 Sep 2022 11:30:29 -0400 Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 28CFUGsW015929 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 12 Sep 2022 15:30:18 GMT From: Andrea Corallo To: Lars Ingebrigtsen Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine In-Reply-To: <87h71c972r.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 12 Sep 2022 13:15:56 +0200") References: <87h71c972r.fsf@gnus.org> Date: Mon, 12 Sep 2022 15:30:16 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Paul Eggert , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Paul Eggert writes: > >> When trying out the emacs-28 branch on both 32- and 64-bit platforms, >> I had test failures that I tracked down to this line: >> >> test/src/comp-tests.el:933: (integer ,most-negative-fixnum >> ,most-positive-fixnum)) >> >> My problem was that I'd built test/src/comp-tests.elc on a 32-bit >> platform (using "./configure CC='gcc -m32'" on an x86-64 machine) so >> that .elc file had been built assuming 32-bit values for >> most-negative-fixnum and most-positive fixnum. When I then re-ran >> 'configure' for a 64-bit platform the .elc files were not >> automatically rebuilt for it (they're supposed to be >> machine-independent, right?) and so the optimizations were incorrect >> for a 64-bit platform and the tests failed. >> >> What's a good way to fix this problem, while still testing everything >> that comp-tests.el wants to test? > > This was a year ago, but the code in question seems unchanged now on > "master": > > ;; 14 > ((defun comp-tests-ret-type-spec-f (x) > (comp-hint-fixnum x)) > (integer ,most-negative-fixnum ,most-positive-fixnum)) > > So I guess the problem is still present? (I haven't tested myself.) > > Andrea, do you see any way to fix this test for this 32-bit/64-bit > scenarion? Hi Lars, I think here IIUC we are using a .elc file (comp-tests.elc) compiled an an arch X to test .eln files for architectures different than X. `most-negative-fixnum' is replaced at byte-compilation time with a value that is indeed arch dependent. This is because we have some macrology to defines those tests. I believe in theory should be possible to move this computation in the compile time to keep "comp-tests.elc" arch indepent if this is requirement. Best Regards Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 13:54:48 2022 Received: (at 51104) by debbugs.gnu.org; 12 Sep 2022 17:54:48 +0000 Received: from localhost ([127.0.0.1]:47787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXndw-00046P-BY for submit@debbugs.gnu.org; Mon, 12 Sep 2022 13:54:48 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXnds-00046A-TL for 51104@debbugs.gnu.org; Mon, 12 Sep 2022 13:54:46 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A60181600C7; Mon, 12 Sep 2022 10:54:38 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id tYxcWnylkQFK; Mon, 12 Sep 2022 10:54:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EE5331600C8; Mon, 12 Sep 2022 10:54:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu EE5331600C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1663005278; bh=cdPk/93T6HZu9Tn6FPokKuoXsEjS+Pi4ch+5/PB3tFw=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type: Content-Transfer-Encoding; b=rqTOKSRyi426/yGHADB0cQ1Tj5W12lbRnT69xyPyIoXaqm2EbnvsKCK6GPKBpT3+N 6WoecbnhC9QC5i0amHT4HjJShR5HIUrz6HF0RhrsdkmtQaqJM7L8UW0vx+hPrf4/yN bk0/6vuBnsigMpKz2mtAYQRtZcg5iYSMmED2jPJU= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rQA0vth_odB3; Mon, 12 Sep 2022 10:54:37 -0700 (PDT) Received: from [192.168.0.205] (ip72-206-2-24.fv.ks.cox.net [72.206.2.24]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8570D1600C7; Mon, 12 Sep 2022 10:54:37 -0700 (PDT) Message-ID: Date: Mon, 12 Sep 2022 12:54:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine Content-Language: en-US To: Andrea Corallo , Lars Ingebrigtsen References: <87h71c972r.fsf@gnus.org> From: Paul Eggert In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 9/12/22 10:30, Andrea Corallo wrote: > I believe in theory should be possible to move this computation in the > compile time to keep "comp-tests.elc" arch indepent if this is > requirement. As I understand it, .elc files are supposed to be architecture independent. Is Lars onto something when he says this should be a .eln file instead? I don't recall what comp-tests.el does. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 15:34:59 2022 Received: (at 51104) by debbugs.gnu.org; 12 Sep 2022 19:34:59 +0000 Received: from localhost ([127.0.0.1]:48097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXpCt-0000dF-2C for submit@debbugs.gnu.org; Mon, 12 Sep 2022 15:34:59 -0400 Received: from mx.sdf.org ([205.166.94.24]:56723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXpCp-0000d4-4w for 51104@debbugs.gnu.org; Mon, 12 Sep 2022 15:34:57 -0400 Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 28CJYnLq001396 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 12 Sep 2022 19:34:51 GMT From: Andrea Corallo To: Paul Eggert via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine In-Reply-To: (Paul Eggert via's message of "Mon, 12 Sep 2022 12:54:36 -0500") References: <87h71c972r.fsf@gnus.org> Date: Mon, 12 Sep 2022 19:34:49 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Lars Ingebrigtsen , Paul Eggert , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Paul Eggert via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > On 9/12/22 10:30, Andrea Corallo wrote: >> I believe in theory should be possible to move this computation in the >> compile time to keep "comp-tests.elc" arch indepent if this is >> requirement. > > As I understand it, .elc files are supposed to be architecture independent. > > Is Lars onto something when he says this should be a .eln file > instead? I don't recall what comp-tests.el does. comp-tests.el just tests the native compiler (in this case the ret type prediction it does). I guess here make check does byte-compile comp-tests.el but being the tests executed with a non-interactive emacs this is never native compiled afterward (it would hide the issue). Probably the quickest and easiest fix is just to add the `no-byte-compile' into comp-tests.el. Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 16:34:41 2022 Received: (at 51104-done) by debbugs.gnu.org; 12 Sep 2022 20:34:41 +0000 Received: from localhost ([127.0.0.1]:48138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXq8e-00027b-Nc for submit@debbugs.gnu.org; Mon, 12 Sep 2022 16:34:40 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXq8c-00027L-DL for 51104-done@debbugs.gnu.org; Mon, 12 Sep 2022 16:34:39 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B0F3D1600CB; Mon, 12 Sep 2022 13:34:31 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rB4xp4RSWpWc; Mon, 12 Sep 2022 13:34:31 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E452D1600CE; Mon, 12 Sep 2022 13:34:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu E452D1600CE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1663014870; bh=yvHT2iwPD3TvxtpmHqYzKPAoxqI0cavNktWpyQkkans=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:From; b=qx45WHXghJtnTXT5ZcbnAbLF5KHaxR7kPuT9Y630tXCw/2r2L/Q7uqEVQqfcwZiSj PClTv2Vq6tTFr52d58/47zYwZC3TCZxZB+LjxCk14N0EkkfyWnHkNsmm54fEayC91q pnJdyvvSFwngMBZRt54J0z5gTrLJLRS3kg74OGaM= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5AXw9qUVkAUm; Mon, 12 Sep 2022 13:34:30 -0700 (PDT) Received: from [192.168.0.205] (ip72-206-2-24.fv.ks.cox.net [72.206.2.24]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 784211600CB; Mon, 12 Sep 2022 13:34:30 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------dSzJwPeG4qjPxSqaesqswJtc" Message-ID: <17c80584-7cac-9edf-8c31-632d032f1666@cs.ucla.edu> Date: Mon, 12 Sep 2022 15:34:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine Content-Language: en-US To: Andrea Corallo References: <87h71c972r.fsf@gnus.org> From: Paul Eggert In-Reply-To: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51104-done Cc: 51104-done@debbugs.gnu.org, Lars Ingebrigtsen , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------dSzJwPeG4qjPxSqaesqswJtc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/12/22 14:34, Andrea Corallo wrote: > Probably the quickest and easiest fix is just to add the > `no-byte-compile' into comp-tests.el. Thanks for the suggestion. I installed the attached and am closing the bug report. --------------dSzJwPeG4qjPxSqaesqswJtc Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-comp-tests.el-problem-after-reconfiguring.patch" Content-Disposition: attachment; filename="0001-Fix-comp-tests.el-problem-after-reconfiguring.patch" Content-Transfer-Encoding: base64 RnJvbSAzNTdlYjhkOTMzZjIwYTllODY4ZDc5OGEzY2Q0ZmViODUzNmIxOTQ4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDEyIFNlcCAyMDIyIDE1OjMxOjM2IC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gRml4IGNvbXAtdGVzdHMuZWwgcHJvYmxlbSBhZnRlciByZWNvbmZpZ3VyaW5nCgoqIHRl c3Qvc3JjL2NvbXAtdGVzdHMuZWw6IERvIG5vdCBieXRlLWNvbXBpbGUsIGFzIHRoZSAuZWxj CmZpbGUgd291bGQgYmUgbWFjaGluZS1kZXBlbmRlbnQgKGJ1ZyM1MTEwNCkuCi0tLQogdGVz dC9zcmMvY29tcC10ZXN0cy5lbCB8IDQgKysrKwogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL3Rlc3Qvc3JjL2NvbXAtdGVzdHMuZWwgYi90ZXN0L3Ny Yy9jb21wLXRlc3RzLmVsCmluZGV4IDFiMjM5Y2VjNzkuLmE1ZjMzMDY5ZTAgMTAwNjQ0Ci0t LSBhL3Rlc3Qvc3JjL2NvbXAtdGVzdHMuZWwKKysrIGIvdGVzdC9zcmMvY29tcC10ZXN0cy5l bApAQCAtMTQ3Miw0ICsxNDcyLDggQEAgY29tcC10ZXN0cy1jb25kLXJ3LWNoZWNrZXItdHlw ZQogICAgICAgICAgIChlcXVhbCAoY29tcC1tdmFyLXR5cGVzZXQgbXZhcikKICAgICAgICAg ICAgICAgICAgY29tcC10ZXN0cy1jb25kLXJ3LWV4cGVjdGVkLXR5cGUpKSkpKSkpKQogCis7 OyBMb2NhbCBWYXJpYWJsZXM6Cis7OyBuby1ieXRlLWNvbXBpbGU6IHQKKzs7IEVuZDoKKwog Ozs7IGNvbXAtdGVzdHMuZWwgZW5kcyBoZXJlCi0tIAoyLjM3LjIKCg== --------------dSzJwPeG4qjPxSqaesqswJtc-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 17:05:36 2022 Received: (at 51104) by debbugs.gnu.org; 12 Sep 2022 21:05:36 +0000 Received: from localhost ([127.0.0.1]:48179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXqcY-000362-Qs for submit@debbugs.gnu.org; Mon, 12 Sep 2022 17:05:36 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXqcU-00035c-TW for 51104@debbugs.gnu.org; Mon, 12 Sep 2022 17:05:33 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0B15B804AB; Mon, 12 Sep 2022 17:05:25 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1FAFF800AE; Mon, 12 Sep 2022 17:05:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663016722; bh=MdDVDkRaAwesDF5msJtKuZb4xSU8rp6Nv6SHlGpy+Nk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Hm0GDGV2MCcdBg2sezmuSQ+avkl34PTWR0232Mw+hm4gMqT515r9y69dLy+bO+fix st0soP3lwzKgnyfEdJrW2K//KD/QvxTtRhgXSw0NWCgN+pprdD4IGzkOByU8EuMmUb Qj6s2f6dTTuEApuR4BZQ73blN6u/SCeBt7QG8uaYBnWG86DjE1ngidQaMBkM7pbVBo 5Rqw9diF5YnPkNUxgRAZ8bqC7ZiVaK0miKOriuGprFdFxTEwG2QVThjbWuF2fMVy0W UwrJq7NuVcn2GBqLSl6LVSdO9VzfwZ5y0sB7nUTm6aILc8WZMFUvy9sS2s06sTFQ9I odbjYJ/hGh9Og== Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D88CF12022E; Mon, 12 Sep 2022 17:05:21 -0400 (EDT) From: Stefan Monnier To: Andrea Corallo Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine In-Reply-To: (Andrea Corallo's message of "Mon, 12 Sep 2022 15:30:16 +0000") Message-ID: References: <87h71c972r.fsf@gnus.org> Date: Mon, 12 Sep 2022 17:05:20 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Lars Ingebrigtsen , Paul Eggert , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Andrea, do you see any way to fix this test for this 32-bit/64-bit >> scenarion? Not Andrea, but IIUC the patch below might do the trick. Can someone confirm? Stefan diff --git a/test/src/comp-tests.el b/test/src/comp-tests.el index a5f33069e01..a400a1a50a1 100644 --- a/test/src/comp-tests.el +++ b/test/src/comp-tests.el @@ -860,21 +860,21 @@ comp-tests-check-ret-type-spec (cl-eval-when (compile eval load) (defconst comp-tests-type-spec-tests - `( + '( ;; 1 ((defun comp-tests-ret-type-spec-f (x) x) - t) + 't) ;; 2 ((defun comp-tests-ret-type-spec-f () 1) - (integer 1 1)) + '(integer 1 1)) ;; 3 ((defun comp-tests-ret-type-spec-f (x) (if x 1 3)) - (or (integer 1 1) (integer 3 3))) + '(or (integer 1 1) (integer 3 3))) ;; 4 ((defun comp-tests-ret-type-spec-f (x) @@ -883,7 +883,7 @@ comp-tests-check-ret-type-spec (setf y 1) (setf y 2)) y)) - (integer 1 2)) + '(integer 1 2)) ;; 5 ((defun comp-tests-ret-type-spec-f (x) @@ -892,73 +892,73 @@ comp-tests-check-ret-type-spec (setf y 1) (setf y 3)) y)) - (or (integer 1 1) (integer 3 3))) + '(or (integer 1 1) (integer 3 3))) ;; 6 ((defun comp-tests-ret-type-spec-f (x) (if x (list x) 3)) - (or cons (integer 3 3))) + '(or cons (integer 3 3))) ;; 7 ((defun comp-tests-ret-type-spec-f (x) (if x 'foo 3)) - (or (member foo) (integer 3 3))) + '(or (member foo) (integer 3 3))) ;; 8 ((defun comp-tests-ret-type-spec-f (x) (if (eq x 3) x 'foo)) - (or (member foo) (integer 3 3))) + '(or (member foo) (integer 3 3))) ;; 9 ((defun comp-tests-ret-type-spec-f (x) (if (eq 3 x) x 'foo)) - (or (member foo) (integer 3 3))) + '(or (member foo) (integer 3 3))) ;; 10 ((defun comp-tests-ret-type-spec-f (x) (if (eql x 3) x 'foo)) - (or (member foo) (integer 3 3))) + '(or (member foo) (integer 3 3))) ;; 11 ((defun comp-tests-ret-type-spec-f (x) (if (eql 3 x) x 'foo)) - (or (member foo) (integer 3 3))) + '(or (member foo) (integer 3 3))) ;; 12 ((defun comp-tests-ret-type-spec-f (x) (if (eql x 3) 'foo x)) - (not (integer 3 3))) + '(not (integer 3 3))) ;; 13 ((defun comp-tests-ret-type-spec-f (x y) (if (= x y) x 'foo)) - (or (member foo) marker number)) + '(or (member foo) marker number)) ;; 14 ((defun comp-tests-ret-type-spec-f (x) (comp-hint-fixnum x)) - (integer ,most-negative-fixnum ,most-positive-fixnum)) + `(integer ,most-negative-fixnum ,most-positive-fixnum)) ;; 15 ((defun comp-tests-ret-type-spec-f (x) (comp-hint-cons x)) - cons) + 'cons) ;; 16 ((defun comp-tests-ret-type-spec-f (x) @@ -966,7 +966,7 @@ comp-tests-check-ret-type-spec (when x (setf y 4)) y)) - (or null (integer 4 4))) + '(or null (integer 4 4))) ;; 17 ((defun comp-tests-ret-type-spec-f () @@ -974,7 +974,7 @@ comp-tests-check-ret-type-spec (y 3)) (setf x y) y)) - (integer 3 3)) + '(integer 3 3)) ;; 18 ((defun comp-tests-ret-type-spec-f (x) @@ -982,120 +982,120 @@ comp-tests-check-ret-type-spec (when x (setf y x)) y)) - t) + 't) ;; 19 ((defun comp-tests-ret-type-spec-f (x y) (eq x y)) - boolean) + 'boolean) ;; 20 ((defun comp-tests-ret-type-spec-f (x) (when x 'foo)) - (or (member foo) null)) + '(or (member foo) null)) ;; 21 ((defun comp-tests-ret-type-spec-f (x) (unless x 'foo)) - (or (member foo) null)) + '(or (member foo) null)) ;; 22 ((defun comp-tests-ret-type-spec-f (x) (when (> x 3) x)) - (or null float (integer 4 *))) + '(or null float (integer 4 *))) ;; 23 ((defun comp-tests-ret-type-spec-f (x) (when (>= x 3) x)) - (or null float (integer 3 *))) + '(or null float (integer 3 *))) ;; 24 ((defun comp-tests-ret-type-spec-f (x) (when (< x 3) x)) - (or null float (integer * 2))) + '(or null float (integer * 2))) ;; 25 ((defun comp-tests-ret-type-spec-f (x) (when (<= x 3) x)) - (or null float (integer * 3))) + '(or null float (integer * 3))) ;; 26 ((defun comp-tests-ret-type-spec-f (x) (when (> 3 x) x)) - (or null float (integer * 2))) + '(or null float (integer * 2))) ;; 27 ((defun comp-tests-ret-type-spec-f (x) (when (>= 3 x) x)) - (or null float (integer * 3))) + '(or null float (integer * 3))) ;; 28 ((defun comp-tests-ret-type-spec-f (x) (when (< 3 x) x)) - (or null float (integer 4 *))) + '(or null float (integer 4 *))) ;; 29 ((defun comp-tests-ret-type-spec-f (x) (when (<= 3 x) x)) - (or null float (integer 3 *))) + '(or null float (integer 3 *))) ;; 30 ((defun comp-tests-ret-type-spec-f (x) (let ((y 3)) (when (> x y) x))) - (or null float (integer 4 *))) + '(or null float (integer 4 *))) ;; 31 ((defun comp-tests-ret-type-spec-f (x) (let ((y 3)) (when (> y x) x))) - (or null float (integer * 2))) + '(or null float (integer * 2))) ;; 32 ((defun comp-tests-ret-type-spec-f (x) (when (and (> x 3) (< x 10)) x)) - (or null float (integer 4 9))) + '(or null float (integer 4 9))) ;; 33 ((defun comp-tests-ret-type-spec-f (x) (when (or (> x 3) (< x 10)) x)) - (or null float integer)) + '(or null float integer)) ;; 34 ((defun comp-tests-ret-type-spec-f (x) (when (or (< x 3) (> x 10)) x)) - (or null float (integer * 2) (integer 11 *))) + '(or null float (integer * 2) (integer 11 *))) ;; 35 No float range support. ((defun comp-tests-ret-type-spec-f (x) (when (> x 1.0) x)) - (or null marker number)) + '(or null marker number)) ;; 36 ((defun comp-tests-ret-type-spec-f (x y) (when (and (> x 3) (> y 2)) (+ x y))) - (or null float (integer 7 *))) + '(or null float (integer 7 *))) ;; 37 ;; SBCL: (OR REAL NULL) @@ -1103,14 +1103,14 @@ comp-tests-check-ret-type-spec (when (and (<= x 3) (<= y 2)) (+ x y))) - (or null float (integer * 5))) + '(or null float (integer * 5))) ;; 38 ((defun comp-tests-ret-type-spec-f (x y) (when (and (< 1 x 5) (< 1 y 5)) (+ x y))) - (or null float (integer 4 8))) + '(or null float (integer 4 8))) ;; 39 ;; SBCL gives: (OR REAL NULL) @@ -1118,7 +1118,7 @@ comp-tests-check-ret-type-spec (when (and (<= 1 x 10) (<= 2 y 3)) (+ x y))) - (or null float (integer 3 13))) + '(or null float (integer 3 13))) ;; 40 ;; SBCL: (OR REAL NULL) @@ -1126,42 +1126,42 @@ comp-tests-check-ret-type-spec (when (and (<= 1 x 10) (<= 2 y 3)) (- x y))) - (or null float (integer -2 8))) + '(or null float (integer -2 8))) ;; 41 ((defun comp-tests-ret-type-spec-f (x y) (when (and (<= 1 x) (<= 2 y 3)) (- x y))) - (or null float (integer -2 *))) + '(or null float (integer -2 *))) ;; 42 ((defun comp-tests-ret-type-spec-f (x y) (when (and (<= 1 x 10) (<= 2 y)) (- x y))) - (or null float (integer * 8))) + '(or null float (integer * 8))) ;; 43 ((defun comp-tests-ret-type-spec-f (x y) (when (and (<= x 10) (<= 2 y)) (- x y))) - (or null float (integer * 8))) + '(or null float (integer * 8))) ;; 44 ((defun comp-tests-ret-type-spec-f (x y) (when (and (<= x 10) (<= y 3)) (- x y))) - (or null float integer)) + '(or null float integer)) ;; 45 ((defun comp-tests-ret-type-spec-f (x y) (when (and (<= 2 x) (<= 3 y)) (- x y))) - (or null float integer)) + '(or null float integer)) ;; 46 ;; SBCL: (OR (RATIONAL (6) (30)) (SINGLE-FLOAT 6.0 30.0) @@ -1174,63 +1174,63 @@ comp-tests-check-ret-type-spec (< 1 j 5) (< 1 k 5)) (+ x y z i j k))) - (or null float (integer 12 24))) + '(or null float (integer 12 24))) ;; 47 ((defun comp-tests-ret-type-spec-f (x) (when (<= 1 x 5) (1+ x))) - (or null float (integer 2 6))) + '(or null float (integer 2 6))) ;;48 ((defun comp-tests-ret-type-spec-f (x) (when (<= 1 x 5) (1- x))) - (or null float (integer 0 4))) + '(or null float (integer 0 4))) ;; 49 ((defun comp-tests-ret-type-spec-f () (error "Foo")) - nil) + 'nil) ;; 50 ((defun comp-tests-ret-type-spec-f (x) (if (stringp x) x 'bar)) - (or (member bar) string)) + '(or (member bar) string)) ;; 51 ((defun comp-tests-ret-type-spec-f (x) (if (stringp x) 'bar x)) - (not string)) + '(not string)) ;; 52 ((defun comp-tests-ret-type-spec-f (x) (if (integerp x) x 'bar)) - (or (member bar) integer)) + '(or (member bar) integer)) ;; 53 ((defun comp-tests-ret-type-spec-f (x) (when (integerp x) x)) - (or null integer)) + '(or null integer)) ;; 54 ((defun comp-tests-ret-type-spec-f (x) (unless (symbolp x) x)) - t) + 't) ;; 55 ((defun comp-tests-ret-type-spec-f (x) (unless (integerp x) x)) - (not integer)) + '(not integer)) ;; 56 ((defun comp-tests-ret-type-spec-f (x) @@ -1238,7 +1238,7 @@ comp-tests-check-ret-type-spec (1 (message "one")) (5 (message "five"))) x) - t + 't ;; FIXME improve `comp-cond-cstrs-target-mvar' to cross block ;; boundary if necessary as this should return: ;; (or (integer 1 1) (integer 5 5)) @@ -1250,7 +1250,7 @@ comp-tests-check-ret-type-spec (eql x 3)) (error "Not foo or 3")) x) - (or (member foo) (integer 3 3))) + '(or (member foo) (integer 3 3))) ;;58 ((defun comp-tests-ret-type-spec-f (x y) @@ -1259,7 +1259,7 @@ comp-tests-check-ret-type-spec (<= x y)) x (error ""))) - (integer 0 *)) + '(integer 0 *)) ;; 59 ((defun comp-tests-ret-type-spec-f (x y) @@ -1268,7 +1268,7 @@ comp-tests-check-ret-type-spec (<= x y)) x (error ""))) - (or float (integer 3 10))) + '(or float (integer 3 10))) ;; 60 ((defun comp-tests-ret-type-spec-f (x y) @@ -1277,56 +1277,56 @@ comp-tests-check-ret-type-spec (>= x y)) x (error ""))) - (or float (integer 3 10))) + '(or float (integer 3 10))) ;; 61 ((defun comp-tests-ret-type-spec-f (x) (if (= x 1.0) x (error ""))) - (or (member 1.0) (integer 1 1))) + '(or (member 1.0) (integer 1 1))) ;; 62 ((defun comp-tests-ret-type-spec-f (x) (if (= x 1.0) x (error ""))) - (or (member 1.0) (integer 1 1))) + '(or (member 1.0) (integer 1 1))) ;; 63 ((defun comp-tests-ret-type-spec-f (x) (if (= x 1.1) x (error ""))) - (member 1.1)) + '(member 1.1)) ;; 64 ((defun comp-tests-ret-type-spec-f (x) (if (= x 1) x (error ""))) - (or (member 1.0) (integer 1 1))) + '(or (member 1.0) (integer 1 1))) ;; 65 ((defun comp-tests-ret-type-spec-f (x) (if (= x 1) x (error ""))) - (or (member 1.0) (integer 1 1))) + '(or (member 1.0) (integer 1 1))) ;; 66 ((defun comp-tests-ret-type-spec-f (x) (if (eql x 0.0) x (error ""))) - float) + 'float) ;; 67 ((defun comp-tests-ret-type-spec-f (x) (if (equal x '(1 2 3)) x (error ""))) - cons) + 'cons) ;; 68 ((defun comp-tests-ret-type-spec-f (x) @@ -1335,7 +1335,7 @@ comp-tests-check-ret-type-spec x (error ""))) ;; Conservative (see cstr relax in `comp-cstr-='). - (or (member 1.0) (integer 1 1))) + '(or (member 1.0) (integer 1 1))) ;; 69 ((defun comp-tests-ret-type-spec-f (x) @@ -1344,7 +1344,7 @@ comp-tests-check-ret-type-spec x (error ""))) ;; Conservative (see cstr relax in `comp-cstr-='). - (or (member 1.0) (integer 1 1))) + '(or (member 1.0) (integer 1 1))) ;; 70 ((defun comp-tests-ret-type-spec-f (x y) @@ -1353,14 +1353,14 @@ comp-tests-check-ret-type-spec (= x y)) x (error ""))) - (or float integer)) + '(or float integer)) ;; 71 ((defun comp-tests-ret-type-spec-f (x) (if (= x 0.0) x (error ""))) - (or (member -0.0 0.0) (integer 0 0))) + '(or (member -0.0 0.0) (integer 0 0))) ;; 72 ((defun comp-tests-ret-type-spec-f (x) @@ -1369,27 +1369,27 @@ comp-tests-check-ret-type-spec (unless (eql x -0.0) (error "")) x) - float) + 'float) ;; 73 ((defun comp-tests-ret-type-spec-f (x) (when (eql x 1.0) (error "")) x) - t) + 't) ;; 74 ((defun comp-tests-ret-type-spec-f (x) (if (eq x 0) (error "") (1+ x))) - number))) + 'number))) (defun comp-tests-define-type-spec-test (number x) `(comp-deftest ,(intern (format "ret-type-spec-%d" number)) () ,(format "Type specifier test number %d." number) (let ((comp-ctxt (make-comp-cstr-ctxt))) - (comp-tests-check-ret-type-spec ',(car x) ',(cadr x)))))) + (comp-tests-check-ret-type-spec ',(car x) ,(cadr x)))))) (defmacro comp-tests-define-type-spec-tests () "Define all type specifier tests." @@ -1472,8 +1472,4 @@ comp-tests-cond-rw-checker-type (equal (comp-mvar-typeset mvar) comp-tests-cond-rw-expected-type)))))))) -;; Local Variables: -;; no-byte-compile: t -;; End: - ;;; comp-tests.el ends here From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 07:22:07 2022 Received: (at 51104) by debbugs.gnu.org; 13 Sep 2022 11:22:07 +0000 Received: from localhost ([127.0.0.1]:49049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY3zT-0002QU-DE for submit@debbugs.gnu.org; Tue, 13 Sep 2022 07:22:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY3zR-0002Px-F4 for 51104@debbugs.gnu.org; Tue, 13 Sep 2022 07:22:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EinjkGQgO0aKF6JbKylVXCzRT4itPTULXzzgDFJCVmk=; b=Tp+o2oW2ckPOXBkKIMktdMxnDL lsSyijkU7toCcmzfkCQqKXnBd4mBYVjNifwZjLbgkcH8u2qS5RXGfnsqBK160MzHNkPNTApO5ko7/ wFeIAGtgtZIIdkf4nomlEqkSREmna9uFUhBiOX3DRJXSfT8LDF+KY9AC3Q+v2gjzflcw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY3zG-00024j-Dj; Tue, 13 Sep 2022 13:21:56 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine In-Reply-To: (Stefan Monnier's message of "Mon, 12 Sep 2022 17:05:20 -0400") References: <87h71c972r.fsf@gnus.org> X-Now-Playing: Laurel Halo's _Quarantine_: "Carcass" Date: Tue, 13 Sep 2022 13:21:53 +0200 Message-ID: <87bkrj4izy.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >>> Andrea, do you see any way to fix this test for this 32-bit/64-bit >>> scenarion? > > Not Andrea, but IIUC the patch below might do the trick. > Can someone confirm? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Paul Eggert , Andrea Corallo , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >>> Andrea, do you see any way to fix this test for this 32-bit/64-bit >>> scenarion? > > Not Andrea, but IIUC the patch below might do the trick. > Can someone confirm? I think that looks better than disabling byte-compilation (because the comp tests are already slow enough =F0=9F=98=80). From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 09:40:04 2022 Received: (at 51104) by debbugs.gnu.org; 13 Sep 2022 13:40:04 +0000 Received: from localhost ([127.0.0.1]:49345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY68y-0006Mq-6N for submit@debbugs.gnu.org; Tue, 13 Sep 2022 09:40:04 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY68x-0006MA-7K for 51104@debbugs.gnu.org; Tue, 13 Sep 2022 09:40:03 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E3275441221; Tue, 13 Sep 2022 09:39:57 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A83D9441217; Tue, 13 Sep 2022 09:39:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663076396; bh=X4WkzPr2YCswInSWD4IJiTBEbRO7xlTcIgPapFT185g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Jfnty3QDAo6oZ7ZFE5mTOQKH8MjI3WCwOATd4L+c8vicRnAsdKjBOa0m//O3zeIGM y35Y7m2cnh4bAHdSiOsDzA3/sBqbY6XVe6aOxSYl8dhKqyz2KPXQ7QPtPySkATVCzA VNRPxPgdKUvMoHhdTh0VdsvWWelLhq7XKlxBo2inHhwfFElhRyDJaPSDmtZlYv6Vxw Nyt+4OQrZZDoGIIb7uWdjocVxbPQD2AtIS/LL4Gw28kQJYh3+SD9kdnPKd40TjpKMn JlvEqYytnvAIrNv4+Kcqx6aDwD3kkXe+2EtM/tKMbcJaulwlixE4LkFjabxUsPSZtA zwv0IsKBJqvWg== Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 747BB120842; Tue, 13 Sep 2022 09:39:56 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine In-Reply-To: <87bkrj4izy.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Sep 2022 13:21:53 +0200") Message-ID: References: <87h71c972r.fsf@gnus.org> <87bkrj4izy.fsf@gnus.org> Date: Tue, 13 Sep 2022 09:39:54 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Paul Eggert , Andrea Corallo , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-09-13 13:21:53] wrote: > Stefan Monnier writes: >>>> Andrea, do you see any way to fix this test for this 32-bit/64-bit >>>> scenarion? >> Not Andrea, but IIUC the patch below might do the trick. >> Can someone confirm? > I think that looks better than disabling byte-compilation (because the > comp tests are already slow enough =F0=9F=98=80). Pushed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 10:09:13 2022 Received: (at 51104) by debbugs.gnu.org; 13 Sep 2022 14:09:13 +0000 Received: from localhost ([127.0.0.1]:52262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY6bB-0003sk-BB for submit@debbugs.gnu.org; Tue, 13 Sep 2022 10:09:13 -0400 Received: from mx.sdf.org ([205.166.94.24]:64149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY6b8-0003sb-FL for 51104@debbugs.gnu.org; Tue, 13 Sep 2022 10:09:11 -0400 Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 28DE94hj011274 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 13 Sep 2022 14:09:04 GMT From: Andrea Corallo To: Lars Ingebrigtsen Subject: Re: bug#51104: comp-tests.elc messes up after reconfiguring for different machine In-Reply-To: <87bkrj4izy.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Sep 2022 13:21:53 +0200") References: <87h71c972r.fsf@gnus.org> <87bkrj4izy.fsf@gnus.org> Date: Tue, 13 Sep 2022 14:09:04 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51104 Cc: 51104@debbugs.gnu.org, Paul Eggert , Stefan Monnier , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Stefan Monnier writes: > >>>> Andrea, do you see any way to fix this test for this 32-bit/64-bit >>>> scenarion? >> >> Not Andrea, but IIUC the patch below might do the trick. >> Can someone confirm? > > I think that looks better than disabling byte-compilation (because the > comp tests are already slow enough =F0=9F=98=80). Comp tests are unfortunatelly slow not because comp-tests.el is slow but because of the compiler itself is not fast :/ Anyway Stefan fix is certanly nicer, I feel sorry for not having had the time to look into it myself. Thanks! Andrea From unknown Sun Jun 22 07:57:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Oct 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator