From unknown Tue Jun 17 01:42:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice. Resent-From: "David M. Koppelman" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2021 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 51101@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16337244019708 (code B ref -1); Fri, 08 Oct 2021 20:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Oct 2021 20:20:01 +0000 Received: from localhost ([127.0.0.1]:51967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYwLY-0002WP-MV for submit@debbugs.gnu.org; Fri, 08 Oct 2021 16:20:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:37660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYwLW-0002WI-TD for submit@debbugs.gnu.org; Fri, 08 Oct 2021 16:19:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYwLW-0007gP-Nx for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 16:19:58 -0400 Received: from relaymail001.lsu.edu ([130.39.6.46]:40858 helo=relay.lsu.edu) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYwLT-0002Mr-3m for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 16:19:57 -0400 Received: from cyc.ece.lsu.edu (cyc.ece.lsu.edu [96.125.115.182]) by relay.lsu.edu (Postfix) with ESMTPS id F173C219BD43 for ; Fri, 8 Oct 2021 15:19:48 -0500 (CDT) From: "David M. Koppelman" Date: Fri, 08 Oct 2021 15:19:48 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=130.39.6.46; envelope-from=eekopp@lsu.edu; helo=relay.lsu.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Execute: (read-char-from-minibuffer "Answer y or n" '(?y ?n)) and press Enter. The form returns Enter (13) rather than re-prompting for a y or n. This causes a dataloss threat due to read-char-from-minibuffer being called through ask-user-about-supersession-threat. Even if the read-char-from-minibuffer bug is quickly fixed, I'd sleep better if the following patch were applied to userlock.el: @@ -194,7 +194,9 @@ ask-user-about-supersession-threat (list "File reverted" filename))) ((eq answer ?n) (signal 'file-supersession - (list "File changed on disk" filename))))) + (list "File changed on disk" filename))) + ((eq answer ?y)) + (t (setq answer nil)))) (message "File on disk now will become a backup file if you save these changes.") (setq buffer-backed-up nil)))) In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-10-08 built on dmk-laptop-21 Repository revision: e73c9ac4ed4ce0a4b423dae6acbfb384c1afbce0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101002 System Description: Fedora Linux 35 (KDE Plasma Prerelease) Configured using: 'configure 'CFLAGS=-O3 -march=native' --without-pop --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LC_TIME: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search seq gv byte-opt bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 68625 10824) (symbols 48 6630 0) (strings 32 19929 1554) (string-bytes 1 675055) (vectors 16 13948) (vector-slots 8 286810 18217) (floats 8 24 38) (intervals 56 232 0) (buffers 992 11)) From unknown Tue Jun 17 01:42:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice. Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Oct 2021 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "David M. Koppelman" Cc: 51101@debbugs.gnu.org, Juri Linkov Received: via spool by 51101-submit@debbugs.gnu.org id=B51101.16337849782315 (code B ref 51101); Sat, 09 Oct 2021 13:10:02 +0000 Received: (at 51101) by debbugs.gnu.org; 9 Oct 2021 13:09:38 +0000 Received: from localhost ([127.0.0.1]:52470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZC6b-0000bH-SI for submit@debbugs.gnu.org; Sat, 09 Oct 2021 09:09:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZC6Z-0000b2-CF for 51101@debbugs.gnu.org; Sat, 09 Oct 2021 09:09:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6bT6+DY97RSUy6wlIkq0sfLJGUpgU17BQdyHl2JZIE4=; b=uBPSzbRo/VWT5wYwp0LvEGb/Xn /FmSEQRzu/u6tHaTMCpxpr34Y1pIsX3e+P40fGf41Hvd962dqfGVlZ9ybk7hq20xLkO6f7RBg4gG4 nAwz5bcsXFXWX4XCraxXlv/pg9/1VMA+En3vxSTq/k4qf/DzPfva/nmyr7KjzMJmFioo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZC6O-0005gx-Q9; Sat, 09 Oct 2021 15:09:27 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: Tom Robinson's _North by Northwest_: "Atmospherics" Date: Sat, 09 Oct 2021 15:09:24 +0200 In-Reply-To: (David M. Koppelman's message of "Fri, 08 Oct 2021 15:19:48 -0500") Message-ID: <877demny4b.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "David M. Koppelman" writes: > Execute: > > (read-char-from-minibuffer "Answer y or n" '(?y ?n)) > > and press Enter. The form returns Enter (13) rather than re-prompting > for a y or n. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "David M. Koppelman" writes: > Execute: > > (read-char-from-minibuffer "Answer y or n" '(?y ?n)) > > and press Enter. The form returns Enter (13) rather than re-prompting > for a y or n. It seems undocumented what RET is supposed to do in this function -- I've added Juri to the CCs, perhaps he has some comments. > This causes a dataloss threat due to read-char-from-minibuffer being > called through ask-user-about-supersession-threat. > > Even if the read-char-from-minibuffer bug is quickly fixed, I'd > sleep better if the following patch were applied to userlock.el: > > @@ -194,7 +194,9 @@ ask-user-about-supersession-threat > (list "File reverted" filename))) > ((eq answer ?n) > (signal 'file-supersession > - (list "File changed on disk" filename))))) > + (list "File changed on disk" filename))) > + ((eq answer ?y)) > + (t (setq answer nil)))) But I think ask-user-about-supersession-threat is working correctly here already (almost by chance). RET means "yes" in functions like `y-or-n-p', which this is basically an extended version of, so it should work as "yes" here, too. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Jun 17 01:42:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice. Resent-From: David Koppelman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Oct 2021 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 51101@debbugs.gnu.org, Juri Linkov Received: via spool by 51101-submit@debbugs.gnu.org id=B51101.163379176931285 (code B ref 51101); Sat, 09 Oct 2021 15:03:02 +0000 Received: (at 51101) by debbugs.gnu.org; 9 Oct 2021 15:02:49 +0000 Received: from localhost ([127.0.0.1]:53948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZDs9-00088X-Ey for submit@debbugs.gnu.org; Sat, 09 Oct 2021 11:02:49 -0400 Received: from relay001.lsu.edu ([130.39.6.46]:48816 helo=relay.lsu.edu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZDs6-00088H-SJ for 51101@debbugs.gnu.org; Sat, 09 Oct 2021 11:02:47 -0400 Received: from cyc.ece.lsu.edu (cyc.ece.lsu.edu [96.125.115.182]) by relay.lsu.edu (Postfix) with ESMTPS id BADCB219CB4F; Sat, 9 Oct 2021 10:02:38 -0500 (CDT) From: David Koppelman References: <877demny4b.fsf@gnus.org> Date: Sat, 09 Oct 2021 10:02:38 -0500 In-Reply-To: <877demny4b.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 09 Oct 2021 15:09:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > But I think ask-user-about-supersession-threat is working correctly here > already (almost by chance). RET means "yes" in functions like > `y-or-n-p', which this is basically an extended version of, so it should > work as "yes" here, too. That might make sense if someone were expecting a prompt, but this prompt appears totally unexpectedly when one tries to enter text into a buffer, often that text includes enter. It would be easy to overlook the prompt and so suffer dataloss. David Lars Ingebrigtsen writes: > "David M. Koppelman" writes: > >> Execute: >> >> (read-char-from-minibuffer "Answer y or n" '(?y ?n)) >> >> and press Enter. The form returns Enter (13) rather than re-prompting >> for a y or n. > > It seems undocumented what RET is supposed to do in this function -- > I've added Juri to the CCs, perhaps he has some comments. > >> This causes a dataloss threat due to read-char-from-minibuffer being >> called through ask-user-about-supersession-threat. >> >> Even if the read-char-from-minibuffer bug is quickly fixed, I'd >> sleep better if the following patch were applied to userlock.el: >> >> @@ -194,7 +194,9 @@ ask-user-about-supersession-threat >> (list "File reverted" filename))) >> ((eq answer ?n) >> (signal 'file-supersession >> - (list "File changed on disk" filename))))) >> + (list "File changed on disk" filename))) >> + ((eq answer ?y)) >> + (t (setq answer nil)))) > > But I think ask-user-about-supersession-threat is working correctly here > already (almost by chance). RET means "yes" in functions like > `y-or-n-p', which this is basically an extended version of, so it should > work as "yes" here, too. From unknown Tue Jun 17 01:42:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice. Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Oct 2021 17:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: "David M. Koppelman" , 51101@debbugs.gnu.org Received: via spool by 51101-submit@debbugs.gnu.org id=B51101.16338872097060 (code B ref 51101); Sun, 10 Oct 2021 17:34:03 +0000 Received: (at 51101) by debbugs.gnu.org; 10 Oct 2021 17:33:29 +0000 Received: from localhost ([127.0.0.1]:55779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZchV-0001po-FK for submit@debbugs.gnu.org; Sun, 10 Oct 2021 13:33:29 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:52615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZchT-0001pW-RD; Sun, 10 Oct 2021 13:33:28 -0400 Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id E99C7200003; Sun, 10 Oct 2021 17:33:18 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <877demny4b.fsf@gnus.org> Date: Sun, 10 Oct 2021 20:31:31 +0300 In-Reply-To: <877demny4b.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 09 Oct 2021 15:09:24 +0200") Message-ID: <87h7dpc7e0.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 51101 28.0.60 quit >> Execute: >> >> (read-char-from-minibuffer "Answer y or n" '(?y ?n)) >> >> and press Enter. The form returns Enter (13) rather than re-prompting >> for a y or n. > > It seems undocumented what RET is supposed to do in this function -- > I've added Juri to the CCs, perhaps he has some comments. RET is supposed to do exactly the same what it did in read-char-choice-with-read-key, or when these variables are non-nil: read-char-choice-use-read-key and y-or-n-p-use-read-key, i.e. to ignore RET and read the character again. So this is fixed accordingly now in 28.0. >> This causes a dataloss threat due to read-char-from-minibuffer being >> called through ask-user-about-supersession-threat. >> >> Even if the read-char-from-minibuffer bug is quickly fixed, I'd >> sleep better if the following patch were applied to userlock.el: >> >> @@ -194,7 +194,9 @@ ask-user-about-supersession-threat >> (list "File reverted" filename))) >> ((eq answer ?n) >> (signal 'file-supersession >> - (list "File changed on disk" filename))))) >> + (list "File changed on disk" filename))) >> + ((eq answer ?y)) >> + (t (setq answer nil)))) I installed the patch provided by David as well. > But I think ask-user-about-supersession-threat is working correctly here > already (almost by chance). RET means "yes" in functions like > `y-or-n-p', which this is basically an extended version of, so it should > work as "yes" here, too. Maybe it works here because ask-user-about-supersession-threat is called from C with some flag that disables signaling 'quit'. But when trying to type RET after (y-or-n-p "Answer y or n: ") it terminates with the 'quit' signal. And indeed in the map used by y-or-n-p, RET is bound to 'exit': (define-key query-replace-map "\r" 'exit) I noticed the recent commit ec9f25bd356c7c81d94c78f11100b97d6d52ce97 saying that RET means "yes" in y-or-n-p. But anyway since RET now does the same that read-char-choice-with-read-key does, so I removed mentions of RET from the doc string. Or should the fixed behavior be mentioned? From unknown Tue Jun 17 01:42:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice. Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Oct 2021 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: "David M. Koppelman" , 51101@debbugs.gnu.org Received: via spool by 51101-submit@debbugs.gnu.org id=B51101.163389642830441 (code B ref 51101); Sun, 10 Oct 2021 20:08:02 +0000 Received: (at 51101) by debbugs.gnu.org; 10 Oct 2021 20:07:08 +0000 Received: from localhost ([127.0.0.1]:55885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZf6C-0007uu-9K for submit@debbugs.gnu.org; Sun, 10 Oct 2021 16:07:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZf6A-0007uR-Mn for 51101@debbugs.gnu.org; Sun, 10 Oct 2021 16:07:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DgSaACfv2fm6FFSP/NuT/v8iS3Gc5BLe8djfiaDCK5c=; b=XxtDPsLblTdsqgMvu+hrzCA4VB Cm6t4ZCpYwfII6Nmg7p0gXhtUtrwqi9ddqeqI5kFFN7VRX3mYyvjOoIgaAXtsb7VeFblW5zdVmL/U CTq3vzhLvShXgL4MFDQZxtoqVHHWhsokM2qa5Alza2maLYX9DJ5AFmIeLcD8ppkgINAo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZf60-0003E0-Q6; Sun, 10 Oct 2021 22:06:59 +0200 From: Lars Ingebrigtsen References: <877demny4b.fsf@gnus.org> <87h7dpc7e0.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEURGCBEU15reIR2 h5SaprH////6wHPaAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UKChQFH0QAKkgAAAHBSURBVDjLrVNt lsMgCIw9gZAeoGAvEPACW7n/mXY02qb7e3nJS3QcGD7ctn+2vCW859/FiPJGOQ/sAiQAlPGk7bGl fD2vdL6dmC4ASyJyYqZO/nhiYlUKds6UOkCLQLsbvW6heccCMiaDmldD9DjI005gLVctGgAOEkMo HFmMGiaUby8+aH8JkZzAwV4EvjkdRk+DjsloqjZyYDk4iipPIIStZ7eH5L05kAX8wFcNjmgl3NUk n9ljY6/xjGGlma8YWGqrNvbbsyHXqapEmNafQbHaXGWmzqVvvbhGDUUNhCZAjNBwV2s0D7d3Hqxd FPSMKA7GbBYVh1U8rTbgecYGAwji9E2rZsJ59UNVS3eiVd1sieqdJSrdOfrlzvIeByZg0qtlYPC7 6RicQdKC+pmu0GcM+FGtSFr5ChT1Hr82Ef146vPGkKJIUHjPl7lKQISqRzswIJ9JxIypoosFLfq+ AmnIRRT/BjIGSaBZ6JPaJ5HUP2P6HinJUtCBMZjpduSbYurj8efG7dRvVKK3z9madG+at3t7bEv1 7SzRiaeD6HE/j97b+E4X+ZmeU/ldpgrUYdzddUf3lWq+1mTbvhf/b7/Nq1BgINOsrAAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMS0xMC0xMFQyMDowNTozMSswMDowMNbK8YkAAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjEtMTAtMTBUMjA6MDU6MzErMDA6MDCnl0k1AAAAAElFTkSuQmCC X-Now-Playing: Cocteau Twins's _Treasure_: "Donimo" Date: Sun, 10 Oct 2021 22:06:56 +0200 In-Reply-To: <87h7dpc7e0.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Oct 2021 20:31:31 +0300") Message-ID: <87wnmkmyov.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Maybe it works here because ask-user-about-supersession-threat > is called from C with some flag that disables signaling 'quit'. > But when trying to type RET after (y-or-n-p "Answer y or n: ") > it [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: > Maybe it works here because ask-user-about-supersession-threat > is called from C with some flag that disables signaling 'quit'. > But when trying to type RET after (y-or-n-p "Answer y or n: ") > it terminates with the 'quit' signal. And indeed in the map > used by y-or-n-p, RET is bound to 'exit': > > (define-key query-replace-map "\r" 'exit) I must have tested this in the wrong version of Emacs -- I thought I was testing y-or-n-p in Emacs 26.3 to see what it did there, but I must have started a more recent version instead. > I noticed the recent commit ec9f25bd356c7c81d94c78f11100b97d6d52ce97 > saying that RET means "yes" in y-or-n-p. But anyway since RET > now does the same that read-char-choice-with-read-key does, > so I removed mentions of RET from the doc string. Or should > the fixed behavior be mentioned? No, that's fine. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no