GNU bug report logs - #5108
23.1; ps-print-buffer infinite loop on image-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5108 in the body.
You can then email your comments to 5108 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; ps-print-buffer infinite loop on image-mode
Date: Thu, 03 Dec 2009 09:26:27 +1100

A ps-print-buffer on some image files in image-mode goes into an
infinite loop.  For example "cut.xpm" in the current emacs cvs,

    (progn
      (switch-to-buffer "x")
      (erase-buffer)
      (insert-file-contents (concat data-directory "images/cut.xpm"))
      (image-mode)
      (ps-print-buffer "/tmp/foo.ps"))

shows message

    Formatting...  0%

and then goes away apparently forever.

debug-on-quit says the loop is ps-mule-plot-string.  It seems (point)
has gone past the intended `stop' position, so "(= (point) stop)" is not
satisfied, or something like that.  Might be the forward-char under
"(looking-at ascii-or-latin-1)" going too far, maybe something to do
with the image overlay, or point movement within image mode ...

(What I actually hoped for was that it might print the image, but
perhaps it doesn't print images at all ...)



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

Message #10 received at 5108 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 5108 <at> debbugs.gnu.org
Subject: Re: 23.1; ps-print-buffer infinite loop on image-mode
Date: Sun, 18 Sep 2011 11:46:19 +0200

Kevin Ryde <user42 <at> zip.com.au> writes:

> A ps-print-buffer on some image files in image-mode goes into an
> infinite loop.  For example "cut.xpm" in the current emacs cvs,
>
>     (progn
>       (switch-to-buffer "x")
>       (erase-buffer)
>       (insert-file-contents (concat data-directory "images/cut.xpm"))
>       (image-mode)
>       (ps-print-buffer "/tmp/foo.ps"))
>
> shows message
>
>     Formatting...  0%
>
> and then goes away apparently forever.

I can confirm that this bug is still present in Emacs 24.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #15 received at 5108-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 5108-done <at> debbugs.gnu.org, Kevin Ryde <user42 <at> zip.com.au>
Subject: Re: bug#5108: 23.1; ps-print-buffer infinite loop on image-mode
Date: Mon, 19 Sep 2011 15:27:36 -0400

>> (with-temp-buffer
>>   (insert-file-contents (concat data-directory "images/cut.xpm"))
>>   (image-mode)
>>   (ps-print-buffer "/tmp/foo.ps"))
>> shows message
>> Formatting...  0%
>> and then goes away apparently forever.
> I can confirm that this bug is still present in Emacs 24.

Yes, it's the evil `intangible' property at work.
I've installed the patch below which should fix the immediate
inf-loop problem.  I also removed the intangible property from
image-mode to avoid similar problems in other codes.


        Stefan


--- lisp/ps-mule.el	2011-04-19 13:44:55 +0000
+++ lisp/ps-mule.el	2011-09-19 18:57:29 +0000
@@ -659,7 +659,7 @@
 	 width)
     (goto-char from)
     (while (not endpos)
-      (cond ((= (point) stop)
+      (cond ((>= (point) stop)
 	     (if (= stop to)
 		 (setq endpos stop)
 	       (when (< from stop)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.