GNU bug report logs - #51077
[PATCH] gnu: ceph: Fix breaking change in snappy.

Previous Next

Package: guix-patches;

Reported by: Greg Hogan <code <at> greghogan.com>

Date: Thu, 7 Oct 2021 12:45:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Greg Hogan <code <at> greghogan.com>
Cc: 51077 <at> debbugs.gnu.org
Subject: [bug#51077] [PATCH] gnu: ceph: Fix breaking change in snappy.
Date: Thu, 07 Oct 2021 15:01:40 +0200
Hi,

> diff --git a/gnu/packages/patches/ceph-fix-snappy-breaking-
> change.patch
> b/gnu/packages/patches/ceph-fix-snappy-breaking-change.patch
> new file mode 100644
> index 0000000000..7a10e2e4ae
> --- /dev/null
> +++ b/gnu/packages/patches/ceph-fix-snappy-breaking-change.patch
> @@ -0,0 +1,13 @@
> +Patch tracked upstream at https://tracker.ceph.com/issues/50934
> +
> +--- a/src/compressor/snappy/SnappyCompressor.h
> ++++ b/src/compressor/snappy/SnappyCompressor.h
> +@@ -96,7 +96,7 @@ class SnappyCompressor : public Compressor {
> +     if (qat_enabled)
> +       return qat_accel.decompress(p, compressed_len, dst);
> + #endif
> +-    snappy::uint32 res_len =3D 0;
> ++    uint32_t res_len =3D 0;
> +     BufferlistSource source_1(p, compressed_len);
> +     if (!snappy::GetUncompressedLength(&source_1, &res_len)) {
> +       return -1;
Instead of patching this line, this can be solved via substitute*
(either as a snippet or in an additional build phase).  Could you send
an updated patch?

Regards,
Liliana





This bug report was last modified 3 years and 306 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.