GNU bug report logs - #51076
28.0.60; Null dereference warning with nox build in make_lispy_position

Previous Next

Package: emacs;

Reported by: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Date: Thu, 7 Oct 2021 11:36:02 UTC

Severity: minor

Found in version 28.0.60

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 51076 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 51076 <at> debbugs.gnu.org
Subject: Re: bug#51076: 28.0.60;
 Null dereference warning with nox build in make_lispy_position
Date: Thu, 07 Oct 2021 16:10:41 +0300
> Date: Thu, 07 Oct 2021 12:35:24 +0100
> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> In file included from keyboard.c:29:
> keyboard.c: In function ‘make_lispy_position’:
> frame.h:949:35: warning: null pointer dereference [-Wnull-dereference]
>   949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines
>       |                                ~~~^~~~~~~~~~~~~~~
> keyboard.c:5134:10: note: in expansion of macro ‘FRAME_TAB_BAR_LINES’
>  5134 |       && FRAME_TAB_BAR_LINES (f) > 0
>       |          ^~~~~~~~~~~~~~~~~~~
> 
> AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true
> in a nox build

Yes, but what about a build with X support that displays a TTY frame?

I installed a trivial fix.




This bug report was last modified 3 years and 305 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.