GNU bug report logs - #51076
28.0.60; Null dereference warning with nox build in make_lispy_position

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51076 <at> debbugs.gnu.org
Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position
Date: Fri, 08 Oct 2021 11:20:41 +0100

close 51076 28.1
quit

Eli Zaretskii [2021-10-07 09:10 -0400] wrote:

>> Date: Thu, 07 Oct 2021 12:35:24 +0100
>> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> In file included from keyboard.c:29:
>> keyboard.c: In function ‘make_lispy_position’:
>> frame.h:949:35: warning: null pointer dereference [-Wnull-dereference]
>>   949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines
>>       |                                ~~~^~~~~~~~~~~~~~~
>> keyboard.c:5134:10: note: in expansion of macro ‘FRAME_TAB_BAR_LINES’
>>  5134 |       && FRAME_TAB_BAR_LINES (f) > 0
>>       |          ^~~~~~~~~~~~~~~~~~~
>> 
>> AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true
>> in a nox build
>
> Yes, but what about a build with X support that displays a TTY frame?
>
> I installed a trivial fix.

Thanks, that does the trick.

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.