From unknown Fri Sep 05 20:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Oct 2021 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 51076@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163360653728540 (code B ref -1); Thu, 07 Oct 2021 11:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Oct 2021 11:35:37 +0000 Received: from localhost ([127.0.0.1]:46210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYRgX-0007QG-Ae for submit@debbugs.gnu.org; Thu, 07 Oct 2021 07:35:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:55004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYRgU-0007Q7-DB for submit@debbugs.gnu.org; Thu, 07 Oct 2021 07:35:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYRgU-0003MW-5g for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 07:35:34 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:46816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYRgQ-00075c-JD for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 07:35:33 -0400 Received: by mail-wr1-x42f.google.com with SMTP id k7so17969678wrd.13 for ; Thu, 07 Oct 2021 04:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=NydJ+6di8XLz9tQsSbaLY/lAzgMNQUSYXTwq7x5gABw=; b=PA5v/TDsbXrS00lwMUg/a8QYQcV+cgj/34gib/YGoAnvrngBE6GGAFeudrJAoKHBfU vrOL+mrd6qhW7y5U7keA8jhi2yjwMbWgtg3rVJis0f8cTjD+FxYFO2y4IilLnnT0IBNW voKns3cVuSJDRaZapEJ2634aSkHLx1ZZlMN12D/IicxUhpzyn6gVszsbMCfTVxI+rfel EYA84JMKztnlDCRvl9bv6c/7zOzaPdnDgipq2ZbIJmfDHu3ynAjrLgdbN0yPVwsY5w2F Yl3EHNHUW7gBbLUB/oIRK5FqVU4TluwoXe2ZwQy0Ea/jJaJiyvTbTw2Cgv0J7wr/xGH7 ircw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=NydJ+6di8XLz9tQsSbaLY/lAzgMNQUSYXTwq7x5gABw=; b=SjTsp6aiIpR8dIjnYk/KKxWc3VAmU9rXaoiVxmIBCte1bfQY7rfmWwNyGWTkSPNuEX Ntn0z6TRcar1YmosBATkz/lWtTp93y81LKrXj+r3kcti387q+zTDNJdU38QIMbLfp3si RhZ6uVmyam7v3IUnsLBULlmsAsvjQO/fTHELsskrwkr0YUWRPmISOdD/3Kg6ayHwDEWf PcdYgw1D0LzQDgRrmvPeKWZl5+nA1bGSPdLPrRAObuLl3DXB6ITXRBD1oZQ3XnJRza/e ESKKTkfwoCarGF0Vi9LK++3/vkGCKLjfNMAsOypZEjYn2nYlxaDqk6dAYd/q9qKj/oUr +11Q== X-Gm-Message-State: AOAM533/5E6f5L+6rjsoMdhZ9/cirKlb2YRHJ6ZQzoUzMBznS+WT69h/ 33MiKVWzvTeIyt1E0LZYvIVaMkgH2ey9mw== X-Google-Smtp-Source: ABdhPJwyZmkjHrq5p5MIS4KpAW+Jf8EFuhhR3tY5cykUjfqj22f1jsxb3Pr2cGfHDhjVjZt/I+fLNg== X-Received: by 2002:a05:600c:1552:: with SMTP id f18mr15403214wmg.184.1633606526085; Thu, 07 Oct 2021 04:35:26 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id u3sm7711690wmc.16.2021.10.07.04.35.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 04:35:25 -0700 (PDT) From: "Basil L. Contovounesios" Date: Thu, 07 Oct 2021 12:35:24 +0100 Message-ID: <87wnmp2hkz.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Severity: minor I'm currently seeing the following warning with GCC 10.3.0 and --without-x: In file included from keyboard.c:29: keyboard.c: In function =E2=80=98make_lispy_position=E2=80=99: frame.h:949:35: warning: null pointer dereference [-Wnull-dereference] 949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines | ~~~^~~~~~~~~~~~~~~ keyboard.c:5134:10: note: in expansion of macro =E2=80=98FRAME_TAB_BAR_LINE= S=E2=80=99 5134 | && FRAME_TAB_BAR_LINES (f) > 0 | ^~~~~~~~~~~~~~~~~~~ AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true in a nox build, but it's not clear to me what the logic of make_lispy_position should do in such a case. Thanks, --=20 Basil In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu) of 2021-10-07 built on tia Repository revision: b7a10b44acf94458ed5f590be76749cec3e1b8dc Repository branch: emacs-28 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CC=3Dccache gcc' 'CFLAGS=3D-O2 -march=3Dnative' --config-cache --prefix=3D/home/blc/.local --program-suffix=3D-28-nox --enable-checking=3Dstructs --with-file-notification=3Dyes --with-x-toolkit=3Dno --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 55431 6608) (symbols 48 6643 1) (strings 32 18253 1556) (string-bytes 1 603597) (vectors 16 10645) (vector-slots 8 126102 7553) (floats 8 24 35) (intervals 56 193 0) (buffers 992 10)) From unknown Fri Sep 05 20:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Oct 2021 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Basil L. Contovounesios" Cc: 51076@debbugs.gnu.org Received: via spool by 51076-submit@debbugs.gnu.org id=B51076.16336122575684 (code B ref 51076); Thu, 07 Oct 2021 13:11:01 +0000 Received: (at 51076) by debbugs.gnu.org; 7 Oct 2021 13:10:57 +0000 Received: from localhost ([127.0.0.1]:46375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYTAm-0001Tc-OZ for submit@debbugs.gnu.org; Thu, 07 Oct 2021 09:10:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYTAj-0001TO-7T for 51076@debbugs.gnu.org; Thu, 07 Oct 2021 09:10:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36118) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYTAc-0000p6-Sd; Thu, 07 Oct 2021 09:10:47 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1502 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYTAc-0007dv-Ex; Thu, 07 Oct 2021 09:10:46 -0400 Date: Thu, 07 Oct 2021 16:10:41 +0300 Message-Id: <831r4x0ylq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87wnmp2hkz.fsf@tcd.ie> (bug-gnu-emacs@gnu.org) References: <87wnmp2hkz.fsf@tcd.ie> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 07 Oct 2021 12:35:24 +0100 > From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In file included from keyboard.c:29: > keyboard.c: In function ‘make_lispy_position’: > frame.h:949:35: warning: null pointer dereference [-Wnull-dereference] > 949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines > | ~~~^~~~~~~~~~~~~~~ > keyboard.c:5134:10: note: in expansion of macro ‘FRAME_TAB_BAR_LINES’ > 5134 | && FRAME_TAB_BAR_LINES (f) > 0 > | ^~~~~~~~~~~~~~~~~~~ > > AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true > in a nox build Yes, but what about a build with X support that displays a TTY frame? I installed a trivial fix. From unknown Fri Sep 05 20:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2021 10:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 51076@debbugs.gnu.org Received: via spool by 51076-submit@debbugs.gnu.org id=B51076.163368845511225 (code B ref 51076); Fri, 08 Oct 2021 10:21:02 +0000 Received: (at 51076) by debbugs.gnu.org; 8 Oct 2021 10:20:55 +0000 Received: from localhost ([127.0.0.1]:49274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYmzn-0002uz-07 for submit@debbugs.gnu.org; Fri, 08 Oct 2021 06:20:55 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:40904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYmzh-0002uT-9p for 51076@debbugs.gnu.org; Fri, 08 Oct 2021 06:20:51 -0400 Received: by mail-wr1-f42.google.com with SMTP id i12so15593535wrb.7 for <51076@debbugs.gnu.org>; Fri, 08 Oct 2021 03:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HGjowycWLwrWSQl1yZ/72gMjhlkw9fv6meCA4k5FpZ4=; b=RdBS+ZB1O1hEUNACW7dHMjAKFe/HAyPwTbrWUOzhmjXYsyoyMOaTLAlvG4jJmUrlZg 6rjyDmSVKK299ffatfCjs51ACNW/fWOA4NdWKMp+Om3V3uXZ154IVaJa+jihFyZYYd0R qibRa7Wn3ZiWyGaKT4eqi4eQmWFw5T5XgFPxF9UF/piP29lRcl9p/0ji/2sBPzRjFoAC aidszsfPmjbfzpHlo+k5qLy0yhRlfPrLHtXiGgxDRu1qxqPus6Csg58n/NWqlfkZM++b QKKHmbVMIUGEoc7IwkD7WoTQtG3c2+tF/+P+BhHVKY0J7Iqz0rhxrM68F8U0NSV2kbl3 fNpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HGjowycWLwrWSQl1yZ/72gMjhlkw9fv6meCA4k5FpZ4=; b=ENVt3zn/IV40LqSrw8ZuwoDoDGT+AfCfAzBOmW+0To7RtDREIvr5fOmaOG4BzrFH+6 M8mDl0/gc1Utcxi2FzZFFdgHmbJVwPMyU0JYnuLgW7HPryu+NOFQeDx+EUm74i1OMRa6 jQ3RlxotXAYcJcHB8xOsJpOFs6d/ieUHsyBwOJgfkKGzMsXg2DIvN+/yfOaBUvpxm1h5 CFmFi17r+dMODRtdWuQzseBvDbr7h73tPTz8boin38BQb68yn81atra6wA2GBcHE7NKl wVeKXxhqAXAeg8kQcT1W2oh60gpXrtyxkkbnLAOKHDqKQTsIRFjK53DGaFQqGQODimNQ 6/Ag== X-Gm-Message-State: AOAM530hh5XeoLS27wJCLJ//it/8SsO+aP8kOP7iA9emYT0Nf+C+fGDV o5Ho4oR+B90XY9ssh7HnTKqQEw== X-Google-Smtp-Source: ABdhPJxlYAkdG16ixJ98776VSpXI9ezydtyIqvsVT+Z3TCjJxFJUMGDUU3pSs4xUgjRkZhQFF0MJ7Q== X-Received: by 2002:a05:6000:1562:: with SMTP id 2mr2968810wrz.36.1633688443437; Fri, 08 Oct 2021 03:20:43 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id q3sm1998622wmc.25.2021.10.08.03.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 03:20:42 -0700 (PDT) From: "Basil L. Contovounesios" References: <87wnmp2hkz.fsf@tcd.ie> <831r4x0ylq.fsf@gnu.org> Date: Fri, 08 Oct 2021 11:20:41 +0100 In-Reply-To: <831r4x0ylq.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Oct 2021 09:10:48 -0400") Message-ID: <87bl3zom12.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 51076 28.1 quit Eli Zaretskii [2021-10-07 09:10 -0400] wrote: >> Date: Thu, 07 Oct 2021 12:35:24 +0100 >> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> In file included from keyboard.c:29: >> keyboard.c: In function =E2=80=98make_lispy_position=E2=80=99: >> frame.h:949:35: warning: null pointer dereference [-Wnull-dereference] >> 949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines >> | ~~~^~~~~~~~~~~~~~~ >> keyboard.c:5134:10: note: in expansion of macro =E2=80=98FRAME_TAB_BAR_L= INES=E2=80=99 >> 5134 | && FRAME_TAB_BAR_LINES (f) > 0 >> | ^~~~~~~~~~~~~~~~~~~ >>=20 >> AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true >> in a nox build > > Yes, but what about a build with X support that displays a TTY frame? > > I installed a trivial fix. Thanks, that does the trick. --=20 Basil