GNU bug report logs - #51064
[PATCH] gnu: fish: Update to 3.3.1

Previous Next

Full log

Message #14 received at 51064 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Filip Staffa <gnu <at> filipstaffa.net>
Cc: 51064 <at> debbugs.gnu.org
Subject: Re: bug#51064: [PATCH] gnu: fish: Update to 3.3.1
Date: Fri, 15 Oct 2021 17:16:17 +0200

Hi Filip,

Filip Staffa <gnu <at> filipstaffa.net> skribis:

> thanks for checking the patch. It worked on my machine, so I have
> checked the test itself. It looks like in your case it failed on a
> precondition. It checks the environment for processes matching Z*, and
> if it find any it fails.  Specifically this command (found here:
> https://github.com/fish-shell/fish-shell/blob/Integration_3.3.1/tests/checks/jobs.fish#L9
> ): ps -o s | string match 'Z*' | count

Builds happen in an isolated environment, specifically in a separate PID
namespace.  So what’s running on my machine shouldn’t matter.

> Would you be able to stop all such processes/run it in environment
> where this command returns 0? If not I would propose to close this
> patch and wait for next version of fish shell, it looks like they
> fixed the test to be less flaky on Fish master branch.

Alternatively, if you prefer, we can apply upstream’s patch in Guix.

Let me know!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.