From unknown Mon Aug 11 21:12:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51064 <51064@debbugs.gnu.org> To: bug#51064 <51064@debbugs.gnu.org> Subject: Status: [PATCH] gnu: fish: Update to 3.3.1 Reply-To: bug#51064 <51064@debbugs.gnu.org> Date: Tue, 12 Aug 2025 04:12:35 +0000 retitle 51064 [PATCH] gnu: fish: Update to 3.3.1 reassign 51064 guix-patches submitter 51064 Filip Staffa severity 51064 normal tag 51064 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 06 14:20:39 2021 Received: (at submit) by debbugs.gnu.org; 6 Oct 2021 18:20:39 +0000 Received: from localhost ([127.0.0.1]:45460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYBWx-0001Ri-2x for submit@debbugs.gnu.org; Wed, 06 Oct 2021 14:20:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:40174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYBUU-0001Nt-S3 for submit@debbugs.gnu.org; Wed, 06 Oct 2021 14:18:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYBUU-0006pP-1Z for guix-patches@gnu.org; Wed, 06 Oct 2021 14:18:06 -0400 Received: from mail-0301.mail-europe.com ([188.165.51.139]:49020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYBUR-0002R0-Cb for guix-patches@gnu.org; Wed, 06 Oct 2021 14:18:05 -0400 Date: Wed, 06 Oct 2021 18:17:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=filipstaffa.net; s=protonmail; t=1633544276; bh=0bh9kxIyo9r94Dmsqmn8H0K5YMcrRKCTKtvuwFnPkNE=; h=Date:To:From:Cc:Reply-To:Subject:From; b=AgYnXfArBqCz7lVRvJgSooTj8AfBgJiqhnMHW8qSbOSFxbtZ/T5KQvxtrL26N8Av7 FJLpKGU13mqI6Ou6FVXrNHYmFGzaesBwzj6AFq7vN+BxuraySroLqzcAbgmzbm04jC bRfoWFbl3QkMWfMJ1TZgTz3zpn2aaDrn78FZn51+C95unOAQ9wAlrXmPvJpXDGg/OX rPOb+n7FREc1HJgS71jIjh0AAxlDaHuX/vafQpfxWTeHax0UYbaw6heG2bboAQX+Rh zEFrVqtB3PANGb46WRXEvEywf4MuBcw9PxaY13F7ngEW8p4SySLCm7l9Cy+3XFwvkf haXjCzUkZ5A7A== To: guix-patches@gnu.org From: Filip Staffa Subject: [PATCH] gnu: fish: Update to 3.3.1 Message-ID: <20211006181722.138-1-gnu@filipstaffa.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=10.0 tests=ALL_TRUSTED,DKIM_INVALID, DKIM_SIGNED shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=188.165.51.139; envelope-from=gnu@filipstaffa.net; helo=mail-0301.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 06 Oct 2021 14:20:37 -0400 Cc: Filip Staffa X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Filip Staffa Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/shells.scm (fish): Update to 3.3.1 --- gnu/packages/shells.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm index 62862516c3..4f2a63f3cf 100644 --- a/gnu/packages/shells.scm +++ b/gnu/packages/shells.scm @@ -113,7 +113,7 @@ direct descendant of NetBSD's Almquist Shell (@command{= ash}).") (define-public fish (package (name "fish") - (version "3.2.2") + (version "3.3.1") (source (origin (method url-fetch) @@ -121,7 +121,7 @@ direct descendant of NetBSD's Almquist Shell (@command{= ash}).") "releases/download/" version "/" "fish-" version ".tar.xz")) (sha256 - (base32 "02a0dgz5cy4iv3ysvl5kzzd4ji8pxqv93zd45041plcki0ddli2r")) + (base32 "12dfkyqv5vm52i1fifz91h8f8xg60xjvv94kx6xjqxk9a8dfxd5m")) (modules '((guix build utils))) (snippet '(begin -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 11:02:55 2021 Received: (at 51064) by debbugs.gnu.org; 12 Oct 2021 15:02:55 +0000 Received: from localhost ([127.0.0.1]:47716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maJIo-0005YC-Ax for submit@debbugs.gnu.org; Tue, 12 Oct 2021 11:02:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maJIa-0005X4-OD for 51064@debbugs.gnu.org; Tue, 12 Oct 2021 11:02:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43952) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maJIV-0000oA-74; Tue, 12 Oct 2021 11:02:31 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=50952 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maJIU-0003JJ-Re; Tue, 12 Oct 2021 11:02:31 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Filip Staffa Subject: Re: bug#51064: [PATCH] gnu: fish: Update to 3.3.1 References: <20211006181722.138-1-gnu@filipstaffa.net> Date: Tue, 12 Oct 2021 17:02:28 +0200 In-Reply-To: <20211006181722.138-1-gnu@filipstaffa.net> (Filip Staffa's message of "Wed, 06 Oct 2021 18:17:44 +0000") Message-ID: <87h7dmuvzv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51064 Cc: 51064@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Filip, Filip Staffa skribis: > * gnu/packages/shells.scm (fish): Update to 3.3.1 On x86_64-linux, I=E2=80=99m getting this test failure: --8<---------------cut here---------------start------------->8--- Testing file checks/invocation.fish ... ok (56 ms) Testing file checks/job-control-noninteractive.fish ... ok (14 ms) Testing file checks/job-control-not-a-tty.fish ... ok (8 ms) Testing file checks/job-ids.fish ... ok (13 ms) Testing file checks/jobs.fish ... Failure: The CHECK on line 18 wants: All clear of zombies. which failed to match line stdout:1: Found existing zombie processes. Clean up zombies before running this t= est. Context: Found existing zombie processes. Clean up zombies before running this t= est. <=3D does not match CHECK 'All clear of zombies.' on line 18 <=3D nothing to match CHECK 'Trigger process reaping' on line 28 <=3D nothing to match CHECK '1' on line 46 <=3D nothing to match CHECK 'Command' on line 50 <=3D nothing to match CHECK 'sleep' on line 51 <=3D nothing to match CHECK 'sleep' on line 52 <=3D nothing to match CHECK '0' on line 55 <=3D nothing to match CHECK 'Command' on line 66 <=3D nothing to match CHECK 'sleep' on line 67 <=3D nothing to match CHECK 'sleep' on line 68 <=3D nothing to match CHECK '1' on line 71 <=3D nothing to match CHECK '2' on line 75 <=3D nothing to match CHECK '1' on line 79 <=3D nothing to match CHECK '2' on line 82 <=3D nothing to match CHECK 'Command' on line 110 <=3D nothing to match CHECK 'sleep' on line 111 <=3D nothing to match CHECK 'sleep is done' on line 112 <=3D nothing to match CHECK '1' on line 113 <=3D nothing to match CHECK 'Command' on line 117 <=3D nothing to match CHECK 'sleep' on line 118 <=3D nothing to match CHECK '0' on line 119 <=3D nothing to match CHECK 'foo' on line 133 <=3D nothing to match CHECK 'caller' on line 134 when running command: ../test/root/bin/fish checks/jobs.fish Testing file checks/line-continuation.fish ... ok (6 ms) Testing file checks/line-number.fish ... ok (6 ms) Testing file checks/locale.fish ... ok (28 ms) --8<---------------cut here---------------end--------------->8--- Does that ring a bell? Any suggestions? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 15:46:46 2021 Received: (at 51064) by debbugs.gnu.org; 12 Oct 2021 19:46:46 +0000 Received: from localhost ([127.0.0.1]:53967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maNjY-0007ia-SR for submit@debbugs.gnu.org; Tue, 12 Oct 2021 15:46:45 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]:22809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maNUo-0007Dw-Oj for 51064@debbugs.gnu.org; Tue, 12 Oct 2021 15:31:33 -0400 Date: Tue, 12 Oct 2021 19:31:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=filipstaffa.net; s=protonmail; t=1634067083; bh=YaDQ+f7MDzWbbB9fiYVwuxeTG8TXrjnmFV6isdfKHTs=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=bcGnFjOT4kuiyvbXaa+JdKJfyywsc/QNY95o16jY7axYjHUVJKYseTSsDHC2/CX5E GXwsb+eiVLTIKVEnL00p9efPcsyeVAzeG9UqVqQjoEJY1zRi+uXgalKnPLHUOd3ENf nJhNZdb0d/ltUBv8RMJnjTTnt4cRVIkXZO4DfHkARUK+8ZC/U1xRUNj+PBGpPaEumR Yom478pZJIhyQo+mX/Y8qppZ8zsSFrxAJcdVeBP8yBVSjU7J6AooKLR256uYINYRwh /Fco1rXiCJgtV7sRmIG4BLuI3BvCpF68/N/KI5QJtN4Tpf+0F+36CpJ5XEx1aI+zts AHnStIrsudSdQ== To: =?utf-8?Q?Ludovic_Court=C3=A8s?= From: Filip Staffa Subject: Re: bug#51064: [PATCH] gnu: fish: Update to 3.3.1 Message-ID: In-Reply-To: <87h7dmuvzv.fsf@gnu.org> References: <20211006181722.138-1-gnu@filipstaffa.net> <87h7dmuvzv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=10.0 tests=ALL_TRUSTED,DKIM_INVALID, DKIM_SIGNED shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51064 X-Mailman-Approved-At: Tue, 12 Oct 2021 15:46:43 -0400 Cc: 51064@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Filip Staffa Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo=E2=80=99, thanks for checking the patch. It worked on my machine, so I have checked t= he test itself. It looks like in your case it failed on a precondition. It = checks the environment for processes matching Z*, and if it find any it fai= ls. Specifically this command (found here: https://github.com/fish-shell/fish-s= hell/blob/Integration_3.3.1/tests/checks/jobs.fish#L9 ): ps -o s | string match 'Z*' | count Would you be able to stop all such processes/run it in environment where th= is command returns 0? If not I would propose to close this patch and wait f= or next version of fish shell, it looks like they fixed the test to be less= flaky on Fish master branch. Regards, Filip =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Tuesday, October 12th, 2021 at 17:02, Ludovic Court=C3=A8s wrote: > Hi Filip, > > Filip Staffa gnu@filipstaffa.net skribis: > > > - gnu/packages/shells.scm (fish): Update to 3.3.1 > > On x86_64-linux, I=E2=80=99m getting this test failure: > > --8<---------------cut here---------------start------------->8--- > > Testing file checks/invocation.fish ... ok (56 ms) > > Testing file checks/job-control-noninteractive.fish ... ok (14 ms) > > Testing file checks/job-control-not-a-tty.fish ... ok (8 ms) > > Testing file checks/job-ids.fish ... ok (13 ms) > > Testing file checks/jobs.fish ... Failure: > > The CHECK on line 18 wants: > > All clear of zombies. > > which failed to match line stdout:1: > > Found existing zombie processes. Clean up zombies before running this tes= t. > > Context: > > Found existing zombie processes. Clean up zombies before running this tes= t. <=3D does not match CHECK 'All clear of zombies.' on line 18 > > <=3D nothing to match CHECK 'Trigger process reaping' on line 28 > > <=3D nothing to match CHECK '1' on line 46 > > <=3D nothing to match CHECK 'Command' on line 50 > > <=3D nothing to match CHECK 'sleep' on line 51 > > <=3D nothing to match CHECK 'sleep' on line 52 > > <=3D nothing to match CHECK '0' on line 55 > > <=3D nothing to match CHECK 'Command' on line 66 > > <=3D nothing to match CHECK 'sleep' on line 67 > > <=3D nothing to match CHECK 'sleep' on line 68 > > <=3D nothing to match CHECK '1' on line 71 > > <=3D nothing to match CHECK '2' on line 75 > > <=3D nothing to match CHECK '1' on line 79 > > <=3D nothing to match CHECK '2' on line 82 > > <=3D nothing to match CHECK 'Command' on line 110 > > <=3D nothing to match CHECK 'sleep' on line 111 > > <=3D nothing to match CHECK 'sleep is done' on line 112 > > <=3D nothing to match CHECK '1' on line 113 > > <=3D nothing to match CHECK 'Command' on line 117 > > <=3D nothing to match CHECK 'sleep' on line 118 > > <=3D nothing to match CHECK '0' on line 119 > > <=3D nothing to match CHECK 'foo' on line 133 > > <=3D nothing to match CHECK 'caller' on line 134 > > when running command: > > ../test/root/bin/fish checks/jobs.fish > > Testing file checks/line-continuation.fish ... ok (6 ms) > > Testing file checks/line-number.fish ... ok (6 ms) > > Testing file checks/locale.fish ... ok (28 ms) > > --8<---------------cut here---------------end--------------->8--- > > Does that ring a bell? Any suggestions? > > Thanks, > > Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 15 11:16:30 2021 Received: (at 51064) by debbugs.gnu.org; 15 Oct 2021 15:16:31 +0000 Received: from localhost ([127.0.0.1]:40304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbOwg-0003OS-NC for submit@debbugs.gnu.org; Fri, 15 Oct 2021 11:16:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbOwa-0003OA-T9 for 51064@debbugs.gnu.org; Fri, 15 Oct 2021 11:16:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33792) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbOwV-00063a-I3; Fri, 15 Oct 2021 11:16:19 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=50958 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbOwV-00062i-9a; Fri, 15 Oct 2021 11:16:19 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Filip Staffa Subject: Re: bug#51064: [PATCH] gnu: fish: Update to 3.3.1 References: <20211006181722.138-1-gnu@filipstaffa.net> <87h7dmuvzv.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 15 Oct 2021 17:16:17 +0200 In-Reply-To: (Filip Staffa's message of "Tue, 12 Oct 2021 19:31:20 +0000") Message-ID: <87sfx2iaim.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51064 Cc: 51064@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Filip, Filip Staffa skribis: > thanks for checking the patch. It worked on my machine, so I have > checked the test itself. It looks like in your case it failed on a > precondition. It checks the environment for processes matching Z*, and > if it find any it fails. Specifically this command (found here: > https://github.com/fish-shell/fish-shell/blob/Integration_3.3.1/tests/che= cks/jobs.fish#L9 > ): ps -o s | string match 'Z*' | count Builds happen in an isolated environment, specifically in a separate PID namespace. So what=E2=80=99s running on my machine shouldn=E2=80=99t matte= r. > Would you be able to stop all such processes/run it in environment > where this command returns 0? If not I would propose to close this > patch and wait for next version of fish shell, it looks like they > fixed the test to be less flaky on Fish master branch. Alternatively, if you prefer, we can apply upstream=E2=80=99s patch in Guix. Let me know! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 15 11:52:00 2021 Received: (at 51064) by debbugs.gnu.org; 15 Oct 2021 15:52:00 +0000 Received: from localhost ([127.0.0.1]:40336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbPV1-0004Oo-Gv for submit@debbugs.gnu.org; Fri, 15 Oct 2021 11:52:00 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:51358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbPLV-00046n-Cd for 51064@debbugs.gnu.org; Fri, 15 Oct 2021 11:42:13 -0400 Date: Fri, 15 Oct 2021 15:42:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=filipstaffa.net; s=protonmail; t=1634312522; bh=psh6rnGvD9MBhkCaMY+WBzDXMTSaYDim/VHAlzo8wZ8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=ehhs9T5MAFfstUHp4/HEF+qlVTJ2ZdSQX9gKPLRaLFlrsnwKI6U92sFTV0d37K/OQ bHyWj9nKpP4/YzDyBRm7b31byHJz/qTxVj/KNHyxUuFrnRwDZSAb5cek3eGiQPwbE3 WVWihNDcXDKEOFtM2Be45ve340OEY3xFveY3J1r4RUjoJgJxIHxyTyxSCzo+OMnxxu XCcLJ6u4fMUCWUVJXYU0Roeib/u42hjuXANjSiNwEbVxrTfiiyOheZ1zva029h1I+Y Hocg6azRiOjQR5KYnFxDNKC1HPChWvUoUMbu+SY8obivf8ip9P1VL+2Md4w7pKu1K1 TwMXfOX5fCm4A== To: =?utf-8?Q?Ludovic_Court=C3=A8s?= From: Filip Staffa Subject: Re: bug#51064: [PATCH] gnu: fish: Update to 3.3.1 Message-ID: In-Reply-To: <87sfx2iaim.fsf@gnu.org> References: <20211006181722.138-1-gnu@filipstaffa.net> <87h7dmuvzv.fsf@gnu.org> <87sfx2iaim.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=10.0 tests=ALL_TRUSTED,DKIM_INVALID, DKIM_SIGNED shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51064 X-Mailman-Approved-At: Fri, 15 Oct 2021 11:51:57 -0400 Cc: 51064@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Filip Staffa Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo=E2=80=99, I am new to Guix and have no knowledge of Fish source code, so I am not sur= e how to replicate/debug the issue. I propose to close this patch, and I will create a new one once new version= of Fish gets released. If the issue persists with the new version, I will = hopefully have more knowledge by then to debug it :-) Regards, Filip =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, October 15th, 2021 at 17:16, Ludovic Court=C3=A8s = wrote: > Hi Filip, > > Filip Staffa gnu@filipstaffa.net skribis: > > > thanks for checking the patch. It worked on my machine, so I have > > > > checked the test itself. It looks like in your case it failed on a > > > > precondition. It checks the environment for processes matching Z*, and > > > > if it find any it fails. Specifically this command (found here: > > > > https://github.com/fish-shell/fish-shell/blob/Integration_3.3.1/tests/c= hecks/jobs.fish#L9 > > > > ): ps -o s | string match 'Z*' | count > > Builds happen in an isolated environment, specifically in a separate PID > > namespace. So what=E2=80=99s running on my machine shouldn=E2=80=99t matt= er. > > > Would you be able to stop all such processes/run it in environment > > > > where this command returns 0? If not I would propose to close this > > > > patch and wait for next version of fish shell, it looks like they > > > > fixed the test to be less flaky on Fish master branch. > > Alternatively, if you prefer, we can apply upstream=E2=80=99s patch in Gu= ix. > > Let me know! > > Thanks, > > Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 15 18:26:47 2021 Received: (at 51064-done) by debbugs.gnu.org; 15 Oct 2021 22:26:47 +0000 Received: from localhost ([127.0.0.1]:40559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbVf4-0007a3-UC for submit@debbugs.gnu.org; Fri, 15 Oct 2021 18:26:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbVf0-0007Zn-5D for 51064-done@debbugs.gnu.org; Fri, 15 Oct 2021 18:26:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52438) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbVeu-00071K-JG; Fri, 15 Oct 2021 18:26:36 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56974 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbVeu-0007xo-9i; Fri, 15 Oct 2021 18:26:36 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Filip Staffa Subject: Re: bug#51064: [PATCH] gnu: fish: Update to 3.3.1 References: <20211006181722.138-1-gnu@filipstaffa.net> <87h7dmuvzv.fsf@gnu.org> <87sfx2iaim.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 16 Oct 2021 00:26:33 +0200 In-Reply-To: (Filip Staffa's message of "Fri, 15 Oct 2021 15:42:01 +0000") Message-ID: <874k9hexgm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51064-done Cc: 51064-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Filip Staffa skribis: > I am new to Guix and have no knowledge of Fish source code, so I am not s= ure how to replicate/debug the issue. > I propose to close this patch, and I will create a new one once new versi= on of Fish gets released. If the issue persists with the new version, I wil= l hopefully have more knowledge by then to debug it :-) Alright, closing! (By sending this message to NNN-done@debbugs.gnu.org.) Ludo=E2=80=99. From unknown Mon Aug 11 21:12:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator