From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Oct 2021 17:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 51062@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16335417051030 (code B ref -1); Wed, 06 Oct 2021 17:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Oct 2021 17:35:05 +0000 Received: from localhost ([127.0.0.1]:45392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYAor-0000GR-Is for submit@debbugs.gnu.org; Wed, 06 Oct 2021 13:35:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:46068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYAom-0000Fx-BJ for submit@debbugs.gnu.org; Wed, 06 Oct 2021 13:35:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYAoe-0003ai-Ar for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 13:34:57 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:29541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYAoa-0001Px-QJ for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 13:34:52 -0400 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 55EA2240012 for ; Wed, 6 Oct 2021 17:34:43 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET Date: Wed, 06 Oct 2021 20:31:36 +0300 Message-ID: <87zgrm2h6v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) There are two ways how window resizing is currently hard-coded: 1. As discussed in https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01627.html when temp-buffer-resize-mode is enabled, it's impossible to disable automatic window resizing of the Help buffer. Thanks to Martin, the patch in https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01873.html allows customization when display-buffer-alist contains (window-height . nil) 2. As discussed in bug#45688, such commands as vc-log, vc-diff automatically resize the window, and the problem is that currently shrink-window-if-larger-than-buffer is used in these commands by default, but this behavior is hard-coded and can't be disabled by customization. A solution is to create a new hook like 'after-display-buffer-function' that by default will contain 'shrink-window-if-larger-than-buffer'. From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Oct 2021 09:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.163359772829437 (code B ref 51062); Thu, 07 Oct 2021 09:09:02 +0000 Received: (at 51062) by debbugs.gnu.org; 7 Oct 2021 09:08:48 +0000 Received: from localhost ([127.0.0.1]:46039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYPOS-0007ej-F4 for submit@debbugs.gnu.org; Thu, 07 Oct 2021 05:08:48 -0400 Received: from mout.gmx.net ([212.227.17.20]:54997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYPOQ-0007eS-Jn for 51062@debbugs.gnu.org; Thu, 07 Oct 2021 05:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1633597720; bh=X2aBetRnfLAydrzpPeXxRN6qNF1l4BjBfnQhs+a65cc=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=YQ5tU9TnRI/SqValckAbMMo+LeEWTHQdmAG0mHjfJEOHNBlTq5iefrQj/L73Rkmj4 Osc9NEbHdQJrrkBgcRU4QjRqi1Dvb8gWu0ph1+aMT+826J4Rm9ahmdUU9U2bNdlivQ +TLUOp2cIfbFMyQHzHyTrMrTKUbE6N5uLkDbH8bk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.142.97.180]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mdvqg-1n5pGT3K1G-00b69e; Thu, 07 Oct 2021 11:08:40 +0200 References: <87zgrm2h6v.fsf@mail.linkov.net> From: martin rudalics Message-ID: <651a937f-940a-1d2a-66a9-1e41082a37d4@gmx.at> Date: Thu, 7 Oct 2021 11:08:37 +0200 MIME-Version: 1.0 In-Reply-To: <87zgrm2h6v.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:TqQtEHft4kC1rcfB5AAsAy0hfz/iyNAbvVT7Z5oY/STPcOlypX6 Gyw/eTxYbR8uFU1hVT6ciDktn4A+w8R6BBiOZCi2v2KxCMQ0grA3OVs+l9T9RH4d9/2Zh7v oU9fndJ4rEI9kcJxoG8Ipvj9CBJ7fuQ4RspEgLg1N7Wk33byAY5BXJmVPZuTmnd88ITzC7J H61SULfDLD9qehjkOHE7A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:xHw6ncP91r8=:RbeG/MmwjYktkDzF+2qEM/ /NDQtFJREMWajGlUs78jl9uMBfGKyIaB+R8z/ZG2+dTf07gonaD8S33Jh3NAeos/UoDWuWfpP NsUdsULsIO2u92SuTt5XBMxr/ABLXL1clE4SQ/CBiHMA6HdFnSYWrXQHUS65fmMBa/s36U6CV rJ80J+EAungtsgufZHXYBFpC3IVIHSEp+kcP9e7gcMOacS80CLBJusJ8MGDwXhhygKNN++wLe KLaRYLbVyjcS/yRC7nyhhzbTJpyY59AtyYb5c/U5eSCVt+59v75siJY50UkOisRQy277t9pUU fpvmL0srxpvmbpeouSEzNy3VI7XR8HQXCDhJI2oBxucPhLmzMJr4ffpFXB/5y3euGijIGlvAB Agmv6RXMcEJ8RzNouz0E6UMIMl/g4LICHjp3wlWqaYnpPKOynbe7SLw7sRkvD8EcQLFyRHM3h okrYR4STtr+yb+vA1Jl1ONvFniYNVx1HO3RaRqeKgXVlNFUIcfbPMDts/UG71u7HPkge1VTWs EcHfJL0m267m7IEt/Itg37+QrOwOJLua4Qt55d6RD3hs4Xolaod5dTEz4KMhT2gF3Q+mRB7VX fy6tRiWqGunTlYS/4Wz1Yd+lFcBfaHY0XrAwjglj8l7Eir6yWUu8kdIOCR9Bp2vB7LAO5OCbT 5AVRClsv6KGVkoBu1rn8p2ja0x53BdV3iTrD6FnlXgcUel+MzhvXHfv8ZOLu96rMaA4zbPOcE KUkUlkR6cBERxUXkWv7/wQSBPRJACzHGvzO3k14Z7YebkAB1Hp7IELg7coImWliJbrQsuntLt kPl2B+MhRywwQrm/J1mPCUAUkix/mCeZVesMs/AjyuA14UH+c5OXZHK81VSfrLxOAh3AVV3Fs gh0x3SNDAuMuRVB6eHQcU/DjaadSF+/Byiq4e9owdgfEeQFcHZaMvPcxtl2deQAzB/Fh38LKx 3+494W0SxRZE4IiqFTGo7neWphZjYdGbrKjfxH/nbQGJUBoHPgR9O2c93hhN8ae1gh3k4l2kx 2b431jH5smc3D0XG4kQRuUUjEcESZNjQolyuC1tzd4KkzeT/ulXAnQzTnWtcI0vK4La5MKnZZ b9q2adP9vIw1kc= X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > There are two ways how window resizing is currently hard-coded: > > 1. As discussed in > https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01627.html > when temp-buffer-resize-mode is enabled, it's impossible > to disable automatic window resizing of the Help buffer. > > Thanks to Martin, the patch in > https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01873.html > allows customization when display-buffer-alist contains > (window-height . nil) That patch should help wherever 'temp-buffer-resize-mode' applies, not just in a Help buffer. > 2. As discussed in bug#45688, such commands as vc-log Which command is 'vc-log'? > , vc-diff > automatically resize the window, and the problem is that currently > shrink-window-if-larger-than-buffer is used in these commands by default, > but this behavior is hard-coded and can't be disabled by customization. > A solution is to create a new hook like 'after-display-buffer-function' > that by default will contain 'shrink-window-if-larger-than-buffer'. Wherever we currently use an idiom like (pop-to-buffer (current-buffer)) (goto-char (point-min)) (shrink-window-if-larger-than-buffer) we should use (pop-to-buffer (current-buffer) '(nil (window-height . shrink-window-if-larger-than-buffer))) (goto-char (point-min)) instead. But if 'display-buffer' is not involved, there isn't much we can do. Maybe something like 'display-buffer-same-window' _after_ putting the buffer into the selected window, but this might not be 100% compatible. Certainly not for Emacs 28. martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Oct 2021 08:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16341141964383 (code B ref 51062); Wed, 13 Oct 2021 08:37:02 +0000 Received: (at 51062) by debbugs.gnu.org; 13 Oct 2021 08:36:36 +0000 Received: from localhost ([127.0.0.1]:58000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maZka-00018d-9l for submit@debbugs.gnu.org; Wed, 13 Oct 2021 04:36:36 -0400 Received: from mout.gmx.net ([212.227.15.19]:58187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maZkY-00018Q-8F for 51062@debbugs.gnu.org; Wed, 13 Oct 2021 04:36:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1634114188; bh=VLbzqkWR10UFfoNbhESECAsTZgqy+iczoquO5M+yvSw=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=GS11DSBhmrANMe+yGdc7ydMq3TD2yJopEC8VSLVe1d2vWYx3u0ml8XC6qm4pU79KM QoavPhQM126leOcmTE7ohHVnkCn9w+BcI+VbUm7LlKqv/AR2d1keQlDI6saiLjQFKb GdwC+BhrS3vhcDmCAUDg5DiSQ3TrCNroIZNMG7Lo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.69]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mqs0R-1n5WrV02dt-00muxS; Wed, 13 Oct 2021 10:36:28 +0200 References: <87zgrm2h6v.fsf@mail.linkov.net> From: martin rudalics Message-ID: <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> Date: Wed, 13 Oct 2021 10:36:27 +0200 MIME-Version: 1.0 In-Reply-To: <87zgrm2h6v.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:I2S++V6IeSuuFALuU5VP79BSu6fpPveHCNR36WXBjDuA+xI4dCW bxwsMDsJWr7/DaNTtCZhER52UjyRFeUWOjJqcduCG4dMN0YnJ1XUEkqd7BLk02V7Imb1nHc QuhZzhoi4IQHYQ260rJSRJR/RqZOriJCh/ANAJ27rRoAUlhqJjpYnSr89Ajxs0isz1H9+bF +y1DPHKlNqcYPW7qOJKHw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6Dmj+ATPcio=:crGklMJga0GwULRrrxDQDO vkVoAxpXV7rJxR1+yPhTwLDDpE6liXrxtFgjSB/du/Tf8rclQgObfdXD90TA7jZmQvwJVdKEx TTHwIYQ5Lk0FvXMk0DgzwBMZECuqMvrJgpE4mrf8gP5WglUkRbEMhwZrdS49igFhMv3gAeVxr AumQ+kgPf8DNbTue06RcEmI70I8BF/rzqHkA4UWjZ9wlAxYYDNFKY6pzI3xX1L2zRM2vTeKGR xfLbcCZS0KkxKVNEF3Y/GOXyFtiQi5hFtwkW61whf8RwIuAImahpX/cZaneRFvU/lpOavVfMM HRoO6L+2fKwicO7oCmcv9CPI410lakoSLvr2qeaxJfb2/7v08K/dPwC5D73UBOHcPFsJsuUuV vYFCH7TUokd5HuXAKccPFbk6tgxaviX18wWqCO5nJgE4Mfac5DllzpYNH+hh/yvuCezJFRHVM PKmmIQgpiRIqdPi6TgKKuf+FAEAcFDjHzVLe828hZfss+PrDtA2YLcBIOzel7xhArULnNxLka KNFE+nauK7RVgOWXqyr1Goeoq9F7+yVlw7Z0FL1QOqLgAoOEDFZ/F+Rm+xtvasJ5Kf3PL0J2O nyRe6D7Ap6dP482hQkodT/2mahupmWpU3j+4wJ3WQ1Bwn8kv/xtgLKw3QzSf3Jv7U3LQjm4al rYvj7zxqmjdMx8MjG6KBtCYegBgDm2cJmaxgAh8Cnq//syqTrhnWBMt3FazxFB7brFBCGnyRh HRSTV7oR2a/a4CNNRnfN0OWT6qB8bGZFUyyjBLwy4pmlAu/LtsRVrypwHXu0f69gz2cu/Vv6P Vl7SFrzvVrZjlRpJh362Sjx8OUbUXH0ybhuWGmbvoBn1rT9QXdCSJWgdjJPIvF+DMiG96F1bx g21Mpohh0koHTkFeng3KEhvAR/nR1os6tvN6rzmo3vjEYQS06FMpWTgT0DQskTq1qXOAwpQ+x iMkWrLOrQe0lCHs7mTZJ8AcMCv/xoLAVZhi6DKHeP9O0QjlTP+eFiemZe4kZGasR3pawe6Y0c DJUg9nzru7jrgF2RHk1SuqGOjK8pKjQ4ZuhMGyPrsxeuHHfO3rj0r1qZms49QrdwXsWT4A1s6 rHtAE9imERwqwc= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks to Martin, the patch in > https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01873.html > allows customization when display-buffer-alist contains > (window-height . nil) This patch has been meanwhile applied on master. martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Oct 2021 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.163415088325291 (code B ref 51062); Wed, 13 Oct 2021 18:49:02 +0000 Received: (at 51062) by debbugs.gnu.org; 13 Oct 2021 18:48:03 +0000 Received: from localhost ([127.0.0.1]:33421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majII-0006Zr-NL for submit@debbugs.gnu.org; Wed, 13 Oct 2021 14:48:02 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:48395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majIG-0006Z2-W6 for 51062@debbugs.gnu.org; Wed, 13 Oct 2021 14:48:01 -0400 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6C614240006; Wed, 13 Oct 2021 18:47:53 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> Date: Wed, 13 Oct 2021 21:46:58 +0300 In-Reply-To: <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> (martin rudalics's message of "Wed, 13 Oct 2021 10:36:27 +0200") Message-ID: <871r4oahjx.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> There are two ways how window resizing is currently hard-coded: >> >> 1. As discussed in >> https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01627.html >> when temp-buffer-resize-mode is enabled, it's impossible >> to disable automatic window resizing of the Help buffer. >> >> Thanks to Martin, the patch in >> https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01873.html >> allows customization when display-buffer-alist contains >> (window-height . nil) > > That patch should help wherever 'temp-buffer-resize-mode' applies, not > just in a Help buffer. > > This patch has been meanwhile applied on master. Strange, when I tested the patch that you sent to emacs-devel, it worked correctly. But after you applied the patch on master, it doesn't work. I'm trying to debug why (window-height . nil) has no effect on Help buffers. >> 2. As discussed in bug#45688, such commands as vc-log > > Which command is 'vc-log'? I meant log-related vc-commands that use shrink-window-if-larger-than-buffer, i.e. all commands that use vc-log-internal-common. >> , vc-diff >> automatically resize the window, and the problem is that currently >> shrink-window-if-larger-than-buffer is used in these commands by default, >> but this behavior is hard-coded and can't be disabled by customization. >> A solution is to create a new hook like 'after-display-buffer-function' >> that by default will contain 'shrink-window-if-larger-than-buffer'. > > Wherever we currently use an idiom like > > (pop-to-buffer (current-buffer)) > (goto-char (point-min)) > (shrink-window-if-larger-than-buffer) > > we should use > > (pop-to-buffer > (current-buffer) > '(nil (window-height . shrink-window-if-larger-than-buffer))) > (goto-char (point-min)) > > instead. But if 'display-buffer' is not involved, there isn't much we > can do. Maybe something like 'display-buffer-same-window' _after_ > putting the buffer into the selected window, but this might not be 100% > compatible. Certainly not for Emacs 28. This is a good idea to try. But not sure how this is possible to use in vc-run-delayed that is called when the buffer was already displayed long ago. From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16342028034524 (code B ref 51062); Thu, 14 Oct 2021 09:14:02 +0000 Received: (at 51062) by debbugs.gnu.org; 14 Oct 2021 09:13:23 +0000 Received: from localhost ([127.0.0.1]:34640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mawnj-0001Au-BA for submit@debbugs.gnu.org; Thu, 14 Oct 2021 05:13:23 -0400 Received: from mout.gmx.net ([212.227.15.18]:60403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mawng-0001Ag-HS for 51062@debbugs.gnu.org; Thu, 14 Oct 2021 05:13:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1634202794; bh=4+K7MPe7MWtKEwQei4q0HcESRv/SQjtStF50/NHppBM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Ne8lDOMrGO9teKDeCAdi3KW7QSV7AaIwghSTmTpvm7K5jILyuooKXid/bfgkhnCHZ p9XWp1/pbHsSiBUbXPzongMKOlRbxxbZKOQAn9GSxFMB/RacvqU0vmz/EHseUkViHn ZYutcXFbOGSF3cAoJVrSHaXD42BgTPyJ0vGi1j48= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.92]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MCKBc-1mRZ840Kqw-009Sqy; Thu, 14 Oct 2021 11:13:14 +0200 References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> From: martin rudalics Message-ID: Date: Thu, 14 Oct 2021 11:13:13 +0200 MIME-Version: 1.0 In-Reply-To: <871r4oahjx.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:1imtEBhTKkJYqLQGjZIOglwr7sMzyL0RfI/YV64rOOyuoeUR0qk yd+7ZNa2HtIEsFZOY3fRdMCX3TIvg20k/6qVuZAZHJt3RKSSkfkXhZw/7AN1B63eOaLUmbf QRn0487+L95DPeiyCxcDGQnU1GTRtO3UyBp3DMmilQQC8qIFYQEcMPmiIqwVbRjfjiTxjT4 tQI4dMU+4WQOgYZqPnzYw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:tjxyU2F4LsI=:TNHy963evFBzZZd4n8rg59 zbPMpo2XYCPpNFWZxF8FjgSJiU2+8Q3xKUjZTBriTGizE6hV0wMI6HE8/gwAg7fZoJYqUNIIL yevJ316gWQ9Z2RQHJudsrfJBL9zq74hn95uxnGFuIZNz5q6izds4LYcNQpH5VBZ47Iyr7wdIF OMTu7T9mDT/0MtrTI/rH36CfFe1ACED+8EQyz+Pgnv/s6hR+qQuQQscpiEPOGZaGP2vLlIMm/ IncLtwJCprykLxEoNMAMkmOjh50z1VBX99KpQ49583XdSXtGAj/H7goYczhlb1QYmM0kiCyji Na4wBXDiwU1W9Th6dTFsIXKG8xsrWYfSOiZ6AUmEF1FQd9uBQEgAsFEq2zzOSNUbJgEpcsGGR wmpCxawRlNI7lCucviSXutdLq3I9/UNhgZSfF5MlSIjphmtk1KjqoF8oZzh/yGt/Y3fh3171g mM0618Z4RcVQwrVdT7vD11dIWVnoiV/UqXWidbrfktU+YHndMWbJeKDTUQhqDqWfUPuDwgcku itrWJOgF5wmkw3nNFHK1eKX75ur7m/ItJTb6cQxAaVDQA0mf7czReqBWntqlQIj6qVofilAMx T4aRdVEDf6qB185xaVx1/XcRV0ZKKI78QFQYt7Yv6VabsZO35FV7jUpw7GXGne9zkD11pPYMm wvZJEJPWe82Xwt616tDFYqGj1rx5deQyMKdEfKJ+vO0kst3PMXMwMMV2RJLl1xVHbkMeqN5Nc BWSb/rlSH/J0P56HSxAwgriDAqMo3WKuvyYEeOgUtugODdRC7ib1go23SVLabJplQHefOtBKL piWfe2rIuXiJz75Fpe/nuKl5rTjWWBv/h+ZGnRrGUQfFgTLeQM= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Strange, when I tested the patch that you sent to emacs-devel, > it worked correctly. But after you applied the patch on master, > it doesn't work. I'm trying to debug why (window-height . nil) > has no effect on Help buffers. Indeed. I probably tried to optimize it before pushing. Should be fixed now. >> Which command is 'vc-log'? > > I meant log-related vc-commands that use > shrink-window-if-larger-than-buffer, i.e. > all commands that use vc-log-internal-common. I see. >> But if 'display-buffer' is not involved, there isn't much we >> can do. Maybe something like 'display-buffer-same-window' _after_ >> putting the buffer into the selected window, but this might not be 100% >> compatible. Certainly not for Emacs 28. > > This is a good idea to try. But not sure how this is possible to use in > vc-run-delayed that is called when the buffer was already displayed long ago. The problem is rather that 'display-buffer' wasn't used in the first place to show the buffer. Two things we could try to cover buffers that are shown via 'set-window-buffer' are - Invent a new buffer-local variable, say 'inhibit-temp-buffer-resize' with the obvious meaning. - Invent a new window parameter 'inhibit-temp-buffer-resize' with the obvious meaning. martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.163422825319051 (code B ref 51062); Thu, 14 Oct 2021 16:18:02 +0000 Received: (at 51062) by debbugs.gnu.org; 14 Oct 2021 16:17:33 +0000 Received: from localhost ([127.0.0.1]:36930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb3QC-0004xD-SU for submit@debbugs.gnu.org; Thu, 14 Oct 2021 12:17:33 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:42829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb3Q8-0004wc-QD for 51062@debbugs.gnu.org; Thu, 14 Oct 2021 12:17:31 -0400 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D25A110000B; Thu, 14 Oct 2021 16:17:21 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> Date: Thu, 14 Oct 2021 19:01:19 +0300 In-Reply-To: (martin rudalics's message of "Thu, 14 Oct 2021 11:13:13 +0200") Message-ID: <87wnmfk40w.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Strange, when I tested the patch that you sent to emacs-devel, >> it worked correctly. But after you applied the patch on master, >> it doesn't work. I'm trying to debug why (window-height . nil) >> has no effect on Help buffers. > > Indeed. I probably tried to optimize it before pushing. Should be > fixed now. Thanks, I confirm it's working now. >>> But if 'display-buffer' is not involved, there isn't much we >>> can do. Maybe something like 'display-buffer-same-window' _after_ >>> putting the buffer into the selected window, but this might not be 100% >>> compatible. Certainly not for Emacs 28. >> >> This is a good idea to try. But not sure how this is possible to use in >> vc-run-delayed that is called when the buffer was already displayed long ago. > > The problem is rather that 'display-buffer' wasn't used in the first > place to show the buffer. Two things we could try to cover buffers that > are shown via 'set-window-buffer' are > > - Invent a new buffer-local variable, say 'inhibit-temp-buffer-resize' > with the obvious meaning. > > - Invent a new window parameter 'inhibit-temp-buffer-resize' with the > obvious meaning. Earlier I proposed to add a new hook whose default value contains shrink-window-if-larger-than-buffer, so it can easily be removed from the hook. From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 17:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.163423091623416 (code B ref 51062); Thu, 14 Oct 2021 17:02:01 +0000 Received: (at 51062) by debbugs.gnu.org; 14 Oct 2021 17:01:56 +0000 Received: from localhost ([127.0.0.1]:36974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb47A-00065c-Cw for submit@debbugs.gnu.org; Thu, 14 Oct 2021 13:01:56 -0400 Received: from mout.gmx.net ([212.227.15.15]:51939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb476-00065M-G2 for 51062@debbugs.gnu.org; Thu, 14 Oct 2021 13:01:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1634230904; bh=f7f2fnuzI7YqF4G2pwcclmie2Eq4S/goErk3oXvcUVI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=EOOReETQogd8hXfvtBy7cAkQsNcp0wMG1+zC/UU14oQEIb8dsdQlef8CHIL5jysm0 cPAp+aZayKw6+lpkZVbOHvihTF0828ljCzHBLhQNJoFDJrvq51THqP9vSj/ABJwWj7 4YyQtwjJQ2sX+/G/wNE02BRN8sfl4T5peMMU1t/s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.92]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N5GDv-1mlHOX2HqP-01196n; Thu, 14 Oct 2021 19:01:44 +0200 References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> From: martin rudalics Message-ID: Date: Thu, 14 Oct 2021 19:01:43 +0200 MIME-Version: 1.0 In-Reply-To: <87wnmfk40w.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:FFVgJQrM99thISbnMhd1IR0/18ucyQDuFZffEd26eXGSZNbq5zV 5ZOz14JIBi6OezSlSis7QGuS6VnjYEW9PLDQ3LfJnfqbA0pGM5x6bqFsd4TGCp2fpijiAU3 A+WCNcIjQ0UgZCYQe6oA+8BbF3LWIWriIAO7cvDU89i1iRO065EYIbO5BNpNPXN+tX3af5m zVFvrN6ky7DuNK5LVwpdA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:sqeEHtA7acA=:60X4X72cbs36Rn2BQ3DFAG dMhVkEa1e4UAQsz8qdGmcg4EUcG9Hy3+FTVY+9ovVzdji/v9bexgegurf2b2PiozYI/d7svvm UqOW3XvHpet/1pBgGLJqXopKlW3DQp0KSlFif2QPK/YKKh7LBmqT8AE9ZO8PtHgJ1HuhjpY1g KWxFVJbvfbBMVpciHO483w2zOQ2c+Gm1WLKtIqcjgCCoPZgaoJ4PJmvT6rhGfMFKxHQbhP8m/ MybdW85dAf01CKj+MWg0Tx0TyXj4eJbvbuTa92nv7te/fiXZvlf8u7AZ5kDXaoPx73oVw4K3W umSbWE7LMqPm5EgWc/AtpSgQY7KG9EXZGl8/68/PvEOL9cVitLXbCn/gVTb8ZwmwnOTFHkqR1 ugXG+G2AhVSINIMDwmagRtukqXWYCyI0Kv51a3nlfK5YwjCv525/dSk4tTW9cPnlErKN724RG yYyEqNzcCHJgWNmoXHlWfqF/FMsM5Sa/tmCejOp44XsnZhQ9uMoj8v8FlOGGLBCsvHQBqChU1 29fP3erts3wATvn40JD1/SF/gIDxvlj/O/LKBIOWWjaBtk0+zclCa5dLAFTtiYOcO4PcM4amE VGcJKZuMLnfdNNTPRTNY3yLaczIChJYtO25yDXkexVu9BBoi0G5YhGsuyXWqPOqpYMDV2uAn4 yHNILmo6Ud2xLBFYiHvba3kTzSNBcr1/sCtgqNmOs4Xd5/zpJNuiRJneL9e2ujkq3TrQg5yKb G5h16PvwjVburJm+1nXj7J8gEZneE4pQLfrKwoRJfpC/39FpeEFoo1vxoEQH3dCzxqSr0Da9i M7EqHjA2BdrfyI6MNjeY9aFQzxUXZD0LjHO1IAFUI48oHkj3bHYILMBz8xEs978XipiGbM2cu YeN89dkiRicF5kl2YHDd5DklHOiaYvO3ODvYQ6ELkjbHOywrfLSicGHPJRuTNPVprvqcOz2GJ P1MaJD2Dmj3WgTJbEIykGPQccumgUypLErF41+Lx6PY0Wi/PXszL2GBUZuxrytgzyOB2GXv/8 fQ4LRlUyp5HNVKGV0qE8jgnvuVGZmeiAcxNJPRbua/c3vvpbXZfGpQTCqL44DEbt0g/IAdgrB 2zWIAZkTRf9fJ0= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> The problem is rather that 'display-buffer' wasn't used in the first >> place to show the buffer. Two things we could try to cover buffers that >> are shown via 'set-window-buffer' are >> >> - Invent a new buffer-local variable, say 'inhibit-temp-buffer-resize' >> with the obvious meaning. >> >> - Invent a new window parameter 'inhibit-temp-buffer-resize' with the >> obvious meaning. > > Earlier I proposed to add a new hook whose default value contains > shrink-window-if-larger-than-buffer, so it can easily be removed from the hook. What was that hook called? I think we first have to decide whether we want to inhibit such shrinks and fits for any display operation or only those administrated by 'display-buffer'. Then we'd either install that inhibiting thing via 'window--display-buffer' (where we work on alist so we can decide who overrides whom) or directly in 'fit-window-to-buffer' (where we cannot discriminate any more whether an application very urgently wants to impose its behavior and we always rely on the user's setting). martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.163423174124797 (code B ref 51062); Thu, 14 Oct 2021 17:16:02 +0000 Received: (at 51062) by debbugs.gnu.org; 14 Oct 2021 17:15:41 +0000 Received: from localhost ([127.0.0.1]:37000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb4KT-0006Rs-4G for submit@debbugs.gnu.org; Thu, 14 Oct 2021 13:15:41 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:50347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb4KP-0006Rb-Uy for 51062@debbugs.gnu.org; Thu, 14 Oct 2021 13:15:40 -0400 Received: (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id EE7E620005; Thu, 14 Oct 2021 17:15:30 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> Date: Thu, 14 Oct 2021 20:14:58 +0300 In-Reply-To: (martin rudalics's message of "Thu, 14 Oct 2021 19:01:43 +0200") Message-ID: <87a6jbil4d.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> The problem is rather that 'display-buffer' wasn't used in the first >>> place to show the buffer. Two things we could try to cover buffers that >>> are shown via 'set-window-buffer' are >>> >>> - Invent a new buffer-local variable, say 'inhibit-temp-buffer-resize' >>> with the obvious meaning. >>> >>> - Invent a new window parameter 'inhibit-temp-buffer-resize' with the >>> obvious meaning. >> >> Earlier I proposed to add a new hook whose default value contains >> shrink-window-if-larger-than-buffer, so it can easily be removed from the hook. > > What was that hook called? I think we first have to decide whether we > want to inhibit such shrinks and fits for any display operation or only > those administrated by 'display-buffer'. Then we'd either install that > inhibiting thing via 'window--display-buffer' (where we work on alist so > we can decide who overrides whom) or directly in 'fit-window-to-buffer' > (where we cannot discriminate any more whether an application very > urgently wants to impose its behavior and we always rely on the user's > setting). This hook was called 'after-display-buffer-function' in https://debbugs.gnu.org/45688#137 From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.163423365528010 (code B ref 51062); Thu, 14 Oct 2021 17:48:02 +0000 Received: (at 51062) by debbugs.gnu.org; 14 Oct 2021 17:47:35 +0000 Received: from localhost ([127.0.0.1]:37034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb4pL-0007Hh-FD for submit@debbugs.gnu.org; Thu, 14 Oct 2021 13:47:35 -0400 Received: from mout.gmx.net ([212.227.17.20]:38035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb4pK-0007Gu-24 for 51062@debbugs.gnu.org; Thu, 14 Oct 2021 13:47:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1634233647; bh=/B6i0dmOq7QYcAtwgQECAAR460xphA9b7rnM1jxyE+w=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=hzydqY/QFQDXSChmVKM6eFPFAjfDRytnI9TNzA3hrDJj8jAd67Xc43FOfjm5SeEbm Ei9L6dsL3LauzeFgIMSnCbBFUhkKOjwycGueIXYff8ig9EozglC/uN5hrYSrGafp7j c6yfVKowlJKC7xdOWY4/Z05flPEu0n9MjH70ah00= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.92]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MA7GM-1mQaQP2B8U-00BbFv; Thu, 14 Oct 2021 19:47:27 +0200 References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> From: martin rudalics Message-ID: Date: Thu, 14 Oct 2021 19:47:26 +0200 MIME-Version: 1.0 In-Reply-To: <87a6jbil4d.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:N/xJ81MZZpuOZDj90RYgKdTVBM40kOYPVUrK7wCH/OsTNCLdxlm 6b9XH+WQAtUkTzT7j75eqEHFOQ+AiRtKC/IBsou0DnRMozgwiY1rR+bxE3qCht3nz49mxJc iFDeV9oME5m3O+ZFl6+HbRyrSCq6FiywYiPJ4o4fVDnJWSL9Nz5xCLp5rb7hY8xxET/NmLi bfRjh0AT0VUWB5XPrQGVQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7sGYmJ0Zl7s=:CAV8KQ1AYhL5E3R1a8S6Dl LcAUIUUWG1OO8cLt53LqnGhZQ2KAADLBoHng+sKZxClpE5tDtIiLdA1NrqGL7MGCo+Qirx9qs j7sD1He/i2TStGcBj4YxZS72lb8HJFnkjY/L0CpiE4YNfoE72nwH0Am92KpQ10L4rM+hEqIe1 Q5mPJZlC3p54uEmt8nC6PQM6UM48BnF/1fKZJAiia49ERGf0WwUREZsd57NKbznm7JlRJVCLq 1qdJ85bgqb5Orr023tJebeLphbKsbsygSa3w3GIAyKKeGjGzPoIxzYp2a2o/1OD48rCrBjoCw A5wRS5OV/lCf2aY3MZqiGK5L2EVszx9OJM1XmClkbvoJh2Uk8Rvwx5hQJfLM9YXJwrGiHQcdK u9QFO9WVUo5EfVfHAsjLXNVgTFKovqLs5zoafbWoZ3lfI9lzAoRtEcFShdd5iRszEYmUnHkAb 73exDoYcpw0PJzSpa3d8ob0AhKM74eCqs39BtJg6WXUi8BPaJowa4bw0/2tWk0qnt8s+9v75T kmdZ7h8ibPUgDM5okwpORdyRJqp8OuAAz1OIJv4uuNvI1AU0Z+zx08+FNZNfo8crDm7nyeJiH EniK0hAnjKLEOl9IuOLRx+5ohlEwQJwBXwbH5/L5JJ2yWWZxXZsKKmZYuFVEhUFsfhEAs4Wg1 FrF6a9ySlnl5g1SBDsTbf4PGNlabVDrsvf7eeXEHzLmzIRFYfxz6xlI/GXouIlpisRv+Kzjvv 6ltXVOa91ZqwCBSBR/m8At0QmNcIn/d6k/MOpkjbUdvG0PuOYus2cNxL3EraGNwHaavoJtcR8 VX4U/BuA6Vk0Y5GXE31gK0eq0GekRKOHLw12dzB3qBspg39RPJgrf8+FsbX9xqdmyO+baZ3Hj nyZX0gnAynCFvfDIPRwE0QKuogGY5BtUGdSfGr2azXJkjKxGyqj8PAf08k3ltnSmA1Zvny8FT rRlVWzPaR5pb2LOupgyd1FAlMYSd4+vHxDggYYDtq3eiF4WGMcKLo9+dEftbC55UjRdVIOY22 3B4A9M3BulNrB1dIOziAH4AttENLm3WOcFwHO63vVnPkozI9zEj088V0XKOazodizepj2oCHD bGy4tf99/OGGK4= X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > This hook was called 'after-display-buffer-function' in > https://debbugs.gnu.org/45688#137 But what would that accomplish when an application does (setq window (display-buffer foo)) [...] (shrink-window-if-larger-than-buffer window) The 'shrink-window-if-larger-than-buffer' can be inhibited only if the hook sets something for FOO or WINDOW that inhibits shrinking it. And that can be easily accomplished by a 'window-height' alist entry. OTOH with (setq window (split-window)) [...] (shrink-window-if-larger-than-buffer window) your hook (and the alist entry) cannot inhibit anything. martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16345740925214 (code B ref 51062); Mon, 18 Oct 2021 16:22:02 +0000 Received: (at 51062) by debbugs.gnu.org; 18 Oct 2021 16:21:32 +0000 Received: from localhost ([127.0.0.1]:48354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcVOG-0001M1-BB for submit@debbugs.gnu.org; Mon, 18 Oct 2021 12:21:32 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcVOE-0001Lj-MG; Mon, 18 Oct 2021 12:21:31 -0400 Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id EF10D1C0013; Mon, 18 Oct 2021 16:21:23 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> Date: Mon, 18 Oct 2021 19:10:50 +0300 In-Reply-To: <87a6jbil4d.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 14 Oct 2021 20:14:58 +0300") Message-ID: <87o87mmjth.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) forcemerge 36859 51062 stop >> What was that hook called? > > This hook was called 'after-display-buffer-function' in > https://debbugs.gnu.org/45688#137 Actually, the right name was 'vc-post-process-functions' proposed in bug#36859 (merged). From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.163457906521660 (code B ref 51062); Mon, 18 Oct 2021 17:45:02 +0000 Received: (at 51062) by debbugs.gnu.org; 18 Oct 2021 17:44:25 +0000 Received: from localhost ([127.0.0.1]:48525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcWgT-0005dI-D4 for submit@debbugs.gnu.org; Mon, 18 Oct 2021 13:44:25 -0400 Received: from mout.gmx.net ([212.227.15.19]:59651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcWgQ-0005d3-Pa for 51062@debbugs.gnu.org; Mon, 18 Oct 2021 13:44:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1634579056; bh=Uxvfw4sOqHCoSTRn208jOZuBmIdc0+zYkheY1Exao6g=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Lgo2AqDxNw5ddJjvY54RLNA019BZdJRKCGRSuXlVZtG0EbALMnVZQMArfsjFiuYw6 HVhA80sKFTRJt8G0cScW1xKbc/9ip6Afzxdh9yuJNfTAswehmnqJs+CzqKvkXvk/xm hiAnKQQT8212NaOjCe1+Q2MfRYLxtM5RzruK3JD0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.39]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6Db0-1meiXQ2LSC-006gTZ; Mon, 18 Oct 2021 19:44:16 +0200 References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> From: martin rudalics Message-ID: <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> Date: Mon, 18 Oct 2021 19:44:15 +0200 MIME-Version: 1.0 In-Reply-To: <87o87mmjth.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:jBZbpUEMx3w9Jag3Wsad3LRYi8/G+wrxNaryHIsXOH3hQlIKNCh hRUap2vdWxRJnZVl2D5O7EX25TaKc/FLZZ42+uRs35m6mhJRkRyGYuDHD3juUX/a9ePdb6M 1Cy6oUYZalcv8vpBK3efwL8UaShnYIHiz5BVEZjrO70VNiSKJ3MP280jzGHsjl8+Dstaacl r+LKhKnwW46OqHGxLbgcA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:AbXFrHshbKI=:ymWJvWho1wH5kn/Y1gP2sl w+RsU3lgNzZ2umjWZBVFiZP15ekEaflX2QiRZWLPi9bSN+h2gAtcPGOyWLdogeXAQkL1RGPH/ 7+LkvDS30cTvbgbGiQ9754E+F04bJpjzEW3jIjbLairo/sgttamUtsbaz+2brucRkRub3/KSx oeGGUBa2gWU2kk6GOw2UwoR3u5o1S+yAGZSOYSxPrzQFSw5b8SbgGV6HEwj0o1IkoSqkdLxZ5 odTp9KQpI5Y6cOtIRexcuYq6aT/Wtb7hLb7I4bGWowFd3hVTzF6/+oAYals99m6Bu+TDw1oOD FwKYSD3RMo8YHzqUHESpeypB12eQD0xZeWEj3P6GW0r5VeV6He8UhqGTrSTykVi68eMZn9HpX 6M/5DDL9T3854EVgy0HjcXclFv85gl0Nr+TRhl4tTTocW/TMY9I1cYVoJ0gUBtF23ezQHnGOl +oFnqqfntX7eJYBijkRlyQ5yRhtpFPNajRPBA8vh9ZuiojNmqwyz8kIIG4jl3LDGrrbI6V65q oGtqrk9lroqYaxCkmXD41pIia58TurIk+Mp9u3k3vZOSLEkx6nMYPWJjVHdWPnLMcNfSLR1ji EMz0MYgtWmfV4S3TxtIBKAGDP2oC8cXT4mbjA9HzQ8oxCn2wpAWANwG5HiTwc5voWBcd4eXA9 dtSW+fwIx0mEKVcwR+iGfpzFT9refQHh+ATAU7KLviyMDt+1BO8eOfIiowSXElKahneUmPPwK cE3/UpaEab0sQxqJjChfU9wVevQBi/vr40tDbrNaHaDU1vtzbUSPiQ+6HI4+rkchPPWsYis6Q LO4PLpxBFKJtPNtMzEYKYZmc209ICTBm8a7Z344vPUFJC/9Sn3nPLRH2egHdoQWIzSjzg2pyG ei0sZg+ZO91J2CXaTMBG46JMQqdHRwhyiZsxtA7CWWWmPKv4bxkqMUv5yxMWWe+gC75CL/loI tU6nHqiO84frdXbVhlu0hOft11Oaz2HkLhmY4x0DmKwms58uFwdQbXBhwbjxIG/HCeRSwh0Z/ gWrSV83/hGNHBSAAQceP3tLiwWgskxgJDRXILmMazMg3c93d8F4LJrjWO42EqCO26oTHD/dSK x3CvjF7EBwPUrc= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Actually, the right name was 'vc-post-process-functions' > proposed in bug#36859 (merged). You mean to run 'shrink-window-if-larger-than-buffer' from that hook unless the user removed it? martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 07:14:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16346276131943 (code B ref 51062); Tue, 19 Oct 2021 07:14:03 +0000 Received: (at 51062) by debbugs.gnu.org; 19 Oct 2021 07:13:33 +0000 Received: from localhost ([127.0.0.1]:49239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcjJU-0000VG-V3 for submit@debbugs.gnu.org; Tue, 19 Oct 2021 03:13:33 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcjJQ-0000Uk-JY for 51062@debbugs.gnu.org; Tue, 19 Oct 2021 03:13:29 -0400 Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 401B44000D; Tue, 19 Oct 2021 07:13:20 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> Date: Tue, 19 Oct 2021 09:54:09 +0300 In-Reply-To: <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> (martin rudalics's message of "Mon, 18 Oct 2021 19:44:15 +0200") Message-ID: <87fssxldzy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Actually, the right name was 'vc-post-process-functions' >> proposed in bug#36859 (merged). > > You mean to run 'shrink-window-if-larger-than-buffer' from that hook > unless the user removed it? Yep. From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Dec 2021 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16407991461057 (code B ref 51062); Wed, 29 Dec 2021 17:33:02 +0000 Received: (at 51062) by debbugs.gnu.org; 29 Dec 2021 17:32:26 +0000 Received: from localhost ([127.0.0.1]:50236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2coM-0000Gy-AV for submit@debbugs.gnu.org; Wed, 29 Dec 2021 12:32:26 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2coK-0000GX-6s; Wed, 29 Dec 2021 12:32:25 -0500 Received: (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A39BA2000A; Wed, 29 Dec 2021 17:32:15 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> Date: Wed, 29 Dec 2021 19:27:07 +0200 In-Reply-To: <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> (martin rudalics's message of "Mon, 18 Oct 2021 19:44:15 +0200") Message-ID: <86czlf1fv8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) forcemerge 51062 52855 stop >> Actually, the right name was 'vc-post-process-functions' >> proposed in bug#36859 (merged). > > You mean to run 'shrink-window-if-larger-than-buffer' from that hook > unless the user removed it? The problem is that the argument of this function should be a buffer, not a window as in 'shrink-window-if-larger-than-buffer'. This is why bug#52855 proposed to add a new function shrink-buffer-if-larger-than-buffer But not sure if this should be added to window.el, or better to leave in vc.el with the name vc-shrink-buffer? From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: [External] : bug#51062: Customizable window resizing Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Dec 2021 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov , martin rudalics Cc: "51062@debbugs.gnu.org" <51062@debbugs.gnu.org> Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.164080516429650 (code B ref 51062); Wed, 29 Dec 2021 19:13:02 +0000 Received: (at 51062) by debbugs.gnu.org; 29 Dec 2021 19:12:44 +0000 Received: from localhost ([127.0.0.1]:50386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2eNN-0007i5-Iq for submit@debbugs.gnu.org; Wed, 29 Dec 2021 14:12:44 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:53140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2eNL-0007hx-29 for 51062@debbugs.gnu.org; Wed, 29 Dec 2021 14:12:40 -0500 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BTFb2v4028964; Wed, 29 Dec 2021 19:12:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=bX9nu+AGRgmy+Ovp1EaZXIe43Uu7OVFp4BnZya+76eY=; b=PoqEaPERfk6owytW69z5J4Ot2OpTFFAtlXuDLRD2bJ6hrSaotWyaTm891z3zsN7yCBt8 TSclIPfoJMO0YeJsFLR43nqM0Kh9ROIicjqoSRWJGqP9ZwxRvtHAVnQBBWbwr2QigfnK 8r4bwpLMXGkyoLGNb+tbtTTsTFry1SxD3r8n7F5UmMgeXTbstjg7VCLPz2ROnfdGkRqc s7no3AM6VyxxJZyZKtBRRlZJ5VoqQ3GFA8Deyr4QxqrtSd1xrjzLZhd4fhau0s2/88nf 6jjHuRxYUPj7MDsH6qYLMts7ELvB3FGUk7ZSB6a14Yf7qEzW2uXqmRhznPF+uMhmSHmd 0g== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3d7ggx3gps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Dec 2021 19:12:36 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BTJ6tlY173694; Wed, 29 Dec 2021 19:12:35 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by userp3020.oracle.com with ESMTP id 3d5vrq4h0r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Dec 2021 19:12:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFHz5jg/7oMnmQ9XNZMW3Jno4zNX3VmiAAwgYqBzktEmrTRcDXhsN9+kWkmPpoE+gPvDsi5n23lY/kOC4b3sJwRzeB/qsQ01FEo9x0vTOFs7XE5boCYdinzs5EuYq+8/o3brrWBvJmXKXECuN5J5ACcCcjJT+HnOVcn060C4R8rH21AQV+F+FInyyD2+s0kU51Q1EwFPjPvsVytdbZCgTQY6PPJrd9N7n4s51xjT+WF1dnhpbYgNEfBspYyYBh0UfBFOUfwD05ujUM8kyX/iSw8YwClWdEVJuX7FnPei2XSp1OuTr6qDtzegmwjJlNVsJk1RWAMLpdoeDW9VOBR1ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bX9nu+AGRgmy+Ovp1EaZXIe43Uu7OVFp4BnZya+76eY=; b=dXDPgojM0Fo0t0RmdDP2pk50drquwVTrAXkXjTS6QhuUsCMonFFIIxAeKATbysmC784+dk2BChXGz0RiURicbaxKJxjHcIqAHQcWFk4V3wnG7718vCCcZhzoR05hfabpR/wH3iaCRVmNTEeesXXcW0q9GgYAWCgyNIGi6rts1cr94rp6a3g+FoLkhM4/9/Sqt0zE74H1hq3FeJRIC73r0kbAI4N2FjLtW/b5/G6v/qLkVfoEYPuM+rBuzqCg7oHGoN9Aa/VDdlo7RKyY5aoknmMl12NvfPlbVOXumUW+VRywkOXye32gqI8sIIb0+9ldq7NZmxvHPwMsr0P3EGHU2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bX9nu+AGRgmy+Ovp1EaZXIe43Uu7OVFp4BnZya+76eY=; b=mv+Q9QC5b14eiFzPdYYd2zfw0B5SOF5dZd5/7HkWSgJg/d0zh956d7OCb3E5cVL1sNnBfGuZRqt2ngxBt7Za4Bh1geVe38VMGi+Q5I6ID+y1oFikvvo3dfdUki3yiBH1w5j9Wl98cI4UaqtNvhmLaEd3uKiOZMEGkBGCS+4JShg= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3671.namprd10.prod.outlook.com (2603:10b6:a03:11c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.22; Wed, 29 Dec 2021 19:12:32 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%7]) with mapi id 15.20.4844.014; Wed, 29 Dec 2021 19:12:32 +0000 From: Drew Adams Thread-Topic: [External] : bug#51062: Customizable window resizing Thread-Index: AQHX/NolNli7q+zYMUq5gp7w0qOrZqxJ1LSQ Date: Wed, 29 Dec 2021 19:12:32 +0000 Message-ID: References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> <86czlf1fv8.fsf@mail.linkov.net> In-Reply-To: <86czlf1fv8.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9339a8cf-4a27-495c-3ef9-08d9caff2a72 x-ms-traffictypediagnostic: BYAPR10MB3671:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nEZVZ1YusfnRR4qMsRz8HZqshb0OfuvDdptLKYEEDJSssErfVFWIGBNOfKUtCxZ6M3O6dT7oaVjsJm9K8/T0AymjKzc2nT+1P2XrUpB1TSMVeIm8glwz9P3l/kumcZbTRDLfjkn2Ysq3Oo0r2II+YrruWbGH8Xmub0ZR/SChde8WhwqpGBD9XYgOEIVmtq3RLfbl+ARB6tHDVLMTzWRD/yaskKOt1mT3W3vyh8xLJwSew8a8UlkvIEIByvjZYDzwyC7Z+md6PJbnJoDSgbWvwe+4jVgCd3AWw/L5NLVRjPUY5J9uAnvNX93rqtLaZCab+9QD1B89AHyGjIJDGWhwU6Z8IW0yjVpySTuu+85INj5MCBNO9Wj161hsA67VG37igtTlbHZeS4Fe3GpCF9iqrIM/+1qjJ5saLc8MP7Viih6kLIfck3tX+zbahzVQbDsrA/5NQHZmjN2xAcYSNBs4jk6Gtp73McsBBUgtQcaC6ifafuCI2cOM1mKhOkDyYFGpQrZ1BaIDJZjyWzftvxjPFUpemNt8pB5f2rhdJk3/mCvHITFE/MWyrP0LI/bHDzgw9uVUUGMBegeejHefFuIJBrUFdWiGC11N0TnBrNwGZscc44AOIXXlAiOEBkdZbUGSF+yWTAMXCMWROCI+cGLavA8g236uDr7d4NLGY7aUJ+Y5f5dYcN6UrAbYSigcBz7IMEHxGXYNIABWQec09tBYUA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(110136005)(52536014)(86362001)(76116006)(2906002)(71200400001)(316002)(4744005)(5660300002)(122000001)(38070700005)(33656002)(8676002)(4326008)(7696005)(66946007)(508600001)(55016003)(64756008)(66556008)(66476007)(66446008)(26005)(9686003)(6506007)(186003)(38100700002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: XyHXLnKbFPU77b2kx7PpEjR+ZRYjxcN7ckZxEg6AQYvtL1iUPSTyuIkkLRlWIK41nKS7UFThre1Mt8rqnZ0cOeH8rQFkYyX9+GUjwp9kriK/322oMqArxhUayxiz+Nr0aFdqbX9qABnkVFqBK7/FYf7QYFvjIKZKwwiaXAjgFRV/q30uvzVsXpM+zyg9g84I0h7f1saEceQe88Y1C/4LeSJRxYra7yOGxTkfSvpoYKCiV3AsSd1tMPeO8Eqv+aJJbOvylNSjcDJ1K43Uifnsb7l1y6mOIjbNCztNN+U7rL9SReQBU/IyO4TnzvEhDc4LKxf0qatOCoDqDUmvLCYQoMk1ZxQNK0XmIRGTJj+OedKLgvJ+Exi8J/LfcRlCDOEt3OsC+M1+vmH2S1pmRFSOkN2qcvcOyztl24ZZQhEUL7RJ3VvraGkGpWoAngDzw1MHwQp3ADWje3IPVgo0GAUKASkdXuMi0mQNTNw23vfOZ0H6IEeUbYu+gllLe4sUNxTnZjzNd8uGYEARoB4kuFgoN33NZ/MaJSgPsgDbOnCDSpQabTxFWt5XuU5HG4FowxRxdV93yeuRdEoaG2WkaVjrZCtHqp+9MzR6Q3IxgWze1v0n0kVhs9+Z0YrGNepVZGQlArJs+YgiDTASfgv/VTvMg9A2lsWMQI1q8wceLPFYk5cAmxbOMgRLG0jQtqEQAqoAq0DuOl1PE+ehmQria7RZ+eXPZ1Y3TCsMZgQZCBnbKsQKJOH66gXznqVKH7iP459RwwHrTsroywvJC57zCGnRyWa/si7SrcZ38VfJDw17T3QMVUAzgE6drBFzjFURK1+EW7fgZSlg/T4AquGqIaXxiFtkyIQgkoZvQMjD6ogSbARs3HbdMhDJSkEKj/sng+o2ASblUDT1lz6plq0P8ySGQKvw8tUHbiPrUfjIat1bKQwD5Z0NFTZuDsVkheL9WCgMnfcdlVmcjlYqlthUmUW87v9bR8pAwyssorqsHq7OCrwZedMfGrrD/n5FhR5G3kuvfCsxNHdyAvz2nj4/GqvNo8Q+v12poPsu3DlqoJ9+/IOo27s3mv97oCBxgZ249o+ON/h3MDuI5rgD745etSBsT38s3qHMDhQZyPfGAf/mnAGcjXnNnyLSUDA3JhxvUUJnEuWSatX9Hsx1IVyDZouSK+kI6n+ZFd5Yx4g2V8VEJePsjSsRRgvSDZq6ehcQJxNhL1KjJVSciWSPAMuzD1iGczPqYIVYMNQZFSxo7qlQI9bfZ9VFvGm3eTJVY3kxJvYr5cOb9G+sQHazdRboCdEtZyjRsS/dQlQeTEpGD1GnThr/ZJ0F2QwBiRYQLxbcDO6voKgIG6dkQhBpsQdX+CFFIRjv4RnjYYn9pvY/BwXi6kaaVntLfgQBaUWkXbF5G0vIUY6GvVFrtN0so9JT+rOA9kBBzzB4YecbkdKMnnTFxfIAgr2gSN8Q/Dgr4Rwqldyj3LeW5rL8hxaxZvdx5BRnorDkRGLKeIlb2lmZytqTGFORZ1maHk1nRrkmH0/jdVtXiEjwJ1JLPPvCg1USLVG4skd8TvtqfaWPKBm9uMekLdpTpMgB2woV32nFSApnTVTPgPtepXeLMnqKEUYHlEe+vw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9339a8cf-4a27-495c-3ef9-08d9caff2a72 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 19:12:32.6924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mFO81zj1bB2osmzQgCfOkWGUTu8JLKL5IP3pfGt2x1ZXCbRK4fopgAimz5tw8phgKO+L3euXCKPpY+WvEGP8MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3671 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10212 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=868 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112290103 X-Proofpoint-GUID: h9to2183GP1HTnE44_wTgyDGqUsie-hV X-Proofpoint-ORIG-GUID: h9to2183GP1HTnE44_wTgyDGqUsie-hV X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The problem is that the argument of this function should be a buffer, > not a window as in 'shrink-window-if-larger-than-buffer'. > This is why bug#52855 proposed to add a new function >=20 > shrink-buffer-if-larger-than-buffer Apologies for not following this thread in detail. But is this really about shrinking a _buffer_? What does that even mean? Same question for `vc-shrink-buffer', I guess. (I don't see that function in Emacs 27.2. If it isn't in an Emacs release, and if it's not about shrinking a buffer, then please consider renaming it.) From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Dec 2021 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16409419448524 (code B ref 51062); Fri, 31 Dec 2021 09:13:02 +0000 Received: (at 51062) by debbugs.gnu.org; 31 Dec 2021 09:12:24 +0000 Received: from localhost ([127.0.0.1]:55064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3DxY-0002DQ-1c for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:12:24 -0500 Received: from mout.gmx.net ([212.227.17.20]:56777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3DxX-0002DE-3o for 51062@debbugs.gnu.org; Fri, 31 Dec 2021 04:12:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640941936; bh=CTaWm6Tg99EiBPY3xpgsITiTgkHmTSrEdij6KEtvMes=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=l4yY42KfBJy8DS/QHDwi8HcK/1cIJUmSPBk2qq1PssXNju1DEHTcJ6zvQQGSgkyJO +AhkxdWhwcXFX6y6io9EPkvez7DNrDtMxRx+zVKEyCOQRqeixDxJxhH5bUjxG7xXpA dSzaRbD2da/zVqemazYkbRYcbTt4QBADb8r+Ee3k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([46.125.249.79]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAONX-1n9Zk33Enj-00Bx2F; Fri, 31 Dec 2021 10:12:16 +0100 References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> <86czlf1fv8.fsf@mail.linkov.net> From: martin rudalics Message-ID: <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> Date: Fri, 31 Dec 2021 10:12:16 +0100 MIME-Version: 1.0 In-Reply-To: <86czlf1fv8.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:1aGAPlYH+cL81zOwINpYbbeG3UnkAKqOealZ0iLaXRDlgX/uYVk CYnGI/ZdN/nfoDcIHAiWd7aeWf+RRN5eK0Z8zzPRAoVLeLzEGahQLtHoLIw6+WtkZ6kd0Uu XxdY2o+6li2talWWW3pBgH3njkkM0RKj70HpMI5YvVA/O28hQK1oWfT0Mbm1Cps/EEDD1ea QdtxihLURw9AsA7LVj+Ag== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UoO7uOqL/Yc=:Rm4K1z2AS0F9gPm5AhBavk yctn88Hc8d7OXWrDnMgclT1QuiGOLXNVQu7clcqdo07KErAtTuKTkskxfyLl3elta+TZeK74P YJHuFsjNPSjpKfHuSQOvxooaUl0w9MYHRui0QuqbqgZkRnO1e6XbU+EhkDwce2favC/ydt+a8 fMuOjjXBxXjhfcVGyFOAP2Ul5U5xPeXmNQpHWGJSsNndcKzAv7VAS/1DsDUY8hd0X7oKTtEd6 M22bXSecEs+uDdOXIxBy/WOet3X0ywrizRE6YIROpeb9MbV4tyZVuoqECpPtvqYetq6bxAOhI z13sul3fhbc0FAMThPjZ6YGGPAqWWoneQp/4viClwXlv6aDwwcx7Y2DTnh+jQeqyyUrEoxUNx 8AXhVzPlLdQzqSGXNCTKH+D6wJUV+mhHglDTOeqR8f0JjPUg49F2LUGvbKr2B91PZVLd0X9DX KETPic2QHFbK+HNxO5ZZfREYI0SAx6/BXvgI/EaWlTOjWMI+c0JTM3pRW9Cw+IgYP/voQ2Gie O395T/hKbKCy4DqqjK8p6HUM0+sC63JtTvfvpgwMMOPTtAbzaafFCGgIDthNsknmcDEsTCK8d 7SHOoZOWRuMYQSnF9V+TCbsAEYhlRQiiBDAo8zRnzPEQ1Jh2Fa+1sqSVknsCUAKlFtk5SkpVX tz4+LDH2IoRsSV0YgDInRjypNuyNlD9g3sOCQdumbAAjMdJyqMgP2dxjY5uRTw0aurwLzz3JU T2uvhhswOx8Ivv8DgbuBjEsFSvfNOP905LJIw7UMrFXso5ziArLU3QVZ6Qa+g/e6tSW1DlFGU kQ5zHcbGtgQjjK9J/OgDLuOecfXrfxoXelZgzg/Rz+wfL8TqLTasg3eTgGQPQwBgTOzHYpbS0 GVok6kcKFZBUoGh7KD36Bp+S3+7TUwLbpkdpBgEmwtQS2XbtFz14MqSAdTiG9LjraAdjJRuQy CJM/ie7QOUhde/jkThgLlhiX/PhXeWnCFGP/68ef/Eew3KPOUEM47JJgn0ClE1vbeIv9EcV8N 8d9nctUab5lMwI4s4wBtn1AjnVBNnJqE+y74rD6YbIPoVetL4EXyhGs8xWw7a2k9zcwcvHnKY z8ZqWIlNyT3h+M= X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Actually, the right name was 'vc-post-process-functions' >>> proposed in bug#36859 (merged). >> >> You mean to run 'shrink-window-if-larger-than-buffer' from that hook >> unless the user removed it? > > The problem is that the argument of this function should be a buffer, > not a window as in 'shrink-window-if-larger-than-buffer'. > This is why bug#52855 proposed to add a new function > > shrink-buffer-if-larger-than-buffer > > But not sure if this should be added to window.el, > or better to leave in vc.el with the name vc-shrink-buffer? "shrink-buffer-if-larger-than-buffer"? Maybe this should become 'shrink-buffer-window-if-larger-than-buffer' then. With the usual problem what to do when there are two windows showing that buffer. martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: [External] : bug#51062: Customizable window resizing Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Dec 2021 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics , Juri Linkov Cc: "51062@debbugs.gnu.org" <51062@debbugs.gnu.org> Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.164096612012074 (code B ref 51062); Fri, 31 Dec 2021 15:56:01 +0000 Received: (at 51062) by debbugs.gnu.org; 31 Dec 2021 15:55:20 +0000 Received: from localhost ([127.0.0.1]:57323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3KFT-00038g-Lc for submit@debbugs.gnu.org; Fri, 31 Dec 2021 10:55:19 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:12460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3KFR-00038Y-QE for 51062@debbugs.gnu.org; Fri, 31 Dec 2021 10:55:18 -0500 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BVDw1Pi009978; Fri, 31 Dec 2021 15:55:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=Qe1w+lLV4FjT4ULlRVzcqB1D+0Q42CRJP4jJWi5rODk=; b=tPDERc4ojx6sImP6eoQ63p7f4WltfZO1juF+jTneBWSDdtzHESwYyrHv+D+D7ZZ3Xjhk gea5bcSfmXgG8+p1EO4gbJ+1xr4RBWNJ57AFtb2xFQ6SzwRBWgH3gNfmXi0LnJbxxKKo eSF4zQ0bTb+kEcDWsGfTKdeFCRe+IWFHxAR7hQqdJH4mo5CPhOajxQCQexIfrbUvhDa0 7gU2cM0mDubdYZVOw41oFrrsO46T2nfQ7IEq8ETTVbwrt/Anzy4OYtI6ZKnEXdFvdG1D MOMSg1NvJV3ShyJamrjqZ/EgkTy4nssfEEm9XgK7O6BVAGsVbU8RahfhXoCiYsON6O+z 4A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3d9f669grf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Dec 2021 15:55:16 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BVFpj2K181832; Fri, 31 Dec 2021 15:55:15 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by userp3030.oracle.com with ESMTP id 3d5re1w640-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Dec 2021 15:55:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SAbbcmH4lRiiN9xb5IVCK7WBBYp+7REoA7sBZ1u5sDYD+zdyoNQDZZe5wVld4FjkC+PjRJO7/H2KX7249j7FKDKFp4gyaJNQVqEto4m3+GIcGbrG9AzGDkcnBEBzWuaKBTbbsTL4frN7Vi1DNtfGi4llDNRpl11Xc7tC9IqPj9rqPCYwjUBbWQv5IGCClIAdt08+VqyJ+L3LP/IYiJpvrUugq6r0Hup34JU7UHZyOgPgcipCVzggpw3QMmq/dgYxWRwwBbXlJGQBY9IiWFgKv0iDRpQxmUMFwLdM8y4K2IkYiILCCbdqGUp3gvTOUYukxSeP8+EqJl/AscSrPFMtfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qe1w+lLV4FjT4ULlRVzcqB1D+0Q42CRJP4jJWi5rODk=; b=dFKYIq2z4xqxXXPVAErt2ARURR+3s2xcVpOvYVfU3S0i/XeKaz0zqDL7cKUNeUcwsQ4c7S6zNbtdW8RbqtjYtaI1dUnHBSbTYsowx9T5OMU+FWTdl0Hqab1uCU5NQzPD5fz5VaNyZUb24nHSdm5lQnyQ65JmzO8H2iDcx8tOh258zfnDpXz55owMQrtl0ckYF6taN+1oei8kJtznhGm3SrpcB+4EHISFRRDU+S7IXvbOhQZnuGiulBbWWHmNml5kX5knaQnlPndMJX/fRMoIl8YPw9si7WY46ZDAcwqRiQ0ttr44S2LS2eTy2GYEVY8+fnyLUsbChh4IIoMt2Bz9Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qe1w+lLV4FjT4ULlRVzcqB1D+0Q42CRJP4jJWi5rODk=; b=bM3wD4aARK7V9HF2xm6EEmiR9JieuEGiwcC0PwhMN94c2rNkOuZCJKjz10k5odxfvWV1r6ZRy2MnsJyh/IsuXCYY4EnnldBtiWCNT1BqAFBVZuqs4lFZF2SipjRPxQO8trUnx/LIEINy1Mq2o10MzkahrqwMZRXGN7zfK6YiT4s= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SJ0PR10MB5534.namprd10.prod.outlook.com (2603:10b6:a03:3fa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Fri, 31 Dec 2021 15:55:14 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%7]) with mapi id 15.20.4844.014; Fri, 31 Dec 2021 15:55:13 +0000 From: Drew Adams Thread-Topic: [External] : bug#51062: Customizable window resizing Thread-Index: AQHX/iaj2cG+XlgtNUao6xtQ+DJ1CKxMwOPQ Date: Fri, 31 Dec 2021 15:55:13 +0000 Message-ID: References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> <86czlf1fv8.fsf@mail.linkov.net> <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> In-Reply-To: <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48c04682-7643-4565-ad98-08d9cc75eecd x-ms-traffictypediagnostic: SJ0PR10MB5534:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lv5fA4qYmLRgvc2C3Z1vTDFxrOWn3whbumFFtjJ0Zkk7pq/cptLgzt6iIB9iitNPMeyDIpPTCbwaEmsvPNMhvABZ/ukWAgZEk5HCctJ1m1ZmvdS7a3E1kt9HiOIYhHSPDLXECw6M5TnGmx+UUmwdLcZH7di3Vh4SSi2XkUQvPe4SCh9DaExbeLyyHw1pQ5gvXkTDFZfwyglGXvs/H9yYMDcjCM4uIOY9GblwvuHdw0PAoxeQQ5hLb3a0u+KVh+9QobhyvlQJFCmPk2xdcvGVp8eo5c9O04Jr9yxGXVT6ZSSnEIM5E+x7fbbQryPTHL4zqsb2Fta/77x2zsz1TzMV3q2a5NBptFYzvN98vB3+mcjMOzjU/9Qohlr0LR/tq8seEBad+gZrCH/WIiR+oGSx4p3wXeu8sWiN8RAmguu/VNZzxHAefhCeO/g+IVDTP6VE723xOIVM/wu/fzlh3N/gbGbfZY5JMdDOcN96/oqHOohMNpqFZpjL+Xpc672NoI1X7/l0zqvXxLoSjE6XUGa6OcoMNkZQjDNcSQSyRoK45+41v6FpiHjnbqd1/oG/wkV3zq6SynS6rvotgiD1kj4TgXEumZyXcXuFdVgjAtK/o5BXmUFKwaVMIriG6VjhPtrATzRli8SiKqP3uvhHyH89IoT3oiEvGwZi3UJBm76PSMvpjW7sNCoZZlRR2hstHd+TpyJeoNgyU+zZXxFM47UY55+mUSs0/5WR1sy+MhCfHtE4mEzwlfKVxgYTp7y6h92KwoO1jo2nKLb8Qr/ALwJECV8AruKi9n/6RLYLAk0GhvA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(55016003)(64756008)(26005)(76116006)(66556008)(66476007)(66446008)(4326008)(38100700002)(5660300002)(6506007)(186003)(52536014)(8936002)(558084003)(66946007)(316002)(2906002)(110136005)(8676002)(86362001)(7696005)(33656002)(966005)(508600001)(38070700005)(71200400001)(122000001)(44832011)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: MD2dU6I083L9UiJODLfFo/6NJsH/nMI40TIq68fe9Y+jWdEhqi6oZygkVq2YZrmAhbr1bQII8ZzLslqiQAiyboRDzCHUQf7uciSUgcB5gDkD6FXrQZS0vxYpdaSXg7JSPWrdoAFK04ZHEhlYnC+EBhuKonfgjrzTzzLADLVg6rGvGY2wC2PVyFMWalCU6wEJNUmWgO8/cxJHVa6cj5dDSqTyTVpjc2MuzzE8aykgSy+sptH72AF5TKcTI3XkEU1TwPauWKfi1vWHCNrpiHcwdUkoItOVd45SHun9sUnf0u96HkQbSkk5M3nWwfB5myj9ionc8IwwGhivyWMW0wHCQ5SGSPQDEWyfEdfDMJtqVUDbzaVfTBIA5jFPGbI14aSd5+srStzC8OS6aestGOqhD0bRcA8rutaLII9P0XnTJuCZOLOpQVS4CR5d8DKcIeTX+m3n6b571pDB+6t4UoZI7QghRtC1RMHSpfcznT5OQUR+kuqUG/uf4O0pqSwCBOtno8ape9LgoYnJiV11z2ituoMyI5oBgMJ2BKEB+xdxflFIhTDBDI9teh7HOilMInM89MYBv1CH+W2laUTtjLWxAxheKoPKIn24xmBd2Qq6TN1QbZzqQSM2YNU2eugPswPIwf5D74oIsD8QrZmuHkWCS1vqqWonjuwkxBGNBHQmNLedws48EWj8g3LOOW7nWDAYohzC7Hj28Bo0w3XzREYFXSxZhkymuLOQ2x/ep2Ji6SCy0J5Yr3EjHYjE4Z4l/9nT7dvLa9oa4WCEKeJ0TzZ7C9JDtoXPp8oOMHlYWUbS+eyBphTMoHcnqpMslzVLp9S/Xm4DlVjth0L/bVNBpPai8TLwIvN93ONT1ib4Lm8XFVH3O1NxvB3pRu0hi/ea5aa5JL5xj/NIbBLajZ1bQYQh0Tu6utxLH2YHwtWL2MHpdz8V5wrxM7rhbLKvQ7Qg4KQ3NduLXq21+pEAFIdNl2Zh1ZfVvijrI+xUrbfmciQQZ/WFNlUrjcMAd/eAs/39DjQ/bZgX5qAcuA30+aXUFOZaYRD0RtUCZsSJjbNCpppFNQJn2/8QBLYE62RuQXkitK7g5Guc3/63UEIc+EpwH//4qbRhAG54l1R1njgpTtVVXmUH4RR+NLMZs5NdHo5TwY+/ErLxFcR/zh/YV2q1tg6PZzcPi/ehfgwpD/4Jhn+C2WFCJaQyE627R8QBgMf6X/dch5JKTpLwT03kh/NdGqXMQWJcjBF5CVjr+vxMySMw8jtGOXJlqKzRPgxk2SmNFgQGo1ASxbyPsVVrk4InR0VkZ02592TlmSjmycsCMtAs4L3GATuU+qqDiHkn+y8MX/6Q6194EvjYogf5HQOw8gujR5zqVZgEbBQG0kVzHugQ9adde7aawGf50ELYKlHAT0cPsB5Seel5lU8VoCZD5YKjYUOlX2xAWduaTsDgBCW7xDhmzp1DY/h6nGFjCosxvjod1acFe/+ugDOBJk9yr9+GOfqauGK7AbgeA6Ili/F9EoWgh6MlzNcKQExWXJxQzlpyjxLrJo5Xg0izoglfBYdY+AcSDWQmRnMrJLlByMIGBYa0ROQ11kD8aN2GvA8I4lx4l/4UMivHqGO+vIpUUHaG6A== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48c04682-7643-4565-ad98-08d9cc75eecd X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2021 15:55:13.8707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SPhzOC7NbGc+Tk5QUrzOPb3g8NBTp0+cts7UHEqp9qMDKoxADInjOgWCokslJaq9cvQpzmX02xICHh1uhVLWQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5534 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10213 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=870 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112310068 X-Proofpoint-GUID: OTkwB4c9saiXBcxLoUeLHReYXsex1fc8 X-Proofpoint-ORIG-GUID: OTkwB4c9saiXBcxLoUeLHReYXsex1fc8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiAic2hyaW5rLWJ1ZmZlci1pZi1sYXJnZXItdGhhbi1idWZmZXIiPyAgTWF5YmUgdGhpcyBzaG91 bGQNCj4gYmVjb21lICdzaHJpbmstYnVmZmVyLXdpbmRvdy1pZi1sYXJnZXItdGhhbi1idWZmZXIn IHRoZW4uDQoNClRoYXQgd2FzIHdoYXQgSSBhc2tlZCBhbHNvOg0KDQpodHRwczovL2RlYmJ1Z3Mu Z251Lm9yZy9jZ2kvYnVncmVwb3J0LmNnaT9idWc9NTEwNjIjNDgNCg0KKFNpbWlsYXIgcXVlc3Rp b24gZm9yIGB2Yy1zaHJpbmstYnVmZmVyJy4pDQoNCg== From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jan 2022 08:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.164128590232064 (code B ref 51062); Tue, 04 Jan 2022 08:46:01 +0000 Received: (at 51062) by debbugs.gnu.org; 4 Jan 2022 08:45:02 +0000 Received: from localhost ([127.0.0.1]:37002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4fRF-0008Kx-VV for submit@debbugs.gnu.org; Tue, 04 Jan 2022 03:45:02 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4fRD-0008KW-FQ for 51062@debbugs.gnu.org; Tue, 04 Jan 2022 03:45:00 -0500 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 0A92DE0012; Tue, 4 Jan 2022 08:44:51 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> <86czlf1fv8.fsf@mail.linkov.net> <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> Date: Tue, 04 Jan 2022 10:33:48 +0200 In-Reply-To: <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> (martin rudalics's message of "Fri, 31 Dec 2021 10:12:16 +0100") Message-ID: <86bl0rgas3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> You mean to run 'shrink-window-if-larger-than-buffer' from that hook >>> unless the user removed it? >> >> The problem is that the argument of this function should be a buffer, >> not a window as in 'shrink-window-if-larger-than-buffer'. >> This is why bug#52855 proposed to add a new function >> >> shrink-buffer-if-larger-than-buffer >> >> But not sure if this should be added to window.el, >> or better to leave in vc.el with the name vc-shrink-buffer? > > "shrink-buffer-if-larger-than-buffer"? Maybe this should become > 'shrink-buffer-window-if-larger-than-buffer' then. Should such a function be added to window.el? > With the usual problem what to do when there are two windows showing > that buffer. It's understandable why vc-diff-internal and vc-diff-finish use get-buffer-window to get a window: vc-diff-internal: (pop-to-buffer (current-buffer)) (let ((buf (current-buffer))) (vc-run-delayed (vc-diff-finish buf ... vc-diff-finish: (let ((window (get-buffer-window buffer t))) (with-current-buffer buffer ... (when window (shrink-window-if-larger-than-buffer window)))) This is needed to handle the case when the window was deleted before the vc command finished. But why vc-log-internal-common doesn't so the same? vc-log-internal-common: (pop-to-buffer buffer) (vc-run-delayed ... (shrink-window-if-larger-than-buffer) So I posted a patch in bug#52855 to use the same function that relies on get-buffer-window in both cases. But it seems you propose to remember the window with e.g. (setq window (pop-to-buffer (current-buffer))) then to use it in: (run-hook-with-args 'vc-diff-finish-functions window) where the defalut value of 'vc-diff-finish-functions' is: '(shrink-window-if-larger-than-buffer) Then 'shrink-buffer-window-if-larger-than-buffer' is not needed. From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jan 2022 10:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16412920429146 (code B ref 51062); Tue, 04 Jan 2022 10:28:02 +0000 Received: (at 51062) by debbugs.gnu.org; 4 Jan 2022 10:27:22 +0000 Received: from localhost ([127.0.0.1]:37049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4h2I-0002NS-3M for submit@debbugs.gnu.org; Tue, 04 Jan 2022 05:27:22 -0500 Received: from mout.gmx.net ([212.227.17.22]:38215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4h2E-0002ND-N3 for 51062@debbugs.gnu.org; Tue, 04 Jan 2022 05:27:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641292032; bh=7XKF8gvBFgTcs2mcwL5h4jzZbs5vemAr5/Z/cr1LZHo=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Hhl18c/D8LCWByW1cWvepNZKEbpQJil68cNT8J0ZN0KVpoJwnlQIQVkweqzA8YWay vbVLc+qbDBFZ1o3Od8bNi50JO5dbV9oKzjmKixUdIcQol0e4AyOYN2jg3xmwyUaeDD kd15Q3oRrUolpkkL5m1DP17BmSTTWGWcmTz95SdU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.171]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Ygt-1n7jAp1wXj-00376S; Tue, 04 Jan 2022 11:27:12 +0100 References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> <86czlf1fv8.fsf@mail.linkov.net> <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> <86bl0rgas3.fsf@mail.linkov.net> From: martin rudalics Message-ID: <7c39d839-3405-dad3-4e45-90152744e48f@gmx.at> Date: Tue, 4 Jan 2022 11:27:11 +0100 MIME-Version: 1.0 In-Reply-To: <86bl0rgas3.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:SnKYaBid2eLIXaep9u97kil0Y1AnVQ9K2bqpdOrZDIimPQQwTk0 ME8Yaj7M0fSzONAuy+V4qW2Gum8oOP+OE/QOxAKoR5obPaJBWfEjGgZGm65ujnuFXDo3Yd3 wwgiAm+DTrlfK5hto3X7vKS7JvG/bmSBpKln55TtxF7kE54E9qLbx/QlOrixTWRihUoLRNi tD7nWBS7C8wmrc1kHoo1g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/YYQlxPveRI=:PXykWRQE4/4OJC5X6Bc/MK PEAAdGd7xOo06/q1mRfunhzPk3Oko+FLPSh7nK5uHf/Lh5LTggM5Ua/F5DA7L5Y+kFcCgiHJU DNhw8QiPusXAM7rxO5phAHo4NqVfP0zX18gjBrUMA1p6aNJPP7nL+zIft17zaN9e6TMmsTeYD RIctu6lz0tW7286Gx09lS4YxU8VYZywEpx9bgyHrm8FFu8SRlFIKp6KFWij8Jz6pZIXE1vQJd IdNnaj7czAk43ydrStrziYwKeQfAJryDfuGEEx+/EMiFqoTudg6O/q3nJa4agz9UurwrPWvog faruW6O/T11yIxNeI1aec9IFlZ9U743SfGYD5/GClateHbmH2dxXLJ+h3vQDrpPmDUQ+iN8bz dKixMgZ9tNDEtaeMC2kWBx0aNqyIcltJf5x9PaZ1dSPla5zKzcVcNBPoddWjeKPrqKlwOEkU7 2R86Y9hwfBPrnbVve+UqKmM9yqIP/cYzdrk2qxjGS98uRsyR+Dm/sbL9JXznt0XHgavY7qC3L TtUQIHSFR/QRaCKWje7C1c3S38kWX/qxkdg6qAeyKDHOFo326rK+EM79LUbI2tb/I7eVVng46 WlbDoNS2X/KKFb7P2m3FJljpCquewzzcYfOa8ONgyozBYrNbjPy8Qhm9zCcu3iI+59Fv11zrk GzN22GjVUF20mjchdylyT7KOFEIioVkWcjJXBSQU4fzyIQuD/6Qm7ofahfBMdBuOJc5tbB911 rNg5IL2Bcg0TFQnCy72LmAgnJhiZkiwgTa1d3s2eVzDrvLIaYITEhYwdCz3dCLC+QfvUeAO9t K2TpGiJgM/p+mVLU4GZxbASpLXr58rSLfGJj76oXj1SliwbiwzPy/CpAAiwuRpkOesHUM2xFV 9x2pFYs2CjzjmilXVnioYbBIo4ORuoZ/LiogMgAO/k1GIz9GACSqEak1oQIg/FvPrblAMbiid ci/p+Yqww0HA8RBBQpywE9IZNjivSBxVTlq/OZbaOqzcB0Dh3rWR+nFN3+7FlixPi3iQUvCc4 JCvxHdyt4HK0NGUKarX4E9u+FZR9aX6k88PGtO2gFq2doIc7SDYgS7Q1PaDgdC7Wq7/hrC8P2 za5Xs+xq0MODDs= X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) >> "shrink-buffer-if-larger-than-buffer"? Maybe this should become >> 'shrink-buffer-window-if-larger-than-buffer' then. > > Should such a function be added to window.el? Maybe. But we could also rename the first argument of 'shrink-window-if-larger-than-buffer' to WINDOW-OR-BUFFER. >> With the usual problem what to do when there are two windows showing >> that buffer. > > It's understandable why vc-diff-internal and vc-diff-finish > use get-buffer-window to get a window: > > vc-diff-internal: > (pop-to-buffer (current-buffer)) > (let ((buf (current-buffer))) > (vc-run-delayed (vc-diff-finish buf ... > > vc-diff-finish: > (let ((window (get-buffer-window buffer t))) > (with-current-buffer buffer > ... > (when window > (shrink-window-if-larger-than-buffer window)))) > > This is needed to handle the case when the window was deleted > before the vc command finished. > > But why vc-log-internal-common doesn't so the same? > > vc-log-internal-common: > (pop-to-buffer buffer) > (vc-run-delayed > ... > (shrink-window-if-larger-than-buffer) > > So I posted a patch in bug#52855 to use the same function > that relies on get-buffer-window in both cases. > > But it seems you propose to remember the window with e.g. > > (setq window (pop-to-buffer (current-buffer))) > > then to use it in: > > (run-hook-with-args 'vc-diff-finish-functions window) > > where the defalut value of 'vc-diff-finish-functions' is: > > '(shrink-window-if-larger-than-buffer) > > Then 'shrink-buffer-window-if-larger-than-buffer' is not needed. Personally I dislike abusing hooks like that. But I probably do not use vc-... much either. So do whatever you like more. martin From unknown Sun Jun 22 07:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51062: Customizable window resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jan 2022 17:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics Cc: 51062@debbugs.gnu.org Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.164192257628562 (code B ref 51062); Tue, 11 Jan 2022 17:37:01 +0000 Received: (at 51062) by debbugs.gnu.org; 11 Jan 2022 17:36:16 +0000 Received: from localhost ([127.0.0.1]:55458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7L4C-0007Qa-21 for submit@debbugs.gnu.org; Tue, 11 Jan 2022 12:36:16 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7L48-0007QD-3m; Tue, 11 Jan 2022 12:36:14 -0500 Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 43B691C0004; Tue, 11 Jan 2022 17:36:03 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> <86czlf1fv8.fsf@mail.linkov.net> <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> <86bl0rgas3.fsf@mail.linkov.net> <7c39d839-3405-dad3-4e45-90152744e48f@gmx.at> Date: Tue, 11 Jan 2022 19:35:33 +0200 In-Reply-To: <7c39d839-3405-dad3-4e45-90152744e48f@gmx.at> (martin rudalics's message of "Tue, 4 Jan 2022 11:27:11 +0100") Message-ID: <86pmoynpju.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 51062 29.0.50 thanks >>> "shrink-buffer-if-larger-than-buffer"? Maybe this should become >>> 'shrink-buffer-window-if-larger-than-buffer' then. >> >> Should such a function be added to window.el? > > Maybe. But we could also rename the first argument of > 'shrink-window-if-larger-than-buffer' to WINDOW-OR-BUFFER. This can't be generalized because vc uses specific logic: (let ((window (get-buffer-window buffer t))) (with-current-buffer buffer ... (when window (shrink-window-if-larger-than-buffer window)))) >>> With the usual problem what to do when there are two windows showing >>> that buffer. >> >> It's understandable why vc-diff-internal and vc-diff-finish >> use get-buffer-window to get a window: >> >> vc-diff-internal: >> (pop-to-buffer (current-buffer)) >> (let ((buf (current-buffer))) >> (vc-run-delayed (vc-diff-finish buf ... >> >> vc-diff-finish: >> (let ((window (get-buffer-window buffer t))) >> (with-current-buffer buffer >> ... >> (when window >> (shrink-window-if-larger-than-buffer window)))) >> >> This is needed to handle the case when the window was deleted >> before the vc command finished. >> >> But why vc-log-internal-common doesn't so the same? >> >> vc-log-internal-common: >> (pop-to-buffer buffer) >> (vc-run-delayed >> ... >> (shrink-window-if-larger-than-buffer) >> >> So I posted a patch in bug#52855 to use the same function >> that relies on get-buffer-window in both cases. >> >> But it seems you propose to remember the window with e.g. >> >> (setq window (pop-to-buffer (current-buffer))) >> >> then to use it in: >> >> (run-hook-with-args 'vc-diff-finish-functions window) >> >> where the defalut value of 'vc-diff-finish-functions' is: >> >> '(shrink-window-if-larger-than-buffer) >> >> Then 'shrink-buffer-window-if-larger-than-buffer' is not needed. > > Personally I dislike abusing hooks like that. But I probably do not use > vc-... much either. And it would require a weird condition: (when window (run-hook-with-args 'vc-diff-finish-functions window)) > So do whatever you like more. So instead of above, I pushed the original patch with a better function name 'vc-shrink-buffer-window'.