GNU bug report logs - #51061
[PATCH v2 01/23] guix: Add extracting-download.

Previous Next

Full log

Message #106 received at 51061 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 42180 <at> debbugs.gnu.org, 51061 <at> debbugs.gnu.org
Subject: Re: bug#51061: [PATCH v2 01/23] guix: Add extracting-download.
Date: Fri, 08 Oct 2021 00:01:59 +0200

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> * guix/scripts/import.scm (importers): Add "hexpm".
> * guix/scripts/import/hexpm.scm, guix/import/hexpm.scm,
>   guix/hexpm-download.scm: New files.
> * guix/import/utils.scm (source-spec->object): Add "hexpm-fetch" to list of
>   fetch methods.
> * guix/upstream.scm (package-update/hexpm-fetch): New function.
>   (%method-updates) Add it.
> * Makefile.am: Add them.

At the very least it misses tests and documentation, like for every
importer, and an entry in po/guix/POTFILES.in.  The (guix
hexpm-download), like extracting-download.scm, needs more attention
because it’s a core API.

Again, I’m in favor of reverting until it’s been reviewed in more
detail.

> +++ b/guix/hexpm-download.scm
> @@ -0,0 +1,74 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès <ludo <at> gnu.org>
> +;;; Copyright © 2017 Mathieu Lirzin <mthl <at> gnu.org>
> +;;; Copyright © 2017 Christopher Baines <mail <at> cbaines.net>
> +;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
> +;;; Copyright © 2020 Hartmut Goebel <h.goebel <at> crazy-compilers.com>

The list of copyright holders looks bogus.

> +;;; An <origin> method that fetches a package from the hex.pm repository,
> +;;; unwrapping the actual content from the download tarball.

It would be nice to explain in a few words what “the hex.pm repository”
is (I have no idea.)

> +(define* (hexpm-fetch url hash-algo hash

Why another method?

> +++ b/guix/import/hexpm.scm
> @@ -0,0 +1,294 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2015 Cyril Roelandt <tipecaml <at> gmail.com>
> +;;; Copyright © 2016 David Craven <david <at> craven.ch>
> +;;; Copyright © 2017, 2019, 2020 Ludovic Courtès <ludo <at> gnu.org>
> +;;; Copyright © 2019 Martin Becze <mjbecze <at> riseup.net>
> +;;; Copyright © 2020, 2021 Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Please strip it.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.