Subject: Re: [bug#51061] [PATCH v2 03/23] guix: Add rebar3 build-system.

From: Maxime Devos <[email-masked]>
Date: Wed, 06 Oct 2021 23:25:57 +0200

Hartmut Goebel schreef op wo 06-10-2021 om 22:27 [+0200]:
> Am 06.10.21 um 20:56 schrieb Maxime Devos:
> > > +         (host-inputs `(,@(if source
> > > +                              `(("source" ,source))
> > > +                              '())
> > > +                        ,@inputs
> > > +                        ;; Keep the standard inputs of 'gnu-build-system'.
> > > +                        ,@(standard-packages)))
> > 
> > (standard-packages) contains packages like gcc, coreutils, bash, ...,
> > which should be in build-inputs.  Not that it matters much here,
> > as this procedure doesn't support cross-compilation.

‘this procedure’ was a bit ambigious here, I meant the procedure 'lower'
that is being defined.

> 
> Not sure what you want to tell me. Anything you recommend me to change?

I recommend moving ,@(standard-packages) from host-inputs to build-inputs.

Greetings,
Maxime