From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 06 06:14:25 2021 Received: (at submit) by debbugs.gnu.org; 6 Oct 2021 10:14:25 +0000 Received: from localhost ([127.0.0.1]:42643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY3wP-0002Cm-AV for submit@debbugs.gnu.org; Wed, 06 Oct 2021 06:14:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:59534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY3wN-0002Cf-LH for submit@debbugs.gnu.org; Wed, 06 Oct 2021 06:14:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY3wN-0006NF-F5 for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 06:14:23 -0400 Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY3wL-0005XE-3Z for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 06:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9w0ajc1Ba+FUdhdmzd9yFOclnsp2CZB990Q4Pvr0zoI=; b=r5F/o7hwDaMM6YYn215BwOnwsp 7Vgw4856vspFh8cuWbDRPZ6JSTvd0ofMC7/4TXMk2y2ZWnIYvZKcRFEPbt5NcXKPnCoCXNQoCkm5Y iwENZUUGKysrDMhaCyXdVFv9J+5GXfAu2bEiV29T5n8lVnhTHBSKjjmPVc+ZC+R1jd54=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY3wD-0000te-Vc; Wed, 06 Oct 2021 12:14:16 +0200 From: Lars Ingebrigtsen To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Making `gnus-define-keys' obsolete X-Now-Playing: Stephan Mathieu's _Radiance (10): Her Dark Gaze Drowned in Light_: "Nacht" Date: Wed, 06 Oct 2021 12:14:13 +0200 Message-ID: <87wnmq5ukq.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Emacs 29 has grown a new function to define keymaps, `define-keymap' somewhat inspired by the more than two-decades-old macro `gnus-define-keys'. So I've now replaced all the usages of `gnus-define-keys' in Emacs 29 with `define-keymap' and was about to make `gnus-define-keys' obsolete, but that macro is used by mh-e, too. mh-e is also distribu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Stephen Gildea X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Emacs 29 has grown a new function to define keymaps, `define-keymap' somewhat inspired by the more than two-decades-old macro `gnus-define-keys'. So I've now replaced all the usages of `gnus-define-keys' in Emacs 29 with `define-keymap' and was about to make `gnus-define-keys' obsolete, but that macro is used by mh-e, too. mh-e is also distributed outside Emacs, if I understand correctly, so this code can't be converted. Stephen, would it make sense to copy the Gnus macro into mh-e, and rename it mh-define-keys? That way `gnus-define-keys' could be obsoleted. A different solution would be to write a new mh-define-keymap that more closely mimics the new `define-keymap' function, and then use it instead in mh-e -- that's probably a better long-term solution, because you could then remove the mh-define-keymap function at some later date (when you shift the mh-e target to Emacs 29+). In GNU Emacs 29.0.50 (build 36, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-10-06 built on elva Repository revision: 8e37466efc36dab153a9c784ce1ff41c5a663318 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 06 10:01:44 2021 Received: (at submit) by debbugs.gnu.org; 6 Oct 2021 14:01:44 +0000 Received: from localhost ([127.0.0.1]:45067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY7UN-0000ly-RX for submit@debbugs.gnu.org; Wed, 06 Oct 2021 10:01:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:48962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY7UK-0000ln-QU for submit@debbugs.gnu.org; Wed, 06 Oct 2021 10:01:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY7UK-0004fE-DP for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 10:01:40 -0400 Received: from tigger.sg.gildea.net ([99.65.78.170]:34356 helo=tigger3.gildea.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY7UI-0007Ng-FY for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 10:01:39 -0400 Received: from tigger3.sg.gildea.net (localhost [IPv6:::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by tigger3.gildea.net (Postfix) with ESMTPS id 7B80A3E057D; Wed, 6 Oct 2021 07:01:29 -0700 (PDT) From: Stephen Gildea To: Lars Ingebrigtsen Subject: Re: 29.0.50; Making `gnus-define-keys' obsolete In-Reply-To: Message from larsi@gnus.org of 6 Oct 2021 12:14:13 +0200 <87wnmq5ukq.fsf@gnus.org> X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2016749.1633528889.1@tigger3.sg.gildea.net> Date: Wed, 06 Oct 2021 07:01:29 -0700 Message-ID: <2016750.1633528889@tigger3.sg.gildea.net> Received-SPF: pass client-ip=99.65.78.170; envelope-from=stepheng+emacs@gildea.com; helo=tigger3.gildea.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) +mh-e-devel Lars Ingebrigtsen wrote to me: > Emacs 29 has grown a new function to define keymaps, `define-keymap' > somewhat inspired by the more than two-decades-old macro > `gnus-define-keys'. > > So I've now replaced all the usages of `gnus-define-keys' in Emacs 29 > with `define-keymap' and was about to make `gnus-define-keys' obsolete, > but that macro is used by mh-e, too. mh-e is also distributed outside > Emacs, if I understand correctly, so this code can't be converted. > > Stephen, would it make sense to copy the Gnus macro into mh-e, and > rename it mh-define-keys? That way `gnus-define-keys' could be > obsoleted. > > A different solution would be to write a new mh-define-keymap that more > closely mimics the new `define-keymap' function, and then use it instead > in mh-e -- that's probably a better long-term solution, because you > could then remove the mh-define-keymap function at some later date (when > you shift the mh-e target to Emacs 29+). MH-E is no longer developed nor distributed separately from GNU Emacs, since maybe 2015. You can update the MH-E part of the Emacs source tree to use Emacs 29 features. No compatibility is needed. Thanks for checking, < Stephen From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 06 17:09:26 2021 Received: (at 51056) by debbugs.gnu.org; 6 Oct 2021 21:09:26 +0000 Received: from localhost ([127.0.0.1]:45589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYEAB-0005o2-3P for submit@debbugs.gnu.org; Wed, 06 Oct 2021 17:09:26 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:44829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYEA9-0005nn-9S for 51056@debbugs.gnu.org; Wed, 06 Oct 2021 17:09:17 -0400 Received: by mail-pj1-f50.google.com with SMTP id oa12-20020a17090b1bcc00b0019f715462a8so3414994pjb.3 for <51056@debbugs.gnu.org>; Wed, 06 Oct 2021 14:09:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=O/0orf930l5qiUnye6wbdqPJLT36wcIk037BYgleJVc=; b=UH72UR6di05/le/piIBd2F8wuwIlNF6wgYoxyZES9VVy/hblttn+oz2y12Rrn0uA0t pq+JE+tbeDAZHqxfdULuxyuLLBiNHUf1Ok7rtqWrE4qEz4HBJtxPK4WFcfoqcRNe82Hj fdb6J/xMuff9/m+/AkAjtEBuT2P0TucEAE4AhKfUUlkH/Gp+YzW2mebfiM8VklXbWjwG R4MKYC5K7B0vuPC9ynm9VcsKQHzzWeM9R5R3cBJoJVtKpbJ+TsC8DqDZ/xgXvfLsdwlK fbxb21/l7PGsajNE9UOnaIk2gLl+L/DyobvYODRl9Zlxd20Gf/QHQKFBSqlJadSavptz h2vA== X-Gm-Message-State: AOAM533Yugl5IGTPgTVKsWW0tFIBesvriQeP1JvXjQhipjKrHZeLTHPF R6lyyGoSklkd1/ffvyZ2pBX/mEGoHMtnP0G0QUg= X-Google-Smtp-Source: ABdhPJxiDpDYx5mHOmEFkZ3FYt5rp06Sx9dwkEmvbLBZ2Vwo7oXqTgn/f0Iv21afJdUxhNQw361dQiEvriOOe9oH0bQ= X-Received: by 2002:a17:90b:890:: with SMTP id bj16mr1033523pjb.143.1633554551581; Wed, 06 Oct 2021 14:09:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Oct 2021 17:09:11 -0400 From: Stefan Kangas In-Reply-To: <2016750.1633528889@tigger3.sg.gildea.net> (Stephen Gildea's message of "Wed, 06 Oct 2021 07:01:29 -0700") References: <87wnmq5ukq.fsf@gnus.org> <2016750.1633528889@tigger3.sg.gildea.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 6 Oct 2021 17:09:11 -0400 Message-ID: Subject: Re: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete To: Stephen Gildea Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51056 Cc: 51056@debbugs.gnu.org, Lars Ingebrigtsen , mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Stephen Gildea writes: > MH-E is no longer developed nor distributed separately from GNU Emacs, > since maybe 2015. Does that mean that the XEmacs compatibility code in MH-E could also be removed? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 06 22:48:19 2021 Received: (at 51056) by debbugs.gnu.org; 7 Oct 2021 02:48:19 +0000 Received: from localhost ([127.0.0.1]:45744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYJSF-0001l2-4W for submit@debbugs.gnu.org; Wed, 06 Oct 2021 22:48:19 -0400 Received: from tigger.sg.gildea.net ([99.65.78.170]:35182 helo=tigger3.gildea.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYJSA-0001kl-OM for 51056@debbugs.gnu.org; Wed, 06 Oct 2021 22:48:18 -0400 Received: from tigger3.sg.gildea.net (localhost [IPv6:::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by tigger3.gildea.net (Postfix) with ESMTPS id 5952C3E057D; Wed, 6 Oct 2021 19:48:08 -0700 (PDT) From: Stephen Gildea To: Stefan Kangas Subject: Re: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete In-Reply-To: Message from stefan@marxist.se of 6 Oct 2021 17:09:11 -0400 X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2156236.1633574888.1@tigger3.sg.gildea.net> Date: Wed, 06 Oct 2021 19:48:08 -0700 Message-ID: <2156237.1633574888@tigger3.sg.gildea.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51056 Cc: 51056@debbugs.gnu.org, Lars Ingebrigtsen , mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas wrote: > Stephen Gildea writes: > > > MH-E is no longer developed nor distributed separately from GNU Emacs, > > since maybe 2015. > > Does that mean that the XEmacs compatibility code in MH-E could also be > removed? Yes. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 07 03:51:31 2021 Received: (at control) by debbugs.gnu.org; 7 Oct 2021 07:51:32 +0000 Received: from localhost ([127.0.0.1]:45894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYOBf-0001DT-QK for submit@debbugs.gnu.org; Thu, 07 Oct 2021 03:51:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYOBc-0001DA-L7 for control@debbugs.gnu.org; Thu, 07 Oct 2021 03:51:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Hg0PhhjvY9r0GBNlZOW/Yvqk61PHoM1Nks3vevKlx/0=; b=D9yT59pYb6SNjVZ8JdsytxYzFo lvos1K1gGvGiAjvoyr2BSrEASUDBrbzD3ZSFzrHThb2pmXg5v8Wg6uBmwdcEnHTvvCf836IYhMlXc sRU63/dwCr8FQxHO2RrFt5mTFlX+jjSLuP/03pJRdyItuBzKHPUaBlG/aszOUo8yVuGE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYOBU-0005hh-CN for control@debbugs.gnu.org; Thu, 07 Oct 2021 09:51:22 +0200 Date: Thu, 07 Oct 2021 09:51:19 +0200 Message-Id: <87r1cx46iw.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51070 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: forcemerge 51070 51056 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 51070 51056 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 07 12:47:28 2021 Received: (at 51056) by debbugs.gnu.org; 7 Oct 2021 16:47:28 +0000 Received: from localhost ([127.0.0.1]:48326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYWYK-0007b9-HT for submit@debbugs.gnu.org; Thu, 07 Oct 2021 12:47:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYWYF-0007aZ-Sq for 51056@debbugs.gnu.org; Thu, 07 Oct 2021 12:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iENDwRD+LUTr/UNCxg6lE/ab0RMJI1rqOIRK1XRrQrk=; b=uhtdIgilAvc5AzweP3liO6IX4H NOC+YbZwZkD2U9HQapFwJHqroSsq/8yGc58AudURu7cr+w9ZcPqCUPf6laE3QNFPSYUsDUwSGJ5c8 /Tuy0OuzGkF49O7XyVAE8wyddMijBHTbdutAbH7uQaKdLFKtHVCaAkdIa+nExoKvmtSo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYWY3-0001Fd-Uj; Thu, 07 Oct 2021 18:47:15 +0200 From: Lars Ingebrigtsen To: Stephen Gildea Subject: Re: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete References: <87wnmq5ukq.fsf@gnus.org> <2016750.1633528889@tigger3.sg.gildea.net> X-Now-Playing: Steven Brown's _Searching For Contact_: "Scene I: The Street" Date: Thu, 07 Oct 2021 18:46:53 +0200 In-Reply-To: <2016750.1633528889@tigger3.sg.gildea.net> (Stephen Gildea's message of "Wed, 06 Oct 2021 07:01:29 -0700") Message-ID: <87h7dsaiki.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Gildea writes: > You can update the MH-E part of the Emacs source tree to use Emacs 29 > features. No compatibility is needed. I've now converted the calls and done some extremely light testing, but I don't see any obvious breakages (but I don't have mh set up properly on my system). Can you check whether I broke anything? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51056 Cc: 51056@debbugs.gnu.org, mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stephen Gildea writes: > You can update the MH-E part of the Emacs source tree to use Emacs 29 > features. No compatibility is needed. I've now converted the calls and done some extremely light testing, but I don't see any obvious breakages (but I don't have mh set up properly on my system). Can you check whether I broke anything? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 07 12:50:25 2021 Received: (at control) by debbugs.gnu.org; 7 Oct 2021 16:50:25 +0000 Received: from localhost ([127.0.0.1]:48330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYWbA-0007hH-Vv for submit@debbugs.gnu.org; Thu, 07 Oct 2021 12:50:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYWb7-0007h2-LU for control@debbugs.gnu.org; Thu, 07 Oct 2021 12:50:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y5k2EuQ78tMl9DPkAOvU9IcwZZtXKUCN8EORIChvAj8=; b=CJDuB72pVzXBvNgYwmz31veAbt nyuTeMgCSTS+6alUWUC1/hfaNeuEy/qzcJDxQq6RnQ4T6xlADZ3FhodeWP+JfBbrOghCbt1H8CvTC nMdEWrnfn65ep8IOdOs84vZcwAF59ddzQs3FQydST1i+3lR6JFu6x2D6+Xub8M6h3AK4=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYWaz-0001Id-LV for control@debbugs.gnu.org; Thu, 07 Oct 2021 18:50:15 +0200 Date: Thu, 07 Oct 2021 18:50:08 +0200 Message-Id: <87ee8waif3.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51056 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: fixed 51056 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) fixed 51056 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 15:00:50 2021 Received: (at 51056) by debbugs.gnu.org; 11 Oct 2021 19:00:50 +0000 Received: from localhost ([127.0.0.1]:60919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma0XZ-0007ji-RS for submit@debbugs.gnu.org; Mon, 11 Oct 2021 15:00:50 -0400 Received: from se6j-iad1.servconfig.com ([173.231.241.32]:57183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma0XY-0007jZ-2M for 51056@debbugs.gnu.org; Mon, 11 Oct 2021 15:00:49 -0400 Received: from ecbiz204.inmotionhosting.com ([198.46.81.33]) by se6-iad1.servconfig.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1ma0X0-000QUk-Nh; Mon, 11 Oct 2021 15:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-ID:Content-Type:MIME-Version:References: In-reply-to:Subject:From:cc:To:Sender:Reply-To:Content-Transfer-Encoding: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PC1TlG7WD+bsQz0TRo2tQEFpE9GLDyLCvcpJibSBLwY=; b=0PPEBudXoMi/fDQRAOnwBfLdXe G/Lmkk8sxKVvAJexJC1LdcMFgtNts9HuPXm2gAIbTq5ik8osQPgRLjSNRP13vrpqVmZt2T/jRn7i1 y6ZjSS0vywi6SEzUEDhrV1ERf12gBy/3sjhMJnPVvgOKh4cN+JiVx22cqh+t7rlzryxY7ZXkk/CF6 vWQgw5842bWFEw1JC6azVMtqxzQhYkTVnzTlwCZ69ODnztSEAXfo8ieSqH5A/GjJQw4aREUADppZ3 xqosyHbHvLwHrjnlbrHajVDgwp55zYy5tBv5l/ZANPB8mk0Xc7u3u0nq6yycLae8b2hX2FgusW98z oeu2OKXA==; Received: from [67.180.9.78] (port=33034 helo=olgas.newt.com) by ecbiz204.inmotionhosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ma0Wz-000cO2-JZ; Mon, 11 Oct 2021 15:00:13 -0400 Received: by olgas.newt.com (Postfix, from userid 1000) id DD81338012D; Mon, 11 Oct 2021 12:00:12 -0700 (PDT) To: Stephen Gildea From: Bill Wohler Subject: Re: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete In-reply-to: <2156237.1633574888@tigger3.sg.gildea.net> References: <2156237.1633574888@tigger3.sg.gildea.net> Comments: In-reply-to Stephen Gildea message dated "Wed, 06 Oct 2021 19:48:08 -0700." Organization: Newt Software X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Mail-Followup-To: mh-e-devel@lists.sourceforge.net MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1178965.1633978812.1@olgas.newt.com> Date: Mon, 11 Oct 2021 12:00:12 -0700 Message-ID: <1178966.1633978812@olgas.newt.com> X-Get-Message-Sender-Via: ecbiz204.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz204.inmotionhosting.com: wohler@newt.com X-Originating-IP: 198.46.81.33 X-SpamExperts-Domain: ecbiz204.inmotionhosting.com X-SpamExperts-Username: 198.46.81.33 Authentication-Results: servconfig.com; auth=pass smtp.auth=198.46.81.33@ecbiz204.inmotionhosting.com X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.15) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT9WLQux0N3HQm8ltz8rnu+BPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5ypm/SQGohL/1DpQaRY18fscCjOphKkwwM5XllWBLNlRfmH HM70sq5CSDyRoTRm/71rah7eYDopdvxMG8mf3a68d9ES7wfLfo7184NcINsvNXs19sXKp8hyzyqQ 9ylzFX6KiBW0U4t92vEldR714Varjc30elPqvxFh0RkhRttcB7JMsao6Qzuui5xhqFJ032E3/wYT awz0Z5rXb2kSM3CEVj7lp1m9ZegYtxBxvvwS6EsXCmY3O+u+IDn26pj0kaUlg6sn8q81J5A0cM/W hbAYTp8iLqyKSlkK2PDDGYjDdheLi9Fg3Wp1ik6Y8h0D42+FjSYVUdeNfUdQPc4WTT+VObMw/mj3 7elTI5YstsTrKE7LXkyUgG/7sMvqc3TG/opxrIFqUzM2JCL4ho/oineXRmwFJpJE6uIbRNWmKdxS XI7cHc7Ni/XNmxf/8oExVGfBSKWFpiDi74OtX00iyUi37zBFxn/qZEPaqIQaWCBQGrALl8c0fHuP qD7CjpAdZ1DzGOBdlUi43AF+cJAY7kbRqq98AcBHl+gIueRT0ac4W6z26Pxs6oT3NUnCpiyTeiu+ vRkvYKdSY+sjsB7RynY1vrFPr9OgAAnumRAZwy+44hrGUe3T4UJzWm9yYeAsAX4SFjdr0dUusSoJ DKZGmQ+ZQiNS0XfPy/Y0QWi9hIl/OUL4rDv/ongJabFsvx08SukGnzYCBATg24qv6MzI4mXA0Y3S tybWzmOFebuEqja23YufINB9bYlqbvRBfAT94cbb3bR+Uhvx6zteRW1zlDi00z6bhalFEM/pjPCQ A+BAlsYOT1N44+P6rEbyfKKeDb/t266BaCapkcEMMfcyb/+DUH+AUUuB4dpnvVGq0uayBtKEhG/c 5fClnWB36PUFdvRArZkQAfnWorPJSurovTyspIC1dJrSE8ejVYoPZbotyXe9ufSsagygvSQ5CoJu FvCK64v3/nZYJsI1JZ/wDtTWm9tenUtqZQFFu3IV3YouJhbEAKmFXEgPo4bBn2o5TQiLyXZH2UP8 eiM78VGJjqBNrPbo/GzqhPc1ScKmLJN6K99vVo3/oYJG0o/saM9fUloHPE4Qu0v/ggd6Yysj+vW4 ARoWNf3eEVVJtzClMHPxEVjua1+0WKJUD40OqgAJtG4= X-Report-Abuse-To: spam@se1-lax1.servconfig.com X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stephen Gildea wrote: > Stefan Kangas wrote: > > > Stephen Gildea writes: > > > > > MH-E is no longer developed nor distributed separately from GNU Emacs, > > > since maybe 2 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [173.231.241.32 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 51056 Cc: 51056@debbugs.gnu.org, Lars Ingebrigtsen , Stefan Kangas , mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Stephen Gildea wrote: > Stefan Kangas wrote: > > > Stephen Gildea writes: > > > > > MH-E is no longer developed nor distributed separately from GNU Emacs, > > > since maybe 2015. > > > > Does that mean that the XEmacs compatibility code in MH-E could also be > > removed? > > Yes. Stefan and Lars, Thanks so much for the MH-E clean-ups! They are very much appreciated. So far, I haven't noticed any issues with your updates. -- Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 15:46:49 2021 Received: (at 51056) by debbugs.gnu.org; 11 Oct 2021 19:46:49 +0000 Received: from localhost ([127.0.0.1]:60977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma1G4-0002aR-VB for submit@debbugs.gnu.org; Mon, 11 Oct 2021 15:46:49 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:55862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma1G3-0002aE-KN for 51056@debbugs.gnu.org; Mon, 11 Oct 2021 15:46:48 -0400 Received: by mail-pj1-f49.google.com with SMTP id om14so2141719pjb.5 for <51056@debbugs.gnu.org>; Mon, 11 Oct 2021 12:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=pE5Wkp/Lmof983iJqj0TQGM8QEMg1T6y1G3kh0agi88=; b=w91WSFnRHKeBNdgoFHn+t1x5BDqiAvKPVX4CwT1UxbvjqHApi7BwX4VD8k0+61vw6V E3Lnz8pxf3Up8aodbJ/Np3LInu1cC19GL2DP/YDaXV4gfdB5sGJttUapQMBDQNIaWjRH 0b2yPLTg32tEVQlovd/H4PD7ut7b1iYqmNQx0Yxll+IPmV2GPO3yu7PMYl2Jxj/otS5Q 3eeX9NQoo+i+QyrCB/PYG4fzxo3kGJX/o5CKmiBMbNsEs3t55akAi2y8ivULorg4Vkno GMIR1E6rDJwfuzrfNWFnKa7bDXR9Ttg9cAkb7cbdlKcscZprg8MDiLue36v+CZqyexNl aJKw== X-Gm-Message-State: AOAM530EqBks+Gcz5pKgI1PlZQ/MTyvfjOIrgW1O9GQIabYrmI5RHH3x 6YL6oseBReUWPKCMoj7d2Qzb8xHnccAdqunYlwY= X-Google-Smtp-Source: ABdhPJyhhzC17UdDsN6q/kpdP5wNM/D1nxKiYroYuYu1i723oFJhGBnivd8vIM51bdt/ogpwEVgaM2fikkEfPe5eYSs= X-Received: by 2002:a17:902:e74a:b0:13f:3538:fca0 with SMTP id p10-20020a170902e74a00b0013f3538fca0mr8473050plf.22.1633981601777; Mon, 11 Oct 2021 12:46:41 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Oct 2021 12:46:41 -0700 From: Stefan Kangas In-Reply-To: <1178966.1633978812@olgas.newt.com> References: <2156237.1633574888@tigger3.sg.gildea.net> <1178966.1633978812@olgas.newt.com> MIME-Version: 1.0 Date: Mon, 11 Oct 2021 12:46:41 -0700 Message-ID: Subject: Re: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete To: Bill Wohler , Stephen Gildea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51056 Cc: 51056@debbugs.gnu.org, Lars Ingebrigtsen , mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Bill Wohler writes: > Thanks so much for the MH-E clean-ups! They are very much appreciated. > So far, I haven't noticed any issues with your updates. Thank you, that is an encouraging report. If we do break something, we can always back those commits out for further investigation, as I already had to do in one case. The culprit was this change, but I can't say that I understand why: diff --git a/lisp/mh-e/mh-tool-bar.el b/lisp/mh-e/mh-tool-bar.el index 805408cfc7..7cc0a1e83c 100644 --- a/lisp/mh-e/mh-tool-bar.el +++ b/lisp/mh-e/mh-tool-bar.el @@ -27,8 +27,7 @@ ;;; Code: (require 'mh-e) -(mh-do-in-gnu-emacs - (require 'tool-bar)) +(require 'tool-bar) ;;; Tool Bar Commands So this innocent looking change leads to this: In mh-tool-bar-define: mh-e/mh-tool-bar.el:180:62: Warning: reference to free variable =E2=80=98fo= lder-docs=E2=80=99 mh-e/mh-tool-bar.el:222:36: Warning: reference to free variable =E2=80=98folder-button-setter=E2=80=99 mh-e/mh-tool-bar.el:226:36: Warning: reference to free variable =E2=80=98sequence-button-setter=E2=80=99 mh-e/mh-tool-bar.el:191:34: Warning: reference to free variable =E2=80=98sh= ow-buttons=E2=80=99 mh-e/mh-tool-bar.el:230:36: Warning: reference to free variable =E2=80=98show-button-setter=E2=80=99 mh-e/mh-tool-bar.el:234:36: Warning: reference to free variable =E2=80=98show-seq-button-setter=E2=80=99 mh-e/mh-tool-bar.el:295:41: Warning: reference to free variable =E2=80=98letter-buttons=E2=80=99 mh-e/mh-tool-bar.el:296:41: Warning: reference to free variable =E2=80=98le= tter-docs=E2=80=99 mh-e/mh-tool-bar.el:245:36: Warning: reference to free variable =E2=80=98letter-button-setter=E2=80=99 mh-e/mh-tool-bar.el:280:51: Warning: reference to free variable =E2=80=98folder-defaults=E2=80=99 mh-e/mh-tool-bar.el:291:51: Warning: reference to free variable =E2=80=98letter-defaults=E2=80=99 mh-e/mh-tool-bar.el:194:36: Warning: reference to free variable =E2=80=98folder-vectors=E2=80=99 mh-e/mh-tool-bar.el:195:11: Warning: reference to free variable =E2=80=98sh= ow-vectors=E2=80=99 mh-e/mh-tool-bar.el:196:11: Warning: reference to free variable =E2=80=98letter-vectors=E2=80=99 mh-e/mh-tool-bar.el:197:14: Warning: assignment to free variable =E2=80=98folder-defaults=E2=80=99 mh-e/mh-tool-bar.el:199:61: Warning: assignment to free variable =E2=80=98letter-defaults=E2=80=99 mh-e/mh-tool-bar.el:189:11: Warning: reference to free variable =E2=80=98folder-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98folder-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98letter-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98show-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98l= etter-docs=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98f= older-docs=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98folder-vectors=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98show-vectors=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98letter-vectors=E2=80=99 mh-e/mh-tool-bar.el:301:1: Error: Symbol=E2=80=99s value as variable is voi= d: folder-docs ELC mh-e/mh-xface.elc make[2]: *** [Makefile:316: mh-e/mh-tool-bar.elc] Error 1 Any ideas here are welcome. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 06:40:09 2021 Received: (at control) by debbugs.gnu.org; 12 Oct 2021 10:40:09 +0000 Received: from localhost ([127.0.0.1]:33571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maFCb-0002Kh-BM for submit@debbugs.gnu.org; Tue, 12 Oct 2021 06:40:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maFCZ-0002KQ-ML for control@debbugs.gnu.org; Tue, 12 Oct 2021 06:40:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VbLVC+vRrZ13ObHTkYLyvkF1C98evCeWaVt0pOksncM=; b=XYI4MFAzHEL0nIg0V1SUbfyuq8 6nn0MmF4LE1bWaz2v7UR7ND7xwTarlbMGfCY5WnuLaEbOl7LLtRKUlJWubepxFeLadbmUPR02YUOa Z9Xw8burRYCY6DaGKYwHgwnjY2ErsFYlufqL9J3VEvZ9c7Hci74pMPdz2iTBSL4Y6ryE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maFCR-000467-K6 for control@debbugs.gnu.org; Tue, 12 Oct 2021 12:40:01 +0200 Date: Tue, 12 Oct 2021 12:39:59 +0200 Message-Id: <87sfx6frwg.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51056 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 51056 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 51056 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 06:43:58 2021 Received: (at 51056) by debbugs.gnu.org; 12 Oct 2021 10:43:58 +0000 Received: from localhost ([127.0.0.1]:33586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maFGI-0002Qp-41 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 06:43:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maFGG-0002QY-2O for 51056@debbugs.gnu.org; Tue, 12 Oct 2021 06:43:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=I1hnANIYZoOBt6ZynNAs0e/u2GNKHVskIlJb6RXcBdw=; b=I5rnDB85wDuv6LtYpEF/nV4Wfr 2E571hQbQFJBJzQdlL/qJmV3R8+TFRLRnKGrK1qvpRvryR+Xg2aBgilOOkadwBvfMVe4MCrcbac96 zKL9Be/0SnmqkfvWlqNSdctVpSPaxA88OP8fXkstp23C6cctdxBEaxng3uKKsddPCeVo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maFG5-00049g-4o; Tue, 12 Oct 2021 12:43:47 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete References: <2156237.1633574888@tigger3.sg.gildea.net> <1178966.1633978812@olgas.newt.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEU8O0NAPkdGSE4q LDWen6Hb29toanC+v78dIS0QFScKDRh8foM+QUn///80+ybcAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+UKDAoiFU3DoJUAAAGcSURBVDjLzdHPS8MwFAfwhFLwuPQ/WKUqnsoycQMPsi1jeJxNK3gR16no RVy7g3oQK5h6EhFM9gcMNjzuLxD/MJN1Pyq2F/Hg99DD+/TlhRcAzcwUgZmTfwpGHuQJADAPclok oB9iJAARMlNYNIpoDgWEZCNKACE0AwALYBqIDJTESGCWAlSlBeAFQHm4rKkRSIE9NQ3O2tTHhkgC xqYGNHPVxiU7QWzawJBQpq5dDgLtmNS1ILL83jrdBRBElW4zXOlubDdpo1Wifb2xH550ZB+rks21 O9J5cMOjK8sLw8mtc6FJ4LHVf7KcDf2AlA6JM6STHg17cprgQ3ppnVe7e+SsFgQx8S+p35Z3FeLx xnttxxIarSBglt/3aB1jIAb6Obl3+ds1iarE4brfd3c+FIhHx3t2R1t7pMp0CZNe2PSm8B7uCv+k GZ9Wopcbtu23PmltCgMuGMcxk6mwiDHM5DYUyHAm2DJ4CSJdZywNqite/pOGVBSB8SibwFgmi34H IhsyhysQOTDKA/HnoNYT/wQ+X3j8HXj6MWb2BSMUhJHZcKTUAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIxLTEwLTEyVDEwOjM0OjIwKzAwOjAwMfb3JAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMC0x MlQxMDozNDoyMCswMDowMECrT5gAAAAASUVORK5CYII= X-Now-Playing: SOPHIE's _PRODUCT_: "HARD" Date: Tue, 12 Oct 2021 12:43:43 +0200 In-Reply-To: (Stefan Kangas's message of "Mon, 11 Oct 2021 12:46:41 -0700") Message-ID: <87o87ufrq8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > If we do break something, we can always back those commits out for > further investigation, as I already had to do in one case. The culprit > was this change, but I can't say that I understand why: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51056 Cc: 51056@debbugs.gnu.org, Stephen Gildea , Bill Wohler , mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > If we do break something, we can always back those commits out for > further investigation, as I already had to do in one case. The culprit > was this change, but I can't say that I understand why: [...] > -(mh-do-in-gnu-emacs > - (require 'tool-bar)) It's because mh-do-in-gnu-emacs is autoloaded and pulls in mh-acros, while mh-dlet* isn't autoloaded, and we're not requiring mh-acros, so it fails if you remove that macro. I think the solution is just to require mh-acros (or possibly autoload mh-dlet*). (The latter can probably just be rewritten to use dlet, though.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 07:44:47 2021 Received: (at 51056) by debbugs.gnu.org; 12 Oct 2021 11:44:47 +0000 Received: from localhost ([127.0.0.1]:33681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maGD8-00024J-R9 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 07:44:46 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:37428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maGD6-000242-Lz for 51056@debbugs.gnu.org; Tue, 12 Oct 2021 07:44:45 -0400 Received: by mail-pg1-f173.google.com with SMTP id r201so13645596pgr.4 for <51056@debbugs.gnu.org>; Tue, 12 Oct 2021 04:44:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=3hjhi7FAEpKtxEjwvwzIugA1TxIrjycN3UBtNW+izfw=; b=4dcpPoWMZNzaou1GTAa6D2w2Km36rxFWZWarXyCFmxHosApl2gFA0ywOwEzTrDrqZA O/KMv37kK5D4ZR3epTz+on2t2T7esK1qm9prTWlhCzHJtyKRKwx65KTgCR2iE7gU4H/O QKfbO6cXNc6mC5tHICoEe5LBponX1XJ2JmfgSPYuFZPl0Icl5XHiZA4CgNFZr8T7nNUB GOHHlez8qDr3rG39LwjygdIGxxxA+3C8GzFIOG26V/f5gCRIvYVSxYHLZ6igYdo1EWNv bAhfTSUdSsT+F4Y/mw2EwYKooClAQcvaYX2np3L2ZHO3MyNATkF0NKmUcwlASI9lkkXX faNQ== X-Gm-Message-State: AOAM532V6U8w+94F13aLZDQRZd3l6HEWsHgI4ASbZ2m24oRhKOtq/8RH SuzBNowDH4l0a7GVlww1dTS7MrOX/l3yb1TxxaQ= X-Google-Smtp-Source: ABdhPJxk0iVaKX7UPCdt047uS+PKI0QL6MSfS34tBS4+2xh6XE2y1qeoU6EyggA47sPs9Hyz6RZ80G5bPNfYAlWpyn8= X-Received: by 2002:aa7:978b:0:b0:44c:abf1:a8b8 with SMTP id o11-20020aa7978b000000b0044cabf1a8b8mr31305869pfp.35.1634039078654; Tue, 12 Oct 2021 04:44:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Oct 2021 04:44:38 -0700 From: Stefan Kangas In-Reply-To: <87o87ufrq8.fsf@gnus.org> References: <2156237.1633574888@tigger3.sg.gildea.net> <1178966.1633978812@olgas.newt.com> <87o87ufrq8.fsf@gnus.org> MIME-Version: 1.0 Date: Tue, 12 Oct 2021 04:44:38 -0700 Message-ID: Subject: Re: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51056 Cc: 51056@debbugs.gnu.org, Stephen Gildea , Bill Wohler , mh-e-devel@lists.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > I think the solution is just to require mh-acros (or possibly autoload > mh-dlet*). (The latter can probably just be rewritten to use dlet, > though.) Aha! Thanks, now fixed on master. From unknown Sun Jun 22 08:02:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Nov 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator