GNU bug report logs - #51037
[PATCH] Make `print-level` & `print-length` customizable in ERT batch tests

Previous Next

Full log

View this message in rfc822 format

From: Michael <sp1ff <at> pobox.com>
To: Filipp Gunbin <fgunbin <at> fastmail.fm>
Cc: gazally <at> runbox.com, Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>, 51037 <at> debbugs.gnu.org
Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests
Date: Wed, 24 Nov 2021 08:29:43 -0800

>> So, we could do either of:
>>
>>    1. As Filipp suggests, just change the contract for
>>    `ert-batch-backtrace-line-length' to: if set to nil, you get
>>    full stack traces, period.
>>
>>    2. change `cl-print-to-string-with-limit' to respect the
>>    existing values of `print-length' & `print-level' when
>>    `limit' is nil. Note that the only caller (in Emacs) of this
>>    function is the backtrace package.
>>
>> I vote for option 2. What say you all?
>
> I think the right way is 1 (which I already installed) because 
> then, as
> the result of your patch, we get the ability to override
> backtrace-line-length with ert-batch-backtrace-line-length, and 
> nothing
> more.
>
> Changing the semantics of backtrace-line-length should be done 
> (if done)
> in a separate issue, IMO.
>
> Personally, I like that LIMIT in cl-print-to-string-with-limit 
> is "hard
> override".

*shrugs* OK... so can we close this issue?

-- 
Michael <sp1ff <at> pobox.com>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.