From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 05 04:23:03 2021 Received: (at submit) by debbugs.gnu.org; 5 Oct 2021 08:23:03 +0000 Received: from localhost ([127.0.0.1]:39002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXfj5-0007tb-5H for submit@debbugs.gnu.org; Tue, 05 Oct 2021 04:23:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:49814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXfj1-0007sw-Tm for submit@debbugs.gnu.org; Tue, 05 Oct 2021 04:23:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXfiy-0000Ve-4G for bug-gnu-emacs@gnu.org; Tue, 05 Oct 2021 04:22:59 -0400 Received: from mail-oln040092073020.outbound.protection.outlook.com ([40.92.73.20]:42614 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXfis-0003T4-4R for bug-gnu-emacs@gnu.org; Tue, 05 Oct 2021 04:22:55 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RDaNmQ6y4DEnMg4uGdjw+Ch8g+bb0Tp7FJsuVv0pcUfMnbFjbf9au1EcUBFTYzY3tYlu4+tUCzlwTRICAwlcMfdtcubsfZYTOyB3rd/iEApw+wekd19jmKJ3WizM56A/rHaxTWQ4jYOdhsCRhOPq7J8XGumwLhmdVcbRNLlWIaFsG8pkEn1aeBY5F2q3MAkgVjeRcqwqyocZl94/cZmx8b8uqJo3p5LisUqoEVDrwm2qNTCIyFSlFGBOBbYVrsgDsO214Kmag2/uzJM55fLtvZzhhIr+SkkpzPOTjvJIWoDmH4HncKGITsl+ZHCMBU//HGbsS1tsJjzPgB3A9afJ4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qYksUyYv+Afc+C1IEyzRLOnfy5XlJQVCRGDe4ChmtZc=; b=jVTnJbediEoNyFg5ItW5ZnsPxtOL1IJc12W9tli1DDcG0MKliltHHGOc2yhCgR/8dEh+waTvQYK9dnzB50byszPMBttwmuv/MtM41Afispau/N/8kdKFusTUfmx1av8zJfw5Lch9l4kQcpT0W7FWnxjPN2kGBZtgq9JUxLFRu6atm89fQdEx5dXMcmRpQAyrdcJweNI9wZES29dAnJsKwwoigriOpMpo11HadHmlruyJS8X4tnQDQ8eFa8encJgU8nZUPIRQZusmzo3d3o4MvZXQtcrUCZ7Exzdk0azYyGeuStARmXDQ8bcjj7OXK11khTlFMRrMReNtxMzqjVYFNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qYksUyYv+Afc+C1IEyzRLOnfy5XlJQVCRGDe4ChmtZc=; b=muZO+wPSebOUOsB47nPrWuY/aHtPdyQ1W0gNlp5/ciN5GbFsNXoJYrQFO3ZLxcVwh9gO3BSq2GNNFbRHrcVxJe1EhJNg2Nw/rsM5/RqObNBk/Nv+BS3eM447MVHFQ7dXvVuxPBVzpzaqBYHL5gVx7WbrgP6el45XYcBGy2C+Dc34eEMpcbhCbqnmYYmuxiOxPUxNRRbuDzZNZxyLcWWP/+muAEdoNVdDZX2YhBkJiWJLf6O7EubwcHm1WtuupzvQ6wfondZRHLJSlmv21NzfG81M7l4Xq7xfbY9bwWNyqIbAZ4Kf1IJ/IPfBUre8F1D9SVfx875twgjDyQhDhpGycQ== Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM9PR09MB4849.eurprd09.prod.outlook.com (2603:10a6:20b:2d7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Tue, 5 Oct 2021 08:22:44 +0000 Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2%9]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 08:22:44 +0000 From: Arthur Miller To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Edebug leaves data in symbols plist after instrumentation Date: Tue, 05 Oct 2021 10:20:14 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [fXXQG0dZVLdkeAGXWeg2bePJebmiW927] X-ClientProxiedBy: AS9PR0301CA0052.eurprd03.prod.outlook.com (2603:10a6:20b:469::7) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87ilybvq25.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pascal.homepc (81.232.177.30) by AS9PR0301CA0052.eurprd03.prod.outlook.com (2603:10a6:20b:469::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22 via Frontend Transport; Tue, 5 Oct 2021 08:22:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ecca4692-195e-4b35-bfc7-08d987d94df3 X-MS-TrafficTypeDiagnostic: AM9PR09MB4849: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oxpN4Pevv0ylNn7X/g2FD3+FoZRHStEmB5kEfWGhfmePf7xdyt1tx0LIbDBIMa9+moC3GhaqwhfKWeZ6yOsuAFad/7jF7mCSMVeyBekjvlJgkhCUTg7zhohdppNKWrPF+qRwInt5vPgOF8LoPfys0x1gAM0B//z0IXHAeIndWVC50XwSjVjV2X655Xq6FvR9/egJDZt1TQg6jHAvrCT6su55UJM4J/uTCUIJM8QhqubnYLkRm+oqhI5N1pCuWnqBLmC7tecNGIKqq/kZyuJJYlDGWBaYUmH90I83cIvQ93v2gxJDtcwIR9PQ6NOtrAlOdaZUNQIJxhXnZ5PZdqDWKbxD66h6m9Vw6/mg+fJp37TrzF98cPnEaP5eyuEQvjf3ZkcX//r8uPCtaWvvUyKwvEWL6TjGi/oGPlXCKTpNuWvjJrF7nhT57cdz0W1iR05C X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Gg83g25jiWR3EQFciIWoSDvuFCfHWsHK5peQ1Bt2+53wpB3Pr38JpliGowMtbib74h6lSEHdpRdXl7qyrC1dSi+gewZ5N0AagTteoTsLz16xOZZ5CviZ8y+XfA6HzVEAI6zKsfyQYrL4Lppm0lAvdA== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: ecca4692-195e-4b35-bfc7-08d987d94df3 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 08:22:44.1152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR09MB4849 Received-SPF: pass client-ip=40.92.73.20; envelope-from=arthur.miller@live.com; helo=EUR04-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain 1. Instrument any defun/macro for edebug with C-u M-x RET eval-defun 2. Remove instrumentation with M-x edebug-remove-instrumentation RET 3. Check the chosed symbols plist: M-x (symbol-plist 'whatever-you-used) Edebug data will be present in plist after instrumentation is removed. Attached patch is suggestion to fix 'edebug-remove-instrumentation' to remove unnecessary data after instrumentation. Is edebug-remove-instrumentation only function that can remove edebug instrumentation? I am not though sure, if some other place needs to be patched, I am thinking mostly of edebug-read-and-maybe-wrap-form. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Clean-edebug-props-on-instrumentation-removal.patch >From 057a4278bf0b8c8a8985850b505f0a1addd8156f Mon Sep 17 00:00:00 2001 From: Arthur Miller Date: Tue, 5 Oct 2021 09:17:20 +0200 Subject: [PATCH] Clean edebug props on instrumentation removal * lisp/emacs-lisp/edebug.el (edebug--strip-plist): New function. (edebug-remove-instrumentation): Added call to 'edebug--strip-plist'. --- lisp/emacs-lisp/edebug.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index a38c8bd5ca..da8a3f1eb8 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -4529,6 +4529,13 @@ edebug--unwrap*-symbol-function (was-macro `(macro . ,unwrapped)) (t unwrapped)))))) +(defun edebug--strip-plist (symbol) + "Remove edebug related properties from SYMBOL's plist." + (dolist (prop '(edebug edebug-behavior edebug-coverage + edebug-form-spec edebug-freq-count + ghost-edebug)) + (cl-remprop symbol prop))) + (defun edebug-remove-instrumentation (functions) "Remove Edebug instrumentation from FUNCTIONS. Interactively, the user is prompted for the function to remove @@ -4560,6 +4567,7 @@ edebug-remove-instrumentation (dolist (symbol functions) (when-let ((unwrapped (edebug--unwrap*-symbol-function symbol))) + (edebug--strip-plist symbol) (defalias symbol unwrapped))) (message "Removed edebug instrumentation from %s" (mapconcat #'symbol-name functions ", "))) -- 2.33.0 --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, cairo version 1.17.4) of 2021-10-04 built on pascal Repository revision: c6be44d9b3ec09195f6279e9a503175f8fd60e14 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Arch Linux Configured using: 'configure --without-modules --with-cairo --with-compress-install --with-x-toolkit=no --with-gnutls --without-gconf --without-xwidgets --without-toolkit-scroll-bars --without-xaw3d --without-gsettings --with-mailutils --with-native-compilation 'CFLAGS=-O2 -march=native -mtune=native'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT NATIVE_COMP NOTIFY INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF X11 XDBE XIM XPM ZLIB Important settings: value of $LANG: sv_SE.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: text-scale-mode: t show-paren-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core eieio-loaddefs password-cache json map mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date compile text-property-search comint ansi-color ring helper edmacro kmacro help-fns radix-tree edebug comp comp-cstr warnings rx cl-seq cl-macs cl-extra debug backtrace help-mode find-func trace elp face-remap vc-git diff-mode easy-mmode vc-dispatcher cl-loaddefs cl-lib seq gv subr-x byte-opt bytecomp byte-compile cconv paren iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 123973 8004) (symbols 48 10003 0) (strings 32 29672 1979) (string-bytes 1 1004452) (vectors 16 21210) (vector-slots 8 371233 17772) (floats 8 50 42) (intervals 56 638 1) (buffers 992 15)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 05 04:50:42 2021 Received: (at 51026) by debbugs.gnu.org; 5 Oct 2021 08:50:43 +0000 Received: from localhost ([127.0.0.1]:39029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXg9q-0002MT-LR for submit@debbugs.gnu.org; Tue, 05 Oct 2021 04:50:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXg9n-0002M5-PT for 51026@debbugs.gnu.org; Tue, 05 Oct 2021 04:50:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xHSh7ZsgxDtFePUTqe19vF73OVPl8R3Y+K8+LfelfCI=; b=HdbJkVhBTgzbTWVR1UDaQjZ2OB WYRmxWDe1adst6LJxtciCPu2XEKz996Siv6rpJXRW+KTelWD3E9jiaq4saUV7iJ12vmXaRe5fhHQZ l7nZKnpByJFz5efBMXFwaN78pXzA35IGhuLtpvV3q66ZXkwbySgyEOqGNVMcJChnxNqQ=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXg9e-00051F-9Q; Tue, 05 Oct 2021 10:50:33 +0200 From: Lars Ingebrigtsen To: Arthur Miller Subject: Re: bug#51026: 29.0.50; Edebug leaves data in symbols plist after instrumentation References: X-Now-Playing: Various's _I Wanna Be Kate: The Songs of Kate Bush_: "Coffee Homeground (2020 Remaster)" Date: Tue, 05 Oct 2021 10:50:29 +0200 In-Reply-To: (Arthur Miller's message of "Tue, 05 Oct 2021 10:20:14 +0200") Message-ID: <87pmsjam96.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Arthur Miller writes: > +(defun edebug--strip-plist (symbol) > + "Remove edebug related properties from SYMBOL's plist." > + (dolist (prop '(edebug edebug-behavior edebug-coverage > + edebug-form-spec edebug-freq-count > + [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51026 Cc: 51026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Arthur Miller writes: > +(defun edebug--strip-plist (symbol) > + "Remove edebug related properties from SYMBOL's plist." > + (dolist (prop '(edebug edebug-behavior edebug-coverage > + edebug-form-spec edebug-freq-count > + ghost-edebug)) > + (cl-remprop symbol prop))) This will break edebug -- edebug-form-spec is set when loading edebug.el, it's not something that happens when you instrument a function. I don't know about the other symbols. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 05 07:18:03 2021 Received: (at 51026) by debbugs.gnu.org; 5 Oct 2021 11:18:03 +0000 Received: from localhost ([127.0.0.1]:39198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXiSR-0002Tq-BX for submit@debbugs.gnu.org; Tue, 05 Oct 2021 07:18:03 -0400 Received: from mail-oln040092074082.outbound.protection.outlook.com ([40.92.74.82]:46145 helo=EUR04-DB3-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXiSO-0002TJ-Nq for 51026@debbugs.gnu.org; Tue, 05 Oct 2021 07:18:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Du00RXfW2g25Lauk2Fmav70tT8LYbUHfgBuJ96lau79L+967GhixbKUnwFx9MwsIasMeIOoTnpT6UJCUMvfjGnK6K6Zpt4bS2+/Mli5mhgCLHFuhr6B/qCTassuM3a4/f17sq9wQ7lGGTgTx9qv+PXMdaFmmjRxpMGdZ2oqLwYKc61U6EAj3BUOfdIYB1casnHKjXGxPa+mTvC4o/3JONXw/zMzivBG5qU+dSicE7SMn4F3ZleLYXL/5MKCAnejv/BteExStaVXb9S5tu5nojKG0nGoEC8km7gqukrO1kmsBMKwlUQxmnThZkDnnyz/q1DpzmfpTrGhuv9YIYgg+yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XU0BUjy0QrFoMmDJ0xDEpb5DF/McBBgZfYvGY4sfc0s=; b=SnzWPU4KoP+lQn7NMKUEoDWkIRevobAnr2/JUDmq40Vue5ZJtcZNHha/9YPsh4WvwX/ewTcJgCxmC3+SiUrpAp3XBNFIsG6f8BQIaH2YRbylYYDUzTxoalyBzjU4YuaRa8GZM3CEVoCf5t5/xnHj9OUGqyff/AkM+h+LP8VAie+suk0jQbbAey0ohudxZ/Tv6BwPQSqlRvUYg5CchgRTuwfsQTsvP6/5JUEGtlNn/STvmboAcDKjZpGkvaJIqtUh0BPhbAIOs5IThHwYaeuNszBL8QvBzEv+6SzJIK78u1Df0s0sS2xrQvfDvG3KqpdL23I4ODCEAgc+4CYoxFHmrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XU0BUjy0QrFoMmDJ0xDEpb5DF/McBBgZfYvGY4sfc0s=; b=c1/GQE/3HxfJ4n8fTCNf53CldVFqkrkuv3yn4NRjYT4KOfnyGmOap8KJ7vaUGS3ep7d9NiFBppi2yag7lHFkxGe0ZUGfMjSBNLvUOMKdzFHaUQJiS0uPPYkjHLuBOEtMySTGIRxNxwemIcf95BWMsw9XMM9itZWUo745T1p9dcfzOhzqV0LZTtEVkqWn7HXQ6FY751imp0O7dIAbwntPjEtV3Ibql/G8KuIpfh+XW/mVpQqwiGt6gBCQsgbIPo041feZ57LYWjw0yMp9zzWlKpX/4lgkRcn2ehGClqMcvSFQ9qClgSsn0aUTwdsBRIA7ozcYqL5SyCjwKo6tEN/1sQ== Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM0PR09MB4434.eurprd09.prod.outlook.com (2603:10a6:20b:16f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Tue, 5 Oct 2021 11:17:50 +0000 Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2%9]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 11:17:50 +0000 From: Arthur Miller To: Lars Ingebrigtsen Subject: Re: bug#51026: 29.0.50; Edebug leaves data in symbols plist after instrumentation References: <87pmsjam96.fsf@gnus.org> Date: Tue, 05 Oct 2021 13:17:48 +0200 In-Reply-To: <87pmsjam96.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 05 Oct 2021 10:50:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [oyz4u7EM9aFc+FiM2qsu9BTGNdx5F2U/] X-ClientProxiedBy: HE1PR05CA0208.eurprd05.prod.outlook.com (2603:10a6:3:f9::32) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87ee8zvhyb.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pascal.homepc (81.232.177.30) by HE1PR05CA0208.eurprd05.prod.outlook.com (2603:10a6:3:f9::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 11:17:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e4380af-7594-43ba-0573-08d987f1c420 X-MS-TrafficTypeDiagnostic: AM0PR09MB4434: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4zH4ybEwkGHRxGvHw0BbBOi4LxG7W6QWzS2eB4Fx1J+AG0MANsJmcwdpoDbVHv32etj93ZcNdQ8P2nh+RWCRLoE1aflnKBfXIV+i2zSPtqFJDfMYRyQST3UbPjTgEO38qQ1UN85UyOaPO3GAMm8JkbNFAJzPAgZWfE0YB0QK7hS7VHYCRTOoYH44rKXJ6EOQ+AVor1X8HrBiEGa3vCtnjdgqcSzFJf+xkrNP/+mYBYzHDkN2RHf9wRkYnSqvZxoK8OUR2HDGogYtm5GpJ01jVN9Uv4AxVLtSYxk2swL4mZ13fq4sPJoX9kSgVi4kEXMPVa3nYqP8HzrSyfzoRP5AbEnlFHtry4paCLkqeOOcYZGtWk0C3BKkAFou7Or/6fSvXzB6IyzexwXMzk93lhGvMvSqi9tNY+PDWysLxdFTZO7M2ZlXAlMV9Et1kjRvA5Jf X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 33wYiHJcJ3YgZYKJTEKgR2xOG5JV/d7YZI6F8eE6vtgKzcbZBfPKMMT8Xr9OKHts+wjZp7+wz6Y4oZ163S7wOCWwOqCQ+eIYBx+ikodqZAIfbRu2B6N4MqkMa0f9yGxIxB1YM5mihSsrJN7qJxLbKw== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 6e4380af-7594-43ba-0573-08d987f1c420 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 11:17:50.6554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB4434 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51026 Cc: 51026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Arthur Miller writes: > >> +(defun edebug--strip-plist (symbol) >> + "Remove edebug related properties from SYMBOL's plist." >> + (dolist (prop '(edebug edebug-behavior edebug-coverage >> + edebug-form-spec edebug-freq-count >> + ghost-edebug)) >> + (cl-remprop symbol prop))) > > This will break edebug -- edebug-form-spec is set when loading > edebug.el, it's not something that happens when you instrument a > function. Ahh that pcase in the niddle of nowhere; what does it do there? Why is it not in some "init" function? :-) Yes, it is true what you say, but only for a handful of symbols, not even all of those handled in that pcase. I think it is emitted only for let, let*, setq and quote, but it is not important. See attached patch, if it is acceptable. It will check if a symbol is one of those specially treated and do nothing for those. I think that is what you mean? I don't see any other place that adds properties and I don't see any edebug properties in "random" symbols unless instrumented. > I don't know about the other symbols. That seems to be the only one added automatically. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Clean-edebug-props-on-instrumentation-removal.patch >From 508dea329d8ef389b6b07d6339faf753d746ff16 Mon Sep 17 00:00:00 2001 From: Arthur Miller Date: Tue, 5 Oct 2021 13:07:07 +0200 Subject: [PATCH] Clean edebug props on instrumentation removal * lisp/emacs-lisp/edebug.el (edebug--strip-plist): New function. (edebug-remove-instrumentation): Added call to 'edebug--strip-plist'. --- lisp/emacs-lisp/edebug.el | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index a38c8bd5ca..97869a2bb9 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -4529,6 +4529,15 @@ edebug--unwrap*-symbol-function (was-macro `(macro . ,unwrapped)) (t unwrapped)))))) +(defun edebug--strip-plist (symbol) + "Remove edebug related properties from SYMBOL's plist." + (unless (memq symbol '(quote defvar defconst defun defmacro function + let let* setq cond condition-case \` \, \,@)) + (dolist (prop '(edebug edebug-behavior edebug-coverage + edebug-form-spec edebug-freq-count + ghost-edebug)) + (cl-remprop symbol prop)))) + (defun edebug-remove-instrumentation (functions) "Remove Edebug instrumentation from FUNCTIONS. Interactively, the user is prompted for the function to remove @@ -4560,6 +4569,7 @@ edebug-remove-instrumentation (dolist (symbol functions) (when-let ((unwrapped (edebug--unwrap*-symbol-function symbol))) + (edebug--strip-plist symbol) (defalias symbol unwrapped))) (message "Removed edebug instrumentation from %s" (mapconcat #'symbol-name functions ", "))) -- 2.33.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 06 04:54:37 2021 Received: (at 51026) by debbugs.gnu.org; 6 Oct 2021 08:54:37 +0000 Received: from localhost ([127.0.0.1]:42485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY2hB-00045u-0h for submit@debbugs.gnu.org; Wed, 06 Oct 2021 04:54:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY2h8-00045h-FD for 51026@debbugs.gnu.org; Wed, 06 Oct 2021 04:54:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IeKNofLa/xXUHlbG5zEpI5XLrpHJOo/aAPbGNkYcc3c=; b=JPdpxvn0EwG1nMQmv1L4kxZYpo 2EYiouaQh7/+7AD2sBoycdlgCUjZrWjVZjkwCU1Qv4NbSyOhYk16vTZy7NtX71n0LfDQp6xatPj3F 4KbxX68Q+J8E0jmfauFPrNScxOE55iLXv9wAXSjnJe2pEgwO4wqNA11QVH5SNpvjlcOI=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY2h0-00009G-56; Wed, 06 Oct 2021 10:54:28 +0200 From: Lars Ingebrigtsen To: Arthur Miller Subject: Re: bug#51026: 29.0.50; Edebug leaves data in symbols plist after instrumentation References: <87pmsjam96.fsf@gnus.org> X-Now-Playing: DJ Screw's _All Work, No Play_: "DJ Screw Lil Keke Fat Pat Herschelwood Hardheadz CD LP s feat Lil Keke Fat Pat Herschelwo" Date: Wed, 06 Oct 2021 10:54:25 +0200 In-Reply-To: (Arthur Miller's message of "Tue, 05 Oct 2021 13:17:48 +0200") Message-ID: <87k0iqfs8u.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Arthur Miller writes: > Yes, it is true what you say, but only for a handful of symbols, not > even all of those handled in that pcase. I think it is emitted only > for let, let*, setq and quote, but it is not important. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51026 Cc: 51026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Arthur Miller writes: > Yes, it is true what you say, but only for a handful of symbols, not > even all of those handled in that pcase. I think it is emitted only > for let, let*, setq and quote, but it is not important. No, `edebug-form-spec' is added to symbols by the (declare (debug ...)) form, and should never be removed from any symbols. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 06 09:06:22 2021 Received: (at 51026) by debbugs.gnu.org; 6 Oct 2021 13:06:22 +0000 Received: from localhost ([127.0.0.1]:42949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY6co-0007I9-4q for submit@debbugs.gnu.org; Wed, 06 Oct 2021 09:06:22 -0400 Received: from mail-oln040092071104.outbound.protection.outlook.com ([40.92.71.104]:17094 helo=EUR03-DB5-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY6ch-0007Ho-Vg for 51026@debbugs.gnu.org; Wed, 06 Oct 2021 09:06:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5uQrItdrMUHTJJ5AVqeh8F/+z/YVwoIv/0knT71hy2IG2+8bGeWH/8jZ0WC+s+NOfoOeSa5XA3V3ypXGNLi45WdU+//D4ub7q2/ypvb9a5OsnDQ18yZL6VSEeG5EHKZxkBrloc6M9hKtnpBBS17rDRu608zTGyT2VBJOio2OKFns7Xx+K1qGLOOBFYML0sVN1MxUv9b/tYj3t89wuT50i9ZRHd8m7dYD5Q719Q7kK+Fs+jkCWYgOSFLRCZSwpYMF4ArEp3RkYDh+rJyYAyOVA/+LuSdhWGTXNUmRHv5sv0feVXGIs3LsXhfc4dTINM93ixdKQ2bfW+lu+DuFq/N8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sOKw4SkzYFNI+Rig3seBplXDlacDYdyhN0rwXiYVBVs=; b=mKZ3O3JOgdk0X8khvpuSXQtzsUgpwNnPvdF0xRYNX6wtRB0OorUmNxyPc9ar8HRwGQfUz7w1U7lgWTAUsB2TMs5qZM/zCJ7OdokeJtXOFGHcJxc6FtQ/5KTOEMT6u8aZr/HNjU45LLsIRcaBCvfa/HKk6ZOB+eQ7KzujcdeFmmP3XanORGhR3aQao8/NbTPxhJZlEIItv1eJAG/f+cM3Oc3JoAdv1FpS+0uhWEbC2bol1Rz3pVISpM7FkLUfrL2Wx++K43eCKvwvOLBXxugaeCyIMhFLrAQ/4JNBoRvjk+oQdK21tAGkBPt3Uecoe3omDfWtrpyzSU2jJdvHf2pTfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sOKw4SkzYFNI+Rig3seBplXDlacDYdyhN0rwXiYVBVs=; b=Bg2GVF/oD6Ukyr45P2Xek6GEnZQ6rbPvPJC+dbqikoUWu/OWsAnhiVEeO9qiWTpYeNmY70wAvh1lsZMmJmfhIzzNSWpsFCr68y/dAPZmZT3t6ezq3wndp/aTyU3/pmwmjnNk6ZCqoCFlb/oeLPbdjHGIPv88SyTCpg9U15wa6kB1vAA/CKdNNlqvf1h/dbypMj8oHJyPEw1gNeNXJyNZE86YqTezNoEA07IN4LuErIpWkFIH1gwdDG1ICpE3w69/Ua+z24Hd3+EM1FOP35RvNcd8ZqY0XZ3ExX5bsyzQLdyR5brNuW+mgJQjCkXeNXshFZDCBRFzlDFyl6dIakwsng== Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM9PR09MB4546.eurprd09.prod.outlook.com (2603:10a6:20b:280::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Wed, 6 Oct 2021 13:06:09 +0000 Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2%9]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021 13:06:09 +0000 From: Arthur Miller To: Lars Ingebrigtsen Subject: Re: bug#51026: 29.0.50; Edebug leaves data in symbols plist after instrumentation References: <87pmsjam96.fsf@gnus.org> <87k0iqfs8u.fsf@gnus.org> Date: Wed, 06 Oct 2021 15:06:07 +0200 In-Reply-To: <87k0iqfs8u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 06 Oct 2021 10:54:25 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [obEIcw0NVQxReuJ3rU76/qrG6gNneruQ] X-ClientProxiedBy: HE1PR0902CA0024.eurprd09.prod.outlook.com (2603:10a6:3:e5::34) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87ee8ywbeo.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pascal.homepc (81.232.177.30) by HE1PR0902CA0024.eurprd09.prod.outlook.com (2603:10a6:3:e5::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Wed, 6 Oct 2021 13:06:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e33c6cba-44d2-48f8-a0e0-08d988ca1075 X-MS-TrafficTypeDiagnostic: AM9PR09MB4546: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uZ4QyWTeRJxwHzCcA8Zgs8p7r4IhinLot72ZyePc5sqibySIy3PClRSZ9OVOlq1CWhHhcgoQLjcANBGhQ3VucLzx8AbENZsH3zfn4IF4LjFOma9xq88nitkY8dIYjAxSDrO289G+MtB4P77HOixeHsPKxsgeP3MG7lZvuQJH6NoRmL7ZuM6GqS56To04KrLHlD+fDb04xEYO9MVOB3tMhFg96QxvBGvzJRFOxf0Nh+0aJswHiT+gF37oXHfhbazoMtnUVZ3PApIWv6BgGoN/DgK2B2GuuBSYiKMfG5nchvtKCoHNVkEiCcpvvKaHV2NqWXvrZo4ivIoJ3uTr9qnc+OZ798Hh6bWCDTFOUD+Tqh3B5s6r7dKuXBbMK7nNqSG7uB3OsdVYHDTNFDouHm97Kf2StCd4tLBJV3RLdxfgE+sEYD3H00iKPuXWU/HjZkJQ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IOgxe05ru+UOUdek7eOTv8khwFFp4kF1I5S9PCveqRx0CuYtcEcOB/GdGkdulzMPN4EGHDOAVZJKoaylKR9Tl9A340KvJqaywS95pTKnM+335HHzAGw7gFyj1pkDHrHztlAL1H1U32D6PLwQxx1GHw== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: e33c6cba-44d2-48f8-a0e0-08d988ca1075 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 13:06:09.4434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR09MB4546 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51026 Cc: 51026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Arthur Miller writes: > >> Yes, it is true what you say, but only for a handful of symbols, not >> even all of those handled in that pcase. I think it is emitted only >> for let, let*, setq and quote, but it is not important. > > No, `edebug-form-spec' is added to symbols by the (declare (debug ...)) > form, and should never be removed from any symbols. Yes, but as I have tested, the previously mentioned pcase-dolist, line 2075 in edebug.el is what get's the action going when edebug is loaded. 'declare' just marks stuff, it does not really do anything on it's own. For some speical forms that property seems to be added via gv.el (let, quote, etc ?), and for some (defun and defmacro), it is tested and done in pcase-dolist itself, since they are no longer special forms but macros. I have tested to remove that property and exec that pcase-dolist, and the property was back as expected. I don't know, I can be wrong too; there is a bit of interaction going on between all this function vars and alists and what "real" function gets executed when edebug starts, so sorry if I am getting it a bit wrong. Anyway, since there can be other special forms and stuff added over time, the static list won't do. The obvious is just to leave that property alone and remove the rest of leftover stuff. It can be quite a lot of data in some cases, in 'edebug-coverage' vector, as I have seen while tested. Since it will be referenced in symbol's plist, it won't get garbage collected either. Also this patch does just the half the job. It removes leftovers only if 'edebug-remove-instrumentation' is called. If eval-defun is called with C-u prefix, but with both 'edebug-all-defs' and 'edebug-all-forms' set to nil, it will "uninstrument" original function, but it does not seem to call 'edebug-remove-instrumentation', so all the leftovers will be left. I haven't looked at that part since I am using 'edebug-remove-instrumentation' in my own code. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Clean-edebug-props-on-instrumentation-removal.patch >From 94016b063faf3f69cf03d7ffa3eac1a15bad34c8 Mon Sep 17 00:00:00 2001 From: Arthur Miller Date: Wed, 6 Oct 2021 14:16:21 +0200 Subject: [PATCH] Clean edebug props on instrumentation removal * lisp/emacs-lisp/edebug.el (edebug--strip-plist): New function. (edebug-remove-instrumentation): Added call to 'edebug--strip-plist'. --- lisp/emacs-lisp/edebug.el | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index a38c8bd5ca..2489680bcb 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -4529,6 +4529,12 @@ edebug--unwrap*-symbol-function (was-macro `(macro . ,unwrapped)) (t unwrapped)))))) +(defun edebug--strip-plist (symbol) + "Remove edebug related properties from plist for SYMBOL." + (dolist (prop '(edebug edebug-behavior edebug-coverage + edebug-freq-count ghost-edebug)) + (cl-remprop symbol prop))) + (defun edebug-remove-instrumentation (functions) "Remove Edebug instrumentation from FUNCTIONS. Interactively, the user is prompted for the function to remove @@ -4560,6 +4566,7 @@ edebug-remove-instrumentation (dolist (symbol functions) (when-let ((unwrapped (edebug--unwrap*-symbol-function symbol))) + (edebug--strip-plist symbol) (defalias symbol unwrapped))) (message "Removed edebug instrumentation from %s" (mapconcat #'symbol-name functions ", "))) -- 2.33.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 06:38:38 2022 Received: (at 51026) by debbugs.gnu.org; 12 Sep 2022 10:38:38 +0000 Received: from localhost ([127.0.0.1]:44225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgpp-0007sm-TV for submit@debbugs.gnu.org; Mon, 12 Sep 2022 06:38:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgpn-0007sI-TB for 51026@debbugs.gnu.org; Mon, 12 Sep 2022 06:38:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NsSHaZ89tV3LHpCWGDNVO2FegJ707W+lhChcQdR/w3I=; b=uJLRQDCi2x10FyDsA8TVyoF+c6 LdnALsyhzkt5dfAJrqsa17XyMDTZ2do9GzUMDTc82wRIa/Vlx9ta3NX7UxggCl1w/NxJESMIOmJUY yntQBXpnpmsR6ui8behY2A4MBO5EwHmXX3bk9ZHtDAKGHgv9TGI5wG/SfNpiYuQtpX64=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXgpf-0005J4-05; Mon, 12 Sep 2022 12:38:30 +0200 From: Lars Ingebrigtsen To: Arthur Miller Subject: Re: bug#51026: 29.0.50; Edebug leaves data in symbols plist after instrumentation In-Reply-To: (Arthur Miller's message of "Wed, 06 Oct 2021 15:06:07 +0200") References: <87pmsjam96.fsf@gnus.org> <87k0iqfs8u.fsf@gnus.org> X-Now-Playing: Django Django's _Django Django Meets The Professor_: "Wor" Date: Mon, 12 Sep 2022 12:38:26 +0200 Message-ID: <87a674andp.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Arthur Miller writes: > * lisp/emacs-lisp/edebug.el (edebug--strip-plist): New function. > (edebug-remove-instrumentation): Added call to 'edebug--strip-plist'. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51026 Cc: 51026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Arthur Miller writes: > * lisp/emacs-lisp/edebug.el (edebug--strip-plist): New function. > (edebug-remove-instrumentation): Added call to 'edebug--strip-plist'. Thanks; pushed to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 06:38:42 2022 Received: (at control) by debbugs.gnu.org; 12 Sep 2022 10:38:42 +0000 Received: from localhost ([127.0.0.1]:44228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgpu-0007t2-58 for submit@debbugs.gnu.org; Mon, 12 Sep 2022 06:38:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgps-0007sa-Ei for control@debbugs.gnu.org; Mon, 12 Sep 2022 06:38:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eaT9RLBqFPeOMREUwzdJ0+VfTL6d4UkPOwfP7bhhb50=; b=hRv98eM5nqBJWziVrdxxSVAM7V xVSJrfc+EP6F5eSFqh1oTpesyzouGDl/hAHStIFRPNYRcKp9Qx6gDrv+P9wlEOkg9S0UhfIRrNbU6 9GcCY58uRS+D5sWNhwtkKABrtEp3tsA4kgqMcSCFJwmr+57na+2cGyew6wemTGDWfgdY=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXgpk-0005JC-UH for control@debbugs.gnu.org; Mon, 12 Sep 2022 12:38:34 +0200 Date: Mon, 12 Sep 2022 12:38:32 +0200 Message-Id: <878rmoandj.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51026 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 51026 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 51026 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 10:16:09 2022 Received: (at 51026) by debbugs.gnu.org; 15 Sep 2022 14:16:09 +0000 Received: from localhost ([127.0.0.1]:58814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYpey-0000XY-O4 for submit@debbugs.gnu.org; Thu, 15 Sep 2022 10:16:08 -0400 Received: from mail-am7eur03olkn2097.outbound.protection.outlook.com ([40.92.59.97]:13024 helo=EUR03-AM7-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYpet-0000Wk-PM for 51026@debbugs.gnu.org; Thu, 15 Sep 2022 10:16:07 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mpv0fZHAaDuhZHFyor3fzouykm7BNG0gPY5tEBiYiJsqEXFEQdYAVYTNpwDoKYnBEw1d6BmO7oppxEe90VZnFw4gBU9UQUrEUDLjI/9ZqC85GCQzwkn4gxRLArGRidesh2RcetiklaUSyKXkogRDO4DNOgPa8y3pCWFjhWq/VwA5CFuU9q59ZdCeSXWVAc7OUJUvgdITM12e2XHKF37XpQXStgLSbll0ev2oFPvwG5PmZNXyuRVG/ZBJ0zZ4IYKSqvhyFKqRHwtjr1+4aEks90GUU+2d1t1aExoZ/gcvQXKsj8U0B6NqslpFB1Van1JLQEFS2Erk/wtZvjNTxbrIag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ixDbh8KLCLh9P61ynhO3Hws3OsWm9ymHgZh4KuyKCs4=; b=JkBmUV59qvLc/R11yWhq2ESI5u694emo2sO3uKxHu47vK6vCm/SVyms4NTtAmv0J1ORQEI6wbT9OhwasFDP9NnR3U+Nl8KBoiZxLSxmWmw+nO3w5dsuXZxbw+jZLzK9w7xHtg/8BqpOfzepWqpUG6aqDffkggKuPRMxZf2yDkb+hpJKqkrfD95Ims4siT6uPXLE/Q7yKwlGv42P2uH7tSvoC0236De6CQRlcImnamDXt0MvqB/uL5FEzyhixt3La4shrX+4d2f+orj9i5XI7t6yLH8TVD8aucxYjAYewjMMubfMND8zJ21Lb5xig8v5Wch6gIZYFizDR5JjnPmQMDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ixDbh8KLCLh9P61ynhO3Hws3OsWm9ymHgZh4KuyKCs4=; b=tubrQYSe9M5pIP631vdGtEov6CTvSgNY4doBvrwU1YYOnsKu3CybCE4uvyTR3+nmuYzCCsUGxQiuCMTA+UzAINwb4LdWyz9Xn9kGDkUlzVQ7A9W0BrPa5Gdcrp3rg5TEoYTXhkxLbKx3ZeAFfHqGRJWMUrknzS1iv1dn4+/20p1OAKBkVbBqiuDkb3LfmFYVniwrdJfPRceeGV51fc/09NIlA5ZTPx4E2NQ8s4tN/cuLA9BWZkQbOz9ck6oyLan0XJIfnc8o64uvwBiCNiE47JO2nk4dMm1NocgTO0jcEpCt4cFIwLwZ2v5dsdD9ouN/WfTrUnpGu8nwLErFXJhAPw== Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by DB8PR09MB3642.eurprd09.prod.outlook.com (2603:10a6:10:114::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15; Thu, 15 Sep 2022 14:15:54 +0000 Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::10cc:8884:c6d8:a23d]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::10cc:8884:c6d8:a23d%6]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 14:15:54 +0000 From: Arthur Miller To: Lars Ingebrigtsen Subject: Re: bug#51026: 29.0.50; Edebug leaves data in symbols plist after instrumentation In-Reply-To: <87a674andp.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 12 Sep 2022 12:38:26 +0200") References: <87pmsjam96.fsf@gnus.org> <87k0iqfs8u.fsf@gnus.org> <87a674andp.fsf@gnus.org> Date: Thu, 15 Sep 2022 16:15:51 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Content-Type: text/plain X-TMN: [zHwnGkFbGsrJ7wq2Ix3P9h7zdjBPA7LF] X-ClientProxiedBy: GV3P280CA0012.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:b::23) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87edwczpt4.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR09MB4977:EE_|DB8PR09MB3642:EE_ X-MS-Office365-Filtering-Correlation-Id: 5eb9cb76-d596-4181-8db9-08da9724ccf3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6q1ufHz4VybxGem314w0FKBOlxi/7jV1KynKCiepbPke+uGvRn0tXYaDXEFcQJjnTs61TNWzK15bWg/+id43j4P5Bx3zIN71WVCYuwhojroKo1gthW4W7Av+LzL0By5tnDWh1Ul6+8jycgsLxihjfB6ozyGh22+YwIHGaj6oNb5l5w/Ix5Il9UxgCf9I14oNfoLaLR898MsOJY2Jc5GnfQeMn8+wqwKvRbsNKpRqn2nkUd6fLLyoC+8yRKFtudnRDCEenHG4BzP4YAZHIGVbFFrswTZZuGTSxiHotubSxCegMBAlYQ5ZmIZu3wcItw2Y+VFsgiLyxnPVro7QL15vvqYWLpK45jbEssHi/ocAfcPikJMAipnBvDw4c8U2I0KW4bzWj8dlWbAQ4j4csQZMMxHQxJykDH49JSmNVl2LKJkR3De8Bc23vPMsabUvcGBuXHsoGJfM0K5SrT4E6SlkwQq4w09uMIHdR3Fe0rQtYT4m6UYFzOpqhvqDgAxETyBTs1SOXoTjrR1/BVti6MGpDaHs1lLUjXzc4qxlnwxSOEf9pZ9TmZr7SxC6QTH3hN1s0Y2UN/YMEVjfmhph/rx9l4331Sk5MTl4AAWBaJYkcSuf5mQPTvXBYQJdLDmCkxBZz249bzr4LU+c0sLLvDfjQGFEk38c7qLgMnQf41jtFVkH67g1Fl0zzo2ey9D0AThp X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L/yzIW+AUlbKyhIw0QxirMyEPJzp2nLIlbBAWpb2fwmhJsZuKVPpIyXGXXRv?= =?us-ascii?Q?EnlKorrTeP9+2gTlZFEqhGuuzZpFhjPoFlf3P7dnbK5NBUaxoRU4k0BViWyA?= =?us-ascii?Q?oQJvZw63hJs05ZBkmNOITLtPQMDeZOCKSbJ0nYH2qnag6nH2+5DdEtRGugyZ?= =?us-ascii?Q?alm+mOyGsj/Y0A8kTmD2O7StjF/yJOlzRrpF/bcECwVkR+fsuxgT/vNFzbEA?= =?us-ascii?Q?EWIl0FcTH410upni6DB+4XeGBYCwCfqDMSx8NukhPQdZCRcBRzU0K5rWjrGH?= =?us-ascii?Q?d+KesJculnoX1+DFH2F12SjiR7bTvkNDn7US4LR9qUW1AxNH1GWEef2cf7bN?= =?us-ascii?Q?MJN5ehc2grJUq0/s3H3zQahsKQDPjG1AwkTy6pkQWovwTM8AQEuFylCEoeVa?= =?us-ascii?Q?i24qGp0PvKNCvthaQheIcQ4fGRgCbSkG6SsgZ6H6mS0pwHQsYd6qZBYCuivu?= =?us-ascii?Q?t43g0Ir5TgG7vBiU1xPyaN2mOfLw3ZCTeKYMAR8d3xDZgIcg+qKMpU91rXjC?= =?us-ascii?Q?YVGdiu2rof/O91wXvoGcTzctGRN8ittGnd706wcVenzHJQ3UFT8AGf6/KKtk?= =?us-ascii?Q?j+IBOM0jKqrsJPYf33LTj5g2g2OoOPErOkU5NJtvKptKOEQn+omlrn6vtWOU?= =?us-ascii?Q?hIKQzTKhhT2MmGyKzhzFd+1rKphHDZALdldrhnG6XgwcPgw5Rz+RA9inSYya?= =?us-ascii?Q?hDC5FNn6dCSkJbnNRLUR6Q5KP/iQk7msKczsQZky9xWzQTzX04R12vLleDUe?= =?us-ascii?Q?ZlSikwqKht6waXJYIykhps8lHuPKVpl+vfdV9MDB6z47iT9kpEhvZ9hMoJCY?= =?us-ascii?Q?TZjyZuIPDm9W/rOasOZvvOjYs1xL3zEjmnAR0l81712gFhRmEaMB5uyy5OyD?= =?us-ascii?Q?0CUNFrpguzi9eWIWCvMILOxnr7/tZ1z4cn/MDQbpR5fstW8IE43npbvtcbLk?= =?us-ascii?Q?PPU77XNa+/15O0ENPgrfrAoWs1fHCBjWturPTOtSnHSMXr1pRynTES1cL3QN?= =?us-ascii?Q?FV5xjQFtbzgV5C7hem9azwX4Ei7IQS7Lg++dYzwh66i+sEJcpUBqs6kGyvpt?= =?us-ascii?Q?77z9AK3Jz+6YkkwRzs4P45mo+73yqeGd02h/OmHf3idsDVDJck+YJbMlY1Yy?= =?us-ascii?Q?tqUSCZxp62yH7CC1qmlGoqQ1SLhLDxLsCCCF8p1yM79GgRQbadI8HtFxtgkw?= =?us-ascii?Q?P3MFzl6Xm5uDevbM6uCr6Pywcdw1alOp2A37WI8++Z9AX6qc6e/Z2q/iCZwy?= =?us-ascii?Q?FLSghDqq2Cig+3/qy56PLzeXamSNUhYW8X5RKXdpfw=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-64da6.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5eb9cb76-d596-4181-8db9-08da9724ccf3 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 14:15:54.3694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR09MB3642 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51026 Cc: 51026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Arthur Miller writes: > >> * lisp/emacs-lisp/edebug.el (edebug--strip-plist): New function. >> (edebug-remove-instrumentation): Added call to 'edebug--strip-plist'. > > Thanks; pushed to Emacs 29. Are you sure about that one? You said in the conversaion at the time that those (or some) symbols should not be stripped, i.e. that the idea there wasn't correct. Please check twice, I don't want to introduce bugs into Emacs :). From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 05:42:43 2022 Received: (at 51026) by debbugs.gnu.org; 16 Sep 2022 09:42:43 +0000 Received: from localhost ([127.0.0.1]:41682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ7rv-0006uq-EQ for submit@debbugs.gnu.org; Fri, 16 Sep 2022 05:42:43 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ7rt-0006ub-5f for 51026@debbugs.gnu.org; Fri, 16 Sep 2022 05:42:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lQbp46HRC1yfwJ/IEUfttR6eqj8/Ff/8z8wypeZ7IXA=; b=r/fafAG2UWXjAFjYoWLPyUM4B4 LyYB3TS+ybOmAmXAwxIUZQZNvH6NFzhTjR4vNRBO+sfdyqGHYLZzLHWwN6j6Y/ZlK8dPMlwD9XUsg ATh1n02lImKaJj/nA3Txay8POqDZLDt56kEhvnVoZh0WpmdyY/yGUoTMwVg9OGNhfjx8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ7rl-0002jh-4n; Fri, 16 Sep 2022 11:42:35 +0200 From: Lars Ingebrigtsen To: Arthur Miller Subject: Re: bug#51026: 29.0.50; Edebug leaves data in symbols plist after instrumentation In-Reply-To: (Arthur Miller's message of "Thu, 15 Sep 2022 16:15:51 +0200") References: <87pmsjam96.fsf@gnus.org> <87k0iqfs8u.fsf@gnus.org> <87a674andp.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEU2LCuzkVj////D FCTDAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+YJEAkFHUBgxMIA AACjSURBVCjPvdHBDoMwCABQmsi9S+R/2sPuLIH//xUBraXLtuNIPLyCBRSAGLDBFXw9HsVPd0ix ZZSvgAb/iDn1O5YB9gzhnMmvPHLZsg5+xNJPBcp9MxnkhpaegKIDT9UfoIGuygkCCTzRDHNQGyEh /eDqGI2q7YzqYWkqA74lGRqfa3j9ZhXR2t4PoOdI40MwdDt92QQGAb+tRwq1R696Lu8FB9XeINDC 9y8+AAAAWmVYSWZNTQAqAAAACAAFARIAAwAAAAEAAQAAARoABQAAAAEAAABKARsABQAAAAEAAABS ASgAAwAAAAEAAgAAAhMAAwAAAAEAAQAAAAAAAAAAAEgAAAABAAAASAAAAAEfUvc0AAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIyLTA5LTE2VDA5OjA1OjI5KzAwOjAwnrkTCgAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMi0wOS0xNlQwOTowNToyOSswMDowMO/kq7YAAAAXdEVYdGV4aWY6WUNiQ3JQb3NpdGlv bmluZwAxrA+AYwAAAABJRU5ErkJggg== X-Now-Playing: Sly Stone's _I'm Just Like You: Sly's Stone Flower 1969-1970_: "Spirit" Date: Fri, 16 Sep 2022 11:42:32 +0200 Message-ID: <87illny7sn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Arthur Miller writes: > Are you sure about that one? You said in the conversaion at the time > that those (or some) symbols should not be stripped, i.e. that the > idea there wasn't correct. Please check twice, I don't wan [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51026 Cc: 51026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Arthur Miller writes: > Are you sure about that one? You said in the conversaion at the time > that those (or some) symbols should not be stripped, i.e. that the > idea there wasn't correct. Please check twice, I don't want to > introduce bugs into Emacs :). I had a look at the symbol-plist elements that we remove here, and it looked OK to me. (But I might be mistaken, of course.) From unknown Tue Jun 17 01:48:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Oct 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator