GNU bug report logs - #50993
29.0.50; Problems when dragging the mouse over the toolbar

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: luangruo <at> yahoo.com, 50993 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: bug#50993: 29.0.50; Problems when dragging the mouse over the toolbar
Date: Tue, 12 Oct 2021 17:01:51 +0300

> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, Eli Zaretskii <eliz <at> gnu.org>,
>  50993 <at> debbugs.gnu.org
> From: martin rudalics <rudalics <at> gmx.at>
> Date: Tue, 12 Oct 2021 10:12:01 +0200
> 
>  >> diff --git a/src/keyboard.c b/src/keyboard.c
>  >> index bc6f97586d..ba625c4f77 100644
>  >> --- a/src/keyboard.c
>  >> +++ b/src/keyboard.c
>  >> @@ -5122,7 +5122,8 @@ make_lispy_position (struct frame *f, Lisp_Object x, Lisp_Object y,
>  >>   #endif
>  >>         )
>  >>       {
>  >> -      posn = EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar;
>  >> +      if (NILP (track_mouse))
>  >> +	posn = EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar;
>  >>         /* Kludge alert: for mouse events on the tab bar and tool bar,
>  >>   	 keyboard.c wants the frame, not the special-purpose window
>  >>   	 we use to display those, and it wants frame-relative
>  >
>  > This seems to work.
> 
> If nobody objects I'll push this to Emacs 28 in the next days.

Rationale?  It means no mouse movement on the tool bar or tab bar will
ever be reported as such.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.