From unknown Fri Aug 15 02:05:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#50944 <50944@debbugs.gnu.org> To: bug#50944 <50944@debbugs.gnu.org> Subject: Status: malformed :safe entry in several defcustoms Reply-To: bug#50944 <50944@debbugs.gnu.org> Date: Fri, 15 Aug 2025 09:05:16 +0000 retitle 50944 malformed :safe entry in several defcustoms reassign 50944 emacs submitter 50944 Glenn Morris severity 50944 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 01 11:42:06 2021 Received: (at submit) by debbugs.gnu.org; 1 Oct 2021 15:42:06 +0000 Received: from localhost ([127.0.0.1]:57159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWKfm-0001Z8-8R for submit@debbugs.gnu.org; Fri, 01 Oct 2021 11:42:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWKfj-0001Ye-IF for submit@debbugs.gnu.org; Fri, 01 Oct 2021 11:42:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43134) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWKfe-0005gX-6j for submit@debbugs.gnu.org; Fri, 01 Oct 2021 11:41:58 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mWKfd-0006qC-0g; Fri, 01 Oct 2021 11:41:57 -0400 From: Glenn Morris To: submit@debbugs.gnu.org Subject: malformed :safe entry in several defcustoms Date: Fri, 01 Oct 2021 11:41:56 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Package: emacs Version: 28.0.60 Around 30 defcustoms (mostly in Org) state ":safe t", which is incorrect. The safe-local-variable property should be a predicate function of one argument. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 02 14:01:43 2021 Received: (at control) by debbugs.gnu.org; 2 Oct 2021 18:01:43 +0000 Received: from localhost ([127.0.0.1]:60527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWjKR-0004KM-Ap for submit@debbugs.gnu.org; Sat, 02 Oct 2021 14:01:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWjKP-0004K6-6j for control@debbugs.gnu.org; Sat, 02 Oct 2021 14:01:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58138) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWjKJ-0001eW-T0 for control@debbugs.gnu.org; Sat, 02 Oct 2021 14:01:35 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mWjKJ-0004VZ-JZ for control@debbugs.gnu.org; Sat, 02 Oct 2021 14:01:35 -0400 Subject: control message for bug 50944 To: X-Mailer: mail (GNU Mailutils 3.4) Message-Id: From: Glenn Morris Date: Sat, 02 Oct 2021 14:01:35 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) # f9111d8784, 62d6cecfcd, 4341e79a5f close 50944 28.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 02 16:01:51 2021 Received: (at 50944) by debbugs.gnu.org; 2 Oct 2021 20:01:51 +0000 Received: from localhost ([127.0.0.1]:60640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWlCh-0001DX-0A for submit@debbugs.gnu.org; Sat, 02 Oct 2021 16:01:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWlCf-0001DK-FL for 50944@debbugs.gnu.org; Sat, 02 Oct 2021 16:01:49 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F1A79806C6; Sat, 2 Oct 2021 16:01:43 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D4FE480580; Sat, 2 Oct 2021 16:01:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1633204902; bh=ICFFgbzii4Ia4XCkrx21ZerVXF4Ir+HHvUnbGxWGXAc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YxrQrheWdS5ufSdYOcH/qmiDKYhl/uoe00M1QUvXCUAl0JFSA+zwclhtfEEy3Ih+e euReFaHTDUsjkNJAb6weEghh7AmQ6BGJckiKhXNMcwjxPK5Sv/lPRbAW7k+hrgmd4p he6mkxpLATZby989W+oLe65T321zDMerNv7n+69Ztd20axxUddL5bJeuK/FvpkJPr3 MdTxKXX1wBPkDQ7qRJIKbQDujp5bXpxAr31okFeXMzexyPZgrNM5j+7MdiksNyIYCw 9f/i85WlHkWF8RtwHoLDqbKILNxdC+9TVG/8Wp59ZHWd3HbiNFS+Q6y6ZMrwBA/kWF OPKoc6KASMknQ== Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B33621202BB; Sat, 2 Oct 2021 16:01:42 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#50944: malformed :safe entry in several defcustoms Message-ID: References: Date: Sat, 02 Oct 2021 16:01:41 -0400 In-Reply-To: (Glenn Morris's message of "Fri, 01 Oct 2021 11:41:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50944 Cc: 50944@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Around 30 defcustoms (mostly in Org) state ":safe t", which is incorrect. > The safe-local-variable property should be a predicate function of one > argument. The secondary bug here is that those errors should be flagged with a warning. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 03 19:52:54 2021 Received: (at 50944) by debbugs.gnu.org; 3 Oct 2021 23:52:54 +0000 Received: from localhost ([127.0.0.1]:35110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXBHq-0000kf-5K for submit@debbugs.gnu.org; Sun, 03 Oct 2021 19:52:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXBHn-0000kQ-Ts for 50944@debbugs.gnu.org; Sun, 03 Oct 2021 19:52:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59454) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXBHi-0001tB-Lp; Sun, 03 Oct 2021 19:52:46 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mXBHh-0007u7-94; Sun, 03 Oct 2021 19:52:45 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#50944: malformed :safe entry in several defcustoms References: X-Spook: pipeline remailers DNDO Sarin Jasmine CONUS Abbas Al X-Ran: ,e)QW*^+?P|U (Stefan Monnier's message of "Sat, 02 Oct 2021 16:01:41 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50944 Cc: 50944@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier wrote: >> Around 30 defcustoms (mostly in Org) state ":safe t", which is incorrect. >> The safe-local-variable property should be a predicate function of one >> argument. > > The secondary bug here is that those errors should be flagged with > a warning. Run-time warning seems easy: --- a/lisp/files.el +++ b/lisp/files.el @@ -4042,7 +4042,7 @@ It is safe if any of these conditions are met: evaluates to a non-nil value with VAL as an argument." (or (member (cons sym val) safe-local-variable-values) (let ((safep (get sym 'safe-local-variable))) - (and (functionp safep) + (and safep ;; If the function signals an error, that means it ;; can't assure us that the value is safe. (with-demoted-errors (funcall safep val)))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 04 05:32:52 2021 Received: (at 50944) by debbugs.gnu.org; 4 Oct 2021 09:32:52 +0000 Received: from localhost ([127.0.0.1]:35700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXKL5-0005NH-Od for submit@debbugs.gnu.org; Mon, 04 Oct 2021 05:32:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXKKu-0005BD-6U for 50944@debbugs.gnu.org; Mon, 04 Oct 2021 05:32:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0kjIveoyjoPCvDBMTuroYuXMub+UJZKYvSWjFRo/tgQ=; b=DZ8quHZPW1Wv8rV6dUTgoVPPNx doV2ake9PEUzEmkB4P3VmtoPQQ3uSzjD0VzmVCDUcP5AymQt/bpB734ukobmw9nNC3cruS8yX7XdV UyKMM0ExBqBVk1pomZE4g6Fq6VZZL4TDv5CH3uo0OizQ678e3sLLCvCKA4mgWucp50yU=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXKKk-00018n-Af; Mon, 04 Oct 2021 11:32:32 +0200 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#50944: malformed :safe entry in several defcustoms References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX7bDxOZ1OdqVDV c0b/////GX2jAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UKBAkTMXBv1UAAAAGVSURBVDjLdZOJsYUg DEUjNGBIA4INgPTf279Z0Lf9zDg6OWS7QSLixjRK3Tc2K3POTrAsdFGlxMnBiUddlKS1dozO2YG+ JDHRaGaFCY7KZRNN/AB8Vt4Ty7bDpeAyt4MDhwEq+ggAQ2u8Uy4ZJ4aCdIOKbpKgw1EVtFq8CABG QmnS5gDCcJBtBHu9gfofGFx/g9yHgjoWKKUWDALdDFjM8Q2yAiGdQ0EzsKl+mJw7PQMOXQFm3KCL gah+KkAyjQjgId3BJlDLU3lIFQfptDkdaAyzAzK5F5g0xwLTTTuxyKSzko+iV0WBXhel2uxJcSVW XvQ/repxa+jVPRsuR6EUwOrotm0sPDkAzl7NiqmimXfflwFLDZ+1GIvSz2YLxcWxLoS2AEUB0jsY UR0N7ewgyQcQA4f+Dib7Armw3xorriCKX7zE0Tq0RifiMDhk4nfqn0BcPgnPA9gV7yFvN3AMP3uV vhZiB6KRw5XmB/RXcC2QNMcD4me3iAXEr+I3KFja4BtcD7i90e4N6hsoLxHtNtPtt/0BL0RR8q+q zVgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTAtMDRUMDk6MTk6NDkrMDA6MDABPsA4AAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIxLTEwLTA0VDA5OjE5OjQ5KzAwOjAwcGN4hAAAAABJRU5ErkJggg== X-Now-Playing: Sacred Paws's _Run Around The Sun_: "How Far" Date: Mon, 04 Oct 2021 11:32:29 +0200 In-Reply-To: (Glenn Morris's message of "Sun, 03 Oct 2021 19:52:45 -0400") Message-ID: <87zgrpnniq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: >> The secondary bug here is that those errors should be flagged with >> a warning. > > Run-time warning seems easy: A compile-time warning would be nicer, I think. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50944 Cc: 50944@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Glenn Morris writes: >> The secondary bug here is that those errors should be flagged with >> a warning. > > Run-time warning seems easy: A compile-time warning would be nicer, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 04 11:27:13 2021 Received: (at 50944) by debbugs.gnu.org; 4 Oct 2021 15:27:13 +0000 Received: from localhost ([127.0.0.1]:38114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXPs1-0007Ix-KU for submit@debbugs.gnu.org; Mon, 04 Oct 2021 11:27:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXPrz-0007Ik-Um for 50944@debbugs.gnu.org; Mon, 04 Oct 2021 11:27:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57900) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXPru-0004vs-HR; Mon, 04 Oct 2021 11:27:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mXPrs-00088R-2l; Mon, 04 Oct 2021 11:27:04 -0400 From: Glenn Morris To: Lars Ingebrigtsen Subject: Re: bug#50944: malformed :safe entry in several defcustoms References: <87zgrpnniq.fsf@gnus.org> X-Spook: Dock Egret Chan advisors Power outage Burst Armani Clinton X-Ran: \%^/qO/:wfYwn4a"IhZ~A0#-bnm&f+Sd<]~}QHHJ$Zl0+6v)k!/af'w@{R6CZ*-J\\=TjA X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 04 Oct 2021 11:27:04 -0400 In-Reply-To: <87zgrpnniq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 04 Oct 2021 11:32:29 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50944 Cc: 50944@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen wrote: >> Run-time warning seems easy: > > A compile-time warning would be nicer, I think. Please make a separate bug report for this (this one is closed). Or a patch. :) To be explicit, the failure mode causes the variable to not be considered safe, so it's not an important issue, and should be obvious if anyone actually tests their :safe property. From unknown Fri Aug 15 02:05:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Nov 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator